Files
tirth8205--code-review-graph/code_review_graph/temporal_resolver.py
T
2026-07-13 12:42:18 +08:00

200 lines
7.7 KiB
Python

"""Post-build Temporal workflow/activity call resolver.
After tree-sitter parsing, Java CALLS edges whose target is a bare method
name carry ``extra.receiver`` naming the local variable called on. This
module resolves those receivers through the TEMPORAL_STUB map to their
declared Temporal interface type, then optionally to the unique concrete
implementation via INHERITS edges.
Resolution chain:
receiver variable name
→ temporal stub field type (from TEMPORAL_STUB.extra.field_name)
→ concrete implementation (from INHERITS, when unique)
Only Java files are processed. TEMPORAL_STUB edges whose target is not a
node with ``temporal_role`` in extra are silently skipped (they may be
non-Temporal types that happen to end in 'Activity'/'Workflow').
"""
from __future__ import annotations
import json
import logging
from typing import TYPE_CHECKING
if TYPE_CHECKING:
from .graph import GraphStore
logger = logging.getLogger(__name__)
def resolve_temporal_calls(store: GraphStore) -> dict:
"""Resolve Java CALLS edges whose receiver is a Temporal activity/workflow stub.
Safe to call multiple times — already-resolved edges (with
``extra.temporal_resolved``) are skipped.
Returns a dict with resolution counts for telemetry.
"""
conn = store._conn
java_files: set[str] = {
row["file_path"]
for row in conn.execute(
"SELECT DISTINCT file_path FROM nodes WHERE language = 'java'"
).fetchall()
}
if not java_files:
return {"files_indexed": 0, "calls_resolved": 0}
# -----------------------------------------------------------------------
# Collect Temporal interface nodes: bare name → qualified_name
# (nodes whose extra contains temporal_role = workflow_interface|activity_interface)
# -----------------------------------------------------------------------
temporal_interfaces: dict[str, str] = {} # bare_name → qualified_name
for row in conn.execute(
"SELECT name, qualified_name, extra FROM nodes "
"WHERE language = 'java' AND extra IS NOT NULL AND extra LIKE '%temporal_role%'"
).fetchall():
try:
ex = json.loads(row["extra"] or "{}")
except (json.JSONDecodeError, TypeError):
ex = {}
if ex.get("temporal_role") in ("workflow_interface", "activity_interface"):
temporal_interfaces[row["name"]] = row["qualified_name"]
if not temporal_interfaces:
logger.info("Temporal resolver: no Workflow/ActivityInterface nodes, skipping")
return {"files_indexed": len(java_files), "calls_resolved": 0}
# -----------------------------------------------------------------------
# Build field_map: (source_qualified_class, field_name) → interface_type
# from TEMPORAL_STUB edges whose target is a known Temporal interface
# -----------------------------------------------------------------------
field_map: dict[tuple[str, str], str] = {}
for row in conn.execute(
"SELECT source_qualified, target_qualified, extra FROM edges WHERE kind = 'TEMPORAL_STUB'"
).fetchall():
bare_target = row["target_qualified"]
if bare_target not in temporal_interfaces:
continue
try:
extra = json.loads(row["extra"] or "{}")
except (json.JSONDecodeError, TypeError):
extra = {}
fname = extra.get("field_name")
if not fname:
continue
field_map[(row["source_qualified"], fname)] = bare_target
if not field_map:
logger.info("Temporal resolver: no TEMPORAL_STUB edges found, skipping")
return {"files_indexed": len(java_files), "calls_resolved": 0}
# -----------------------------------------------------------------------
# method_to_qual: (class_name, method_name) → full qualified_name
# -----------------------------------------------------------------------
method_to_qual: dict[tuple[str, str], str] = {}
for row in conn.execute(
"SELECT name, qualified_name, parent_name FROM nodes "
"WHERE kind IN ('Function', 'Test') AND language = 'java' AND parent_name IS NOT NULL"
).fetchall():
method_to_qual[(row["parent_name"], row["name"])] = row["qualified_name"]
# -----------------------------------------------------------------------
# implementors: bare interface name → list of implementing class quals
# -----------------------------------------------------------------------
implementors: dict[str, list[str]] = {}
for row in conn.execute(
"SELECT source_qualified, target_qualified FROM edges WHERE kind = 'INHERITS'"
).fetchall():
iface = row["target_qualified"]
impl = row["source_qualified"]
if any(impl.startswith(f) for f in java_files) or "::" in impl:
implementors.setdefault(iface, []).append(impl)
# -----------------------------------------------------------------------
# Resolve CALLS edges
# -----------------------------------------------------------------------
calls_rows = conn.execute(
"SELECT id, source_qualified, target_qualified, extra, file_path "
"FROM edges WHERE kind = 'CALLS'"
).fetchall()
resolved = 0
for row in calls_rows:
if row["file_path"] not in java_files:
continue
try:
extra = json.loads(row["extra"] or "{}")
except (json.JSONDecodeError, TypeError):
extra = {}
receiver = extra.get("receiver")
if not receiver:
continue
if extra.get("temporal_resolved") or extra.get("spring_resolved"):
continue
raw_target = row["target_qualified"]
if "::" in raw_target:
after = raw_target.split("::", 1)[1]
method_name = after.split(".")[-1] if "." in after else after
else:
method_name = raw_target
source_qual = row["source_qualified"]
# Derive enclosing class qualified name
enclosing_class_qual: str | None = None
if "::" in source_qual:
after_sep = source_qual.split("::", 1)[1]
if "." in after_sep:
class_part = after_sep.split(".")[0]
prefix = source_qual.split("::")[0]
enclosing_class_qual = f"{prefix}::{class_part}"
else:
enclosing_class_qual = source_qual
if not enclosing_class_qual:
continue
interface_bare = field_map.get((enclosing_class_qual, receiver))
if not interface_bare:
continue
interface_qual = temporal_interfaces.get(interface_bare, interface_bare)
impls = implementors.get(interface_qual, [])
if len(impls) == 1:
concrete_class = impls[0].split("::")[-1]
fallback = f"{impls[0]}.{method_name}"
new_target = method_to_qual.get((concrete_class, method_name)) or fallback
else:
fallback = f"{interface_qual}.{method_name}"
new_target = method_to_qual.get((interface_bare, method_name)) or fallback
extra["temporal_resolved"] = True
extra["temporal_interface"] = interface_bare
new_extra = json.dumps(extra)
conn.execute(
"UPDATE edges SET target_qualified = ?, extra = ? WHERE id = ?",
(new_target, new_extra, row["id"]),
)
resolved += 1
logger.debug(
"Temporal resolved: %s%s (receiver=%s, interface=%s)",
source_qual, new_target, receiver, interface_bare,
)
if resolved:
conn.commit()
logger.info("Temporal resolver: resolved %d CALLS edges in %d Java files",
resolved, len(java_files))
return {"files_indexed": len(java_files), "calls_resolved": resolved}