0d3cb498a3
Deploy local.promptfoo.app / Deploy to Cloudflare Pages (push) Waiting to run
Test and Publish Multi-arch Docker Image / test (push) Waiting to run
Test and Publish Multi-arch Docker Image / build-docker-and-push-digests (map[digest-suffix:linux-amd64 platform:linux/amd64 runner:ubuntu-latest]) (push) Blocked by required conditions
Test and Publish Multi-arch Docker Image / build-docker-and-push-digests (map[digest-suffix:linux-arm64 platform:linux/arm64 runner:ubuntu-24.04-arm]) (push) Blocked by required conditions
Test and Publish Multi-arch Docker Image / merge-docker-digests (push) Blocked by required conditions
Test and Publish Multi-arch Docker Image / Attest Multi-arch Image (push) Blocked by required conditions
Validate Renovate Config / Validate Renovate Configuration (push) Waiting to run
CI / Shell Format Check (push) Has been cancelled
CI / Check Ruby (3.4) (push) Has been cancelled
CI / CI Config (push) Has been cancelled
CI / Test on Node ${{ matrix.node }} and ${{ matrix.os }}${{ matrix.shard && format(' (shard {0}/3)', matrix.shard) || '' }} (push) Has been cancelled
CI / Build on Node ${{ matrix.node }} (push) Has been cancelled
CI / Style Check (push) Has been cancelled
CI / Generate Assets (push) Has been cancelled
CI / Check Python (3.14) (push) Has been cancelled
CI / Check Python (3.9) (push) Has been cancelled
CI / Build Docs (push) Has been cancelled
CI / Code Scan Action (push) Has been cancelled
CI / Site tests (push) Has been cancelled
CI / webui tests (push) Has been cancelled
CI / Run Integration Tests (push) Has been cancelled
CI / Run Smoke Tests (push) Has been cancelled
CI / Go Tests (push) Has been cancelled
CI / Share Test (push) Has been cancelled
CI / Redteam (Production API) (push) Has been cancelled
CI / Redteam (Staging API) (push) Has been cancelled
CI / GitHub Actions Lint (push) Has been cancelled
CI / Check Ruby (3.0) (push) Has been cancelled
release-please / release-please (push) Has been cancelled
release-please / build (push) Has been cancelled
release-please / publish-npm (push) Has been cancelled
release-please / publish-npm-backfill (push) Has been cancelled
release-please / docker (push) Has been cancelled
release-please / publish-code-scan-action (push) Has been cancelled
release-please / attest-code-scan-action (push) Has been cancelled
245 lines
8.4 KiB
TypeScript
245 lines
8.4 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
|
import {
|
|
isRateLimitWrapped,
|
|
wrapProvidersWithRateLimiting,
|
|
wrapProviderWithRateLimiting,
|
|
} from '../../src/scheduler/providerWrapper';
|
|
import { createMockProvider } from '../factories/provider';
|
|
|
|
import type { RateLimitRegistry } from '../../src/scheduler/rateLimitRegistry';
|
|
import type { ApiProvider, ProviderResponse } from '../../src/types/providers';
|
|
|
|
describe('providerWrapper', () => {
|
|
let mockProvider: ApiProvider;
|
|
let mockRegistry: RateLimitRegistry;
|
|
let mockExecute: ReturnType<typeof vi.fn>;
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
|
|
mockExecute = vi.fn();
|
|
|
|
mockProvider = createMockProvider({
|
|
response: { output: 'test output' },
|
|
config: { apiKey: 'test-key' },
|
|
});
|
|
|
|
// Create a mock registry with the execute method
|
|
mockRegistry = {
|
|
execute: mockExecute,
|
|
} as unknown as RateLimitRegistry;
|
|
});
|
|
|
|
describe('wrapProviderWithRateLimiting', () => {
|
|
it('should wrap provider callApi with registry.execute', async () => {
|
|
mockExecute.mockImplementation(async (_provider, callFn) => callFn());
|
|
|
|
const wrappedProvider = wrapProviderWithRateLimiting(mockProvider, mockRegistry);
|
|
await wrappedProvider.callApi('test prompt');
|
|
|
|
expect(mockExecute).toHaveBeenCalledTimes(1);
|
|
expect(mockExecute).toHaveBeenCalledWith(
|
|
mockProvider,
|
|
expect.any(Function),
|
|
expect.objectContaining({
|
|
getHeaders: expect.any(Function),
|
|
isRateLimited: expect.any(Function),
|
|
getRetryAfter: expect.any(Function),
|
|
}),
|
|
);
|
|
});
|
|
|
|
it('should preserve other provider properties', () => {
|
|
const wrappedProvider = wrapProviderWithRateLimiting(mockProvider, mockRegistry);
|
|
|
|
expect(wrappedProvider.id()).toBe('test-provider');
|
|
expect(wrappedProvider.config).toEqual({ apiKey: 'test-key' });
|
|
});
|
|
|
|
it('should preserve id() method from class prototype', () => {
|
|
// This tests the specific bug where spread operator doesn't copy prototype methods.
|
|
// When a provider is a class instance, id() is on the prototype, not an own property.
|
|
class TestProvider implements ApiProvider {
|
|
callApi = vi.fn().mockResolvedValue({ output: 'test' });
|
|
|
|
id(): string {
|
|
return 'class-based-provider';
|
|
}
|
|
}
|
|
|
|
const classProvider = new TestProvider();
|
|
const wrappedProvider = wrapProviderWithRateLimiting(classProvider, mockRegistry);
|
|
|
|
// Verify that id() works on the wrapped provider
|
|
expect(wrappedProvider.id()).toBe('class-based-provider');
|
|
});
|
|
|
|
it('should not double-wrap already wrapped providers', () => {
|
|
const wrappedOnce = wrapProviderWithRateLimiting(mockProvider, mockRegistry);
|
|
const wrappedTwice = wrapProviderWithRateLimiting(wrappedOnce, mockRegistry);
|
|
|
|
expect(wrappedOnce).toBe(wrappedTwice);
|
|
});
|
|
|
|
it('should mark wrapped provider with symbol', () => {
|
|
const wrappedProvider = wrapProviderWithRateLimiting(mockProvider, mockRegistry);
|
|
|
|
expect(isRateLimitWrapped(wrappedProvider)).toBe(true);
|
|
expect(isRateLimitWrapped(mockProvider)).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('wrapProvidersWithRateLimiting', () => {
|
|
it('should wrap multiple providers', () => {
|
|
const provider1 = createMockProvider({ id: 'provider-1' });
|
|
const provider2 = createMockProvider({ id: 'provider-2' });
|
|
|
|
const wrappedProviders = wrapProvidersWithRateLimiting([provider1, provider2], mockRegistry);
|
|
|
|
expect(wrappedProviders).toHaveLength(2);
|
|
expect(isRateLimitWrapped(wrappedProviders[0])).toBe(true);
|
|
expect(isRateLimitWrapped(wrappedProviders[1])).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe('rate limit detection callbacks', () => {
|
|
it('should detect rate limit from HTTP 429 status', async () => {
|
|
let capturedOptions: any;
|
|
mockExecute.mockImplementation(async (_provider, callFn, options) => {
|
|
capturedOptions = options;
|
|
return callFn();
|
|
});
|
|
|
|
const wrappedProvider = wrapProviderWithRateLimiting(mockProvider, mockRegistry);
|
|
await wrappedProvider.callApi('test');
|
|
|
|
const result: ProviderResponse = {
|
|
output: 'test',
|
|
metadata: { http: { status: 429, statusText: 'Too Many Requests', headers: {} } },
|
|
};
|
|
expect(capturedOptions.isRateLimited(result, undefined)).toBe(true);
|
|
});
|
|
|
|
it('should detect explicit transient rate limit metadata without error text parsing', async () => {
|
|
let capturedOptions: any;
|
|
mockExecute.mockImplementation(async (_provider, callFn, options) => {
|
|
capturedOptions = options;
|
|
return callFn();
|
|
});
|
|
|
|
const wrappedProvider = wrapProviderWithRateLimiting(mockProvider, mockRegistry);
|
|
await wrappedProvider.callApi('test');
|
|
|
|
const result: ProviderResponse = {
|
|
error: 'SDK throttle',
|
|
metadata: { rateLimitKind: 'rate_limit' },
|
|
};
|
|
expect(capturedOptions.isRateLimited(result, undefined)).toBe(true);
|
|
});
|
|
|
|
it('should detect rate limit from error message', async () => {
|
|
let capturedOptions: any;
|
|
mockExecute.mockImplementation(async (_provider, callFn, options) => {
|
|
capturedOptions = options;
|
|
return callFn();
|
|
});
|
|
|
|
const wrappedProvider = wrapProviderWithRateLimiting(mockProvider, mockRegistry);
|
|
await wrappedProvider.callApi('test');
|
|
|
|
const error = new Error('Error 429: rate limit exceeded');
|
|
expect(capturedOptions.isRateLimited(undefined, error)).toBe(true);
|
|
});
|
|
|
|
it('should extract headers from metadata.http.headers', async () => {
|
|
let capturedOptions: any;
|
|
mockExecute.mockImplementation(async (_provider, callFn, options) => {
|
|
capturedOptions = options;
|
|
return callFn();
|
|
});
|
|
|
|
const wrappedProvider = wrapProviderWithRateLimiting(mockProvider, mockRegistry);
|
|
await wrappedProvider.callApi('test');
|
|
|
|
const result: ProviderResponse = {
|
|
output: 'test',
|
|
metadata: {
|
|
http: {
|
|
status: 200,
|
|
statusText: 'OK',
|
|
headers: { 'retry-after': '60' },
|
|
},
|
|
},
|
|
};
|
|
|
|
const headers = capturedOptions.getHeaders(result);
|
|
expect(headers).toEqual({ 'retry-after': '60' });
|
|
});
|
|
|
|
it('should parse retry-after header', async () => {
|
|
let capturedOptions: any;
|
|
mockExecute.mockImplementation(async (_provider, callFn, options) => {
|
|
capturedOptions = options;
|
|
return callFn();
|
|
});
|
|
|
|
const wrappedProvider = wrapProviderWithRateLimiting(mockProvider, mockRegistry);
|
|
await wrappedProvider.callApi('test');
|
|
|
|
const result: ProviderResponse = {
|
|
output: 'test',
|
|
metadata: {
|
|
http: {
|
|
status: 429,
|
|
statusText: 'Too Many Requests',
|
|
headers: { 'Retry-After': '30' },
|
|
},
|
|
},
|
|
};
|
|
|
|
// Headers are normalized to lowercase in getRetryAfter
|
|
const retryAfter = capturedOptions.getRetryAfter(result, undefined);
|
|
expect(retryAfter).toBe(30000); // 30 seconds in ms
|
|
});
|
|
|
|
it('should ignore non-finite retry-after-ms and fall back to retry-after', async () => {
|
|
let capturedOptions: any;
|
|
mockExecute.mockImplementation(async (_provider, callFn, options) => {
|
|
capturedOptions = options;
|
|
return callFn();
|
|
});
|
|
|
|
const wrappedProvider = wrapProviderWithRateLimiting(mockProvider, mockRegistry);
|
|
await wrappedProvider.callApi('test');
|
|
|
|
const result: ProviderResponse = {
|
|
output: 'test',
|
|
metadata: {
|
|
http: {
|
|
status: 429,
|
|
statusText: 'Too Many Requests',
|
|
headers: { 'retry-after-ms': '9'.repeat(400), 'retry-after': '30' },
|
|
},
|
|
},
|
|
};
|
|
|
|
expect(capturedOptions.getRetryAfter(result, undefined)).toBe(30000);
|
|
});
|
|
|
|
it('should ignore a non-finite retry-after parsed from the error message', async () => {
|
|
let capturedOptions: any;
|
|
mockExecute.mockImplementation(async (_provider, callFn, options) => {
|
|
capturedOptions = options;
|
|
return callFn();
|
|
});
|
|
|
|
const wrappedProvider = wrapProviderWithRateLimiting(mockProvider, mockRegistry);
|
|
await wrappedProvider.callApi('test');
|
|
|
|
const overflowingRetryAfter = `retry after ${'9'.repeat(400)}`;
|
|
const error = new Error(overflowingRetryAfter);
|
|
expect(capturedOptions.getRetryAfter(undefined, error)).toBeUndefined();
|
|
});
|
|
});
|
|
});
|