4b6817381b
CI (OpenClaw E2E) / openclaw test (push) Has been cancelled
CI / coverage-report (push) Has been cancelled
CI / test-kubernetes (push) Has been cancelled
CI / should-run-thorough (push) Has been cancelled
CI / test-thorough (cloudwatch-demo) (push) Has been cancelled
CI / test-thorough (flink-ecs) (push) Has been cancelled
CI / test-thorough (upstream-lambda) (push) Has been cancelled
CI / test-thorough (prefect-ecs-fargate) (push) Has been cancelled
Release / build-binaries (zip, opensre.exe, onefile, windows-latest, windows-x64) (push) Has been cancelled
Benchmark image — build + push to ECR (any adapter) / build + push (push) Has been cancelled
CI / quality (ubuntu-latest) (push) Has been cancelled
CI / test (tools-runtime) (push) Has been cancelled
CI / test (e2e-general) (push) Has been cancelled
CI / test (cli-runtime) (push) Has been cancelled
CI / test (e2e-provider-and-openclaw) (push) Has been cancelled
CI / test (integrations-and-misc) (push) Has been cancelled
Release / verify (push) Has been cancelled
Release / build-python-dist (push) Has been cancelled
Release / build-binaries (tar.gz, opensre, onedir, macos-15-intel, darwin-x64) (push) Has been cancelled
Release / build-binaries (tar.gz, opensre, onedir, macos-latest, darwin-arm64) (push) Has been cancelled
Release / build-binaries (tar.gz, opensre, onedir, ubuntu-22.04, linux-x64) (push) Has been cancelled
Release / publish-release (push) Has been cancelled
Release / publish-main-release (push) Has been cancelled
Interactive Shell Live (PR + post-merge) / turn-checks (no-LLM) (push) Has been cancelled
CodeQL / Analyze (python) (push) Has been cancelled
Interactive Shell Live (PR + post-merge) / turn-live shard ${{ matrix.shard_index }} (push) Has been cancelled
Release / prepare (push) Has been cancelled
Release / build-binaries (tar.gz, opensre, onedir, ubuntu-22.04-arm, linux-arm64) (push) Has been cancelled
Synthetic Deterministic Tests / Synthetic offline (deterministic) (push) Has been cancelled
253 lines
10 KiB
Python
253 lines
10 KiB
Python
"""
|
|
Description:
|
|
--------------------------------
|
|
The problem that I concretely need to solve now with this test
|
|
is that I do not believe that our agent has the same data access as the agent in the interactive shell
|
|
so we need to bridge that gap between the two.
|
|
|
|
The approach to do that is:
|
|
- start the gateway and get the session
|
|
- this initializes the agent.
|
|
- the agent is being passed down the gateway to the event handler to execute the event loops
|
|
|
|
--------------------------------
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
import logging
|
|
from concurrent.futures import ThreadPoolExecutor
|
|
from typing import Any
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from core.agent_harness.accounting.run_record import DefaultRunRecordFactory
|
|
from core.agent_harness.accounting.turn_accounting import DefaultTurnAccounting
|
|
from core.agent_harness.error_reporting import DefaultErrorReporter
|
|
from core.agent_harness.prompts.prompt_context import DefaultPromptContextProvider
|
|
from core.agent_harness.session import SessionCore
|
|
from core.agent_harness.session.persistence.memory import InMemorySessionStorage
|
|
from core.agent_harness.tools.tool_provider import DefaultToolProvider
|
|
from core.agent_harness.turns.default_reasoning_client import DefaultReasoningClientProvider
|
|
from core.agent_harness.turns.turn_results import ShellTurnResult, ToolCallingTurnResult
|
|
from gateway.config.get_gateway_settings import (
|
|
GatewayConfigurationError,
|
|
GatewaySettings,
|
|
TelegramInboundMessage,
|
|
)
|
|
from gateway.manager import GatewayManager, start_gateway
|
|
from gateway.polling.handle_polled_inbound_telegram_msg import (
|
|
handle_polled_inbound_telegram_message,
|
|
)
|
|
from gateway.session.inbound_message_security import InboundDecision
|
|
|
|
|
|
def _patch_non_telegram_components(monkeypatch) -> None:
|
|
"""Keep lifecycle tests focused on the Telegram worker: skip web/scheduler/pidfile."""
|
|
monkeypatch.setattr(GatewayManager, "_start_web", lambda *_args: None)
|
|
monkeypatch.setattr(GatewayManager, "_start_scheduler", lambda *_args: None)
|
|
monkeypatch.setattr(GatewayManager, "_publish_status", lambda *_args: None)
|
|
|
|
|
|
def test_gateway_start_returns_running_gateway_handle(monkeypatch) -> None:
|
|
settings = GatewaySettings(bot_token="tok", auto_start_enabled=False)
|
|
logger = logging.getLogger("gateway.lifecycle.test")
|
|
handle = MagicMock()
|
|
agent_cls = MagicMock()
|
|
signal_calls: list[tuple[int, Any]] = []
|
|
background_kwargs: dict[str, Any] = {}
|
|
|
|
monkeypatch.setattr("core.agent_harness.harness.load_dotenv", lambda **_kwargs: None)
|
|
monkeypatch.setattr("gateway.manager.configure_gateway_logging", lambda: logger)
|
|
_patch_non_telegram_components(monkeypatch)
|
|
monkeypatch.setattr("gateway.telegram_gateway.load_gateway_settings", lambda: settings)
|
|
monkeypatch.setattr(
|
|
"gateway.manager.signal.signal",
|
|
lambda signum, handler: signal_calls.append((signum, handler)),
|
|
)
|
|
# Patch the agent class the gateway constructs so the turn callback is spyable.
|
|
monkeypatch.setattr("gateway.turn_handler.HeadlessAgent", agent_cls)
|
|
|
|
def _start_telegram_gateway_background(**kwargs: Any) -> MagicMock:
|
|
background_kwargs.update(kwargs)
|
|
return handle
|
|
|
|
monkeypatch.setattr(
|
|
"gateway.telegram_gateway.start_telegram_gateway_background",
|
|
_start_telegram_gateway_background,
|
|
)
|
|
|
|
gateway = GatewayManager().start_gateway(wait=False)
|
|
|
|
assert isinstance(gateway, GatewayManager)
|
|
assert gateway.settings is settings
|
|
assert gateway.logger is logger
|
|
assert gateway.telegram_background_worker is handle
|
|
assert background_kwargs["settings"] is settings
|
|
assert background_kwargs["logger"] is logger
|
|
assert background_kwargs["handle_callback_to_gateway_agent"] is not None
|
|
assert signal_calls
|
|
handle.wait.assert_not_called()
|
|
|
|
sink = MagicMock()
|
|
session = MagicMock()
|
|
agent_cls.return_value.dispatch.return_value = ShellTurnResult(
|
|
final_intent="cli_agent_handled",
|
|
action_result=ToolCallingTurnResult(
|
|
planned_count=1,
|
|
executed_count=1,
|
|
executed_success_count=1,
|
|
has_unhandled_clause=False,
|
|
handled=True,
|
|
response_text="Hawaii: +25C",
|
|
),
|
|
assistant_response_text="Hawaii: +25C",
|
|
llm_run=None,
|
|
)
|
|
callback = background_kwargs["handle_callback_to_gateway_agent"]
|
|
callback("hello", session, sink, logger)
|
|
agent_cls.return_value.dispatch.assert_called_once()
|
|
sink.finalize.assert_called_once_with("Hawaii: +25C")
|
|
assert agent_cls.return_value.dispatch.call_args.args == ("hello",)
|
|
ctor = agent_cls.call_args
|
|
assert ctor.kwargs["session"] is session
|
|
assert ctor.kwargs["output"] is sink
|
|
tool_provider = ctor.kwargs["tools"]
|
|
assert isinstance(tool_provider, DefaultToolProvider)
|
|
assert tool_provider._precomputed_action_tools is None
|
|
with patch.object(logger, "info") as mock_info:
|
|
tool_provider.observer(message="hello")(
|
|
"tool_start",
|
|
{"name": "shell_run", "input": {"command": "pwd"}},
|
|
)
|
|
mock_info.assert_called_once_with(
|
|
"tool action name=%s input=%s",
|
|
"shell_run",
|
|
"{'command': 'pwd'}",
|
|
)
|
|
assert isinstance(ctor.kwargs["prompts"], DefaultPromptContextProvider)
|
|
assert isinstance(ctor.kwargs["reasoning"], DefaultReasoningClientProvider)
|
|
assert isinstance(ctor.kwargs["run_factory"], DefaultRunRecordFactory)
|
|
assert isinstance(ctor.kwargs["accounting"], DefaultTurnAccounting)
|
|
assert isinstance(ctor.kwargs["error_reporter"], DefaultErrorReporter)
|
|
assert ctor.kwargs["gather_enabled"] is True
|
|
|
|
|
|
def test_polled_telegram_message_reaches_start_gateway_agent_callback(monkeypatch) -> None:
|
|
settings = GatewaySettings(
|
|
bot_token="tok",
|
|
auto_start_enabled=False,
|
|
allowed_user_ids=["user-1"],
|
|
stream_edit_interval_seconds=0.01,
|
|
)
|
|
logger = logging.getLogger("gateway.lifecycle.e2e.test")
|
|
handle = MagicMock()
|
|
background_kwargs: dict[str, Any] = {}
|
|
|
|
class FakeSessionResolver:
|
|
def __init__(self, session: SessionCore) -> None:
|
|
self._session = session
|
|
|
|
def resolve(self, *, user_id: str, chat_id: str) -> SessionCore:
|
|
assert user_id == "user-1"
|
|
assert chat_id == "chat-1"
|
|
return self._session
|
|
|
|
def rotate(self, *, user_id: str, chat_id: str) -> SessionCore:
|
|
assert user_id == "user-1"
|
|
assert chat_id == "chat-1"
|
|
return self._session
|
|
|
|
monkeypatch.setattr("core.agent_harness.harness.load_dotenv", lambda **_kwargs: None)
|
|
monkeypatch.setattr("gateway.manager.configure_gateway_logging", lambda: logger)
|
|
_patch_non_telegram_components(monkeypatch)
|
|
monkeypatch.setattr("gateway.telegram_gateway.load_gateway_settings", lambda: settings)
|
|
monkeypatch.setattr("gateway.manager.signal.signal", lambda *_args: None)
|
|
|
|
def _start_telegram_gateway_background(**kwargs: Any) -> MagicMock:
|
|
background_kwargs.update(kwargs)
|
|
return handle
|
|
|
|
monkeypatch.setattr(
|
|
"gateway.telegram_gateway.start_telegram_gateway_background",
|
|
_start_telegram_gateway_background,
|
|
)
|
|
monkeypatch.setattr(
|
|
"gateway.polling.handle_polled_inbound_telegram_msg."
|
|
"enforce_inbound_telegram_message_security",
|
|
lambda **_kwargs: InboundDecision(allowed=True),
|
|
)
|
|
|
|
GatewayManager().start_gateway(wait=False)
|
|
callback = background_kwargs["handle_callback_to_gateway_agent"]
|
|
session = SessionCore(storage=InMemorySessionStorage())
|
|
client = MagicMock()
|
|
client.send_message.return_value = (True, "", "message-1")
|
|
client.edit_message_text.return_value = (True, "")
|
|
|
|
async def _run_message() -> None:
|
|
executor = ThreadPoolExecutor(max_workers=1)
|
|
try:
|
|
await handle_polled_inbound_telegram_message(
|
|
TelegramInboundMessage(
|
|
update_id=1,
|
|
user_id="user-1",
|
|
chat_id="chat-1",
|
|
message_id="telegram-message-1",
|
|
text="/status",
|
|
),
|
|
client=client,
|
|
session_resolver=FakeSessionResolver(session),
|
|
settings=settings,
|
|
executor=executor,
|
|
chat_locks={},
|
|
turn_semaphore=asyncio.Semaphore(1),
|
|
handle_callback_to_gateway_agent=callback,
|
|
)
|
|
finally:
|
|
executor.shutdown(wait=True, cancel_futures=True)
|
|
|
|
asyncio.run(_run_message())
|
|
# Typing fires at sink creation and again on each status refresh.
|
|
client.send_chat_action.assert_called_with("chat-1", "typing")
|
|
|
|
|
|
def test_gateway_start_continues_without_telegram_configuration(monkeypatch) -> None:
|
|
"""The unified daemon keeps its other components when Telegram is unconfigured."""
|
|
logger = logging.getLogger("gateway.lifecycle.test")
|
|
monkeypatch.setattr("core.agent_harness.harness.load_dotenv", lambda **_kwargs: None)
|
|
monkeypatch.setattr("gateway.manager.configure_gateway_logging", lambda: logger)
|
|
monkeypatch.setattr("gateway.manager.signal.signal", lambda *_args: None)
|
|
monkeypatch.setattr("gateway.manager.clear_component_status", lambda: None)
|
|
_patch_non_telegram_components(monkeypatch)
|
|
|
|
def _unconfigured() -> GatewaySettings:
|
|
raise GatewayConfigurationError("TELEGRAM_BOT_TOKEN is not set")
|
|
|
|
monkeypatch.setattr("gateway.telegram_gateway.load_gateway_settings", _unconfigured)
|
|
|
|
gateway = GatewayManager().start_gateway(wait=False)
|
|
|
|
assert gateway.telegram_background_worker is None
|
|
assert gateway.components["telegram"].startswith("not configured")
|
|
assert gateway.stop() is True
|
|
|
|
|
|
def test_start_gateway_wrapper_delegates_to_gateway_instance(monkeypatch) -> None:
|
|
expected = MagicMock(spec=GatewayManager)
|
|
calls: list[bool] = []
|
|
|
|
def _start_gateway(
|
|
self: GatewayManager,
|
|
*,
|
|
wait: bool = True,
|
|
) -> GatewayManager:
|
|
assert isinstance(self, GatewayManager)
|
|
calls.append(wait)
|
|
return expected
|
|
|
|
monkeypatch.setattr(GatewayManager, "start_gateway", _start_gateway)
|
|
|
|
assert start_gateway(wait=False) is expected
|
|
assert calls == [False]
|