4b6817381b
Benchmark image — build + push to ECR (any adapter) / build + push (push) Waiting to run
CI / quality (ubuntu-latest) (push) Waiting to run
CI / test (tools-runtime) (push) Waiting to run
CI / test (e2e-general) (push) Waiting to run
CI / test (cli-runtime) (push) Waiting to run
CI / test (e2e-provider-and-openclaw) (push) Waiting to run
CI / test (integrations-and-misc) (push) Waiting to run
CI / coverage-report (push) Blocked by required conditions
CI / test-kubernetes (push) Waiting to run
CI / should-run-thorough (push) Waiting to run
CI / test-thorough (cloudwatch-demo) (push) Blocked by required conditions
CI / test-thorough (flink-ecs) (push) Blocked by required conditions
CI / test-thorough (upstream-lambda) (push) Blocked by required conditions
CI / test-thorough (prefect-ecs-fargate) (push) Blocked by required conditions
CodeQL / Analyze (python) (push) Waiting to run
Release / build-binaries (zip, opensre.exe, onefile, windows-latest, windows-x64) (push) Blocked by required conditions
Release / publish-release (push) Blocked by required conditions
Release / publish-main-release (push) Blocked by required conditions
Release / prepare (push) Waiting to run
Release / verify (push) Blocked by required conditions
Release / build-python-dist (push) Blocked by required conditions
Release / build-binaries (tar.gz, opensre, onedir, macos-15-intel, darwin-x64) (push) Blocked by required conditions
Release / build-binaries (tar.gz, opensre, onedir, macos-latest, darwin-arm64) (push) Blocked by required conditions
Release / build-binaries (tar.gz, opensre, onedir, ubuntu-22.04, linux-x64) (push) Blocked by required conditions
Release / build-binaries (tar.gz, opensre, onedir, ubuntu-22.04-arm, linux-arm64) (push) Blocked by required conditions
Synthetic Deterministic Tests / Synthetic offline (deterministic) (push) Waiting to run
Interactive Shell Live (PR + post-merge) / turn-checks (no-LLM) (push) Waiting to run
Interactive Shell Live (PR + post-merge) / turn-live shard ${{ matrix.shard_index }} (push) Waiting to run
CI (OpenClaw E2E) / openclaw test (push) Has been cancelled
3.1 KiB
3.1 KiB
Naming conventions for core/
A small, enforceable vocabulary so file and type names say what they are. The goal is that a reader can tell a data type from a process, a mutable state from a frozen view, and a package's purpose from its name alone.
Glossary (one meaning per term)
| Term | Means | Example |
|---|---|---|
| State | Mutable investigation/session facts that evolve during a run | AgentState, InvestigationState |
| Snapshot | A frozen view captured at a boundary (turn start, run start) | TurnSnapshot |
| RunInput / RunResult | The input to and output from one Agent.run() boundary |
AgentRunInput, AgentRunResult |
| Slice | A typed segment of a state dict | DiagnosisSlice, AlertInputSlice |
| Resources | Handles passed into tool executors for one call | ToolCallResources |
| Budget | An LLM token/window policy — not application state | enforce_token_budget |
| Host | The callback contract an algorithm drives (a Protocol) |
LoopHost |
Module naming: {domain}_{role}.py
Name a file for the concept it holds, not with a generic bucket word.
core/agent/
agent.py # the Agent facade
react_loop.py # ReactLoop + run_react_loop (the algorithm)
loop_host.py # LoopHost (the callback contract)
run_io.py # AgentRunInput, AgentRunResult (the run boundary's I/O)
mixins.py # the reusable *Mixin behaviors
provider_hooks.py # ProviderHookDelegate
Type naming
- Mixins carry a
Mixinsuffix — they cannot stand alone (they assume fields/methods the host provides).EventEmitterMixin,ToolFilterMixin,SteeringMixin. - Protocols are named by their role, not with a
Protocolsuffix — matches the stdlib (Iterable,SupportsRead) andagent_harness/ports.py(OutputSink,SessionStore).LoopHost, notLoopHostProtocol. - Do not prefix a type with its own package name. Inside
core/agent/, a class isEventEmitterMixin, notAgentEventEmitter— the namespace already says "agent."
Anti-patterns (do not add in new code)
context.pyatcore/orcore/agent/root — "context" is overloaded across the repo. Name the concept (run_io.py,turn_snapshot.py).models.pywhen the file holds only run I/O — too vague. Say what the models are (run_io.py).*Contextwithout a domain prefix when another*Contextalready exists.- A package whose only child is a single sub-package — collapse the wrapper.
Imports
Use fully qualified paths in code; keep short mental labels for docs.
| Mental label | Import |
|---|---|
| ReAct run I/O | from core.agent.run_io import AgentRunInput, AgentRunResult |
| ReAct loop | from core.agent.react_loop import run_react_loop |
| Loop callback contract | from core.agent.loop_host import LoopHost |
| The agent primitive | from core.agent import Agent |
| Harness turn snapshot | from core.agent_harness.turns.turn_snapshot import TurnSnapshot |
Re-export from a package __init__.py only for its single canonical symbol
(Agent), not everything — avoid from core.agent import *-style ambiguity.