wehub-resource-sync
4b6817381b
CI (OpenClaw E2E) / openclaw test (push) Has been cancelled
CI / coverage-report (push) Has been cancelled
CI / test-kubernetes (push) Has been cancelled
CI / should-run-thorough (push) Has been cancelled
CI / test-thorough (cloudwatch-demo) (push) Has been cancelled
CI / test-thorough (flink-ecs) (push) Has been cancelled
CI / test-thorough (upstream-lambda) (push) Has been cancelled
CI / test-thorough (prefect-ecs-fargate) (push) Has been cancelled
Release / build-binaries (zip, opensre.exe, onefile, windows-latest, windows-x64) (push) Has been cancelled
Benchmark image — build + push to ECR (any adapter) / build + push (push) Has been cancelled
CI / quality (ubuntu-latest) (push) Has been cancelled
CI / test (tools-runtime) (push) Has been cancelled
CI / test (e2e-general) (push) Has been cancelled
CI / test (cli-runtime) (push) Has been cancelled
CI / test (e2e-provider-and-openclaw) (push) Has been cancelled
CI / test (integrations-and-misc) (push) Has been cancelled
Release / verify (push) Has been cancelled
Release / build-python-dist (push) Has been cancelled
Release / build-binaries (tar.gz, opensre, onedir, macos-15-intel, darwin-x64) (push) Has been cancelled
Release / build-binaries (tar.gz, opensre, onedir, macos-latest, darwin-arm64) (push) Has been cancelled
Release / build-binaries (tar.gz, opensre, onedir, ubuntu-22.04, linux-x64) (push) Has been cancelled
Release / publish-release (push) Has been cancelled
Release / publish-main-release (push) Has been cancelled
Interactive Shell Live (PR + post-merge) / turn-checks (no-LLM) (push) Has been cancelled
CodeQL / Analyze (python) (push) Has been cancelled
Interactive Shell Live (PR + post-merge) / turn-live shard ${{ matrix.shard_index }} (push) Has been cancelled
Release / prepare (push) Has been cancelled
Release / build-binaries (tar.gz, opensre, onedir, ubuntu-22.04-arm, linux-arm64) (push) Has been cancelled
Synthetic Deterministic Tests / Synthetic offline (deterministic) (push) Has been cancelled
44 lines
1.0 KiB
Plaintext
44 lines
1.0 KiB
Plaintext
---
|
|
description: Pre-commit quality checklist and PR standards
|
|
alwaysApply: true
|
|
---
|
|
|
|
# Quality Standards
|
|
|
|
## Before Every PR
|
|
|
|
All three must pass — CI blocks merging if any fail:
|
|
|
|
```bash
|
|
make lint # ruff: style and import checking
|
|
make typecheck # mypy: type annotation checking
|
|
make test-cov # pytest: tests with coverage report
|
|
```
|
|
|
|
## PR Checklist
|
|
|
|
- Link to the relevant GitHub issue (`Fixes #123`)
|
|
- All local checks pass
|
|
- Tests added for bug fixes and new features
|
|
- Documentation updated if behavior changed
|
|
- Self-reviewed your own code
|
|
- Edge cases considered
|
|
- Breaking changes called out explicitly
|
|
|
|
## AI-Assisted Code
|
|
|
|
If AI tools were used to generate code:
|
|
- Review every line (not just skim)
|
|
- Understand the logic and can explain it
|
|
- Test edge cases
|
|
- Match project conventions
|
|
- Verify tests pass
|
|
|
|
## Code Quality Principles
|
|
|
|
- Clarity over cleverness
|
|
- DRY: extract common patterns
|
|
- Strong typing on all function signatures
|
|
- One responsibility per function/class
|
|
- Comments explain "why", not "what"
|