chore: import upstream snapshot with attribution

tests/tools/interactive_shell/test_import_boundaries.py

@@ -0,0 +1,60 @@
+"""Import-boundary tests for decoupled interactive-shell action tools."""
+
+from __future__ import annotations
+
+import ast
+from pathlib import Path
+
+
+def _repo_root() -> Path:
+    for parent in Path(__file__).resolve().parents:
+        if (parent / "pyproject.toml").is_file():
+            return parent
+    return Path(__file__).resolve().parents[3]
+
+
+def _collect_surface_import_offenders(
+    root: Path,
+    *,
+    paths: list[Path],
+    forbidden_modules: frozenset[str],
+    forbidden_prefixes: tuple[str, ...],
+) -> list[str]:
+    offenders: list[str] = []
+    for path in sorted(paths):
+        if not path.is_file():
+            continue
+        tree = ast.parse(path.read_text(encoding="utf-8"), filename=str(path))
+        for node in ast.walk(tree):
+            if isinstance(node, ast.Import):
+                for alias in node.names:
+                    name = alias.name
+                    if name in forbidden_modules or any(
+                        name.startswith(prefix) for prefix in forbidden_prefixes
+                    ):
+                        offenders.append(str(path.relative_to(root)))
+            elif isinstance(node, ast.ImportFrom):
+                module = node.module or ""
+                if module in forbidden_modules or any(
+                    module.startswith(prefix) for prefix in forbidden_prefixes
+                ):
+                    offenders.append(str(path.relative_to(root)))
+    return offenders
+
+
+def test_t03_runners_do_not_import_interactive_shell_surface() -> None:
+    root = _repo_root()
+    tools_root = root / "tools" / "interactive_shell"
+    scoped_paths = [
+        tools_root / "shell" / "runner.py",
+        tools_root / "synthetic" / "runner.py",
+        tools_root / "implementation" / "claude_code_executor.py",
+        tools_root / "actions" / "cli_command.py",
+    ]
+    offenders = _collect_surface_import_offenders(
+        root,
+        paths=scoped_paths,
+        forbidden_modules=frozenset({"surfaces.interactive_shell"}),
+        forbidden_prefixes=("surfaces.interactive_shell.",),
+    )
+    assert not offenders, "\n".join(sorted(set(offenders)))

tests/tools/interactive_shell/test_subprocess_primitives.py

@@ -0,0 +1,57 @@
+"""Unit tests for pure subprocess helpers in tools.interactive_shell.subprocess."""
+
+from __future__ import annotations
+
+import subprocess
+import tempfile
+import threading
+
+import pytest
+
+from tools.interactive_shell.subprocess import (
+    read_diag,
+    subprocess_env_with_width,
+    terminate_child_process,
+    watch_subprocess_until_exit,
+)
+
+
+def test_subprocess_env_with_width_reserves_prefix(monkeypatch: pytest.MonkeyPatch) -> None:
+    monkeypatch.delenv("LINES", raising=False)
+    env = subprocess_env_with_width(columns=100, lines=30)
+    assert env["COLUMNS"] == "81"
+    assert env["LINES"] == "30"
+
+
+def test_subprocess_env_with_width_preserves_existing_lines(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    monkeypatch.setenv("LINES", "24")
+    env = subprocess_env_with_width(columns=100, lines=30)
+    assert env["LINES"] == "24"
+
+
+def test_read_diag_strips_ansi() -> None:
+    with tempfile.SpooledTemporaryFile(max_size=4096) as buf:
+        buf.write(b"\x1b[31merror\x1b[0m")
+        buf.seek(0)
+        assert read_diag(buf) == "error"
+
+
+def test_terminate_child_process_noop_when_exited() -> None:
+    proc = subprocess.Popen(["true"])
+    proc.wait()
+    terminate_child_process(proc)
+
+
+def test_watch_subprocess_until_exit_on_cancel() -> None:
+    proc = subprocess.Popen(["sleep", "30"])
+    cancel = threading.Event()
+    cancel.set()
+    result = watch_subprocess_until_exit(
+        proc,
+        cancel_event=cancel,
+        timeout_seconds=60,
+    )
+    assert result.cancelled
+    assert result.terminated_by_watcher