thedotmack--claude-mem/tests/sdk/parse-summary.test.ts

import { afterEach, beforeEach, describe, it, expect } from 'bun:test';

import { ModeManager } from '../../src/services/domain/ModeManager.js';

import { parseAgentXml } from '../../src/sdk/parser.js';

// Load the real bundled `code` mode rather than mocking ModeManager. The
// previous `mock.module(...)` replaced ModeManager process-globally and was
// never restored, so its partial stub (no `loadMode`) leaked into other test
// files in the same `bun test` run — notably the SDK integration tests, whose
// createCmemClient() calls `ModeManager.getInstance().loadMode('code')`. The
// real `code` mode is a superset of the types these tests exercise, so the
// assertions below are unchanged.
ModeManager.getInstance().loadMode('code');

describe('parseAgentXml — summaries', () => {
  beforeEach(() => {
    const modeManager = ModeManager.getInstance() as unknown as { activeMode: unknown };
    modeManager.activeMode = {
      observation_types: [{ id: 'bugfix' }, { id: 'discovery' }, { id: 'refactor' }],
      observation_concepts: [],
    };
  });

  afterEach(() => {
    const modeManager = ModeManager.getInstance() as unknown as { activeMode: unknown };
    modeManager.activeMode = null;
  });

  it('returns invalid when response is plain text (no XML)', () => {
    const result = parseAgentXml('Some plain text response without any XML tags');
    expect(result.valid).toBe(false);
  });

  it('returns invalid when <summary> has no sub-tags (false positive — was #1360)', () => {
    const result = parseAgentXml('<observation>done <summary>some content here</summary></observation>');
    expect(result.valid).toBe(false);
  });

  it('returns invalid for bare <summary> with only plain text, no sub-tags', () => {
    const result = parseAgentXml('<summary>This session was productive.</summary>');
    expect(result.valid).toBe(false);
  });

  it('returns valid summary when at least one sub-tag is present', () => {
    const text = `<summary><request>Fix the bug</request></summary>`;
    const result = parseAgentXml(text);
    expect(result.valid).toBe(true);
    if (result.valid && result.summary) {
      expect(result.summary.request).toBe('Fix the bug');
      expect(result.summary.investigated).toBeNull();
      expect(result.summary.learned).toBeNull();
    }
  });

  it('returns full summary when all fields are present', () => {
    const text = `<summary>
      <request>Fix login bug</request>
      <investigated>Auth flow and JWT expiry</investigated>
      <learned>Token was expiring too soon</learned>
      <completed>Extended token TTL to 24h</completed>
      <next_steps>Monitor error rates</next_steps>
    </summary>`;
    const result = parseAgentXml(text);
    expect(result.valid).toBe(true);
    if (result.valid && result.summary) {
      expect(result.summary.request).toBe('Fix login bug');
      expect(result.summary.investigated).toBe('Auth flow and JWT expiry');
      expect(result.summary.learned).toBe('Token was expiring too soon');
      expect(result.summary.completed).toBe('Extended token TTL to 24h');
      expect(result.summary.next_steps).toBe('Monitor error rates');
    }
  });

  it('treats <skip_summary reason="…"/> as a first-class summary with skipped:true', () => {
    const result = parseAgentXml('<skip_summary reason="no work done"/>');
    expect(result.valid).toBe(true);
    if (result.valid && result.summary) {
      expect(result.summary.skipped).toBe(true);
      expect(result.summary.skip_reason).toBe('no work done');
    }
  });

  it('does NOT coerce <observation> into a summary (former #1633 path deleted)', () => {
    const result = parseAgentXml('<observation><title>foo</title></observation>');
    expect(result.valid).toBe(true);
    if (result.valid) {
      expect(result.summary).toBeNull();
      expect(result.observations).toHaveLength(1);
    }
  });

  it('treats first root tag (<observation>) as the result kind when both present', () => {
    const text = `<observation><title>obs title</title></observation>
    <summary><request>summary request</request></summary>`;
    const result = parseAgentXml(text);
    expect(result.valid).toBe(true);
    if (result.valid) {
      expect(result.summary).toBeNull();
      expect(result.observations).toHaveLength(1);
      expect(result.observations[0].title).toBe('obs title');
    }
  });

  it('returns invalid for empty input', () => {
    expect(parseAgentXml('').valid).toBe(false);
    expect(parseAgentXml('   \n  ').valid).toBe(false);
  });
});