thedotmack--claude-mem/tests/integration/worker-api-endpoints.test.ts

import { describe, it, expect, beforeEach, afterEach, afterAll, spyOn, mock } from 'bun:test';
import { logger } from '../../src/utils/logger.js';

// Capture the real middleware module before mock.module mutates the live
// namespace, then re-register the snapshot in afterAll. bun's mock.module is
// process-global and mock.restore() does NOT undo it, so without this the stub
// createMiddleware leaks into later files (e.g. CORS + v1-routes server tests).
import * as realMiddleware from '../../src/services/worker/http/middleware.js';
const realMiddlewareSnapshot = { ...realMiddleware };

mock.module('../../src/services/worker/http/middleware.js', () => ({
  createMiddleware: () => [],
  requireLocalhost: (_req: any, _res: any, next: any) => next(),
  summarizeRequestBody: () => 'test body',
}));

import { Server } from '../../src/services/server/Server.js';
import type { ServerOptions } from '../../src/services/server/Server.js';
import { WorkerService } from '../../src/services/worker-service.js';
import {
  recordDependencyStatus,
  resetDependencyStatusesForTesting,
} from '../../src/shared/dependency-health.js';

let loggerSpies: ReturnType<typeof spyOn>[] = [];

describe('Worker API Endpoints Integration', () => {
  let server: Server;
  let testPort: number;
  let mockOptions: ServerOptions;

  beforeEach(() => {
    resetDependencyStatusesForTesting();
    loggerSpies = [
      spyOn(logger, 'info').mockImplementation(() => {}),
      spyOn(logger, 'debug').mockImplementation(() => {}),
      spyOn(logger, 'warn').mockImplementation(() => {}),
      spyOn(logger, 'error').mockImplementation(() => {}),
    ];

    mockOptions = {
      getInitializationComplete: () => true,
      getMcpReady: () => true,
      onShutdown: mock(() => Promise.resolve()),
      onRestart: mock(() => Promise.resolve()),
      workerPath: '/test/worker-service.cjs',
      getAiStatus: () => ({
        provider: 'claude',
        authMethod: 'cli',
        lastInteraction: null,
      }),
    };

    testPort = 40000 + Math.floor(Math.random() * 10000);
  });

  afterEach(async () => {
    resetDependencyStatusesForTesting();
    loggerSpies.forEach(spy => spy.mockRestore());

    if (server && server.getHttpServer()) {
      try {
        await server.close();
      } catch {
        // Ignore cleanup errors
      }
    }
    mock.restore();
  });

  afterAll(() => {
    mock.module('../../src/services/worker/http/middleware.js', () => realMiddlewareSnapshot);
  });

  describe('Health/Readiness/Version Endpoints', () => {
    describe('GET /api/health', () => {
      it('should return status, initialized, mcpReady, platform, pid', async () => {
        server = new Server(mockOptions);
        await server.listen(testPort, '127.0.0.1');

        const response = await fetch(`http://127.0.0.1:${testPort}/api/health`);
        expect(response.status).toBe(200);

        const body = await response.json();
        expect(body).toHaveProperty('status', 'ok');
        expect(body).toHaveProperty('initialized', true);
        expect(body).toHaveProperty('mcpReady', true);
        expect(body).toHaveProperty('platform');
        expect(body).toHaveProperty('pid');
        expect(typeof body.platform).toBe('string');
        expect(typeof body.pid).toBe('number');
      });

      it('should reflect uninitialized state', async () => {
        const uninitOptions: ServerOptions = {
          getInitializationComplete: () => false,
          getMcpReady: () => false,
          onShutdown: mock(() => Promise.resolve()),
          onRestart: mock(() => Promise.resolve()),
          workerPath: '/test/worker-service.cjs',
          getAiStatus: () => ({ provider: 'claude', authMethod: 'cli', lastInteraction: null }),
        };

        server = new Server(uninitOptions);
        await server.listen(testPort, '127.0.0.1');

        const response = await fetch(`http://127.0.0.1:${testPort}/api/health`);
        const body = await response.json();

        expect(body.status).toBe('ok'); 
        expect(body.initialized).toBe(false);
        expect(body.mcpReady).toBe(false);
      });

      it('includes dependency health and stays HTTP 200 for dependency-only degradation', async () => {
        recordDependencyStatus(
          'uvx',
          'vector_search_unavailable',
          'uvx executable not found on effective PATH for vector search',
          'Install uv and restart claude-mem',
        );

        server = new Server(mockOptions);
        await server.listen(testPort, '127.0.0.1');

        const response = await fetch(`http://127.0.0.1:${testPort}/api/health`);
        expect(response.status).toBe(200);

        const body = await response.json();
        expect(body.status).toBe('ok');
        expect(body.dependencies).toMatchObject({
          degraded: true,
          statuses: [
            {
              dependency: 'uvx',
              kind: 'vector_search_unavailable',
              message: 'uvx executable not found on effective PATH for vector search',
              remediation: 'Install uv and restart claude-mem',
            },
          ],
        });
      });
    });

    describe('GET /api/readiness', () => {
      it('should return 200 with status ready when initialized', async () => {
        server = new Server(mockOptions);
        await server.listen(testPort, '127.0.0.1');

        const response = await fetch(`http://127.0.0.1:${testPort}/api/readiness`);
        expect(response.status).toBe(200);

        const body = await response.json();
        expect(body.status).toBe('ready');
        expect(body.mcpReady).toBe(true);
      });

      it('should return 503 with status initializing when not ready', async () => {
        const uninitOptions: ServerOptions = {
          getInitializationComplete: () => false,
          getMcpReady: () => false,
          onShutdown: mock(() => Promise.resolve()),
          onRestart: mock(() => Promise.resolve()),
          workerPath: '/test/worker-service.cjs',
          getAiStatus: () => ({ provider: 'claude', authMethod: 'cli', lastInteraction: null }),
        };

        server = new Server(uninitOptions);
        await server.listen(testPort, '127.0.0.1');

        const response = await fetch(`http://127.0.0.1:${testPort}/api/readiness`);
        expect(response.status).toBe(503);

        const body = await response.json();
        expect(body.status).toBe('initializing');
        expect(body.message).toContain('initializing');
      });
    });

    describe('GET /api/version', () => {
      it('should return version string', async () => {
        server = new Server(mockOptions);
        await server.listen(testPort, '127.0.0.1');

        const response = await fetch(`http://127.0.0.1:${testPort}/api/version`);
        expect(response.status).toBe(200);

        const body = await response.json();
        expect(body).toHaveProperty('version');
        expect(typeof body.version).toBe('string');
      });
    });

    describe('GET /api/settings/dependency-health', () => {
      it('passes through WorkerService initialization guard while initialization is incomplete', async () => {
        recordDependencyStatus(
          'claude_cli',
          'setup_required',
          'Claude executable not found',
          'Install Claude Code CLI',
        );

        const worker = new WorkerService();
        expect((worker as any).initializationCompleteFlag).toBe(false);
        server = (worker as unknown as { server: Server }).server;
        await server.listen(testPort, '127.0.0.1');

        const guardedResponse = await fetch(`http://127.0.0.1:${testPort}/api/settings`);
        expect(guardedResponse.status).toBe(503);

        const response = await fetch(`http://127.0.0.1:${testPort}/api/settings/dependency-health`);
        expect(response.status).toBe(200);

        const body = await response.json();
        expect(body).toMatchObject({
          degraded: true,
          statuses: [
            {
              dependency: 'claude_cli',
              kind: 'setup_required',
              message: 'Claude executable not found',
              remediation: 'Install Claude Code CLI',
            },
          ],
        });
      });
    });
  });

  describe('Error Handling', () => {
    it('includes dependency health in admin doctor output', async () => {
      recordDependencyStatus(
        'claude_cli',
        'setup_required',
        'Claude executable not found',
        'Install Claude Code CLI',
      );

      server = new Server(mockOptions);
      await server.listen(testPort, '127.0.0.1');

      const response = await fetch(`http://127.0.0.1:${testPort}/api/admin/doctor`);
      expect(response.status).toBe(200);

      const body = await response.json();
      expect(body.health.dependencies).toMatchObject({
        degraded: true,
        statuses: [
          {
            dependency: 'claude_cli',
            kind: 'setup_required',
            message: 'Claude executable not found',
            remediation: 'Install Claude Code CLI',
          },
        ],
      });
    });

    describe('404 Not Found', () => {
      it('should return 404 for unknown GET routes', async () => {
        server = new Server(mockOptions);
        server.finalizeRoutes();
        await server.listen(testPort, '127.0.0.1');

        const response = await fetch(`http://127.0.0.1:${testPort}/api/unknown-endpoint`);
        expect(response.status).toBe(404);

        const body = await response.json();
        expect(body.error).toBe('NotFound');
      });

      it('should return 404 for unknown POST routes', async () => {
        server = new Server(mockOptions);
        server.finalizeRoutes();
        await server.listen(testPort, '127.0.0.1');

        const response = await fetch(`http://127.0.0.1:${testPort}/api/unknown-endpoint`, {
          method: 'POST',
          headers: { 'Content-Type': 'application/json' },
          body: JSON.stringify({ test: 'data' })
        });
        expect(response.status).toBe(404);
      });

      it('should return 404 for nested unknown routes', async () => {
        server = new Server(mockOptions);
        server.finalizeRoutes();
        await server.listen(testPort, '127.0.0.1');

        const response = await fetch(`http://127.0.0.1:${testPort}/api/search/nonexistent/nested`);
        expect(response.status).toBe(404);
      });
    });

    describe('Method handling', () => {
      it('should handle OPTIONS requests', async () => {
        server = new Server(mockOptions);
        await server.listen(testPort, '127.0.0.1');

        const response = await fetch(`http://127.0.0.1:${testPort}/api/health`, {
          method: 'OPTIONS'
        });
        expect([200, 204]).toContain(response.status);
      });
    });
  });

  describe('Content-Type Handling', () => {
    it('should accept application/json content type', async () => {
      server = new Server(mockOptions);
      server.finalizeRoutes();
      await server.listen(testPort, '127.0.0.1');

      const response = await fetch(`http://127.0.0.1:${testPort}/api/nonexistent`, {
        method: 'POST',
        headers: { 'Content-Type': 'application/json' },
        body: JSON.stringify({ key: 'value' })
      });

      expect(response.status).toBe(404);
    });

    it('should return JSON responses with correct content type', async () => {
      server = new Server(mockOptions);
      await server.listen(testPort, '127.0.0.1');

      const response = await fetch(`http://127.0.0.1:${testPort}/api/health`);
      const contentType = response.headers.get('content-type');

      expect(contentType).toContain('application/json');
    });
  });

  describe('Server State Management', () => {
    it('should track initialization state dynamically', async () => {
      let initialized = false;
      const dynamicOptions: ServerOptions = {
        getInitializationComplete: () => initialized,
        getMcpReady: () => true,
        onShutdown: mock(() => Promise.resolve()),
        onRestart: mock(() => Promise.resolve()),
        workerPath: '/test/worker-service.cjs',
        getAiStatus: () => ({ provider: 'claude', authMethod: 'cli', lastInteraction: null }),
      };

      server = new Server(dynamicOptions);
      await server.listen(testPort, '127.0.0.1');

      let response = await fetch(`http://127.0.0.1:${testPort}/api/readiness`);
      expect(response.status).toBe(503);

      initialized = true;

      response = await fetch(`http://127.0.0.1:${testPort}/api/readiness`);
      expect(response.status).toBe(200);
    });

    it('should track MCP ready state dynamically', async () => {
      let mcpReady = false;
      const dynamicOptions: ServerOptions = {
        getInitializationComplete: () => true,
        getMcpReady: () => mcpReady,
        onShutdown: mock(() => Promise.resolve()),
        onRestart: mock(() => Promise.resolve()),
        workerPath: '/test/worker-service.cjs',
        getAiStatus: () => ({ provider: 'claude', authMethod: 'cli', lastInteraction: null }),
      };

      server = new Server(dynamicOptions);
      await server.listen(testPort, '127.0.0.1');

      let response = await fetch(`http://127.0.0.1:${testPort}/api/health`);
      let body = await response.json();
      expect(body.mcpReady).toBe(false);

      mcpReady = true;

      response = await fetch(`http://127.0.0.1:${testPort}/api/health`);
      body = await response.json();
      expect(body.mcpReady).toBe(true);
    });
  });

  describe('Server Lifecycle', () => {
    it('should start listening on specified port', async () => {
      server = new Server(mockOptions);
      await server.listen(testPort, '127.0.0.1');

      const httpServer = server.getHttpServer();
      expect(httpServer).not.toBeNull();
      expect(httpServer!.listening).toBe(true);
    });

    it('should close gracefully', async () => {
      server = new Server(mockOptions);
      await server.listen(testPort, '127.0.0.1');

      const response = await fetch(`http://127.0.0.1:${testPort}/api/health`);
      expect(response.status).toBe(200);

      try {
        await server.close();
      } catch (e: any) {
        if (e.code !== 'ERR_SERVER_NOT_RUNNING') throw e;
      }

      const httpServer = server.getHttpServer();
      if (httpServer) {
        expect(httpServer.listening).toBe(false);
      }
    });

    it('should handle port conflicts', async () => {
      server = new Server(mockOptions);
      const server2 = new Server(mockOptions);

      await server.listen(testPort, '127.0.0.1');

      await expect(server2.listen(testPort, '127.0.0.1')).rejects.toThrow();

      const httpServer2 = server2.getHttpServer();
      if (httpServer2) {
        expect(httpServer2.listening).toBe(false);
      }
    });

    it('should allow restart on same port after close', async () => {
      server = new Server(mockOptions);
      await server.listen(testPort, '127.0.0.1');

      try {
        await server.close();
      } catch (e: any) {
        if (e.code !== 'ERR_SERVER_NOT_RUNNING') throw e;
      }

      await new Promise(resolve => setTimeout(resolve, 100));

      const server2 = new Server(mockOptions);
      await server2.listen(testPort, '127.0.0.1');

      expect(server2.getHttpServer()!.listening).toBe(true);

      try {
        await server2.close();
      } catch {
        // Ignore cleanup errors
      }
    });
  });

  describe('Route Registration', () => {
    it('should register route handlers', () => {
      server = new Server(mockOptions);

      const setupRoutesMock = mock(() => {});
      const mockRouteHandler = {
        setupRoutes: setupRoutesMock,
      };

      server.registerRoutes(mockRouteHandler);

      expect(setupRoutesMock).toHaveBeenCalledTimes(1);
      expect(setupRoutesMock).toHaveBeenCalledWith(server.app);
    });

    it('should register multiple route handlers', () => {
      server = new Server(mockOptions);

      const handler1Mock = mock(() => {});
      const handler2Mock = mock(() => {});

      server.registerRoutes({ setupRoutes: handler1Mock });
      server.registerRoutes({ setupRoutes: handler2Mock });

      expect(handler1Mock).toHaveBeenCalledTimes(1);
      expect(handler2Mock).toHaveBeenCalledTimes(1);
    });
  });
});