thedotmack--claude-mem/tests/claude-provider-error-classifier.test.ts

import { describe, it, expect, beforeEach, afterEach, spyOn } from 'bun:test';

import {
  classifyClaudeError,
  __resetEffortHintLatchForTesting,
} from '../src/services/worker/ClaudeProvider.js';
import { isClassified } from '../src/services/worker/provider-errors.js';
import { logger } from '../src/utils/logger.js';

/**
 * Tests for HTTP 400 classification in ClaudeProvider's classifyClaudeError.
 *
 * Regression coverage for #2357: ClaudeProvider previously had no explicit
 * HTTP 400 handling, so the default branch classified all 400s as `transient`
 * and the retry loop would hammer a permanent error indefinitely (e.g. when
 * CLAUDE_CODE_EFFORT_LEVEL leaks into the SDK subprocess and the model
 * rejects the `effort` parameter).
 */
describe('classifyClaudeError — HTTP 400 handling (#2357)', () => {
  let warnSpy: ReturnType<typeof spyOn>;

  beforeEach(() => {
    __resetEffortHintLatchForTesting();
    warnSpy = spyOn(logger, 'warn').mockImplementation(() => {});
  });

  afterEach(() => {
    warnSpy.mockRestore();
    __resetEffortHintLatchForTesting();
  });

  it('classifies 400 with "effort parameter" body as unrecoverable AND logs an SDK warn once', () => {
    const sdkErr = Object.assign(
      new Error('This model does not support the effort parameter.'),
      { status: 400 },
    );

    const classified = classifyClaudeError(sdkErr);

    expect(isClassified(classified)).toBe(true);
    expect(classified.kind).toBe('unrecoverable');
    expect(warnSpy).toHaveBeenCalledTimes(1);
    // First positional arg of logger.warn is the component category.
    const [component, hintMessage] = warnSpy.mock.calls[0] as [string, string, ...unknown[]];
    expect(component).toBe('SDK');
    expect(hintMessage).toMatch(/effort/i);
    expect(hintMessage).toMatch(/2357/);
  });

  it('classifies 400 with effort marker in a structured body field', () => {
    const sdkErr = Object.assign(
      new Error('Bad request'),
      {
        status: 400,
        body: { error: { message: 'This model does not support the effort parameter.' } },
      },
    );

    const classified = classifyClaudeError(sdkErr);

    expect(classified.kind).toBe('unrecoverable');
    expect(warnSpy).toHaveBeenCalledTimes(1);
  });

  it('classifies 400 without effort body as unrecoverable WITHOUT firing the effort hint', () => {
    const sdkErr = Object.assign(
      new Error('some other 400 error'),
      { status: 400 },
    );

    const classified = classifyClaudeError(sdkErr);

    expect(classified.kind).toBe('unrecoverable');
    expect(warnSpy).not.toHaveBeenCalled();
  });

  it('throttles the effort hint to one log per process even on repeated 400s', () => {
    const sdkErr = Object.assign(
      new Error('This model does not support the effort parameter.'),
      { status: 400 },
    );

    for (let i = 0; i < 5; i++) {
      const classified = classifyClaudeError(sdkErr);
      expect(classified.kind).toBe('unrecoverable');
    }

    expect(warnSpy).toHaveBeenCalledTimes(1);
  });
});

describe('classifyClaudeError — sibling status codes (regression sanity)', () => {
  let warnSpy: ReturnType<typeof spyOn>;

  beforeEach(() => {
    __resetEffortHintLatchForTesting();
    warnSpy = spyOn(logger, 'warn').mockImplementation(() => {});
  });

  afterEach(() => {
    warnSpy.mockRestore();
    __resetEffortHintLatchForTesting();
  });

  it('classifies status=401 as auth_invalid', () => {
    const sdkErr = Object.assign(new Error('unauthorized'), { status: 401 });
    const classified = classifyClaudeError(sdkErr);
    expect(classified.kind).toBe('auth_invalid');
  });

  it('classifies status=429 as rate_limit', () => {
    const sdkErr = Object.assign(new Error('rate limited'), { status: 429 });
    const classified = classifyClaudeError(sdkErr);
    expect(classified.kind).toBe('rate_limit');
  });

  it('classifies a network error with no status as transient', () => {
    const networkErr = new Error('ECONNRESET: socket hang up');
    const classified = classifyClaudeError(networkErr);
    expect(classified.kind).toBe('transient');
  });
});

/**
 * Regression coverage for #2656: when the Anthropic Agent SDK wraps a 400
 * `invalid_request_error` (e.g. "The provided model identifier is invalid")
 * the `.status` field can be lost in the wrapping. Without a message-based
 * fallback the error fell through to the default `transient` branch and the
 * worker retried indefinitely while `/health` kept reporting `ok`.
 */
describe('classifyClaudeError — model identifier rejections without .status (#2656)', () => {
  let warnSpy: ReturnType<typeof spyOn>;

  beforeEach(() => {
    __resetEffortHintLatchForTesting();
    warnSpy = spyOn(logger, 'warn').mockImplementation(() => {});
  });

  afterEach(() => {
    warnSpy.mockRestore();
    __resetEffortHintLatchForTesting();
  });

  it('classifies "The provided model identifier is invalid" as unrecoverable even without a status field', () => {
    const sdkErr = new Error('The provided model identifier is invalid');
    const classified = classifyClaudeError(sdkErr);
    expect(classified.kind).toBe('unrecoverable');
  });

  it('classifies wrapped errors exposing error.type=invalid_request_error as unrecoverable', () => {
    const sdkErr = Object.assign(
      new Error('Anthropic SDK error'),
      { error: { type: 'invalid_request_error' } },
    );
    const classified = classifyClaudeError(sdkErr);
    expect(classified.kind).toBe('unrecoverable');
  });

  it('classifies errors carrying the "invalid_request_error" string in the message as unrecoverable', () => {
    const sdkErr = new Error('Request failed: invalid_request_error from upstream');
    const classified = classifyClaudeError(sdkErr);
    expect(classified.kind).toBe('unrecoverable');
  });

  it('does not match unrelated messages containing the word "invalid"', () => {
    const sdkErr = new Error('Some unrelated invalid input from a tool');
    const classified = classifyClaudeError(sdkErr);
    // Must NOT be unrecoverable just because the word "invalid" appears —
    // matching is anchored on the canonical Anthropic phrases only.
    expect(classified.kind).toBe('transient');
  });

  it('still routes statused 400s through the existing branch (does not fall through)', () => {
    const sdkErr = Object.assign(
      new Error('The provided model identifier is invalid'),
      { status: 400 },
    );
    const classified = classifyClaudeError(sdkErr);
    expect(classified.kind).toBe('unrecoverable');
    // The pre-existing status=400 branch handles this case before the new
    // fallback runs; no effort-hint should fire (no effort marker present).
    expect(warnSpy).not.toHaveBeenCalled();
  });

  it('keeps a statused 5xx carrying invalid_request_error transient (status guard)', () => {
    const sdkErr = Object.assign(
      new Error('gateway error: invalid_request_error from upstream'),
      { status: 503, error: { type: 'invalid_request_error' } },
    );
    const classified = classifyClaudeError(sdkErr);
    expect(classified.kind).toBe('transient');
  });
});