347 lines
12 KiB
TypeScript
347 lines
12 KiB
TypeScript
import type { Page, TestInfo } from '@stablyai/playwright-test'
|
|
import { expect } from '@stablyai/playwright-test'
|
|
import { randomUUID } from 'node:crypto'
|
|
import { rmSync } from 'node:fs'
|
|
import path from 'node:path'
|
|
import {
|
|
type HiddenPressureOutputMode,
|
|
writePressureOutputScript
|
|
} from './artificial-opencode-hidden-pressure-script'
|
|
import {
|
|
ensureTerminalVisible,
|
|
getActiveWorktreeId,
|
|
getAllWorktreeIds,
|
|
switchToWorktree,
|
|
waitForActiveWorktree,
|
|
waitForSessionReady
|
|
} from './helpers/store'
|
|
import {
|
|
getTerminalContent,
|
|
sendToTerminal,
|
|
waitForActivePanePtyId,
|
|
waitForActiveTerminalManager
|
|
} from './helpers/terminal'
|
|
|
|
type HiddenPressurePane = {
|
|
ptyId: string
|
|
}
|
|
|
|
type HiddenPressureDeps<TMeasurement, TDebug, TScheduler, TMainPressure, TAckGate> = {
|
|
annotateTypingMeasurement: (
|
|
testInfo: TestInfo,
|
|
type: string,
|
|
paneCount: number,
|
|
measurement: TMeasurement,
|
|
debug: TDebug | null,
|
|
scheduler: TScheduler | null,
|
|
mainPressure: TMainPressure | null,
|
|
ackGate: TAckGate | null
|
|
) => void
|
|
ensureActiveWorktreePaneLoad: (page: Page, paneCount: number) => Promise<HiddenPressurePane[]>
|
|
holdTerminalAckGate: (page: Page, ptyIds: string[]) => Promise<void>
|
|
measureTypingDuringLoad: (
|
|
page: Page,
|
|
scriptPath: string,
|
|
ptyId: string,
|
|
runId: string
|
|
) => Promise<TMeasurement>
|
|
readMainPtyPressureDebug: (page: Page) => Promise<TMainPressure | null>
|
|
readTerminalAckGateDebug: (page: Page) => Promise<TAckGate | null>
|
|
readTerminalOutputSchedulerDebug: (page: Page) => Promise<TScheduler | null>
|
|
readTerminalPtyOutputDebug: (page: Page) => Promise<TDebug | null>
|
|
releaseTerminalAckGate: (page: Page) => Promise<void>
|
|
resetTerminalPtyOutputDebug: (page: Page) => Promise<void>
|
|
writeInteractivePromptScript: (scriptPath: string, runId: string) => void
|
|
}
|
|
|
|
// Why: the renderer hidden-skip counters are gone with the skip grammar —
|
|
// withheld hidden output is observed via main's delivery-drop counters only.
|
|
type HiddenPressureDebug = {
|
|
hiddenRendererMode2031ReplyCount: number
|
|
}
|
|
|
|
type HiddenPressureMeasurement = {
|
|
medianLatencyMs: number
|
|
worstLatencyMs: number
|
|
maxTimerDriftMs: number
|
|
}
|
|
|
|
type HiddenPressureMainSnapshot = {
|
|
peakPendingChars: number
|
|
peakRendererInFlightChars: number
|
|
ackGatedFlushSkipCount: number
|
|
hiddenDeliveryDroppedChars: number
|
|
hiddenDeliveryGatedPtyCount: number
|
|
}
|
|
|
|
type HiddenPressureSchedulerSnapshot = {
|
|
peakQueuedChars: number
|
|
droppedBacklogCount: number
|
|
}
|
|
|
|
type HiddenPressureAckGate = {
|
|
heldAckChars: number
|
|
}
|
|
|
|
// Why: restore still has to finish promptly, but parallel Electron workers on
|
|
// Linux CI can overshoot the 1s product target without a responsiveness regression.
|
|
// Main relaxed this to 4s for drain-plus-poll overhead on loaded OSS runners;
|
|
// this branch KEEPS the strict budget — the background keep-tail global budget
|
|
// bounds the aggregate a reveal drains, so a slow restore here is a regression.
|
|
const MAX_HIDDEN_RESTORE_LATENCY_MS = 1_500
|
|
// Why: Phase-4 hidden-delivery gate contract — hidden PTY bytes are dropped in
|
|
// main after model ingestion, so renderer-delivery pressure must stay FAR
|
|
// below the old 2 MB ACK-backpressure target instead of reaching it.
|
|
const MAIN_RENDERER_PRESSURE_TARGET_CHARS = 2 * 1024 * 1024
|
|
// Why: in this hidden real-PTY pressure case, maxTimerDriftMs and worst-key
|
|
// latency catch the same isolated CI starvation spike; median remains strict.
|
|
const MAX_HIDDEN_PRESSURE_TIMER_DRIFT_MS = 3_000
|
|
|
|
export async function runHiddenRealPtyPressureScenario<
|
|
TMeasurement extends HiddenPressureMeasurement,
|
|
TDebug extends HiddenPressureDebug,
|
|
TMainPressure extends HiddenPressureMainSnapshot,
|
|
TAckGate extends HiddenPressureAckGate,
|
|
TScheduler extends HiddenPressureSchedulerSnapshot
|
|
>({
|
|
deps,
|
|
annotationSuffix,
|
|
hiddenPaneCount,
|
|
pressureOutputChars,
|
|
pressureOutputMode = 'tui',
|
|
pressureStartDelayMs,
|
|
testInfo,
|
|
testRepoPath,
|
|
orcaPage
|
|
}: {
|
|
deps: HiddenPressureDeps<TMeasurement, TDebug, TScheduler, TMainPressure, TAckGate>
|
|
annotationSuffix?: string
|
|
hiddenPaneCount: number
|
|
pressureOutputChars: number
|
|
pressureOutputMode?: HiddenPressureOutputMode
|
|
pressureStartDelayMs: number
|
|
testInfo: TestInfo
|
|
testRepoPath: string
|
|
orcaPage: Page
|
|
}): Promise<void> {
|
|
await waitForSessionReady(orcaPage)
|
|
const firstWorktreeId = await waitForActiveWorktree(orcaPage)
|
|
const allWorktreeIds = await getAllWorktreeIds(orcaPage)
|
|
const secondWorktreeId = allWorktreeIds.find((id) => id !== firstWorktreeId)
|
|
expect(Boolean(secondWorktreeId), 'OpenCode hidden PTY pressure needs a second worktree').toBe(
|
|
true
|
|
)
|
|
if (!secondWorktreeId) {
|
|
return
|
|
}
|
|
|
|
await switchToWorktree(orcaPage, secondWorktreeId)
|
|
const hiddenPanes = await deps.ensureActiveWorktreePaneLoad(orcaPage, hiddenPaneCount)
|
|
|
|
const runId = randomUUID()
|
|
const typingScriptPath = path.join(
|
|
testRepoPath,
|
|
`.orca-opencode-hidden-pressure-typing-${runId}.mjs`
|
|
)
|
|
const pressureScriptPath = path.join(
|
|
testRepoPath,
|
|
`.orca-opencode-hidden-pressure-load-${runId}.mjs`
|
|
)
|
|
deps.writeInteractivePromptScript(typingScriptPath, runId)
|
|
writePressureOutputScript(pressureScriptPath, runId, pressureOutputMode)
|
|
|
|
await deps.resetTerminalPtyOutputDebug(orcaPage)
|
|
await deps.holdTerminalAckGate(
|
|
orcaPage,
|
|
hiddenPanes.map((pane) => pane.ptyId)
|
|
)
|
|
try {
|
|
await startHiddenPressureCommands({
|
|
hiddenPanes,
|
|
orcaPage,
|
|
pressureOutputChars,
|
|
pressureScriptPath,
|
|
pressureStartDelayMs
|
|
})
|
|
await switchToTypingWorkspace(orcaPage, firstWorktreeId)
|
|
const typingPtyId = await waitForActivePanePtyId(orcaPage)
|
|
|
|
// Why: under the Phase-4 hidden-delivery gate the hidden panes' bytes are
|
|
// dropped in main after model ingestion, so renderer-delivery pressure
|
|
// never builds. Wait for the gate to drop at least one pane's worth of
|
|
// output instead of the old 2 MB ACK-backpressure target.
|
|
await waitForMainHiddenDeliveryDrops(orcaPage, deps, pressureOutputChars)
|
|
const measurement = await deps.measureTypingDuringLoad(
|
|
orcaPage,
|
|
typingScriptPath,
|
|
typingPtyId,
|
|
runId
|
|
)
|
|
const debug = await deps.readTerminalPtyOutputDebug(orcaPage)
|
|
const scheduler = await deps.readTerminalOutputSchedulerDebug(orcaPage)
|
|
const mainPressure = await deps.readMainPtyPressureDebug(orcaPage)
|
|
const ackGate = await deps.readTerminalAckGateDebug(orcaPage)
|
|
deps.annotateTypingMeasurement(
|
|
testInfo,
|
|
`opencode-hidden-real-pty-pressure-typing${annotationSuffix ?? ''}`,
|
|
hiddenPanes.length + 1,
|
|
measurement,
|
|
debug,
|
|
scheduler,
|
|
mainPressure,
|
|
ackGate
|
|
)
|
|
|
|
// Hidden-delivery contract (all pressure modes): bytes never reach the
|
|
// renderer — main's drop counter is the withheld-output signal (the
|
|
// renderer skip counters were deleted with the skip grammar) — and main's
|
|
// renderer-delivery pressure must stay clearly below the old 2 MB
|
|
// backpressure target.
|
|
expect(mainPressure?.hiddenDeliveryDroppedChars ?? 0).toBeGreaterThanOrEqual(
|
|
pressureOutputChars
|
|
)
|
|
expect(mainPressure?.peakRendererInFlightChars ?? 0).toBeLessThan(
|
|
MAIN_RENDERER_PRESSURE_TARGET_CHARS
|
|
)
|
|
// Why: the renderer scheduler queue must stay ~empty (no hidden bytes to
|
|
// queue) and must never drop a backlog — strict, per the gate contract.
|
|
expect(scheduler?.peakQueuedChars ?? 0).toBeLessThan(pressureOutputChars)
|
|
expect(scheduler?.droppedBacklogCount ?? Number.POSITIVE_INFINITY).toBe(0)
|
|
expect(measurement.medianLatencyMs).toBeLessThan(75)
|
|
// Why: worst *single-key echo* under 8MB synthetic backpressure lands behind
|
|
// whichever flush it collides with, so on a contended OSS shard it is
|
|
// environment-dominated (seen at ~2s). Keep it only as a catastrophic-hang
|
|
// detector — the original regression (input freezing for seconds) shows up in
|
|
// the median too. Aligns with ssh-docker-relay-perf's 2s worst-key tolerance.
|
|
expect(measurement.worstLatencyMs).toBeLessThan(3_000)
|
|
expect(measurement.maxTimerDriftMs).toBeLessThan(MAX_HIDDEN_PRESSURE_TIMER_DRIFT_MS)
|
|
|
|
await deps.releaseTerminalAckGate(orcaPage)
|
|
const restoreLatencyMs = await measureHiddenOutputRestoreLatency(
|
|
orcaPage,
|
|
secondWorktreeId,
|
|
runId
|
|
)
|
|
testInfo.annotations.push({
|
|
type: `opencode-hidden-real-pty-restore${annotationSuffix ?? ''}`,
|
|
description: `panes=${hiddenPanes.length + 1} restore=${restoreLatencyMs.toFixed(
|
|
1
|
|
)}ms hiddenDeliveryDroppedChars=${
|
|
mainPressure?.hiddenDeliveryDroppedChars ?? 0
|
|
} mainPeakInFlightChars=${mainPressure?.peakRendererInFlightChars ?? 0} heldAckChars=${
|
|
ackGate?.heldAckChars ?? 0
|
|
}`
|
|
})
|
|
expect(restoreLatencyMs).toBeLessThan(MAX_HIDDEN_RESTORE_LATENCY_MS)
|
|
} finally {
|
|
await cleanupHiddenPressureScenario({
|
|
deps,
|
|
firstWorktreeId,
|
|
hiddenPanes,
|
|
orcaPage,
|
|
pressureScriptPath,
|
|
secondWorktreeId,
|
|
typingScriptPath
|
|
})
|
|
}
|
|
}
|
|
|
|
// Why: replaces the old waitForMainPtyPressureBacklog premise — the Phase-4
|
|
// gate drops hidden bytes in main, so renderer-delivery pressure never builds;
|
|
// readiness is the gate reporting one pane's worth of dropped output.
|
|
async function waitForMainHiddenDeliveryDrops<TMainPressure extends HiddenPressureMainSnapshot>(
|
|
orcaPage: Page,
|
|
deps: { readMainPtyPressureDebug: (page: Page) => Promise<TMainPressure | null> },
|
|
pressureOutputChars: number
|
|
): Promise<void> {
|
|
await expect
|
|
.poll(
|
|
async () => (await deps.readMainPtyPressureDebug(orcaPage))?.hiddenDeliveryDroppedChars ?? 0,
|
|
{ timeout: 30_000, message: 'Main hidden-delivery gate did not drop hidden PTY output' }
|
|
)
|
|
.toBeGreaterThanOrEqual(pressureOutputChars)
|
|
}
|
|
|
|
async function measureHiddenOutputRestoreLatency(
|
|
orcaPage: Page,
|
|
worktreeId: string,
|
|
runId: string
|
|
): Promise<number> {
|
|
const restoreStart = performance.now()
|
|
await switchToWorktree(orcaPage, worktreeId)
|
|
await expect
|
|
.poll(() => getTerminalContent(orcaPage, 20_000), {
|
|
timeout: 20_000,
|
|
message: 'Hidden PTY output was not restored from main buffer on return'
|
|
})
|
|
.toContain(`OPENCODE_PRESSURE_DONE_${runId}_`)
|
|
return performance.now() - restoreStart
|
|
}
|
|
|
|
async function startHiddenPressureCommands({
|
|
hiddenPanes,
|
|
orcaPage,
|
|
pressureOutputChars,
|
|
pressureScriptPath,
|
|
pressureStartDelayMs
|
|
}: {
|
|
hiddenPanes: HiddenPressurePane[]
|
|
orcaPage: Page
|
|
pressureOutputChars: number
|
|
pressureScriptPath: string
|
|
pressureStartDelayMs: number
|
|
}): Promise<void> {
|
|
await Promise.all(
|
|
hiddenPanes.map((pane, paneIndex) =>
|
|
sendToTerminal(
|
|
orcaPage,
|
|
pane.ptyId,
|
|
`node ${JSON.stringify(pressureScriptPath)} ${paneIndex} ${pressureOutputChars} ${pressureStartDelayMs}\r`
|
|
)
|
|
)
|
|
)
|
|
}
|
|
|
|
async function switchToTypingWorkspace(orcaPage: Page, worktreeId: string): Promise<void> {
|
|
await switchToWorktree(orcaPage, worktreeId)
|
|
await expect.poll(() => getActiveWorktreeId(orcaPage), { timeout: 10_000 }).toBe(worktreeId)
|
|
await ensureTerminalVisible(orcaPage)
|
|
await waitForActiveTerminalManager(orcaPage, 30_000)
|
|
}
|
|
|
|
async function cleanupHiddenPressureScenario<
|
|
TMeasurement,
|
|
TDebug,
|
|
TScheduler,
|
|
TMainPressure,
|
|
TAckGate
|
|
>({
|
|
deps,
|
|
firstWorktreeId,
|
|
hiddenPanes,
|
|
orcaPage,
|
|
pressureScriptPath,
|
|
secondWorktreeId,
|
|
typingScriptPath
|
|
}: {
|
|
deps: HiddenPressureDeps<TMeasurement, TDebug, TScheduler, TMainPressure, TAckGate>
|
|
firstWorktreeId: string
|
|
hiddenPanes: HiddenPressurePane[]
|
|
orcaPage: Page
|
|
pressureScriptPath: string
|
|
secondWorktreeId: string
|
|
typingScriptPath: string
|
|
}): Promise<void> {
|
|
await deps.releaseTerminalAckGate(orcaPage)
|
|
await switchToWorktree(orcaPage, firstWorktreeId).catch(() => undefined)
|
|
await waitForActivePanePtyId(orcaPage)
|
|
.then((ptyId) => sendToTerminal(orcaPage, ptyId, '\x03'))
|
|
.catch(() => undefined)
|
|
await switchToWorktree(orcaPage, secondWorktreeId).catch(() => undefined)
|
|
await Promise.all(
|
|
hiddenPanes.map((pane) => sendToTerminal(orcaPage, pane.ptyId, '\x03').catch(() => undefined))
|
|
)
|
|
rmSync(typingScriptPath, { force: true })
|
|
rmSync(pressureScriptPath, { force: true })
|
|
}
|