d25d482dc2
CI / Migrate Dev DB (push) Has been skipped
CI / Detect Version (push) Has been cancelled
CI / Migrate DB (push) Has been cancelled
CI / Build Dev ECR (./docker/app.Dockerfile, ECR_APP) (push) Has been cancelled
CI / Build Dev ECR (./docker/db.Dockerfile, ECR_MIGRATIONS) (push) Has been cancelled
CI / Build Dev ECR (./docker/pii.Dockerfile, ECR_PII) (push) Has been cancelled
CI / Build Dev ECR (./docker/realtime.Dockerfile, ECR_REALTIME) (push) Has been cancelled
CI / Deploy Trigger.dev (Dev) (push) Has been cancelled
CI / Build AMD64 (./docker/app.Dockerfile, ECR_APP, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build AMD64 (./docker/db.Dockerfile, ECR_MIGRATIONS, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build AMD64 (./docker/pii.Dockerfile, ECR_PII, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build AMD64 (./docker/realtime.Dockerfile, ECR_REALTIME, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/app.Dockerfile, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/db.Dockerfile, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/pii.Dockerfile, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/realtime.Dockerfile, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Check Docs Changes (push) Has been cancelled
CI / Process Docs (push) Has been cancelled
CI / Create GitHub Release (push) Has been cancelled
CI / Test and Build (push) Has been cancelled
Publish CLI Package / publish-npm (push) Has been cancelled
Publish Python SDK / publish-pypi (push) Has been cancelled
Publish TypeScript SDK / publish-npm (push) Has been cancelled
257 lines
8.3 KiB
TypeScript
257 lines
8.3 KiB
TypeScript
/**
|
|
* @vitest-environment node
|
|
*/
|
|
|
|
import { redisConfigMock, redisConfigMockFns } from '@sim/testing'
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
const { mockHasAbortMarker, mockClearAbortMarker, mockWriteAbortMarker } = vi.hoisted(() => ({
|
|
mockHasAbortMarker: vi.fn().mockResolvedValue(false),
|
|
mockClearAbortMarker: vi.fn().mockResolvedValue(undefined),
|
|
mockWriteAbortMarker: vi.fn().mockResolvedValue(undefined),
|
|
}))
|
|
|
|
vi.mock('@/lib/core/config/redis', () => redisConfigMock)
|
|
vi.mock('@/lib/copilot/request/session/buffer', () => ({
|
|
hasAbortMarker: mockHasAbortMarker,
|
|
clearAbortMarker: mockClearAbortMarker,
|
|
writeAbortMarker: mockWriteAbortMarker,
|
|
}))
|
|
vi.mock('@/lib/copilot/request/otel', () => ({
|
|
withCopilotSpan: (_span: unknown, _attrs: unknown, fn: (span: unknown) => unknown) =>
|
|
fn({ setAttribute: vi.fn() }),
|
|
}))
|
|
|
|
import {
|
|
acquirePendingChatStream,
|
|
getChatStreamLockOwners,
|
|
releasePendingChatStream,
|
|
startAbortPoller,
|
|
} from '@/lib/copilot/request/session/abort'
|
|
|
|
describe('startAbortPoller heartbeat', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
vi.useFakeTimers()
|
|
mockHasAbortMarker.mockResolvedValue(false)
|
|
redisConfigMockFns.mockExtendLock.mockResolvedValue(true)
|
|
})
|
|
|
|
afterEach(() => {
|
|
vi.useRealTimers()
|
|
})
|
|
|
|
it('extends the chat stream lock approximately every heartbeat interval', async () => {
|
|
const controller = new AbortController()
|
|
const streamId = 'stream-heartbeat-1'
|
|
const chatId = 'chat-heartbeat-1'
|
|
|
|
const interval = startAbortPoller(streamId, controller, { chatId })
|
|
|
|
try {
|
|
await vi.advanceTimersByTimeAsync(15_000)
|
|
expect(redisConfigMockFns.mockExtendLock).not.toHaveBeenCalled()
|
|
|
|
await vi.advanceTimersByTimeAsync(6_000)
|
|
|
|
expect(redisConfigMockFns.mockExtendLock).toHaveBeenCalledTimes(1)
|
|
expect(redisConfigMockFns.mockExtendLock).toHaveBeenLastCalledWith(
|
|
`copilot:chat-stream-lock:${chatId}`,
|
|
streamId,
|
|
60
|
|
)
|
|
|
|
await vi.advanceTimersByTimeAsync(20_000)
|
|
expect(redisConfigMockFns.mockExtendLock).toHaveBeenCalledTimes(2)
|
|
|
|
await vi.advanceTimersByTimeAsync(20_000)
|
|
expect(redisConfigMockFns.mockExtendLock).toHaveBeenCalledTimes(3)
|
|
} finally {
|
|
clearInterval(interval)
|
|
}
|
|
})
|
|
|
|
it('does not extend the lock when no chatId is passed (backward compat)', async () => {
|
|
const controller = new AbortController()
|
|
const interval = startAbortPoller('stream-no-chat', controller, {})
|
|
|
|
try {
|
|
await vi.advanceTimersByTimeAsync(90_000)
|
|
expect(redisConfigMockFns.mockExtendLock).not.toHaveBeenCalled()
|
|
} finally {
|
|
clearInterval(interval)
|
|
}
|
|
})
|
|
|
|
it('retries on the next tick when extendLock throws (no 20s backoff)', async () => {
|
|
const controller = new AbortController()
|
|
const streamId = 'stream-retry'
|
|
const chatId = 'chat-retry'
|
|
|
|
redisConfigMockFns.mockExtendLock.mockRejectedValueOnce(new Error('redis down'))
|
|
|
|
const interval = startAbortPoller(streamId, controller, { chatId })
|
|
|
|
try {
|
|
await vi.advanceTimersByTimeAsync(20_000)
|
|
expect(redisConfigMockFns.mockExtendLock).toHaveBeenCalledTimes(1)
|
|
|
|
await vi.advanceTimersByTimeAsync(1_000)
|
|
expect(redisConfigMockFns.mockExtendLock).toHaveBeenCalledTimes(2)
|
|
} finally {
|
|
clearInterval(interval)
|
|
}
|
|
})
|
|
|
|
it('aborts the controller before clearing the marker so the marker is never observable as cleared while the signal is still unaborted', async () => {
|
|
const controller = new AbortController()
|
|
const streamId = 'stream-order-1'
|
|
|
|
let signalAbortedWhenMarkerCleared: boolean | null = null
|
|
mockClearAbortMarker.mockImplementationOnce(async () => {
|
|
signalAbortedWhenMarkerCleared = controller.signal.aborted
|
|
})
|
|
mockHasAbortMarker.mockResolvedValueOnce(true)
|
|
|
|
const interval = startAbortPoller(streamId, controller, {})
|
|
|
|
try {
|
|
await vi.advanceTimersByTimeAsync(300)
|
|
|
|
expect(mockClearAbortMarker).toHaveBeenCalledWith(streamId)
|
|
expect(signalAbortedWhenMarkerCleared).toBe(true)
|
|
expect(controller.signal.aborted).toBe(true)
|
|
} finally {
|
|
clearInterval(interval)
|
|
}
|
|
})
|
|
|
|
it('does not clear the marker when the signal is already aborted (no double abort)', async () => {
|
|
const controller = new AbortController()
|
|
controller.abort('preexisting')
|
|
const streamId = 'stream-order-2'
|
|
|
|
mockHasAbortMarker.mockResolvedValueOnce(true)
|
|
|
|
const interval = startAbortPoller(streamId, controller, {})
|
|
|
|
try {
|
|
await vi.advanceTimersByTimeAsync(300)
|
|
|
|
expect(mockClearAbortMarker).not.toHaveBeenCalled()
|
|
} finally {
|
|
clearInterval(interval)
|
|
}
|
|
})
|
|
|
|
it('stops heartbeating after ownership is lost', async () => {
|
|
const controller = new AbortController()
|
|
const streamId = 'stream-lost'
|
|
const chatId = 'chat-lost'
|
|
|
|
redisConfigMockFns.mockExtendLock.mockResolvedValueOnce(false)
|
|
|
|
const interval = startAbortPoller(streamId, controller, { chatId })
|
|
|
|
try {
|
|
await vi.advanceTimersByTimeAsync(21_000)
|
|
expect(redisConfigMockFns.mockExtendLock).toHaveBeenCalledTimes(1)
|
|
|
|
await vi.advanceTimersByTimeAsync(60_000)
|
|
expect(redisConfigMockFns.mockExtendLock).toHaveBeenCalledTimes(1)
|
|
} finally {
|
|
clearInterval(interval)
|
|
}
|
|
})
|
|
})
|
|
|
|
describe('getChatStreamLockOwners', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
redisConfigMockFns.mockGetRedisClient.mockReturnValue(null)
|
|
})
|
|
|
|
it('returns a verified empty owner map when no chat ids are provided', async () => {
|
|
const result = await getChatStreamLockOwners([])
|
|
expect(result.status).toBe('verified')
|
|
expect(result.ownersByChatId.size).toBe(0)
|
|
})
|
|
|
|
it('returns Redis lock owners keyed by chat id', async () => {
|
|
const mget = vi.fn().mockResolvedValue(['stream-1', null, 'stream-3'])
|
|
redisConfigMockFns.mockGetRedisClient.mockReturnValue({ mget } as never)
|
|
|
|
const result = await getChatStreamLockOwners(['chat-1', 'chat-2', 'chat-3'])
|
|
|
|
expect(mget).toHaveBeenCalledWith([
|
|
'copilot:chat-stream-lock:chat-1',
|
|
'copilot:chat-stream-lock:chat-2',
|
|
'copilot:chat-stream-lock:chat-3',
|
|
])
|
|
expect(result.status).toBe('verified')
|
|
expect(result.ownersByChatId).toEqual(
|
|
new Map([
|
|
['chat-1', 'stream-1'],
|
|
['chat-3', 'stream-3'],
|
|
])
|
|
)
|
|
})
|
|
|
|
it('returns a verified empty map when every lock has expired in Redis', async () => {
|
|
const mget = vi.fn().mockResolvedValue([null, null])
|
|
redisConfigMockFns.mockGetRedisClient.mockReturnValue({ mget } as never)
|
|
|
|
const result = await getChatStreamLockOwners(['chat-stuck-1', 'chat-stuck-2'])
|
|
|
|
expect(result.status).toBe('verified')
|
|
expect(result.ownersByChatId.size).toBe(0)
|
|
})
|
|
|
|
it('trusts verified Redis null over a process-local pending stream', async () => {
|
|
const mget = vi.fn().mockResolvedValue([null])
|
|
redisConfigMockFns.mockGetRedisClient.mockReturnValue({ mget } as never)
|
|
await acquirePendingChatStream('chat-local', 'stream-local')
|
|
|
|
try {
|
|
const result = await getChatStreamLockOwners(['chat-local'])
|
|
|
|
expect(result.status).toBe('verified')
|
|
expect(result.ownersByChatId.size).toBe(0)
|
|
} finally {
|
|
await releasePendingChatStream('chat-local', 'stream-local')
|
|
}
|
|
})
|
|
|
|
it('returns unknown status when Redis is unavailable', async () => {
|
|
redisConfigMockFns.mockGetRedisClient.mockReturnValue(null)
|
|
|
|
const result = await getChatStreamLockOwners(['chat-1', 'chat-2'])
|
|
|
|
expect(result.status).toBe('unknown')
|
|
expect(result.ownersByChatId.size).toBe(0)
|
|
})
|
|
|
|
it('preserves local pending stream owners when Redis is unavailable', async () => {
|
|
await acquirePendingChatStream('chat-local', 'stream-local')
|
|
|
|
try {
|
|
const result = await getChatStreamLockOwners(['chat-local', 'chat-remote'])
|
|
|
|
expect(result.status).toBe('unknown')
|
|
expect(result.ownersByChatId).toEqual(new Map([['chat-local', 'stream-local']]))
|
|
} finally {
|
|
await releasePendingChatStream('chat-local', 'stream-local')
|
|
}
|
|
})
|
|
|
|
it('returns unknown status without throwing when mget rejects', async () => {
|
|
const mget = vi.fn().mockRejectedValue(new Error('redis down'))
|
|
redisConfigMockFns.mockGetRedisClient.mockReturnValue({ mget } as never)
|
|
|
|
const result = await getChatStreamLockOwners(['chat-1', 'chat-2'])
|
|
|
|
expect(result.status).toBe('unknown')
|
|
expect(result.ownersByChatId.size).toBe(0)
|
|
})
|
|
})
|