d25d482dc2
CI / Migrate Dev DB (push) Has been skipped
CI / Detect Version (push) Has been cancelled
CI / Migrate DB (push) Has been cancelled
CI / Build Dev ECR (./docker/app.Dockerfile, ECR_APP) (push) Has been cancelled
CI / Build Dev ECR (./docker/db.Dockerfile, ECR_MIGRATIONS) (push) Has been cancelled
CI / Build Dev ECR (./docker/pii.Dockerfile, ECR_PII) (push) Has been cancelled
CI / Build Dev ECR (./docker/realtime.Dockerfile, ECR_REALTIME) (push) Has been cancelled
CI / Deploy Trigger.dev (Dev) (push) Has been cancelled
CI / Build AMD64 (./docker/app.Dockerfile, ECR_APP, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build AMD64 (./docker/db.Dockerfile, ECR_MIGRATIONS, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build AMD64 (./docker/pii.Dockerfile, ECR_PII, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build AMD64 (./docker/realtime.Dockerfile, ECR_REALTIME, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/app.Dockerfile, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/db.Dockerfile, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/pii.Dockerfile, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/realtime.Dockerfile, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Check Docs Changes (push) Has been cancelled
CI / Process Docs (push) Has been cancelled
CI / Create GitHub Release (push) Has been cancelled
CI / Test and Build (push) Has been cancelled
Publish CLI Package / publish-npm (push) Has been cancelled
Publish Python SDK / publish-pypi (push) Has been cancelled
Publish TypeScript SDK / publish-npm (push) Has been cancelled
252 lines
8.8 KiB
TypeScript
252 lines
8.8 KiB
TypeScript
/**
|
|
* @vitest-environment node
|
|
*/
|
|
import {
|
|
createMockRequest,
|
|
hybridAuthMockFns,
|
|
inputValidationMock,
|
|
inputValidationMockFns,
|
|
} from '@sim/testing'
|
|
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
const { mockProcessFilesToUserFiles, mockDownloadFileFromStorage, mockAssertToolFileAccess } =
|
|
vi.hoisted(() => ({
|
|
mockProcessFilesToUserFiles: vi.fn(),
|
|
mockDownloadFileFromStorage: vi.fn(),
|
|
mockAssertToolFileAccess: vi.fn(),
|
|
}))
|
|
|
|
vi.mock('@/lib/core/security/input-validation.server', () => inputValidationMock)
|
|
vi.mock('@/lib/uploads/utils/file-utils', () => ({
|
|
processFilesToUserFiles: mockProcessFilesToUserFiles,
|
|
}))
|
|
vi.mock('@/lib/uploads/utils/file-utils.server', () => ({
|
|
downloadServableFileFromStorage: mockDownloadFileFromStorage,
|
|
}))
|
|
vi.mock('@/app/api/files/authorization', () => ({
|
|
assertToolFileAccess: mockAssertToolFileAccess,
|
|
}))
|
|
|
|
import { POST } from '@/app/api/tools/brex/upload-receipt/route'
|
|
|
|
const mockFetch = vi.fn()
|
|
|
|
const PINNED_IP = '52.216.0.1'
|
|
|
|
const baseBody = {
|
|
apiKey: 'bxt_test_token',
|
|
expenseId: 'expense_123',
|
|
file: { key: 'uploads/receipt.pdf', name: 'receipt.pdf', size: 5, type: 'application/pdf' },
|
|
}
|
|
|
|
function jsonResponse(body: unknown, status = 200) {
|
|
return {
|
|
ok: status >= 200 && status < 300,
|
|
status,
|
|
text: async () => JSON.stringify(body),
|
|
json: async () => body,
|
|
}
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
vi.stubGlobal('fetch', mockFetch)
|
|
hybridAuthMockFns.mockCheckInternalAuth.mockResolvedValue({
|
|
success: true,
|
|
userId: 'user-1',
|
|
authType: 'internal_jwt',
|
|
})
|
|
inputValidationMockFns.mockValidateUrlWithDNS.mockResolvedValue({
|
|
isValid: true,
|
|
resolvedIP: PINNED_IP,
|
|
})
|
|
inputValidationMockFns.mockSecureFetchWithPinnedIP.mockResolvedValue(jsonResponse({}))
|
|
mockProcessFilesToUserFiles.mockReturnValue([
|
|
{ key: 'uploads/receipt.pdf', name: 'receipt.pdf', size: 5, type: 'application/pdf' },
|
|
])
|
|
mockAssertToolFileAccess.mockResolvedValue(null)
|
|
mockDownloadFileFromStorage.mockResolvedValue({
|
|
buffer: Buffer.from('receipt-bytes'),
|
|
contentType: 'application/pdf',
|
|
})
|
|
})
|
|
|
|
describe('POST /api/tools/brex/upload-receipt', () => {
|
|
it('rejects unauthenticated requests', async () => {
|
|
hybridAuthMockFns.mockCheckInternalAuth.mockResolvedValueOnce({
|
|
success: false,
|
|
error: 'unauthorized',
|
|
})
|
|
|
|
const response = await POST(createMockRequest('POST', baseBody))
|
|
expect(response.status).toBe(401)
|
|
expect(mockFetch).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('creates a receipt upload for an expense and PUTs the file to the pre-signed URL', async () => {
|
|
mockFetch.mockResolvedValueOnce(
|
|
jsonResponse({ id: 'receipt_1', uri: 'https://s3.example.com/presigned' })
|
|
)
|
|
|
|
const response = await POST(createMockRequest('POST', baseBody))
|
|
expect(response.status).toBe(200)
|
|
const data = await response.json()
|
|
expect(data).toEqual({
|
|
success: true,
|
|
output: { receiptId: 'receipt_1', receiptName: 'receipt.pdf', expenseId: 'expense_123' },
|
|
})
|
|
|
|
expect(mockFetch).toHaveBeenCalledTimes(1)
|
|
const [createUrl, createInit] = mockFetch.mock.calls[0]
|
|
expect(createUrl).toBe('https://api.brex.com/v1/expenses/card/expense_123/receipt_upload')
|
|
expect(createInit.method).toBe('POST')
|
|
expect(createInit.headers.Authorization).toBe('Bearer bxt_test_token')
|
|
expect(JSON.parse(createInit.body)).toEqual({ receipt_name: 'receipt.pdf' })
|
|
|
|
expect(inputValidationMockFns.mockValidateUrlWithDNS).toHaveBeenCalledWith(
|
|
'https://s3.example.com/presigned',
|
|
'uri'
|
|
)
|
|
const [uploadUrl, pinnedIP, uploadInit] =
|
|
inputValidationMockFns.mockSecureFetchWithPinnedIP.mock.calls[0]
|
|
expect(uploadUrl).toBe('https://s3.example.com/presigned')
|
|
expect(pinnedIP).toBe(PINNED_IP)
|
|
expect(uploadInit.method).toBe('PUT')
|
|
})
|
|
|
|
it('rejects a whitespace-only expense ID instead of falling back to receipt match', async () => {
|
|
const response = await POST(createMockRequest('POST', { ...baseBody, expenseId: ' ' }))
|
|
expect(response.status).toBe(400)
|
|
expect(mockFetch).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('trims a padded expense ID before building the upload URL', async () => {
|
|
mockFetch.mockResolvedValueOnce(
|
|
jsonResponse({ id: 'receipt_5', uri: 'https://s3.example.com/presigned' })
|
|
)
|
|
|
|
const response = await POST(
|
|
createMockRequest('POST', { ...baseBody, expenseId: ' expense_123 ' })
|
|
)
|
|
expect(response.status).toBe(200)
|
|
const [createUrl] = mockFetch.mock.calls[0]
|
|
expect(createUrl).toBe('https://api.brex.com/v1/expenses/card/expense_123/receipt_upload')
|
|
const data = await response.json()
|
|
expect(data.output.expenseId).toBe('expense_123')
|
|
})
|
|
|
|
it('rejects a whitespace-only receipt name', async () => {
|
|
const response = await POST(createMockRequest('POST', { ...baseBody, receiptName: ' ' }))
|
|
expect(response.status).toBe(400)
|
|
expect(mockFetch).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('rejects an API key containing header-breaking characters', async () => {
|
|
const response = await POST(
|
|
createMockRequest('POST', { ...baseBody, apiKey: 'bxt_test\r\nX-Injected: 1' })
|
|
)
|
|
expect(response.status).toBe(400)
|
|
expect(mockFetch).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('uses receipt match when no expense ID is provided', async () => {
|
|
mockFetch.mockResolvedValueOnce(
|
|
jsonResponse({ id: 'receipt_2', uri: 'https://s3.example.com/presigned' })
|
|
)
|
|
|
|
const response = await POST(
|
|
createMockRequest('POST', { apiKey: 'bxt_test_token', file: baseBody.file })
|
|
)
|
|
expect(response.status).toBe(200)
|
|
const data = await response.json()
|
|
expect(data.output).toEqual({
|
|
receiptId: 'receipt_2',
|
|
receiptName: 'receipt.pdf',
|
|
expenseId: null,
|
|
})
|
|
|
|
const [createUrl] = mockFetch.mock.calls[0]
|
|
expect(createUrl).toBe('https://api.brex.com/v1/expenses/card/receipt_match')
|
|
})
|
|
|
|
it('honors a receipt name override', async () => {
|
|
mockFetch.mockResolvedValueOnce(
|
|
jsonResponse({ id: 'receipt_3', uri: 'https://s3.example.com/presigned' })
|
|
)
|
|
|
|
const response = await POST(
|
|
createMockRequest('POST', { ...baseBody, receiptName: 'march-dinner.pdf' })
|
|
)
|
|
expect(response.status).toBe(200)
|
|
const [, createInit] = mockFetch.mock.calls[0]
|
|
expect(JSON.parse(createInit.body)).toEqual({ receipt_name: 'march-dinner.pdf' })
|
|
})
|
|
|
|
it('propagates Brex API errors', async () => {
|
|
mockFetch.mockResolvedValueOnce(jsonResponse({ message: 'Expense not found' }, 404))
|
|
|
|
const response = await POST(createMockRequest('POST', baseBody))
|
|
expect(response.status).toBe(404)
|
|
const data = await response.json()
|
|
expect(data.success).toBe(false)
|
|
expect(data.error).toContain('Expense not found')
|
|
expect(mockFetch).toHaveBeenCalledTimes(1)
|
|
expect(inputValidationMockFns.mockSecureFetchWithPinnedIP).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('rejects files over the 50 MB limit', async () => {
|
|
mockDownloadFileFromStorage.mockResolvedValueOnce({
|
|
buffer: Buffer.alloc(50 * 1024 * 1024 + 1),
|
|
contentType: 'application/pdf',
|
|
})
|
|
|
|
const response = await POST(createMockRequest('POST', baseBody))
|
|
expect(response.status).toBe(400)
|
|
const data = await response.json()
|
|
expect(data.error).toContain('50 MB')
|
|
expect(mockFetch).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('blocks pre-signed URLs that fail SSRF validation', async () => {
|
|
mockFetch.mockResolvedValueOnce(
|
|
jsonResponse({ id: 'receipt_6', uri: 'https://169.254.169.254/latest/meta-data' })
|
|
)
|
|
inputValidationMockFns.mockValidateUrlWithDNS.mockResolvedValueOnce({
|
|
isValid: false,
|
|
error: 'uri resolves to a blocked IP address',
|
|
})
|
|
|
|
const response = await POST(createMockRequest('POST', baseBody))
|
|
expect(response.status).toBe(502)
|
|
const data = await response.json()
|
|
expect(data.error).toContain('invalid upload URL')
|
|
expect(inputValidationMockFns.mockSecureFetchWithPinnedIP).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('fails when the pre-signed upload fails', async () => {
|
|
mockFetch.mockResolvedValueOnce(
|
|
jsonResponse({ id: 'receipt_4', uri: 'https://s3.example.com/presigned' })
|
|
)
|
|
inputValidationMockFns.mockSecureFetchWithPinnedIP.mockResolvedValueOnce(jsonResponse({}, 403))
|
|
|
|
const response = await POST(createMockRequest('POST', baseBody))
|
|
expect(response.status).toBe(502)
|
|
const data = await response.json()
|
|
expect(data.success).toBe(false)
|
|
})
|
|
|
|
it('denies access to files the caller cannot read', async () => {
|
|
const deniedResponse = new Response(
|
|
JSON.stringify({ success: false, error: 'File not found' }),
|
|
{
|
|
status: 404,
|
|
}
|
|
)
|
|
mockAssertToolFileAccess.mockResolvedValueOnce(deniedResponse)
|
|
|
|
const response = await POST(createMockRequest('POST', baseBody))
|
|
expect(response.status).toBe(404)
|
|
expect(mockFetch).not.toHaveBeenCalled()
|
|
})
|
|
})
|