chore: import upstream snapshot with attribution
CI / Migrate Dev DB (push) Has been skipped
CI / Detect Version (push) Has been cancelled
CI / Migrate DB (push) Has been cancelled
CI / Build Dev ECR (./docker/app.Dockerfile, ECR_APP) (push) Has been cancelled
CI / Build Dev ECR (./docker/db.Dockerfile, ECR_MIGRATIONS) (push) Has been cancelled
CI / Build Dev ECR (./docker/pii.Dockerfile, ECR_PII) (push) Has been cancelled
CI / Build Dev ECR (./docker/realtime.Dockerfile, ECR_REALTIME) (push) Has been cancelled
CI / Deploy Trigger.dev (Dev) (push) Has been cancelled
CI / Build AMD64 (./docker/app.Dockerfile, ECR_APP, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build AMD64 (./docker/db.Dockerfile, ECR_MIGRATIONS, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build AMD64 (./docker/pii.Dockerfile, ECR_PII, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build AMD64 (./docker/realtime.Dockerfile, ECR_REALTIME, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/app.Dockerfile, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/db.Dockerfile, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/pii.Dockerfile, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/realtime.Dockerfile, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Check Docs Changes (push) Has been cancelled
CI / Process Docs (push) Has been cancelled
CI / Create GitHub Release (push) Has been cancelled
CI / Test and Build (push) Has been cancelled
Publish CLI Package / publish-npm (push) Has been cancelled
Publish Python SDK / publish-pypi (push) Has been cancelled
Publish TypeScript SDK / publish-npm (push) Has been cancelled
CI / Migrate Dev DB (push) Has been skipped
CI / Detect Version (push) Has been cancelled
CI / Migrate DB (push) Has been cancelled
CI / Build Dev ECR (./docker/app.Dockerfile, ECR_APP) (push) Has been cancelled
CI / Build Dev ECR (./docker/db.Dockerfile, ECR_MIGRATIONS) (push) Has been cancelled
CI / Build Dev ECR (./docker/pii.Dockerfile, ECR_PII) (push) Has been cancelled
CI / Build Dev ECR (./docker/realtime.Dockerfile, ECR_REALTIME) (push) Has been cancelled
CI / Deploy Trigger.dev (Dev) (push) Has been cancelled
CI / Build AMD64 (./docker/app.Dockerfile, ECR_APP, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build AMD64 (./docker/db.Dockerfile, ECR_MIGRATIONS, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build AMD64 (./docker/pii.Dockerfile, ECR_PII, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build AMD64 (./docker/realtime.Dockerfile, ECR_REALTIME, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/app.Dockerfile, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/db.Dockerfile, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/pii.Dockerfile, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/realtime.Dockerfile, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Check Docs Changes (push) Has been cancelled
CI / Process Docs (push) Has been cancelled
CI / Create GitHub Release (push) Has been cancelled
CI / Test and Build (push) Has been cancelled
Publish CLI Package / publish-npm (push) Has been cancelled
Publish Python SDK / publish-pypi (push) Has been cancelled
Publish TypeScript SDK / publish-npm (push) Has been cancelled
This commit is contained in:
@@ -0,0 +1,215 @@
|
||||
/**
|
||||
* @vitest-environment node
|
||||
*/
|
||||
import { redisConfigMock, redisConfigMockFns } from '@sim/testing'
|
||||
import { sleep } from '@sim/utils/helpers'
|
||||
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
||||
|
||||
vi.mock('@/lib/core/config/redis', () => redisConfigMock)
|
||||
|
||||
import { withLeaderLock } from '@/lib/concurrency/leader-lock'
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
redisConfigMockFns.mockAcquireLock.mockResolvedValue(true)
|
||||
redisConfigMockFns.mockReleaseLock.mockResolvedValue(true)
|
||||
})
|
||||
|
||||
describe('withLeaderLock', () => {
|
||||
it('runs onLeader exactly once when lock acquired', async () => {
|
||||
const onLeader = vi.fn(async () => 'leader-result')
|
||||
const onFollower = vi.fn(async () => null)
|
||||
|
||||
const result = await withLeaderLock<string>({
|
||||
key: 'k',
|
||||
onLeader,
|
||||
onFollower,
|
||||
})
|
||||
|
||||
expect(result).toBe('leader-result')
|
||||
expect(onLeader).toHaveBeenCalledTimes(1)
|
||||
expect(onFollower).not.toHaveBeenCalled()
|
||||
expect(redisConfigMockFns.mockReleaseLock).toHaveBeenCalledTimes(1)
|
||||
})
|
||||
|
||||
it('passes a fresh owner token to acquireLock and releaseLock', async () => {
|
||||
await withLeaderLock<string>({
|
||||
key: 'k',
|
||||
onLeader: async () => 'x',
|
||||
onFollower: async () => null,
|
||||
})
|
||||
|
||||
const [acquireKey, acquireValue] = redisConfigMockFns.mockAcquireLock.mock.calls[0]!
|
||||
const [releaseKey, releaseValue] = redisConfigMockFns.mockReleaseLock.mock.calls[0]!
|
||||
|
||||
expect(acquireKey).toBe('k')
|
||||
expect(releaseKey).toBe('k')
|
||||
expect(acquireValue).toBe(releaseValue)
|
||||
expect(typeof acquireValue).toBe('string')
|
||||
expect((acquireValue as string).length).toBeGreaterThan(0)
|
||||
})
|
||||
|
||||
it('falls back to uncoordinated leader when acquireLock throws', async () => {
|
||||
redisConfigMockFns.mockAcquireLock.mockRejectedValueOnce(new Error('redis down'))
|
||||
|
||||
const onLeader = vi.fn(async () => 'fallback')
|
||||
const onFollower = vi.fn(async () => null)
|
||||
|
||||
const result = await withLeaderLock<string>({
|
||||
key: 'k',
|
||||
onLeader,
|
||||
onFollower,
|
||||
})
|
||||
|
||||
expect(result).toBe('fallback')
|
||||
expect(onLeader).toHaveBeenCalledTimes(1)
|
||||
expect(onFollower).not.toHaveBeenCalled()
|
||||
expect(redisConfigMockFns.mockReleaseLock).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('does not propagate releaseLock errors out of the leader path', async () => {
|
||||
redisConfigMockFns.mockReleaseLock.mockRejectedValueOnce(new Error('redis blip'))
|
||||
|
||||
const result = await withLeaderLock<string>({
|
||||
key: 'k',
|
||||
onLeader: async () => 'leader-value',
|
||||
onFollower: async () => null,
|
||||
})
|
||||
|
||||
expect(result).toBe('leader-value')
|
||||
})
|
||||
|
||||
it('releases the lock even when onLeader throws', async () => {
|
||||
const onLeader = vi.fn(async () => {
|
||||
throw new Error('boom')
|
||||
})
|
||||
|
||||
await expect(
|
||||
withLeaderLock<string>({
|
||||
key: 'k',
|
||||
onLeader,
|
||||
onFollower: async () => null,
|
||||
})
|
||||
).rejects.toThrow('boom')
|
||||
|
||||
expect(redisConfigMockFns.mockReleaseLock).toHaveBeenCalledTimes(1)
|
||||
})
|
||||
|
||||
it('follower polls onFollower until it returns non-null', async () => {
|
||||
redisConfigMockFns.mockAcquireLock.mockResolvedValueOnce(false)
|
||||
|
||||
let polls = 0
|
||||
const onFollower = vi.fn(async () => {
|
||||
polls += 1
|
||||
if (polls >= 2) return 'available'
|
||||
return null
|
||||
})
|
||||
|
||||
const result = await withLeaderLock<string>({
|
||||
key: 'k',
|
||||
pollIntervalMs: 5,
|
||||
maxWaitMs: 1000,
|
||||
onLeader: async () => 'should-not-run',
|
||||
onFollower,
|
||||
})
|
||||
|
||||
expect(result).toBe('available')
|
||||
expect(onFollower.mock.calls.length).toBeGreaterThanOrEqual(2)
|
||||
})
|
||||
|
||||
it('follower does a final read after timeout to catch a just-finished leader', async () => {
|
||||
redisConfigMockFns.mockAcquireLock.mockResolvedValueOnce(false)
|
||||
|
||||
/**
|
||||
* The intent: after the in-loop poll deadline is reached, the follower
|
||||
* does exactly one more (last-chance) `onFollower` call to catch a leader
|
||||
* that finished between the previous poll and the timeout. Using fake
|
||||
* timers makes the timing deterministic — pollInterval=10 and maxWait=15
|
||||
* cause two in-loop polls (T+10, T+20) and one last-chance read (T+20),
|
||||
* but the schedule is driven by mocked time, not the CI wall clock.
|
||||
*/
|
||||
vi.useFakeTimers()
|
||||
try {
|
||||
let polls = 0
|
||||
const onFollower = vi.fn(async () => {
|
||||
polls += 1
|
||||
if (polls <= 2) return null
|
||||
return 'late-leader'
|
||||
})
|
||||
|
||||
const promise = withLeaderLock<string>({
|
||||
key: 'k',
|
||||
pollIntervalMs: 10,
|
||||
maxWaitMs: 15,
|
||||
onLeader: async () => 'should-not-run',
|
||||
onFollower,
|
||||
})
|
||||
|
||||
await vi.advanceTimersByTimeAsync(30)
|
||||
const result = await promise
|
||||
|
||||
expect(result).toBe('late-leader')
|
||||
expect(onFollower).toHaveBeenCalledTimes(3)
|
||||
} finally {
|
||||
vi.useRealTimers()
|
||||
}
|
||||
})
|
||||
|
||||
it('follower returns null after timeout', async () => {
|
||||
redisConfigMockFns.mockAcquireLock.mockResolvedValueOnce(false)
|
||||
|
||||
vi.useFakeTimers()
|
||||
try {
|
||||
const onFollower = vi.fn(async () => null)
|
||||
const promise = withLeaderLock<string>({
|
||||
key: 'k',
|
||||
pollIntervalMs: 10,
|
||||
maxWaitMs: 25,
|
||||
onLeader: async () => 'should-not-run',
|
||||
onFollower,
|
||||
})
|
||||
|
||||
await vi.advanceTimersByTimeAsync(50)
|
||||
const result = await promise
|
||||
|
||||
expect(result).toBeNull()
|
||||
} finally {
|
||||
vi.useRealTimers()
|
||||
}
|
||||
})
|
||||
|
||||
it('only one of N concurrent callers acquires the lock', async () => {
|
||||
// Track which calls won the lock: first one returns true, rest return false.
|
||||
let acquired = false
|
||||
redisConfigMockFns.mockAcquireLock.mockImplementation(async () => {
|
||||
if (acquired) return false
|
||||
acquired = true
|
||||
return true
|
||||
})
|
||||
redisConfigMockFns.mockReleaseLock.mockImplementation(async () => {
|
||||
acquired = false
|
||||
return true
|
||||
})
|
||||
|
||||
let leaderRuns = 0
|
||||
|
||||
const callers = Array.from({ length: 5 }, () =>
|
||||
withLeaderLock<string>({
|
||||
key: 'shared',
|
||||
pollIntervalMs: 5,
|
||||
maxWaitMs: 200,
|
||||
onLeader: async () => {
|
||||
leaderRuns += 1
|
||||
await sleep(20)
|
||||
return 'leader-value'
|
||||
},
|
||||
onFollower: async () => (acquired ? null : 'follower-saw-released'),
|
||||
})
|
||||
)
|
||||
|
||||
const results = await Promise.all(callers)
|
||||
expect(leaderRuns).toBe(1)
|
||||
expect(results.filter((r) => r === 'leader-value').length).toBe(1)
|
||||
expect(results.filter((r) => r === 'follower-saw-released').length).toBeGreaterThan(0)
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user