chore: import upstream snapshot with attribution
CI / Migrate Dev DB (push) Has been skipped
CI / Detect Version (push) Has been cancelled
CI / Migrate DB (push) Has been cancelled
CI / Build Dev ECR (./docker/app.Dockerfile, ECR_APP) (push) Has been cancelled
CI / Build Dev ECR (./docker/db.Dockerfile, ECR_MIGRATIONS) (push) Has been cancelled
CI / Build Dev ECR (./docker/pii.Dockerfile, ECR_PII) (push) Has been cancelled
CI / Build Dev ECR (./docker/realtime.Dockerfile, ECR_REALTIME) (push) Has been cancelled
CI / Deploy Trigger.dev (Dev) (push) Has been cancelled
CI / Build AMD64 (./docker/app.Dockerfile, ECR_APP, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build AMD64 (./docker/db.Dockerfile, ECR_MIGRATIONS, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build AMD64 (./docker/pii.Dockerfile, ECR_PII, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build AMD64 (./docker/realtime.Dockerfile, ECR_REALTIME, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/app.Dockerfile, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/db.Dockerfile, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/pii.Dockerfile, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/realtime.Dockerfile, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Check Docs Changes (push) Has been cancelled
CI / Process Docs (push) Has been cancelled
CI / Create GitHub Release (push) Has been cancelled
CI / Test and Build (push) Has been cancelled
Publish CLI Package / publish-npm (push) Has been cancelled
Publish Python SDK / publish-pypi (push) Has been cancelled
Publish TypeScript SDK / publish-npm (push) Has been cancelled
CI / Migrate Dev DB (push) Has been skipped
CI / Detect Version (push) Has been cancelled
CI / Migrate DB (push) Has been cancelled
CI / Build Dev ECR (./docker/app.Dockerfile, ECR_APP) (push) Has been cancelled
CI / Build Dev ECR (./docker/db.Dockerfile, ECR_MIGRATIONS) (push) Has been cancelled
CI / Build Dev ECR (./docker/pii.Dockerfile, ECR_PII) (push) Has been cancelled
CI / Build Dev ECR (./docker/realtime.Dockerfile, ECR_REALTIME) (push) Has been cancelled
CI / Deploy Trigger.dev (Dev) (push) Has been cancelled
CI / Build AMD64 (./docker/app.Dockerfile, ECR_APP, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build AMD64 (./docker/db.Dockerfile, ECR_MIGRATIONS, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build AMD64 (./docker/pii.Dockerfile, ECR_PII, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build AMD64 (./docker/realtime.Dockerfile, ECR_REALTIME, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/app.Dockerfile, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/db.Dockerfile, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/pii.Dockerfile, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/realtime.Dockerfile, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Check Docs Changes (push) Has been cancelled
CI / Process Docs (push) Has been cancelled
CI / Create GitHub Release (push) Has been cancelled
CI / Test and Build (push) Has been cancelled
Publish CLI Package / publish-npm (push) Has been cancelled
Publish Python SDK / publish-pypi (push) Has been cancelled
Publish TypeScript SDK / publish-npm (push) Has been cancelled
This commit is contained in:
@@ -0,0 +1,143 @@
|
||||
/**
|
||||
* Tests for the workspace files upload route's bounded multipart read.
|
||||
*
|
||||
* @vitest-environment node
|
||||
*/
|
||||
import { authMockFns, permissionsMock, permissionsMockFns, posthogServerMock } from '@sim/testing'
|
||||
import { NextRequest } from 'next/server'
|
||||
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
||||
|
||||
const { mockUploadWorkspaceFile, mockGetSharesForResources, mockRecordAudit } = vi.hoisted(() => ({
|
||||
mockUploadWorkspaceFile: vi.fn(),
|
||||
mockGetSharesForResources: vi.fn(),
|
||||
mockRecordAudit: vi.fn(),
|
||||
}))
|
||||
|
||||
vi.mock('@/lib/uploads/contexts/workspace', () => ({
|
||||
uploadWorkspaceFile: mockUploadWorkspaceFile,
|
||||
FileConflictError: class FileConflictError extends Error {},
|
||||
}))
|
||||
|
||||
vi.mock('@/lib/uploads/shared/types', async (importOriginal) => {
|
||||
const actual = await importOriginal<typeof import('@/lib/uploads/shared/types')>()
|
||||
return {
|
||||
...actual,
|
||||
MAX_WORKSPACE_FORMDATA_FILE_SIZE: 1024,
|
||||
}
|
||||
})
|
||||
|
||||
vi.mock('@/lib/public-shares/share-manager', () => ({
|
||||
getSharesForResources: mockGetSharesForResources,
|
||||
}))
|
||||
|
||||
vi.mock('@/lib/posthog/server', () => posthogServerMock)
|
||||
vi.mock('@/lib/workspaces/permissions/utils', () => permissionsMock)
|
||||
vi.mock('@/app/api/workflows/utils', () => ({
|
||||
verifyWorkspaceMembership: vi.fn().mockResolvedValue('write'),
|
||||
}))
|
||||
vi.mock('@sim/audit', () => ({
|
||||
recordAudit: mockRecordAudit,
|
||||
AuditAction: { FILE_UPLOADED: 'file_uploaded' },
|
||||
AuditResourceType: { FILE: 'file' },
|
||||
}))
|
||||
|
||||
const WS = '7727ef3f-8cf6-4686-b063-2bb006a10785'
|
||||
|
||||
import { POST } from '@/app/api/workspaces/[id]/files/route'
|
||||
|
||||
const routeContext = { params: Promise.resolve({ id: WS }) }
|
||||
|
||||
function buildFormData(file: File): FormData {
|
||||
const formData = new FormData()
|
||||
formData.append('file', file)
|
||||
return formData
|
||||
}
|
||||
|
||||
/**
|
||||
* Builds a pull-based stream that emits fixed-size chunks on demand, so the
|
||||
* size-capped reader's `reader.cancel()` simply stops future `pull` calls
|
||||
* instead of racing an external (e.g. undici FormData) chunk producer.
|
||||
*/
|
||||
function makeChunkedOverLimitBody(
|
||||
chunkBytes: number,
|
||||
chunkCount: number
|
||||
): ReadableStream<Uint8Array> {
|
||||
let emitted = 0
|
||||
return new ReadableStream<Uint8Array>({
|
||||
pull(controller) {
|
||||
if (emitted >= chunkCount) {
|
||||
controller.close()
|
||||
return
|
||||
}
|
||||
emitted++
|
||||
controller.enqueue(new Uint8Array(chunkBytes))
|
||||
},
|
||||
})
|
||||
}
|
||||
|
||||
describe('workspace files upload route', () => {
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
authMockFns.mockGetSession.mockResolvedValue({ user: { id: 'user-1' } })
|
||||
permissionsMockFns.mockGetUserEntityPermissions.mockResolvedValue('write')
|
||||
mockGetSharesForResources.mockResolvedValue(new Map())
|
||||
mockUploadWorkspaceFile.mockResolvedValue({
|
||||
id: 'file-1',
|
||||
name: 'file.txt',
|
||||
url: 'https://example.com/file.txt',
|
||||
size: 11,
|
||||
type: 'text/plain',
|
||||
})
|
||||
})
|
||||
|
||||
it('rejects a declared content-length above the limit before reading the body', async () => {
|
||||
const formData = buildFormData(new File(['x'.repeat(10)], 'file.txt', { type: 'text/plain' }))
|
||||
const req = new NextRequest(`http://localhost:3000/api/workspaces/${WS}/files`, {
|
||||
method: 'POST',
|
||||
headers: { 'content-length': String(10 * 1024 * 1024) },
|
||||
body: formData,
|
||||
})
|
||||
|
||||
const response = await POST(req, routeContext)
|
||||
const data = await response.json()
|
||||
|
||||
expect(response.status).toBe(413)
|
||||
expect(data.error).toContain('exceeds maximum size')
|
||||
expect(mockUploadWorkspaceFile).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('rejects a chunked body without content-length once the streamed size trips the cap', async () => {
|
||||
const body = makeChunkedOverLimitBody(64 * 1024, 32)
|
||||
const req = new NextRequest(`http://localhost:3000/api/workspaces/${WS}/files`, {
|
||||
method: 'POST',
|
||||
body,
|
||||
// @ts-expect-error - duplex is required by undici for streamed bodies but missing from NextRequestInit types
|
||||
duplex: 'half',
|
||||
})
|
||||
expect(req.headers.get('content-length')).toBeNull()
|
||||
|
||||
const response = await POST(req, routeContext)
|
||||
const data = await response.json()
|
||||
|
||||
expect(response.status).toBe(413)
|
||||
expect(data.error).toContain('exceeds maximum size')
|
||||
expect(mockUploadWorkspaceFile).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('uploads a normal, well-under-limit file successfully', async () => {
|
||||
const file = new File(['hello world'], 'file.txt', { type: 'text/plain' })
|
||||
const formData = buildFormData(file)
|
||||
const req = new NextRequest(`http://localhost:3000/api/workspaces/${WS}/files`, {
|
||||
method: 'POST',
|
||||
headers: { 'content-length': '512' },
|
||||
body: formData,
|
||||
})
|
||||
|
||||
const response = await POST(req, routeContext)
|
||||
const data = await response.json()
|
||||
|
||||
expect(response.status).toBe(200)
|
||||
expect(data.success).toBe(true)
|
||||
expect(mockUploadWorkspaceFile).toHaveBeenCalledTimes(1)
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user