chore: import upstream snapshot with attribution
CI / Migrate Dev DB (push) Has been skipped
CI / Detect Version (push) Has been cancelled
CI / Migrate DB (push) Has been cancelled
CI / Build Dev ECR (./docker/app.Dockerfile, ECR_APP) (push) Has been cancelled
CI / Build Dev ECR (./docker/db.Dockerfile, ECR_MIGRATIONS) (push) Has been cancelled
CI / Build Dev ECR (./docker/pii.Dockerfile, ECR_PII) (push) Has been cancelled
CI / Build Dev ECR (./docker/realtime.Dockerfile, ECR_REALTIME) (push) Has been cancelled
CI / Deploy Trigger.dev (Dev) (push) Has been cancelled
CI / Build AMD64 (./docker/app.Dockerfile, ECR_APP, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build AMD64 (./docker/db.Dockerfile, ECR_MIGRATIONS, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build AMD64 (./docker/pii.Dockerfile, ECR_PII, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build AMD64 (./docker/realtime.Dockerfile, ECR_REALTIME, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/app.Dockerfile, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/db.Dockerfile, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/pii.Dockerfile, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/realtime.Dockerfile, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Check Docs Changes (push) Has been cancelled
CI / Process Docs (push) Has been cancelled
CI / Create GitHub Release (push) Has been cancelled
CI / Test and Build (push) Has been cancelled
Publish CLI Package / publish-npm (push) Has been cancelled
Publish Python SDK / publish-pypi (push) Has been cancelled
Publish TypeScript SDK / publish-npm (push) Has been cancelled
CI / Migrate Dev DB (push) Has been skipped
CI / Detect Version (push) Has been cancelled
CI / Migrate DB (push) Has been cancelled
CI / Build Dev ECR (./docker/app.Dockerfile, ECR_APP) (push) Has been cancelled
CI / Build Dev ECR (./docker/db.Dockerfile, ECR_MIGRATIONS) (push) Has been cancelled
CI / Build Dev ECR (./docker/pii.Dockerfile, ECR_PII) (push) Has been cancelled
CI / Build Dev ECR (./docker/realtime.Dockerfile, ECR_REALTIME) (push) Has been cancelled
CI / Deploy Trigger.dev (Dev) (push) Has been cancelled
CI / Build AMD64 (./docker/app.Dockerfile, ECR_APP, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build AMD64 (./docker/db.Dockerfile, ECR_MIGRATIONS, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build AMD64 (./docker/pii.Dockerfile, ECR_PII, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build AMD64 (./docker/realtime.Dockerfile, ECR_REALTIME, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/app.Dockerfile, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/db.Dockerfile, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/pii.Dockerfile, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/realtime.Dockerfile, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Check Docs Changes (push) Has been cancelled
CI / Process Docs (push) Has been cancelled
CI / Create GitHub Release (push) Has been cancelled
CI / Test and Build (push) Has been cancelled
Publish CLI Package / publish-npm (push) Has been cancelled
Publish Python SDK / publish-pypi (push) Has been cancelled
Publish TypeScript SDK / publish-npm (push) Has been cancelled
This commit is contained in:
@@ -0,0 +1,312 @@
|
||||
/**
|
||||
* @vitest-environment node
|
||||
*/
|
||||
import { auditMock, createMockRequest } from '@sim/testing'
|
||||
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
||||
|
||||
const {
|
||||
mockDbState,
|
||||
mockGetSession,
|
||||
mockGetUserEntityPermissions,
|
||||
mockGetWorkspaceById,
|
||||
mockEncryptSecret,
|
||||
mockDecryptSecret,
|
||||
mockUpdateSet,
|
||||
mockInsertValues,
|
||||
mockDeleteWhere,
|
||||
} = vi.hoisted(() => {
|
||||
const state = {
|
||||
selectResults: [] as unknown[][],
|
||||
insertReturning: [] as unknown[],
|
||||
deleteReturning: [] as unknown[],
|
||||
}
|
||||
return {
|
||||
mockDbState: state,
|
||||
mockGetSession: vi.fn(),
|
||||
mockGetUserEntityPermissions: vi.fn(),
|
||||
mockGetWorkspaceById: vi.fn(),
|
||||
mockEncryptSecret: vi.fn(),
|
||||
mockDecryptSecret: vi.fn(),
|
||||
mockUpdateSet: vi.fn(() => ({ where: vi.fn(() => Promise.resolve()) })),
|
||||
mockInsertValues: vi.fn(() => ({
|
||||
returning: vi.fn(() => Promise.resolve(state.insertReturning)),
|
||||
})),
|
||||
mockDeleteWhere: vi.fn(() => ({
|
||||
returning: vi.fn(() => Promise.resolve(state.deleteReturning)),
|
||||
})),
|
||||
}
|
||||
})
|
||||
|
||||
vi.mock('@sim/db', () => {
|
||||
const dbMock: Record<string, unknown> = {
|
||||
select: vi.fn(() => {
|
||||
const chain: Record<string, unknown> = {}
|
||||
chain.from = vi.fn().mockReturnValue(chain)
|
||||
chain.where = vi.fn().mockImplementation(() => {
|
||||
const result: any = Promise.resolve(mockDbState.selectResults.shift() ?? [])
|
||||
result.limit = vi.fn(() => result)
|
||||
result.orderBy = vi.fn(() => result)
|
||||
return result
|
||||
})
|
||||
return chain
|
||||
}),
|
||||
update: vi.fn(() => ({ set: mockUpdateSet })),
|
||||
insert: vi.fn(() => ({ values: mockInsertValues })),
|
||||
delete: vi.fn(() => ({ where: mockDeleteWhere })),
|
||||
execute: vi.fn(() => Promise.resolve([])),
|
||||
}
|
||||
dbMock.transaction = vi.fn(async (callback: (tx: unknown) => unknown) => callback(dbMock))
|
||||
return { db: dbMock }
|
||||
})
|
||||
|
||||
vi.mock('@sim/audit', () => auditMock)
|
||||
|
||||
vi.mock('@/lib/auth', () => ({
|
||||
getSession: mockGetSession,
|
||||
}))
|
||||
|
||||
vi.mock('@/lib/core/security/encryption', () => ({
|
||||
encryptSecret: mockEncryptSecret,
|
||||
decryptSecret: mockDecryptSecret,
|
||||
}))
|
||||
|
||||
vi.mock('@/lib/posthog/server', () => ({
|
||||
captureServerEvent: vi.fn(),
|
||||
}))
|
||||
|
||||
vi.mock('@/lib/workspaces/permissions/utils', () => ({
|
||||
getUserEntityPermissions: mockGetUserEntityPermissions,
|
||||
getWorkspaceById: mockGetWorkspaceById,
|
||||
}))
|
||||
|
||||
import { DELETE, GET, POST } from '@/app/api/workspaces/[id]/byok-keys/route'
|
||||
|
||||
const WORKSPACE_ID = 'workspace-1'
|
||||
const routeContext = { params: Promise.resolve({ id: WORKSPACE_ID }) }
|
||||
|
||||
const storedKeyRow = (id: string, name: string | null = null) => ({
|
||||
id,
|
||||
providerId: 'openai',
|
||||
encryptedApiKey: `encrypted-${id}`,
|
||||
name,
|
||||
createdBy: 'user-1',
|
||||
createdAt: new Date('2026-01-01T00:00:00Z'),
|
||||
updatedAt: new Date('2026-01-01T00:00:00Z'),
|
||||
})
|
||||
|
||||
describe('workspace BYOK keys route', () => {
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
mockDbState.selectResults = []
|
||||
mockDbState.insertReturning = []
|
||||
mockDbState.deleteReturning = []
|
||||
|
||||
mockGetSession.mockResolvedValue({ user: { id: 'user-1' } })
|
||||
mockGetUserEntityPermissions.mockResolvedValue('admin')
|
||||
mockGetWorkspaceById.mockResolvedValue({ id: WORKSPACE_ID })
|
||||
mockEncryptSecret.mockResolvedValue({ encrypted: 'encrypted-value', iv: 'iv' })
|
||||
mockDecryptSecret.mockImplementation(async (encrypted: string) => ({
|
||||
decrypted: encrypted.replace('encrypted-', 'sk-decrypted-value-'),
|
||||
}))
|
||||
})
|
||||
|
||||
describe('GET', () => {
|
||||
it('lists every stored key with name and masked value', async () => {
|
||||
mockDbState.selectResults = [[storedKeyRow('key-1', 'Production'), storedKeyRow('key-2')]]
|
||||
|
||||
const res = await GET(createMockRequest('GET'), routeContext)
|
||||
|
||||
expect(res.status).toBe(200)
|
||||
const body = await res.json()
|
||||
expect(body.keys).toHaveLength(2)
|
||||
expect(body.keys[0]).toMatchObject({ id: 'key-1', name: 'Production', providerId: 'openai' })
|
||||
expect(body.keys[0].maskedKey).toBe('sk-dec...ey-1')
|
||||
expect(body.keys[1]).toMatchObject({ id: 'key-2', name: null })
|
||||
})
|
||||
|
||||
it('returns 401 when the user has no workspace permission', async () => {
|
||||
mockGetUserEntityPermissions.mockResolvedValue(null)
|
||||
|
||||
const res = await GET(createMockRequest('GET'), routeContext)
|
||||
|
||||
expect(res.status).toBe(401)
|
||||
})
|
||||
})
|
||||
|
||||
describe('POST', () => {
|
||||
it('returns 403 when the user is not a workspace admin', async () => {
|
||||
mockGetUserEntityPermissions.mockResolvedValue('write')
|
||||
|
||||
const res = await POST(
|
||||
createMockRequest('POST', { providerId: 'openai', apiKey: 'sk-new' }),
|
||||
routeContext
|
||||
)
|
||||
|
||||
expect(res.status).toBe(403)
|
||||
expect(mockInsertValues).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('adds a new key even when the provider already has keys', async () => {
|
||||
mockDbState.selectResults = [[{ keyCount: 2 }]]
|
||||
mockDbState.insertReturning = [
|
||||
{ id: 'key-3', providerId: 'openai', name: 'Backup', createdAt: new Date() },
|
||||
]
|
||||
|
||||
const res = await POST(
|
||||
createMockRequest('POST', { providerId: 'openai', apiKey: 'sk-new-key', name: 'Backup' }),
|
||||
routeContext
|
||||
)
|
||||
|
||||
expect(res.status).toBe(200)
|
||||
const body = await res.json()
|
||||
expect(body.success).toBe(true)
|
||||
expect(body.key).toMatchObject({ id: 'key-3', name: 'Backup' })
|
||||
expect(mockInsertValues).toHaveBeenCalledWith(
|
||||
expect.objectContaining({
|
||||
workspaceId: WORKSPACE_ID,
|
||||
providerId: 'openai',
|
||||
encryptedApiKey: 'encrypted-value',
|
||||
name: 'Backup',
|
||||
})
|
||||
)
|
||||
})
|
||||
|
||||
it('stores a null name when none is provided', async () => {
|
||||
mockDbState.selectResults = [[{ keyCount: 0 }]]
|
||||
mockDbState.insertReturning = [
|
||||
{ id: 'key-1', providerId: 'openai', name: null, createdAt: new Date() },
|
||||
]
|
||||
|
||||
const res = await POST(
|
||||
createMockRequest('POST', { providerId: 'openai', apiKey: 'sk-new-key' }),
|
||||
routeContext
|
||||
)
|
||||
|
||||
expect(res.status).toBe(200)
|
||||
expect(mockInsertValues).toHaveBeenCalledWith(expect.objectContaining({ name: null }))
|
||||
})
|
||||
|
||||
it('rejects adding a key beyond the per-provider cap', async () => {
|
||||
mockDbState.selectResults = [[{ keyCount: 10 }]]
|
||||
|
||||
const res = await POST(
|
||||
createMockRequest('POST', { providerId: 'openai', apiKey: 'sk-new-key' }),
|
||||
routeContext
|
||||
)
|
||||
|
||||
expect(res.status).toBe(400)
|
||||
const body = await res.json()
|
||||
expect(body.error).toContain('at most 10 keys')
|
||||
expect(mockInsertValues).not.toHaveBeenCalled()
|
||||
expect(mockEncryptSecret).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('updates the targeted key in place when keyId is provided', async () => {
|
||||
mockDbState.selectResults = [[{ id: 'key-2', name: 'Old name' }]]
|
||||
|
||||
const res = await POST(
|
||||
createMockRequest('POST', { providerId: 'openai', apiKey: 'sk-rotated', keyId: 'key-2' }),
|
||||
routeContext
|
||||
)
|
||||
|
||||
expect(res.status).toBe(200)
|
||||
const body = await res.json()
|
||||
expect(body.key).toMatchObject({ id: 'key-2', name: 'Old name' })
|
||||
expect(mockUpdateSet).toHaveBeenCalledWith(
|
||||
expect.objectContaining({ encryptedApiKey: 'encrypted-value', name: 'Old name' })
|
||||
)
|
||||
expect(mockInsertValues).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('clears the name when updating with an empty name', async () => {
|
||||
mockDbState.selectResults = [[{ id: 'key-2', name: 'Old name' }]]
|
||||
|
||||
const res = await POST(
|
||||
createMockRequest('POST', {
|
||||
providerId: 'openai',
|
||||
apiKey: 'sk-rotated',
|
||||
keyId: 'key-2',
|
||||
name: '',
|
||||
}),
|
||||
routeContext
|
||||
)
|
||||
|
||||
expect(res.status).toBe(200)
|
||||
expect(mockUpdateSet).toHaveBeenCalledWith(expect.objectContaining({ name: null }))
|
||||
})
|
||||
|
||||
it('returns 404 when the keyId does not exist in the workspace', async () => {
|
||||
mockDbState.selectResults = [[]]
|
||||
|
||||
const res = await POST(
|
||||
createMockRequest('POST', { providerId: 'openai', apiKey: 'sk-rotated', keyId: 'missing' }),
|
||||
routeContext
|
||||
)
|
||||
|
||||
expect(res.status).toBe(404)
|
||||
expect(mockUpdateSet).not.toHaveBeenCalled()
|
||||
expect(mockEncryptSecret).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('rejects an empty apiKey', async () => {
|
||||
const res = await POST(
|
||||
createMockRequest('POST', { providerId: 'openai', apiKey: '' }),
|
||||
routeContext
|
||||
)
|
||||
|
||||
expect(res.status).toBe(400)
|
||||
})
|
||||
})
|
||||
|
||||
describe('DELETE', () => {
|
||||
it('deletes a single key when keyId is provided', async () => {
|
||||
mockDbState.deleteReturning = [{ id: 'key-2' }]
|
||||
|
||||
const res = await DELETE(
|
||||
createMockRequest('DELETE', { providerId: 'openai', keyId: 'key-2' }),
|
||||
routeContext
|
||||
)
|
||||
|
||||
expect(res.status).toBe(200)
|
||||
expect(await res.json()).toEqual({ success: true })
|
||||
})
|
||||
|
||||
it('returns 404 when keyId is provided but no key matches', async () => {
|
||||
mockDbState.deleteReturning = []
|
||||
|
||||
const res = await DELETE(
|
||||
createMockRequest('DELETE', { providerId: 'openai', keyId: 'missing' }),
|
||||
routeContext
|
||||
)
|
||||
|
||||
expect(res.status).toBe(404)
|
||||
})
|
||||
|
||||
it('deletes all provider keys when keyId is omitted', async () => {
|
||||
mockDbState.deleteReturning = [{ id: 'key-1' }, { id: 'key-2' }]
|
||||
|
||||
const res = await DELETE(createMockRequest('DELETE', { providerId: 'openai' }), routeContext)
|
||||
|
||||
expect(res.status).toBe(200)
|
||||
expect(await res.json()).toEqual({ success: true })
|
||||
})
|
||||
|
||||
it('succeeds when keyId is omitted and the provider has no keys', async () => {
|
||||
mockDbState.deleteReturning = []
|
||||
|
||||
const res = await DELETE(createMockRequest('DELETE', { providerId: 'openai' }), routeContext)
|
||||
|
||||
expect(res.status).toBe(200)
|
||||
expect(await res.json()).toEqual({ success: true })
|
||||
})
|
||||
|
||||
it('returns 403 when the user is not a workspace admin', async () => {
|
||||
mockGetUserEntityPermissions.mockResolvedValue('write')
|
||||
|
||||
const res = await DELETE(createMockRequest('DELETE', { providerId: 'openai' }), routeContext)
|
||||
|
||||
expect(res.status).toBe(403)
|
||||
expect(mockDeleteWhere).not.toHaveBeenCalled()
|
||||
})
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user