chore: import upstream snapshot with attribution
CI / Migrate Dev DB (push) Has been skipped
CI / Detect Version (push) Has been cancelled
CI / Migrate DB (push) Has been cancelled
CI / Build Dev ECR (./docker/app.Dockerfile, ECR_APP) (push) Has been cancelled
CI / Build Dev ECR (./docker/db.Dockerfile, ECR_MIGRATIONS) (push) Has been cancelled
CI / Build Dev ECR (./docker/pii.Dockerfile, ECR_PII) (push) Has been cancelled
CI / Build Dev ECR (./docker/realtime.Dockerfile, ECR_REALTIME) (push) Has been cancelled
CI / Deploy Trigger.dev (Dev) (push) Has been cancelled
CI / Build AMD64 (./docker/app.Dockerfile, ECR_APP, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build AMD64 (./docker/db.Dockerfile, ECR_MIGRATIONS, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build AMD64 (./docker/pii.Dockerfile, ECR_PII, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build AMD64 (./docker/realtime.Dockerfile, ECR_REALTIME, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/app.Dockerfile, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/db.Dockerfile, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/pii.Dockerfile, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/realtime.Dockerfile, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Check Docs Changes (push) Has been cancelled
CI / Process Docs (push) Has been cancelled
CI / Create GitHub Release (push) Has been cancelled
CI / Test and Build (push) Has been cancelled
Publish CLI Package / publish-npm (push) Has been cancelled
Publish Python SDK / publish-pypi (push) Has been cancelled
Publish TypeScript SDK / publish-npm (push) Has been cancelled
CI / Migrate Dev DB (push) Has been skipped
CI / Detect Version (push) Has been cancelled
CI / Migrate DB (push) Has been cancelled
CI / Build Dev ECR (./docker/app.Dockerfile, ECR_APP) (push) Has been cancelled
CI / Build Dev ECR (./docker/db.Dockerfile, ECR_MIGRATIONS) (push) Has been cancelled
CI / Build Dev ECR (./docker/pii.Dockerfile, ECR_PII) (push) Has been cancelled
CI / Build Dev ECR (./docker/realtime.Dockerfile, ECR_REALTIME) (push) Has been cancelled
CI / Deploy Trigger.dev (Dev) (push) Has been cancelled
CI / Build AMD64 (./docker/app.Dockerfile, ECR_APP, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build AMD64 (./docker/db.Dockerfile, ECR_MIGRATIONS, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build AMD64 (./docker/pii.Dockerfile, ECR_PII, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build AMD64 (./docker/realtime.Dockerfile, ECR_REALTIME, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/app.Dockerfile, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/db.Dockerfile, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/pii.Dockerfile, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (./docker/realtime.Dockerfile, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Check Docs Changes (push) Has been cancelled
CI / Process Docs (push) Has been cancelled
CI / Create GitHub Release (push) Has been cancelled
CI / Test and Build (push) Has been cancelled
Publish CLI Package / publish-npm (push) Has been cancelled
Publish Python SDK / publish-pypi (push) Has been cancelled
Publish TypeScript SDK / publish-npm (push) Has been cancelled
This commit is contained in:
@@ -0,0 +1,116 @@
|
||||
/**
|
||||
* @vitest-environment node
|
||||
*/
|
||||
import { NextRequest } from 'next/server'
|
||||
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
||||
|
||||
const { mockResolveShare, mockRateLimit, mockValidateAuth, mockDownloadFile, mockResolveImage } =
|
||||
vi.hoisted(() => ({
|
||||
mockResolveShare: vi.fn(),
|
||||
mockRateLimit: vi.fn(),
|
||||
mockValidateAuth: vi.fn(),
|
||||
mockDownloadFile: vi.fn(),
|
||||
mockResolveImage: vi.fn(),
|
||||
}))
|
||||
|
||||
vi.mock('@/lib/public-shares/share-manager', () => ({
|
||||
resolveActiveShareByToken: mockResolveShare,
|
||||
}))
|
||||
vi.mock('@/lib/public-shares/rate-limit', () => ({ enforcePublicFileRateLimit: mockRateLimit }))
|
||||
vi.mock('@/lib/core/security/deployment-auth', () => ({ validateDeploymentAuth: mockValidateAuth }))
|
||||
vi.mock('@/lib/uploads/core/storage-service', () => ({ downloadFile: mockDownloadFile }))
|
||||
vi.mock('@/lib/uploads/server/inline-image', () => ({
|
||||
resolveWorkspaceInlineImage: mockResolveImage,
|
||||
}))
|
||||
|
||||
import { GET } from '@/app/api/files/public/[token]/inline/route'
|
||||
|
||||
const TOKEN = 'tok_share_123456'
|
||||
const DOC_KEY = 'workspace/ws-1/doc.md'
|
||||
const IMG_KEY = 'workspace/ws-1/photo.png'
|
||||
const FILE_ID = 'wf_YwDXi8eWOkTxn0sbgChlB'
|
||||
const PNG = Buffer.from([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a, 0x00])
|
||||
|
||||
const params = { params: Promise.resolve({ token: TOKEN }) }
|
||||
const req = (q: string) => new NextRequest(`http://localhost/api/files/public/${TOKEN}/inline?${q}`)
|
||||
|
||||
const share = {
|
||||
share: { id: 'sh_1', token: TOKEN, authType: 'public' },
|
||||
file: { id: 'wf_doc', key: DOC_KEY, workspaceId: 'ws-1', originalName: 'doc.md' },
|
||||
workspaceName: 'Acme',
|
||||
ownerName: 'Jane',
|
||||
}
|
||||
|
||||
/** doc bytes embed the image via the view form; image bytes are a real PNG */
|
||||
function downloadByKey(docContent = ``) {
|
||||
return ({ key }: { key: string }) =>
|
||||
Promise.resolve(key === DOC_KEY ? Buffer.from(docContent, 'utf-8') : PNG)
|
||||
}
|
||||
|
||||
describe('GET /api/files/public/[token]/inline', () => {
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
mockRateLimit.mockResolvedValue(null)
|
||||
mockResolveShare.mockResolvedValue(share)
|
||||
mockValidateAuth.mockResolvedValue({ authorized: true })
|
||||
mockResolveImage.mockResolvedValue({
|
||||
key: IMG_KEY,
|
||||
contentType: 'image/png',
|
||||
filename: 'photo.png',
|
||||
})
|
||||
mockDownloadFile.mockImplementation(downloadByKey())
|
||||
})
|
||||
|
||||
it('serves a same-workspace image referenced by the doc, typed from its bytes', async () => {
|
||||
const res = await GET(req(`fileId=${FILE_ID}`), params)
|
||||
expect(res.status).toBe(200)
|
||||
expect(res.headers.get('content-type')).toBe('image/png')
|
||||
})
|
||||
|
||||
it('serves a key-referenced image', async () => {
|
||||
mockDownloadFile.mockImplementation(
|
||||
downloadByKey(`}?context=workspace)`)
|
||||
)
|
||||
const res = await GET(req(`key=${encodeURIComponent(IMG_KEY)}`), params)
|
||||
expect(res.status).toBe(200)
|
||||
})
|
||||
|
||||
it('404s when the reference is not embedded in the shared document', async () => {
|
||||
mockDownloadFile.mockImplementation(downloadByKey('no images here'))
|
||||
const res = await GET(req(`fileId=${FILE_ID}`), params)
|
||||
expect(res.status).toBe(404)
|
||||
expect(mockResolveImage).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('404s when the referenced file is not in the document workspace', async () => {
|
||||
mockResolveImage.mockResolvedValue(null)
|
||||
const res = await GET(req(`fileId=${FILE_ID}`), params)
|
||||
expect(res.status).toBe(404)
|
||||
})
|
||||
|
||||
it('404s when the bytes are not a renderable image', async () => {
|
||||
mockDownloadFile.mockImplementation(({ key }: { key: string }) =>
|
||||
Promise.resolve(
|
||||
key === DOC_KEY
|
||||
? Buffer.from(``, 'utf-8')
|
||||
: Buffer.from('<svg/>', 'utf-8')
|
||||
)
|
||||
)
|
||||
const res = await GET(req(`fileId=${FILE_ID}`), params)
|
||||
expect(res.status).toBe(404)
|
||||
})
|
||||
|
||||
it('401s and never reads storage when the share is unauthorized', async () => {
|
||||
mockValidateAuth.mockResolvedValue({ authorized: false, error: 'auth_required_password' })
|
||||
const res = await GET(req(`fileId=${FILE_ID}`), params)
|
||||
expect(res.status).toBe(401)
|
||||
expect(mockDownloadFile).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('404s for an unknown or inactive token', async () => {
|
||||
mockResolveShare.mockResolvedValue(null)
|
||||
const res = await GET(req(`fileId=${FILE_ID}`), params)
|
||||
expect(res.status).toBe(404)
|
||||
expect(mockDownloadFile).not.toHaveBeenCalled()
|
||||
})
|
||||
})
|
||||
@@ -0,0 +1,119 @@
|
||||
import { AuditAction, AuditResourceType, recordAudit } from '@sim/audit'
|
||||
import { createLogger } from '@sim/logger'
|
||||
import type { NextRequest } from 'next/server'
|
||||
import { NextResponse } from 'next/server'
|
||||
import { getPublicInlineFileContract } from '@/lib/api/contracts/public-shares'
|
||||
import { parseRequest } from '@/lib/api/server'
|
||||
import {
|
||||
extractEmbeddedImageIds,
|
||||
extractEmbeddedImageKeys,
|
||||
} from '@/lib/copilot/tools/server/files/embedded-image-refs'
|
||||
import { validateDeploymentAuth } from '@/lib/core/security/deployment-auth'
|
||||
import { generateRequestId } from '@/lib/core/utils/request'
|
||||
import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
|
||||
import { enforcePublicFileRateLimit } from '@/lib/public-shares/rate-limit'
|
||||
import { resolveActiveShareByToken } from '@/lib/public-shares/share-manager'
|
||||
import { downloadFile } from '@/lib/uploads/core/storage-service'
|
||||
import { resolveWorkspaceInlineImage } from '@/lib/uploads/server/inline-image'
|
||||
import { serveInlineImage } from '@/app/api/files/serve-inline-image'
|
||||
import { createErrorResponse, FileNotFoundError } from '@/app/api/files/utils'
|
||||
|
||||
export const dynamic = 'force-dynamic'
|
||||
|
||||
const logger = createLogger('PublicInlineFileAPI')
|
||||
|
||||
/**
|
||||
* GET /api/files/public/[token]/inline?key=<cloudKey>|fileId=<id>
|
||||
*
|
||||
* Cascades a markdown document's public share to the images it embeds, so a logged-out viewer sees them
|
||||
* instead of broken icons. The share grants the document bytes; this route extends that grant to the
|
||||
* document's referenced images only, behind three gates that together hold the security boundary:
|
||||
*
|
||||
* 1. Referenced-by-doc — the requested key/id must appear in the shared document's current bytes. The
|
||||
* token is a capability for the document and its embeds, never an arbitrary workspace file.
|
||||
* 2. Same-workspace — the referenced file must be a `workspace` file in the document's own workspace
|
||||
* ({@link resolveWorkspaceInlineImage}). This blocks any cross-workspace reference (which an author
|
||||
* can write but must never resolve) from loading.
|
||||
* 3. Content-truth — the served content type is sniffed from the bytes, not the client-declared type,
|
||||
* and only genuine raster images are served. A file spoofing `image/png` while holding HTML/SVG is
|
||||
* refused rather than rendered inline.
|
||||
*/
|
||||
export const GET = withRouteHandler(
|
||||
async (request: NextRequest, context: { params: Promise<{ token: string }> }) => {
|
||||
const requestId = generateRequestId()
|
||||
|
||||
try {
|
||||
const limited = await enforcePublicFileRateLimit(request, 'content')
|
||||
if (limited) return limited
|
||||
|
||||
const parsed = await parseRequest(getPublicInlineFileContract, request, context)
|
||||
if (!parsed.success) return parsed.response
|
||||
const { token } = parsed.data.params
|
||||
const ref = parsed.data.query
|
||||
|
||||
const resolved = await resolveActiveShareByToken(token)
|
||||
if (!resolved) {
|
||||
throw new FileNotFoundError('Not found')
|
||||
}
|
||||
|
||||
const auth = await validateDeploymentAuth(
|
||||
requestId,
|
||||
resolved.share,
|
||||
request,
|
||||
undefined,
|
||||
'file'
|
||||
)
|
||||
if (!auth.authorized) {
|
||||
return NextResponse.json({ error: auth.error ?? 'auth_required_password' }, { status: 401 })
|
||||
}
|
||||
|
||||
const { file: doc } = resolved
|
||||
if (!doc.workspaceId) {
|
||||
throw new FileNotFoundError('Not found')
|
||||
}
|
||||
|
||||
// Referenced-by-doc gate: the share grants exactly the images the document embeds.
|
||||
const docText = (await downloadFile({ key: doc.key, context: 'workspace' })).toString('utf-8')
|
||||
const referenced = ref.fileId
|
||||
? extractEmbeddedImageIds(docText).includes(ref.fileId)
|
||||
: extractEmbeddedImageKeys(docText).includes(ref.key as string)
|
||||
if (!referenced) {
|
||||
throw new FileNotFoundError('Not found')
|
||||
}
|
||||
|
||||
// Same-workspace gate: resolve scoped to the document's own workspace.
|
||||
const image = await resolveWorkspaceInlineImage(doc.workspaceId, ref)
|
||||
if (!image) {
|
||||
throw new FileNotFoundError('Not found')
|
||||
}
|
||||
|
||||
// Content-truth gate (`sniff`): render only genuine raster image bytes; audit after.
|
||||
const response = await serveInlineImage(image, { sniff: true })
|
||||
|
||||
// Anonymous access: null actor (owner-as-actor would misread as a self-download).
|
||||
recordAudit({
|
||||
workspaceId: doc.workspaceId,
|
||||
actorId: null,
|
||||
action: AuditAction.FILE_DOWNLOADED,
|
||||
resourceType: AuditResourceType.FILE,
|
||||
resourceName: image.filename,
|
||||
description: `Public share inline image "${image.filename}"`,
|
||||
metadata: {
|
||||
access: 'public_share',
|
||||
anonymous: true,
|
||||
inline: true,
|
||||
sharedByUserId: doc.userId,
|
||||
},
|
||||
request,
|
||||
})
|
||||
|
||||
return response
|
||||
} catch (error) {
|
||||
if (error instanceof FileNotFoundError) {
|
||||
return createErrorResponse(error)
|
||||
}
|
||||
logger.error('Error serving public inline image:', error)
|
||||
return createErrorResponse(error instanceof Error ? error : new Error('Failed to serve file'))
|
||||
}
|
||||
}
|
||||
)
|
||||
Reference in New Issue
Block a user