chore: import upstream snapshot with attribution
CI / Shell Format Check (push) Has been cancelled
CI / Check Ruby (3.4) (push) Has been cancelled
CI / CI Config (push) Has been cancelled
CI / Test on Node ${{ matrix.node }} and ${{ matrix.os }}${{ matrix.shard && format(' (shard {0}/3)', matrix.shard) || '' }} (push) Has been cancelled
CI / Build on Node ${{ matrix.node }} (push) Has been cancelled
CI / Style Check (push) Has been cancelled
CI / Generate Assets (push) Has been cancelled
CI / Check Python (3.14) (push) Has been cancelled
CI / Check Python (3.9) (push) Has been cancelled
CI / Build Docs (push) Has been cancelled
CI / Code Scan Action (push) Has been cancelled
CI / Site tests (push) Has been cancelled
CI / webui tests (push) Has been cancelled
CI / Run Integration Tests (push) Has been cancelled
CI / Run Smoke Tests (push) Has been cancelled
CI / Go Tests (push) Has been cancelled
CI / Share Test (push) Has been cancelled
CI / Redteam (Production API) (push) Has been cancelled
CI / Redteam (Staging API) (push) Has been cancelled
CI / GitHub Actions Lint (push) Has been cancelled
CI / Check Ruby (3.0) (push) Has been cancelled
release-please / release-please (push) Has been cancelled
release-please / build (push) Has been cancelled
release-please / publish-npm (push) Has been cancelled
release-please / publish-npm-backfill (push) Has been cancelled
release-please / docker (push) Has been cancelled
release-please / publish-code-scan-action (push) Has been cancelled
release-please / attest-code-scan-action (push) Has been cancelled
Deploy local.promptfoo.app / Deploy to Cloudflare Pages (push) Has been cancelled
Test and Publish Multi-arch Docker Image / test (push) Has been cancelled
Test and Publish Multi-arch Docker Image / build-docker-and-push-digests (map[digest-suffix:linux-amd64 platform:linux/amd64 runner:ubuntu-latest]) (push) Has been cancelled
Test and Publish Multi-arch Docker Image / build-docker-and-push-digests (map[digest-suffix:linux-arm64 platform:linux/arm64 runner:ubuntu-24.04-arm]) (push) Has been cancelled
Test and Publish Multi-arch Docker Image / merge-docker-digests (push) Has been cancelled
Test and Publish Multi-arch Docker Image / Attest Multi-arch Image (push) Has been cancelled
Validate Renovate Config / Validate Renovate Configuration (push) Has been cancelled
CI / Shell Format Check (push) Has been cancelled
CI / Check Ruby (3.4) (push) Has been cancelled
CI / CI Config (push) Has been cancelled
CI / Test on Node ${{ matrix.node }} and ${{ matrix.os }}${{ matrix.shard && format(' (shard {0}/3)', matrix.shard) || '' }} (push) Has been cancelled
CI / Build on Node ${{ matrix.node }} (push) Has been cancelled
CI / Style Check (push) Has been cancelled
CI / Generate Assets (push) Has been cancelled
CI / Check Python (3.14) (push) Has been cancelled
CI / Check Python (3.9) (push) Has been cancelled
CI / Build Docs (push) Has been cancelled
CI / Code Scan Action (push) Has been cancelled
CI / Site tests (push) Has been cancelled
CI / webui tests (push) Has been cancelled
CI / Run Integration Tests (push) Has been cancelled
CI / Run Smoke Tests (push) Has been cancelled
CI / Go Tests (push) Has been cancelled
CI / Share Test (push) Has been cancelled
CI / Redteam (Production API) (push) Has been cancelled
CI / Redteam (Staging API) (push) Has been cancelled
CI / GitHub Actions Lint (push) Has been cancelled
CI / Check Ruby (3.0) (push) Has been cancelled
release-please / release-please (push) Has been cancelled
release-please / build (push) Has been cancelled
release-please / publish-npm (push) Has been cancelled
release-please / publish-npm-backfill (push) Has been cancelled
release-please / docker (push) Has been cancelled
release-please / publish-code-scan-action (push) Has been cancelled
release-please / attest-code-scan-action (push) Has been cancelled
Deploy local.promptfoo.app / Deploy to Cloudflare Pages (push) Has been cancelled
Test and Publish Multi-arch Docker Image / test (push) Has been cancelled
Test and Publish Multi-arch Docker Image / build-docker-and-push-digests (map[digest-suffix:linux-amd64 platform:linux/amd64 runner:ubuntu-latest]) (push) Has been cancelled
Test and Publish Multi-arch Docker Image / build-docker-and-push-digests (map[digest-suffix:linux-arm64 platform:linux/arm64 runner:ubuntu-24.04-arm]) (push) Has been cancelled
Test and Publish Multi-arch Docker Image / merge-docker-digests (push) Has been cancelled
Test and Publish Multi-arch Docker Image / Attest Multi-arch Image (push) Has been cancelled
Validate Renovate Config / Validate Renovate Configuration (push) Has been cancelled
This commit is contained in:
@@ -0,0 +1,308 @@
|
||||
import request from 'supertest';
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
|
||||
import { mockProcessEnv } from '../../util/utils';
|
||||
|
||||
vi.mock('../../../src/updates', () => ({ getLatestVersion: vi.fn() }));
|
||||
vi.mock('../../../src/updates/updateCommands', () => ({ getUpdateCommands: vi.fn() }));
|
||||
vi.mock('../../../src/util/promptfooCommand', () => ({ isRunningUnderNpx: vi.fn() }));
|
||||
|
||||
import { createApp } from '../../../src/server/server';
|
||||
import { getLatestVersion } from '../../../src/updates';
|
||||
import { getUpdateCommands } from '../../../src/updates/updateCommands';
|
||||
import { isRunningUnderNpx } from '../../../src/util/promptfooCommand';
|
||||
|
||||
const mockedGetLatestVersion = vi.mocked(getLatestVersion);
|
||||
const mockedGetUpdateCommands = vi.mocked(getUpdateCommands);
|
||||
const mockedIsRunningUnderNpx = vi.mocked(isRunningUnderNpx);
|
||||
|
||||
describe('Version Route', () => {
|
||||
let app: ReturnType<typeof createApp>;
|
||||
|
||||
beforeEach(() => {
|
||||
vi.resetAllMocks();
|
||||
mockedIsRunningUnderNpx.mockReturnValue(false);
|
||||
mockedGetUpdateCommands.mockReturnValue({
|
||||
primary: 'npm install -g promptfoo@latest',
|
||||
alternative: 'npx promptfoo@latest',
|
||||
commandType: 'npm',
|
||||
});
|
||||
app = createApp();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
vi.useRealTimers();
|
||||
vi.restoreAllMocks();
|
||||
});
|
||||
|
||||
it('should return 200 with valid response schema shape', async () => {
|
||||
mockedGetLatestVersion.mockResolvedValue('99.0.0');
|
||||
|
||||
const response = await request(app).get('/api/version');
|
||||
|
||||
// If schema validation fails (e.g. wrong field names), Response.parse() throws → 500
|
||||
expect(response.status).toBe(200);
|
||||
expect(response.body).toMatchObject({
|
||||
selfHosted: false,
|
||||
isNpx: false,
|
||||
updateCommands: {
|
||||
primary: 'npm install -g promptfoo@latest',
|
||||
alternative: 'npx promptfoo@latest',
|
||||
commandType: 'npm',
|
||||
},
|
||||
commandType: 'npm',
|
||||
});
|
||||
expect(typeof response.body.currentVersion).toBe('string');
|
||||
expect(typeof response.body.latestVersion).toBe('string');
|
||||
expect(typeof response.body.updateAvailable).toBe('boolean');
|
||||
expect(typeof response.body.updateBlockedByRuntime).toBe('boolean');
|
||||
if (process.versions.node.startsWith('20.')) {
|
||||
expect(response.body.runtimeNotice).toMatchObject({ currentMajor: 20, runtime: 'node' });
|
||||
expect(response.body.blockedUpdateNotice).toMatchObject({
|
||||
currentMajor: 20,
|
||||
runtime: 'node',
|
||||
});
|
||||
expect(response.body.runtimePolicy).toEqual({ supportEndDate: '2026-07-30' });
|
||||
} else {
|
||||
expect(response.body.runtimeNotice).toBeNull();
|
||||
expect(response.body.blockedUpdateNotice).toBeNull();
|
||||
expect(response.body.runtimePolicy).toBeNull();
|
||||
}
|
||||
});
|
||||
|
||||
it('should not return 500 when fetch fails (graceful fallback)', async () => {
|
||||
vi.spyOn(Date, 'now').mockReturnValue(Date.parse('2099-01-01T00:00:00.000Z'));
|
||||
mockedGetLatestVersion.mockRejectedValue(new Error('Network error'));
|
||||
|
||||
const response = await request(app).get('/api/version');
|
||||
|
||||
// Should still return 200, not 500 — schema must match even on fallback path
|
||||
expect(response.status).toBe(200);
|
||||
expect(mockedGetLatestVersion).toHaveBeenCalledTimes(1);
|
||||
expect(typeof response.body.currentVersion).toBe('string');
|
||||
expect(typeof response.body.latestVersion).toBe('string');
|
||||
expect(typeof response.body.updateAvailable).toBe('boolean');
|
||||
expect(typeof response.body.updateBlockedByRuntime).toBe('boolean');
|
||||
});
|
||||
|
||||
it('should skip upstream update checks when they are disabled', async () => {
|
||||
const restoreEnv = mockProcessEnv({ PROMPTFOO_DISABLE_UPDATE: 'true' });
|
||||
|
||||
try {
|
||||
const response = await request(app).get('/api/version');
|
||||
|
||||
expect(response.status).toBe(200);
|
||||
expect(mockedGetLatestVersion).not.toHaveBeenCalled();
|
||||
expect(response.body.latestVersion).toBe(response.body.currentVersion);
|
||||
expect(response.body.updateAvailable).toBe(false);
|
||||
if (process.versions.node.startsWith('20.')) {
|
||||
expect(response.body.runtimePolicy).toEqual({ supportEndDate: '2026-07-30' });
|
||||
}
|
||||
} finally {
|
||||
restoreEnv();
|
||||
}
|
||||
});
|
||||
|
||||
it('should preserve blocked update guidance when runtime reminders are disabled', async () => {
|
||||
vi.useFakeTimers({ toFake: ['Date'] });
|
||||
vi.setSystemTime(new Date('2026-07-31T00:00:00.000Z'));
|
||||
vi.spyOn(process, 'version', 'get').mockReturnValue('v20.20.0');
|
||||
const restoreEnv = mockProcessEnv({ PROMPTFOO_DISABLE_RUNTIME_WARNINGS: 'true' });
|
||||
mockedGetLatestVersion.mockResolvedValue('99.0.0');
|
||||
|
||||
try {
|
||||
const response = await request(app).get('/api/version');
|
||||
|
||||
expect(response.status).toBe(200);
|
||||
expect(response.body).toMatchObject({
|
||||
latestVersion: '99.0.0',
|
||||
updateAvailable: false,
|
||||
updateBlockedByRuntime: true,
|
||||
runtimeNotice: null,
|
||||
blockedUpdateNotice: {
|
||||
currentVersion: 'v20.20.0',
|
||||
currentMajor: 20,
|
||||
removalDate: '2026-07-30',
|
||||
minimumVersion: '22.22.0',
|
||||
recommendedVersion: '24 LTS',
|
||||
},
|
||||
});
|
||||
} finally {
|
||||
restoreEnv();
|
||||
}
|
||||
});
|
||||
|
||||
it('should include all required fields matching UpdateCommandResult shape', async () => {
|
||||
mockedGetLatestVersion.mockResolvedValue('99.0.0');
|
||||
mockedGetUpdateCommands.mockReturnValue({
|
||||
primary: 'docker pull ghcr.io/promptfoo/promptfoo:latest',
|
||||
alternative: null,
|
||||
commandType: 'docker',
|
||||
});
|
||||
|
||||
const response = await request(app).get('/api/version');
|
||||
|
||||
expect(response.status).toBe(200);
|
||||
// Validates that updateCommands has primary/alternative (not global/npx)
|
||||
expect(response.body.updateCommands).toHaveProperty('primary');
|
||||
expect(response.body.updateCommands).toHaveProperty('alternative');
|
||||
expect(response.body.updateCommands).toHaveProperty('commandType');
|
||||
expect(response.body.updateCommands).not.toHaveProperty('global');
|
||||
expect(response.body.updateCommands).not.toHaveProperty('npx');
|
||||
expect(['docker', 'npx', 'npm']).toContain(response.body.commandType);
|
||||
});
|
||||
|
||||
it('should not classify generic self-hosted mode as Docker', async () => {
|
||||
const restoreEnv = mockProcessEnv({
|
||||
PROMPTFOO_OFFICIAL_DOCKER_IMAGE: undefined,
|
||||
PROMPTFOO_SELF_HOSTED: 'true',
|
||||
});
|
||||
mockedGetLatestVersion.mockResolvedValue('99.0.0');
|
||||
|
||||
try {
|
||||
const response = await request(app).get('/api/version');
|
||||
|
||||
expect(response.status).toBe(200);
|
||||
expect(response.body.selfHosted).toBe(true);
|
||||
expect(mockedGetUpdateCommands).toHaveBeenCalledWith({
|
||||
isContainer: false,
|
||||
isOfficialDockerImage: false,
|
||||
isNpx: false,
|
||||
});
|
||||
} finally {
|
||||
restoreEnv();
|
||||
}
|
||||
});
|
||||
|
||||
it('should use Docker guidance only when the official-image marker is set', async () => {
|
||||
const restoreEnv = mockProcessEnv({
|
||||
PROMPTFOO_OFFICIAL_DOCKER_IMAGE: 'true',
|
||||
PROMPTFOO_RUNNING_IN_DOCKER: 'true',
|
||||
PROMPTFOO_SELF_HOSTED: 'true',
|
||||
});
|
||||
mockedGetLatestVersion.mockResolvedValue('99.0.0');
|
||||
|
||||
try {
|
||||
const response = await request(app).get('/api/version');
|
||||
|
||||
expect(response.status).toBe(200);
|
||||
expect(response.body.selfHosted).toBe(true);
|
||||
expect(mockedGetUpdateCommands).toHaveBeenCalledWith({
|
||||
isContainer: true,
|
||||
isOfficialDockerImage: true,
|
||||
isNpx: false,
|
||||
});
|
||||
} finally {
|
||||
restoreEnv();
|
||||
}
|
||||
});
|
||||
|
||||
it('should distinguish custom containers from official images', async () => {
|
||||
const restoreEnv = mockProcessEnv({
|
||||
PROMPTFOO_OFFICIAL_DOCKER_IMAGE: undefined,
|
||||
PROMPTFOO_RUNNING_IN_DOCKER: 'true',
|
||||
PROMPTFOO_SELF_HOSTED: 'true',
|
||||
});
|
||||
mockedGetLatestVersion.mockResolvedValue('99.0.0');
|
||||
mockedGetUpdateCommands.mockReturnValue({
|
||||
primary: '',
|
||||
alternative: null,
|
||||
commandType: 'npm',
|
||||
isCustomContainer: true,
|
||||
});
|
||||
|
||||
try {
|
||||
const response = await request(app).get('/api/version');
|
||||
|
||||
expect(response.status).toBe(200);
|
||||
expect(response.body).toMatchObject({
|
||||
commandType: 'npm',
|
||||
updateCommands: {
|
||||
primary: '',
|
||||
alternative: null,
|
||||
commandType: 'npm',
|
||||
isCustomContainer: true,
|
||||
},
|
||||
});
|
||||
expect(mockedGetUpdateCommands).toHaveBeenCalledWith({
|
||||
isContainer: true,
|
||||
isOfficialDockerImage: false,
|
||||
isNpx: false,
|
||||
});
|
||||
} finally {
|
||||
restoreEnv();
|
||||
}
|
||||
});
|
||||
|
||||
it('should block package updates but preserve Docker updates at the cutoff', async () => {
|
||||
vi.useFakeTimers({ toFake: ['Date'] });
|
||||
vi.setSystemTime(new Date('2099-01-01T00:00:00.000Z'));
|
||||
mockedGetLatestVersion.mockRejectedValueOnce(new Error('Seed future retry state'));
|
||||
const futureResponse = await request(app).get('/api/version');
|
||||
expect(futureResponse.status).toBe(200);
|
||||
|
||||
mockedGetLatestVersion.mockReset();
|
||||
mockedGetLatestVersion.mockResolvedValue('99.0.0');
|
||||
vi.setSystemTime(new Date('2026-07-30T00:00:00.000Z'));
|
||||
|
||||
const packageResponse = await request(app).get('/api/version');
|
||||
expect(packageResponse.status).toBe(200);
|
||||
expect(mockedGetLatestVersion).toHaveBeenCalledTimes(1);
|
||||
expect(packageResponse.body.updateBlockedByRuntime).toBe(
|
||||
process.versions.node.startsWith('20.'),
|
||||
);
|
||||
expect(packageResponse.body.updateAvailable).toBe(!process.versions.node.startsWith('20.'));
|
||||
expect(packageResponse.body.blockedUpdateNotice).toEqual(
|
||||
process.versions.node.startsWith('20.')
|
||||
? expect.objectContaining({ currentMajor: 20 })
|
||||
: null,
|
||||
);
|
||||
|
||||
mockedGetUpdateCommands.mockReturnValue({
|
||||
primary: '',
|
||||
alternative: null,
|
||||
commandType: 'npm',
|
||||
isCustomContainer: true,
|
||||
});
|
||||
const customContainerResponse = await request(app).get('/api/version');
|
||||
expect(customContainerResponse.status).toBe(200);
|
||||
expect(customContainerResponse.body.updateBlockedByRuntime).toBe(
|
||||
process.versions.node.startsWith('20.'),
|
||||
);
|
||||
expect(customContainerResponse.body.updateAvailable).toBe(
|
||||
!process.versions.node.startsWith('20.'),
|
||||
);
|
||||
expect(customContainerResponse.body.blockedUpdateNotice).toEqual(
|
||||
process.versions.node.startsWith('20.')
|
||||
? expect.objectContaining({ currentMajor: 20 })
|
||||
: null,
|
||||
);
|
||||
|
||||
mockedGetUpdateCommands.mockReturnValue({
|
||||
primary: 'docker pull ghcr.io/promptfoo/promptfoo:latest',
|
||||
alternative: null,
|
||||
commandType: 'docker',
|
||||
});
|
||||
const dockerResponse = await request(app).get('/api/version');
|
||||
expect(dockerResponse.status).toBe(200);
|
||||
expect(dockerResponse.body.updateBlockedByRuntime).toBe(false);
|
||||
expect(dockerResponse.body.updateAvailable).toBe(true);
|
||||
expect(dockerResponse.body.blockedUpdateNotice).toBeNull();
|
||||
});
|
||||
|
||||
it('should return 500 with fallback response when schema parse fails', async () => {
|
||||
mockedGetLatestVersion.mockResolvedValue('99.0.0');
|
||||
// Return an invalid shape that will cause VersionSchemas.Response.parse() to throw
|
||||
mockedGetUpdateCommands.mockReturnValue({
|
||||
primary: 'npm install -g promptfoo@latest',
|
||||
alternative: 'npx promptfoo@latest',
|
||||
commandType: 'invalid-type' as any,
|
||||
});
|
||||
|
||||
const response = await request(app).get('/api/version');
|
||||
|
||||
expect(response.status).toBe(500);
|
||||
expect(response.body).toHaveProperty('error', 'Failed to check version');
|
||||
expect(response.body).toHaveProperty('currentVersion');
|
||||
expect(response.body).toHaveProperty('updateCommands');
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user