wehub-resource-sync
102 lines
3.5 KiB
Python
102 lines
3.5 KiB
Python
"""Tests for `--picture-description-prompt` propagation in the hybrid server.
|
|
|
|
Covers PDFDLOSP-20: the CLI accepted `--picture-description-prompt` without
|
|
error but the prompt was never written into `PictureDescriptionVlmOptions`,
|
|
so output was byte-identical regardless of the user's prompt. These tests
|
|
lock in both halves of the contract:
|
|
|
|
* A custom prompt reaches `PictureDescriptionVlmOptions.prompt`.
|
|
* Omitting the prompt preserves docling's built-in default.
|
|
* Blank / whitespace-only prompts are treated as "not provided" so they
|
|
never silently inject an empty prompt into the VLM.
|
|
* The whole feature is gated by `enrich_picture_description=True`.
|
|
"""
|
|
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from opendataloader_pdf import hybrid_server
|
|
|
|
|
|
def _capture_pipeline_options(**kwargs):
|
|
"""Build a converter while mocking out docling's heavy bits so we can
|
|
introspect the PdfPipelineOptions instance.
|
|
"""
|
|
captured = {}
|
|
|
|
def fake_pdf_format_option(*, pipeline_options):
|
|
captured["pipeline_options"] = pipeline_options
|
|
return object()
|
|
|
|
with patch(
|
|
"docling.document_converter.DocumentConverter"
|
|
) as mock_dc, patch(
|
|
"docling.document_converter.PdfFormatOption", side_effect=fake_pdf_format_option
|
|
):
|
|
mock_dc.return_value = object()
|
|
hybrid_server.create_converter(**kwargs)
|
|
|
|
return captured["pipeline_options"]
|
|
|
|
|
|
def test_custom_prompt_is_forwarded_to_vlm_options():
|
|
"""The user-supplied prompt must end up on PictureDescriptionVlmOptions.
|
|
|
|
Regression for PDFDLOSP-20.
|
|
"""
|
|
opts = _capture_pipeline_options(
|
|
enrich_picture_description=True,
|
|
picture_description_prompt="HELLO WORLD",
|
|
)
|
|
assert opts.picture_description_options is not None
|
|
assert opts.picture_description_options.prompt == "HELLO WORLD"
|
|
|
|
|
|
def test_default_prompt_is_preserved_when_user_omits_flag():
|
|
"""When no prompt is given, docling's built-in default must survive.
|
|
|
|
Locks the current docling default. If a docling upgrade changes the
|
|
phrase, this canary fires — at which point we decide whether to track
|
|
the new default or pin our own.
|
|
"""
|
|
opts = _capture_pipeline_options(enrich_picture_description=True)
|
|
assert opts.picture_description_options is not None
|
|
assert (
|
|
opts.picture_description_options.prompt
|
|
== "Describe this image in a few sentences."
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize("blank", ["", " ", "\t\n"])
|
|
def test_blank_prompt_falls_back_to_default(blank):
|
|
"""Empty / whitespace-only prompts must not inject an empty prompt.
|
|
|
|
Otherwise we recreate the same class of silent-flag misbehavior that
|
|
PDFDLOSP-20 reported.
|
|
"""
|
|
opts = _capture_pipeline_options(
|
|
enrich_picture_description=True,
|
|
picture_description_prompt=blank,
|
|
)
|
|
assert opts.picture_description_options is not None
|
|
assert (
|
|
opts.picture_description_options.prompt
|
|
== "Describe this image in a few sentences."
|
|
)
|
|
|
|
|
|
def test_prompt_ignored_when_enrichment_disabled():
|
|
"""Without --enrich-picture-description, the prompt has no destination.
|
|
|
|
Docling populates a default `picture_description_options` object on
|
|
`PdfPipelineOptions` even when do_picture_description=False, so we
|
|
assert on the gate (`do_picture_description`) rather than identity of
|
|
the options object.
|
|
"""
|
|
opts = _capture_pipeline_options(
|
|
enrich_picture_description=False,
|
|
picture_description_prompt="HELLO WORLD",
|
|
)
|
|
assert opts.do_picture_description is False
|