wehub-resource-sync
113 lines
4.0 KiB
Python
113 lines
4.0 KiB
Python
"""Tests for the shared server-config loader (:mod:`omnigent.server.server_config`).
|
|
|
|
Covers path resolution (env override → ``<data_dir>/config.yaml`` →
|
|
None), loading + fail-open behavior (missing / malformed / non-mapping
|
|
→ empty dict, never a crash), and the ``config_str_list`` coercion used
|
|
for ``admins`` / ``allowed_domains``.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from omnigent.server.server_config import (
|
|
config_str_list,
|
|
load_server_config,
|
|
resolve_config_path,
|
|
)
|
|
|
|
|
|
def _pin_data_dir(monkeypatch: pytest.MonkeyPatch, tmp_path: Path) -> None:
|
|
"""Point <data_dir> at tmp_path and clear the explicit-path override."""
|
|
monkeypatch.delenv("OMNIGENT_CONFIG", raising=False)
|
|
monkeypatch.setenv("OMNIGENT_ADMIN_CREDENTIALS_PATH", str(tmp_path / "admin-credentials"))
|
|
|
|
|
|
# ── path resolution ───────────────────────────────────────────────
|
|
|
|
|
|
def test_resolve_config_path_env_override(monkeypatch: pytest.MonkeyPatch, tmp_path: Path) -> None:
|
|
"""``OMNIGENT_CONFIG`` wins over the data-dir default."""
|
|
p = tmp_path / "custom.yaml"
|
|
p.write_text("{}")
|
|
monkeypatch.setenv("OMNIGENT_CONFIG", str(p))
|
|
assert resolve_config_path() == p
|
|
|
|
|
|
def test_resolve_config_path_default_when_present(
|
|
monkeypatch: pytest.MonkeyPatch, tmp_path: Path
|
|
) -> None:
|
|
"""Falls back to ``<data_dir>/config.yaml`` when that file exists."""
|
|
_pin_data_dir(monkeypatch, tmp_path)
|
|
cfg = tmp_path / "config.yaml"
|
|
cfg.write_text("admins: [a@x.com]\n")
|
|
assert resolve_config_path() == cfg
|
|
|
|
|
|
def test_resolve_config_path_none_when_absent(
|
|
monkeypatch: pytest.MonkeyPatch, tmp_path: Path
|
|
) -> None:
|
|
"""No env, no default file → ``None`` (pure-env back-compat)."""
|
|
_pin_data_dir(monkeypatch, tmp_path)
|
|
assert resolve_config_path() is None
|
|
|
|
|
|
# ── loading ───────────────────────────────────────────────────────
|
|
|
|
|
|
def test_load_server_config_parses(monkeypatch: pytest.MonkeyPatch, tmp_path: Path) -> None:
|
|
"""A well-formed config loads into a dict."""
|
|
_pin_data_dir(monkeypatch, tmp_path)
|
|
(tmp_path / "config.yaml").write_text("admins:\n - a@x.com\nallowed_domains: [x.com]\n")
|
|
cfg = load_server_config()
|
|
assert cfg["admins"] == ["a@x.com"]
|
|
assert cfg["allowed_domains"] == ["x.com"]
|
|
|
|
|
|
def test_load_server_config_empty_when_no_file(
|
|
monkeypatch: pytest.MonkeyPatch, tmp_path: Path
|
|
) -> None:
|
|
"""No config file → empty dict (not an error)."""
|
|
_pin_data_dir(monkeypatch, tmp_path)
|
|
assert load_server_config() == {}
|
|
|
|
|
|
def test_load_server_config_malformed_is_empty(
|
|
monkeypatch: pytest.MonkeyPatch, tmp_path: Path
|
|
) -> None:
|
|
"""Malformed YAML fails open to empty rather than crashing startup."""
|
|
_pin_data_dir(monkeypatch, tmp_path)
|
|
(tmp_path / "config.yaml").write_text("admins: [unclosed\n")
|
|
assert load_server_config() == {}
|
|
|
|
|
|
def test_load_server_config_non_mapping_is_empty(
|
|
monkeypatch: pytest.MonkeyPatch, tmp_path: Path
|
|
) -> None:
|
|
"""A top-level non-mapping (e.g. a list) is ignored."""
|
|
_pin_data_dir(monkeypatch, tmp_path)
|
|
(tmp_path / "config.yaml").write_text("- a\n- b\n")
|
|
assert load_server_config() == {}
|
|
|
|
|
|
# ── config_str_list ───────────────────────────────────────────────
|
|
|
|
|
|
def test_config_str_list_accepts_list() -> None:
|
|
assert config_str_list(["a@x.com", "b@x.com"]) == ["a@x.com", "b@x.com"]
|
|
|
|
|
|
def test_config_str_list_accepts_scalar() -> None:
|
|
"""A single scalar is wrapped — a one-entry value needn't be a list."""
|
|
assert config_str_list("a@x.com") == ["a@x.com"]
|
|
|
|
|
|
def test_config_str_list_none_is_empty() -> None:
|
|
assert config_str_list(None) == []
|
|
|
|
|
|
def test_config_str_list_strips_and_drops_empty() -> None:
|
|
assert config_str_list([" a@x.com ", "", " "]) == ["a@x.com"]
|