wehub-resource-sync
147 lines
6.8 KiB
Python
147 lines
6.8 KiB
Python
"""E2E: right rail Shells tab and file viewer.
|
|
|
|
Execution-logs coverage was dropped: that surface used to be a
|
|
``SessionRail`` card but the rail is now tabbed (Agents/Files/Shells)
|
|
and the only entry point left is the ``md:hidden`` mobile session menu —
|
|
unreachable on the desktop viewport these tests run at.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import re
|
|
from pathlib import Path
|
|
|
|
import httpx
|
|
from playwright.sync_api import Page, expect
|
|
|
|
from tests.e2e_ui.conftest import (
|
|
_TERMINAL_PANEL_FILE,
|
|
_TERMINAL_PANEL_FILE_CONTENT,
|
|
open_right_rail,
|
|
)
|
|
|
|
_REPO_ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_right_panel_terminals_and_file_viewer(
|
|
page: Page,
|
|
terminal_session: tuple[str, str],
|
|
) -> None:
|
|
"""Launch a terminal and exercise the Terminals tab + file viewer.
|
|
|
|
The terminal session fixture registers the test agent and creates a
|
|
session bound to it. We send ``spin up zsh``, then verify:
|
|
|
|
- the right rail's Terminals tab lists the launched terminal, its
|
|
xterm connects inline, and the maximize button opens the full
|
|
terminals push panel;
|
|
- the Files tab can open a workspace file and the file viewer renders
|
|
its contents.
|
|
|
|
The file is seeded via the filesystem API rather than relying on the
|
|
agent's terminal ``printf`` to write it: the agent's workspace cwd
|
|
differs by environment (empty on CI), and the changed-files panel only
|
|
refreshes on turn active→idle, so a late PTY write races the refresh.
|
|
The terminal launch above is the real terminal coverage; the file
|
|
viewer just needs a deterministic file present in the scanned workspace.
|
|
"""
|
|
base_url, session_id = terminal_session
|
|
test_file = _REPO_ROOT / _TERMINAL_PANEL_FILE
|
|
if test_file.exists():
|
|
test_file.unlink()
|
|
|
|
# Seed the file into the session workspace (same API the markdown tests
|
|
# use) so it deterministically appears in the Files panel.
|
|
seed_resp = httpx.put(
|
|
f"{base_url}/v1/sessions/{session_id}"
|
|
f"/resources/environments/default/filesystem/{_TERMINAL_PANEL_FILE}",
|
|
json={"content": f"{_TERMINAL_PANEL_FILE_CONTENT}\n", "encoding": "utf-8"},
|
|
timeout=10.0,
|
|
)
|
|
seed_resp.raise_for_status()
|
|
|
|
# Scope rail-content lookups to the desktop "Workspace" rail so they
|
|
# don't match the hidden mobile drawer that mirrors the same testids.
|
|
rail = page.get_by_role("complementary", name="Workspace")
|
|
|
|
try:
|
|
page.goto(f"{base_url}/c/{session_id}")
|
|
# The rail defaults open but is remembered per session; ensure it is
|
|
# open so the Shells tab and Files panel below are reachable.
|
|
open_right_rail(page)
|
|
|
|
composer = page.get_by_placeholder("Ask the agent anything…")
|
|
expect(composer).to_be_visible()
|
|
composer.fill("spin up zsh")
|
|
page.get_by_role("button", name="Send", exact=True).click()
|
|
|
|
# Open the Shells tab (present by default — the agent declares
|
|
# terminals). The launched shell's row shows once the agent's
|
|
# sys_terminal_launch completes (LLM turn → up to 60s); keep
|
|
# main's generous click timeout for slow CI turns.
|
|
rail.get_by_role("tab", name=re.compile("Shells")).click(timeout=60_000)
|
|
terminal_row = rail.get_by_role("button").filter(has_text="zsh").filter(has_text="main")
|
|
expect(terminal_row.first).to_be_visible(timeout=60_000)
|
|
|
|
# Clicking a shell row replaces the main session view with that
|
|
# shell — terminal-first sessions (every runner-hosted SDK
|
|
# session) render it inline in the main pane via
|
|
# MainTerminalView; the rail never mounts an xterm of its own.
|
|
# The view must focus the CLICKED shell: a ``tui`` active key
|
|
# here means the explicit key was dropped and the view fell
|
|
# back to the agent's embedded REPL terminal.
|
|
terminal_row.first.click()
|
|
main_terminal = page.get_by_test_id("main-terminal-view")
|
|
expect(main_terminal).to_be_visible()
|
|
expect(main_terminal).to_have_attribute(
|
|
"data-active-terminal", "terminal:terminal_zsh_main"
|
|
)
|
|
expect(main_terminal).to_contain_text("zsh")
|
|
# The shell's xterm mounts in the main pane and connects.
|
|
terminal_view = page.get_by_test_id("terminal-view")
|
|
expect(terminal_view.last).to_be_visible(timeout=20_000)
|
|
expect(terminal_view.last).to_have_attribute("data-state", "connected", timeout=20_000)
|
|
# Chrome-free shell view: the Chat/Terminal pill is hidden (a
|
|
# "Chat" option under a shell misreads as the shell being the
|
|
# agent) and no agent tab renders next to the shell. A visible
|
|
# pill or "tui" text means the isShellView gate regressed.
|
|
expect(page.get_by_role("button", name="Chat", exact=True)).to_have_count(0)
|
|
expect(main_terminal).not_to_contain_text("tui")
|
|
# The header's close X is the way back to the conversation
|
|
# surface for the Files steps below.
|
|
page.get_by_role("button", name="Close shell").click()
|
|
expect(main_terminal).to_have_count(0)
|
|
|
|
# Switch to the Files tab and open the seeded file. The
|
|
# changed-file row renders two buttons carrying the filename: the
|
|
# file-open button (visible text) and an icon-only Download button
|
|
# (aria-label "Download <name>"). Filter to the open button by its
|
|
# visible text so the locator stays single-element under strict mode.
|
|
rail.get_by_role("tab", name=re.compile("Files")).click()
|
|
file_button = rail.get_by_role(
|
|
"button", name=re.compile(re.escape(_TERMINAL_PANEL_FILE))
|
|
).filter(has_text=_TERMINAL_PANEL_FILE)
|
|
expect(file_button).to_be_visible(timeout=60_000)
|
|
file_button.click()
|
|
|
|
# Two FileViewer instances mount (hidden mobile drawer + desktop
|
|
# rail); scope to the rail so the locator is single-element and the
|
|
# visible desktop instance — the bare-page ``.last`` can resolve to
|
|
# the hidden drawer once other push panels have mounted.
|
|
file_viewer = rail.get_by_test_id("file-viewer")
|
|
expect(file_viewer).to_be_visible()
|
|
# The open file is identified by its tab (the desktop viewer header no
|
|
# longer repeats a top-level filename — it's redundant with the tab).
|
|
# The tab's close button carries an "Close <name>" label.
|
|
expect(
|
|
rail.get_by_role("button", name=f"Close {_TERMINAL_PANEL_FILE}", exact=True)
|
|
).to_be_visible()
|
|
# The viewer renders the file body; scope inside the file viewer and
|
|
# pick the first match — its presence proves the content landed.
|
|
expect(file_viewer.get_by_text(_TERMINAL_PANEL_FILE_CONTENT).first).to_be_visible(
|
|
timeout=20_000
|
|
)
|
|
finally:
|
|
if test_file.exists():
|
|
test_file.unlink()
|