b4fbd6fe9f
Deploy Site / deploy-vercel (push) Has been skipped
Deploy Site / deploy-docs (push) Has been skipped
Build Skills Index / build-index (push) Has been skipped
CI / Deny unrelated histories (push) Has been skipped
CI / Detect affected areas (push) Successful in 27m35s
CI / OSV scan (push) Failing after 4s
CI / Build&Test Docker image (push) Successful in 9s
CI / Supply-chain scan (push) Has been skipped
CI / Lint Docker scripts (push) Failing after 5m13s
CI / Check contributors (push) Failing after 12m8s
CI / Docs Site (push) Failing after 12m8s
CI / TypeScript (push) Failing after 12m8s
CI / Python lints (push) Failing after 12m9s
CI / Python tests (push) Failing after 12m9s
CI / Check uv.lock (push) Failing after 23m22s
CI / CI timing report (push) Has been cancelled
Build Skills Index / trigger-deploy (push) Has been cancelled
CI / All required checks pass (push) Has been cancelled
61 lines
2.1 KiB
Python
61 lines
2.1 KiB
Python
"""Regression: text_to_speech_tool output_path must reject '..' traversal.
|
|
|
|
The TTS surface accepts agent/user-supplied absolute paths (writing to a
|
|
chosen file is the whole point). What it must reject is paths that use
|
|
``..`` components to escape their declared base — those are almost
|
|
always either a bug or prompt-injection-controlled
|
|
(e.g. ``output_path="audio/../../etc/cron.d/x"``).
|
|
"""
|
|
|
|
import json
|
|
|
|
from tools.tts_tool import text_to_speech_tool
|
|
|
|
|
|
def test_output_path_rejects_traversal_escape():
|
|
"""A path with '..' components must be rejected before any provider work."""
|
|
result = json.loads(text_to_speech_tool(
|
|
text="hello",
|
|
output_path="audio/../../etc/cron.d/malicious",
|
|
))
|
|
assert result["success"] is False
|
|
assert "traversal" in result["error"].lower()
|
|
|
|
|
|
def test_output_path_rejects_bare_dotdot():
|
|
"""Bare '..' prefix must be rejected."""
|
|
result = json.loads(text_to_speech_tool(
|
|
text="hello",
|
|
output_path="../escape.mp3",
|
|
))
|
|
assert result["success"] is False
|
|
assert "traversal" in result["error"].lower()
|
|
|
|
|
|
def test_output_path_absolute_path_passes_guard(tmp_path, monkeypatch):
|
|
"""Explicit absolute paths must pass the traversal guard.
|
|
|
|
The agent legitimately writes audio to user-specified absolute paths;
|
|
only ``..`` components are rejected. Any subsequent failure (no
|
|
provider configured, etc.) is fine — the assertion is specifically
|
|
that the 'traversal' rejection didn't fire.
|
|
"""
|
|
inside = tmp_path / "clip.mp3"
|
|
result = json.loads(text_to_speech_tool(
|
|
text="hello",
|
|
output_path=str(inside),
|
|
))
|
|
error = result.get("error", "")
|
|
assert "traversal" not in error.lower()
|
|
|
|
|
|
def test_output_path_relative_no_dotdot_passes_guard(tmp_path, monkeypatch):
|
|
"""Relative paths without '..' components must pass the guard."""
|
|
monkeypatch.chdir(tmp_path)
|
|
result = json.loads(text_to_speech_tool(
|
|
text="hello",
|
|
output_path="subdir/clip.mp3",
|
|
))
|
|
error = result.get("error", "")
|
|
assert "traversal" not in error.lower()
|