wehub-resource-sync
b4fbd6fe9f
Deploy Site / deploy-vercel (push) Has been skipped
Deploy Site / deploy-docs (push) Has been skipped
Build Skills Index / build-index (push) Has been skipped
CI / Deny unrelated histories (push) Has been skipped
CI / Detect affected areas (push) Successful in 27m35s
CI / OSV scan (push) Failing after 4s
CI / Build&Test Docker image (push) Successful in 9s
CI / Supply-chain scan (push) Has been skipped
CI / Lint Docker scripts (push) Failing after 5m13s
CI / Check contributors (push) Failing after 12m8s
CI / Docs Site (push) Failing after 12m8s
CI / TypeScript (push) Failing after 12m8s
CI / Python lints (push) Failing after 12m9s
CI / Python tests (push) Failing after 12m9s
CI / Check uv.lock (push) Failing after 23m22s
CI / CI timing report (push) Has been cancelled
Build Skills Index / trigger-deploy (push) Has been cancelled
CI / All required checks pass (push) Has been cancelled
65 lines
2.5 KiB
Python
65 lines
2.5 KiB
Python
"""Regression tests for OpenAI Codex model validation when the listing lags behind
|
|
actually usable backend model IDs.
|
|
|
|
The bug originally reported in #16172: `/model` and `switch_model()` rejected
|
|
`gpt-5.3-codex-spark` because the curated listing omitted it, even though direct
|
|
runtime calls succeeded. PR #19729 fixed this by soft-accepting unknown-but-
|
|
plausible Codex slugs with a warning, and this test pins the soft-accept
|
|
behavior so it doesn't regress.
|
|
|
|
Note: gpt-5.3-codex-spark itself is now in the curated catalog (PR #22991),
|
|
so the real-world Spark request takes the `recognized=True` fast path. This
|
|
test still uses Spark as the example slug but explicitly mocks
|
|
``provider_model_ids`` to omit it, exercising the soft-accept path generically
|
|
for any future entitlement-gated Codex slug that ships before Hermes catalogs
|
|
it.
|
|
"""
|
|
|
|
from unittest.mock import patch
|
|
|
|
from hermes_cli.model_switch import switch_model
|
|
from hermes_cli.models import validate_requested_model
|
|
|
|
|
|
def test_openai_codex_unknown_but_plausible_model_is_accepted_with_warning():
|
|
"""If the Codex listing is incomplete, `/model` should soft-accept the model
|
|
with a warning instead of hard-rejecting it.
|
|
"""
|
|
with patch(
|
|
"hermes_cli.models.provider_model_ids",
|
|
return_value=["gpt-5.5", "gpt-5.4", "gpt-5.3-codex"],
|
|
):
|
|
result = validate_requested_model("gpt-5.3-codex-spark", "openai-codex")
|
|
|
|
assert result["accepted"] is True
|
|
assert result["persist"] is True
|
|
assert result["recognized"] is False
|
|
assert "gpt-5.3-codex-spark" in result["message"]
|
|
assert "OpenAI Codex model listing" in result["message"]
|
|
assert "Similar models" in result["message"]
|
|
assert "gpt-5.3-codex" in result["message"]
|
|
|
|
|
|
def test_switch_model_allows_openai_codex_model_missing_from_listing():
|
|
"""switch_model() should succeed for Codex models that the runtime accepts
|
|
even when the listing has not caught up yet.
|
|
"""
|
|
with patch(
|
|
"hermes_cli.models.provider_model_ids",
|
|
return_value=["gpt-5.5", "gpt-5.4", "gpt-5.3-codex"],
|
|
):
|
|
result = switch_model(
|
|
"gpt-5.3-codex-spark",
|
|
current_provider="openai-codex",
|
|
current_model="gpt-5.4",
|
|
current_base_url="",
|
|
current_api_key="",
|
|
user_providers=None,
|
|
)
|
|
|
|
assert result.success is True
|
|
assert result.new_model == "gpt-5.3-codex-spark"
|
|
assert result.target_provider == "openai-codex"
|
|
assert result.warning_message
|
|
assert "OpenAI Codex model listing" in result.warning_message
|