b4fbd6fe9f
Deploy Site / deploy-vercel (push) Has been skipped
Deploy Site / deploy-docs (push) Has been skipped
Build Skills Index / build-index (push) Has been skipped
CI / Deny unrelated histories (push) Has been skipped
CI / Detect affected areas (push) Successful in 27m35s
CI / OSV scan (push) Failing after 4s
CI / Build&Test Docker image (push) Successful in 9s
CI / Supply-chain scan (push) Has been skipped
CI / Lint Docker scripts (push) Failing after 5m13s
CI / Check contributors (push) Failing after 12m8s
CI / Docs Site (push) Failing after 12m8s
CI / TypeScript (push) Failing after 12m8s
CI / Python lints (push) Failing after 12m9s
CI / Python tests (push) Failing after 12m9s
CI / Check uv.lock (push) Failing after 23m22s
CI / CI timing report (push) Has been cancelled
Build Skills Index / trigger-deploy (push) Has been cancelled
CI / All required checks pass (push) Has been cancelled
44 lines
1.4 KiB
Python
44 lines
1.4 KiB
Python
"""Tests for shared tool result classification helpers."""
|
|
|
|
import json
|
|
|
|
from agent.tool_result_classification import (
|
|
file_mutation_result_landed,
|
|
)
|
|
|
|
|
|
def test_write_file_with_nested_lint_error_counts_as_landed():
|
|
result = json.dumps({
|
|
"bytes_written": 12,
|
|
"lint": {"status": "error", "output": "SyntaxError: invalid syntax"},
|
|
})
|
|
|
|
assert file_mutation_result_landed("write_file", result) is True
|
|
|
|
|
|
def test_patch_with_nested_lsp_diagnostics_counts_as_landed():
|
|
result = json.dumps({
|
|
"success": True,
|
|
"diff": "--- a/tmp.py\n+++ b/tmp.py\n",
|
|
"lsp_diagnostics": "<diagnostics>ERROR [1:1] type mismatch</diagnostics>",
|
|
})
|
|
|
|
assert file_mutation_result_landed("patch", result) is True
|
|
|
|
|
|
def test_top_level_file_mutation_error_does_not_count_as_landed():
|
|
result = json.dumps({"success": True, "error": "post-write verification failed"})
|
|
|
|
assert file_mutation_result_landed("patch", result) is False
|
|
|
|
|
|
def test_side_effect_classification_keeps_session_mutations():
|
|
from agent.tool_result_classification import tool_may_have_side_effect
|
|
|
|
assert tool_may_have_side_effect("todo") is True
|
|
assert tool_may_have_side_effect("memory") is True
|
|
assert tool_may_have_side_effect("write_file") is True
|
|
assert tool_may_have_side_effect("mcp_unknown") is True
|
|
assert tool_may_have_side_effect("read_file") is False
|
|
assert tool_may_have_side_effect("web_search") is False
|