milvus-io--milvus/tests/integration/replication/force_promote_test.go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
//     http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package replication

import (
	"context"
	"fmt"
	"testing"

	"github.com/stretchr/testify/suite"

	"github.com/milvus-io/milvus-proto/go-api/v3/commonpb"
	"github.com/milvus-io/milvus-proto/go-api/v3/milvuspb"
	"github.com/milvus-io/milvus/pkg/v3/util/merr"
	"github.com/milvus-io/milvus/pkg/v3/util/paramtable"
	"github.com/milvus-io/milvus/tests/integration"
)

type ForcePromoteSuite struct {
	integration.MiniClusterSuite
}

func TestForcePromote(t *testing.T) {
	suite.Run(t, new(ForcePromoteSuite))
}

// getPChannelNames generates the correct pchannel names for the current cluster.
// Pchannels are named <RootCoordDml>_<n> where n goes from 0 to DmlChannelNum-1.
func (s *ForcePromoteSuite) getPChannelNames() []string {
	rootCoordDml := paramtable.Get().CommonCfg.RootCoordDml.GetValue()
	dmlChannelNum := paramtable.Get().RootCoordCfg.DmlChannelNum.GetAsInt()
	pchannels := make([]string, dmlChannelNum)
	for i := 0; i < dmlChannelNum; i++ {
		pchannels[i] = fmt.Sprintf("%s_%d", rootCoordDml, i)
	}
	return pchannels
}

// TestNormalUpdateReplicateConfiguration verifies that normal (non-force) updates
// work correctly on a primary cluster.
func (s *ForcePromoteSuite) TestNormalUpdateReplicateConfiguration() {
	ctx := context.Background()

	clusterID := paramtable.Get().CommonCfg.ClusterPrefix.GetValue()
	pchannels := s.getPChannelNames()

	// Create a valid single-cluster config (making current cluster primary)
	config := &commonpb.ReplicateConfiguration{
		Clusters: []*commonpb.MilvusCluster{
			{
				ClusterId: clusterID,
				Pchannels: pchannels,
				ConnectionParam: &commonpb.ConnectionParam{
					Uri:   "http://localhost:19530",
					Token: "test-token",
				},
			},
		},
		CrossClusterTopology: []*commonpb.CrossClusterTopology{},
	}

	// Call without force_promote
	req := &milvuspb.UpdateReplicateConfigurationRequest{
		ReplicateConfiguration: config,
		ForcePromote:           false,
	}

	resp, err := s.Cluster.MilvusClient.UpdateReplicateConfiguration(ctx, req)

	// Normal update on primary should succeed
	s.NoError(err)
	s.NotNil(resp)
	err = merr.Error(resp)
	s.NoError(err)
}

// TestUpdateReplicateConfigurationIdempotent verifies that calling
// UpdateReplicateConfiguration with the same configuration is idempotent.
func (s *ForcePromoteSuite) TestUpdateReplicateConfigurationIdempotent() {
	ctx := context.Background()

	clusterID := paramtable.Get().CommonCfg.ClusterPrefix.GetValue()
	pchannels := s.getPChannelNames()

	config := &commonpb.ReplicateConfiguration{
		Clusters: []*commonpb.MilvusCluster{
			{
				ClusterId: clusterID,
				Pchannels: pchannels,
				ConnectionParam: &commonpb.ConnectionParam{
					Uri:   "http://localhost:19530",
					Token: "test-token",
				},
			},
		},
		CrossClusterTopology: []*commonpb.CrossClusterTopology{},
	}

	req := &milvuspb.UpdateReplicateConfigurationRequest{
		ReplicateConfiguration: config,
		ForcePromote:           false,
	}

	// First call
	resp1, err := s.Cluster.MilvusClient.UpdateReplicateConfiguration(ctx, req)
	s.NoError(err)
	s.NotNil(resp1)
	s.NoError(merr.Error(resp1))

	// Second call with same config should also succeed (idempotent)
	resp2, err := s.Cluster.MilvusClient.UpdateReplicateConfiguration(ctx, req)
	s.NoError(err)
	s.NotNil(resp2)
	s.NoError(merr.Error(resp2))
}