498b235461
Build and test / Build and test AMD64 Ubuntu 22.04 (push) Failing after 0s
Publish Builder / amazonlinux2023 (push) Failing after 1s
Build and test / UT for Go (push) Has been skipped
Publish KRTE Images / KRTE (push) Failing after 1s
Build and test / Integration Test (push) Has been skipped
Build and test / Upload Code Coverage (push) Has been skipped
Publish Builder / rockylinux9 (push) Failing after 1s
Publish Builder / ubuntu22.04 (push) Failing after 0s
Publish Builder / ubuntu24.04 (push) Failing after 0s
Publish Gpu Builder / publish-gpu-builder (push) Failing after 1s
Publish Test Images / PyTest (push) Failing after 0s
Build and test / UT for Cpp (push) Has been cancelled
222 lines
8.0 KiB
Go
222 lines
8.0 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package segments
|
|
|
|
import (
|
|
"context"
|
|
"sync"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v3/commonpb"
|
|
"github.com/milvus-io/milvus/internal/util/streamrpc"
|
|
"github.com/milvus-io/milvus/pkg/v3/metrics"
|
|
"github.com/milvus-io/milvus/pkg/v3/mlog"
|
|
"github.com/milvus-io/milvus/pkg/v3/proto/internalpb"
|
|
"github.com/milvus-io/milvus/pkg/v3/proto/querypb"
|
|
"github.com/milvus-io/milvus/pkg/v3/proto/segcorepb"
|
|
"github.com/milvus-io/milvus/pkg/v3/util/contextutil"
|
|
"github.com/milvus-io/milvus/pkg/v3/util/merr"
|
|
"github.com/milvus-io/milvus/pkg/v3/util/paramtable"
|
|
"github.com/milvus-io/milvus/pkg/v3/util/timerecord"
|
|
"github.com/milvus-io/milvus/pkg/v3/util/typeutil"
|
|
)
|
|
|
|
type RetrieveSegmentResult struct {
|
|
Result *segcorepb.RetrieveResults
|
|
Segment Segment
|
|
}
|
|
|
|
// retrieveOnSegments performs retrieve on listed segments
|
|
// all segment ids are validated before calling this function
|
|
func retrieveOnSegments(ctx context.Context, mgr *Manager, segments []Segment, segType SegmentType, plan *RetrievePlan, req *querypb.QueryRequest) ([]RetrieveSegmentResult, error) {
|
|
resultCh := make(chan RetrieveSegmentResult, len(segments))
|
|
|
|
plan.SetIgnoreNonPk(shouldEnableIgnoreNonPk(req, len(segments), plan.ShouldIgnoreNonPk()))
|
|
|
|
label := metrics.SealedSegmentLabel
|
|
if segType == commonpb.SegmentState_Growing {
|
|
label = metrics.GrowingSegmentLabel
|
|
}
|
|
|
|
retriever := func(ctx context.Context, s Segment) error {
|
|
tr := timerecord.NewTimeRecorder("retrieveOnSegments")
|
|
result, err := s.Retrieve(ctx, plan)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if mlog.LevelEnabled(mlog.DebugLevel) && req.GetReq().GetIsCount() {
|
|
allRetrieveCount := result.AllRetrieveCount
|
|
countRet := result.GetFieldsData()[0].GetScalars().GetLongData().GetData()[0]
|
|
if allRetrieveCount != countRet {
|
|
mlog.Debug(ctx, "count segment done with delete",
|
|
mlog.Uint64("mvcc", req.GetReq().GetMvccTimestamp()),
|
|
mlog.String("channel", s.LoadInfo().GetInsertChannel()),
|
|
mlog.FieldSegmentID(s.ID()),
|
|
mlog.Int64("allRetrieveCount", allRetrieveCount),
|
|
mlog.Int64("countRet", countRet))
|
|
} else {
|
|
mlog.Debug(ctx, "count segment done",
|
|
mlog.Uint64("mvcc", req.GetReq().GetMvccTimestamp()),
|
|
mlog.String("channel", s.LoadInfo().GetInsertChannel()),
|
|
mlog.FieldSegmentID(s.ID()),
|
|
mlog.Int64("allRetrieveCount", allRetrieveCount),
|
|
mlog.Int64("countRet", countRet))
|
|
}
|
|
}
|
|
resultCh <- RetrieveSegmentResult{
|
|
result,
|
|
s,
|
|
}
|
|
metrics.QueryNodeSQSegmentLatency.WithLabelValues(paramtable.GetStringNodeID(),
|
|
contextutil.GetQueryLabel(ctx), label).Observe(float64(tr.ElapseSpan().Microseconds()) / 1000.0)
|
|
return nil
|
|
}
|
|
|
|
err := doOnSegments(ctx, mgr, segments, retriever)
|
|
close(resultCh)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
results := make([]RetrieveSegmentResult, 0, len(segments))
|
|
for r := range resultCh {
|
|
results = append(results, r)
|
|
}
|
|
return results, nil
|
|
}
|
|
|
|
// shouldEnableIgnoreNonPk determines whether to use two-phase retrieval
|
|
// (first fetch PKs only, then fetch full field data for selected rows).
|
|
//
|
|
// Note: ORDER BY queries are excluded at the C++ layer — ShouldIgnoreNonPk()
|
|
// in plan_c.cpp returns false when has_order_by_=true, so planShouldIgnoreNonPk
|
|
// is already false for ORDER BY. No explicit !hasOrderBy check is needed here.
|
|
func shouldEnableIgnoreNonPk(req *querypb.QueryRequest, segmentNum int, planShouldIgnoreNonPk bool) bool {
|
|
hasGroupBy := len(req.GetReq().GetGroupByFieldIds()) > 0 || len(req.GetReq().GetAggregates()) > 0
|
|
return !hasGroupBy && segmentNum > 1 && req.GetReq().GetLimit() != typeutil.Unlimited && planShouldIgnoreNonPk
|
|
}
|
|
|
|
func retrieveOnSegmentsWithStream(ctx context.Context, mgr *Manager, segments []Segment, segType SegmentType, plan *RetrievePlan, svr streamrpc.QueryStreamServer) error {
|
|
var (
|
|
errs = make([]error, len(segments))
|
|
wg sync.WaitGroup
|
|
)
|
|
|
|
label := metrics.SealedSegmentLabel
|
|
if segType == commonpb.SegmentState_Growing {
|
|
label = metrics.GrowingSegmentLabel
|
|
}
|
|
|
|
for i, segment := range segments {
|
|
wg.Add(1)
|
|
go func(segment Segment, i int) {
|
|
defer wg.Done()
|
|
tr := timerecord.NewTimeRecorder("retrieveOnSegmentsWithStream")
|
|
var result *segcorepb.RetrieveResults
|
|
err := doOnSegment(ctx, mgr, segment, func(ctx context.Context, segment Segment) error {
|
|
var err error
|
|
result, err = segment.Retrieve(ctx, plan)
|
|
return err
|
|
})
|
|
if err != nil {
|
|
errs[i] = err
|
|
return
|
|
}
|
|
|
|
if len(result.GetOffset()) != 0 {
|
|
if err = svr.Send(&internalpb.RetrieveResults{
|
|
Status: merr.Success(),
|
|
Ids: result.GetIds(),
|
|
FieldsData: result.GetFieldsData(),
|
|
CostAggregation: &internalpb.CostAggregation{
|
|
TotalRelatedDataSize: GetSegmentRelatedDataSize(segment),
|
|
},
|
|
SealedSegmentIDsRetrieved: []int64{segment.ID()},
|
|
AllRetrieveCount: result.GetAllRetrieveCount(),
|
|
ScannedRemoteBytes: result.GetScannedRemoteBytes(),
|
|
ScannedTotalBytes: result.GetScannedTotalBytes(),
|
|
}); err != nil {
|
|
errs[i] = err
|
|
}
|
|
}
|
|
|
|
errs[i] = nil
|
|
metrics.QueryNodeSQSegmentLatency.WithLabelValues(paramtable.GetStringNodeID(),
|
|
contextutil.GetQueryLabel(ctx), label).Observe(float64(tr.ElapseSpan().Microseconds()) / 1000.0)
|
|
}(segment, i)
|
|
}
|
|
wg.Wait()
|
|
return merr.Combine(errs...)
|
|
}
|
|
|
|
// retrieve will retrieve all the validate target segments
|
|
func Retrieve(ctx context.Context, manager *Manager, plan *RetrievePlan, req *querypb.QueryRequest) ([]RetrieveSegmentResult, []Segment, error) {
|
|
if ctx.Err() != nil {
|
|
return nil, nil, ctx.Err()
|
|
}
|
|
|
|
var err error
|
|
var SegType commonpb.SegmentState
|
|
var retrieveSegments []Segment
|
|
|
|
segIDs := req.GetSegmentIDs()
|
|
collID := req.Req.GetCollectionID()
|
|
|
|
mlog.Debug(ctx, "retrieve on segments", mlog.Int64s("segmentIDs", segIDs), mlog.FieldCollectionID(collID))
|
|
|
|
if req.GetScope() == querypb.DataScope_Historical {
|
|
SegType = SegmentTypeSealed
|
|
retrieveSegments, err = validateOnHistorical(ctx, manager, collID, req.GetReq().GetPartitionIDs(), segIDs)
|
|
} else {
|
|
SegType = SegmentTypeGrowing
|
|
retrieveSegments, err = validateOnStream(ctx, manager, collID, req.GetReq().GetPartitionIDs(), segIDs)
|
|
}
|
|
|
|
if err != nil {
|
|
return nil, retrieveSegments, err
|
|
}
|
|
|
|
result, err := retrieveOnSegments(ctx, manager, retrieveSegments, SegType, plan, req)
|
|
return result, retrieveSegments, err
|
|
}
|
|
|
|
// retrieveStreaming will retrieve all the validate target segments and return by stream
|
|
func RetrieveStream(ctx context.Context, manager *Manager, plan *RetrievePlan, req *querypb.QueryRequest, srv streamrpc.QueryStreamServer) ([]Segment, error) {
|
|
var err error
|
|
var SegType commonpb.SegmentState
|
|
var retrieveSegments []Segment
|
|
|
|
segIDs := req.GetSegmentIDs()
|
|
collID := req.Req.GetCollectionID()
|
|
mlog.Debug(ctx, "retrieve stream on segments", mlog.Int64s("segmentIDs", segIDs), mlog.FieldCollectionID(collID))
|
|
|
|
if req.GetScope() == querypb.DataScope_Historical {
|
|
SegType = SegmentTypeSealed
|
|
retrieveSegments, err = validateOnHistorical(ctx, manager, collID, req.GetReq().GetPartitionIDs(), segIDs)
|
|
} else {
|
|
SegType = SegmentTypeGrowing
|
|
retrieveSegments, err = validateOnStream(ctx, manager, collID, req.GetReq().GetPartitionIDs(), segIDs)
|
|
}
|
|
|
|
if err != nil {
|
|
return retrieveSegments, err
|
|
}
|
|
|
|
err = retrieveOnSegmentsWithStream(ctx, manager, retrieveSegments, SegType, plan, srv)
|
|
return retrieveSegments, err
|
|
}
|