Files
wehub-resource-sync 498b235461
Build and test / Build and test AMD64 Ubuntu 22.04 (push) Failing after 0s
Publish Builder / amazonlinux2023 (push) Failing after 1s
Build and test / UT for Go (push) Has been skipped
Publish KRTE Images / KRTE (push) Failing after 1s
Build and test / Integration Test (push) Has been skipped
Build and test / Upload Code Coverage (push) Has been skipped
Publish Builder / rockylinux9 (push) Failing after 1s
Publish Builder / ubuntu22.04 (push) Failing after 0s
Publish Builder / ubuntu24.04 (push) Failing after 0s
Publish Gpu Builder / publish-gpu-builder (push) Failing after 1s
Publish Test Images / PyTest (push) Failing after 0s
Build and test / UT for Cpp (push) Has been cancelled
chore: import upstream snapshot with attribution
2026-07-13 12:31:17 +08:00

2333 lines
68 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package proxy
import (
"context"
"os"
"sort"
"strconv"
"strings"
"testing"
"github.com/cockroachdb/errors"
"github.com/gin-gonic/gin"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"github.com/milvus-io/milvus-proto/go-api/v3/commonpb"
"github.com/milvus-io/milvus-proto/go-api/v3/milvuspb"
"github.com/milvus-io/milvus-proto/go-api/v3/schemapb"
"github.com/milvus-io/milvus/internal/distributed/streaming"
"github.com/milvus-io/milvus/internal/json"
"github.com/milvus-io/milvus/internal/mocks"
"github.com/milvus-io/milvus/internal/util/indexparamcheck"
"github.com/milvus-io/milvus/pkg/v3/common"
"github.com/milvus-io/milvus/pkg/v3/proto/querypb"
"github.com/milvus-io/milvus/pkg/v3/util/funcutil"
"github.com/milvus-io/milvus/pkg/v3/util/merr"
"github.com/milvus-io/milvus/pkg/v3/util/metric"
"github.com/milvus-io/milvus/pkg/v3/util/paramtable"
"github.com/milvus-io/milvus/pkg/v3/util/typeutil"
)
func TestMain(m *testing.M) {
paramtable.Init()
gin.SetMode(gin.TestMode)
streaming.SetupNoopWALForTest()
code := m.Run()
os.Exit(code)
}
func sortKeyValuePairs(pairs []*commonpb.KeyValuePair) {
sort.Slice(pairs, func(i, j int) bool {
return pairs[i].Key > pairs[j].Key
})
}
func TestGetIndexStateTask_Execute(t *testing.T) {
dbName := funcutil.GenRandomStr()
collectionName := funcutil.GenRandomStr()
collectionID := UniqueID(1)
fieldName := funcutil.GenRandomStr()
indexName := ""
ctx := context.Background()
queryCoord := NewMixCoordMock()
gist := &getIndexStateTask{
GetIndexStateRequest: &milvuspb.GetIndexStateRequest{
Base: &commonpb.MsgBase{},
DbName: dbName,
CollectionName: collectionName,
FieldName: fieldName,
IndexName: indexName,
},
ctx: ctx,
mixCoord: queryCoord,
result: &milvuspb.GetIndexStateResponse{
Status: &commonpb.Status{ErrorCode: commonpb.ErrorCode_UnexpectedError, Reason: "mock-1"},
State: commonpb.IndexState_Unissued,
},
collectionID: collectionID,
}
// failed to get collection id.
err := InitMetaCache(ctx, queryCoord)
assert.NoError(t, err)
assert.Error(t, gist.Execute(ctx))
}
func TestDropIndexTask_PreExecute(t *testing.T) {
collectionName := "collection1"
collectionID := UniqueID(1)
fieldName := "field1"
indexName := "_default_idx_101"
paramtable.Init()
qc := NewMixCoordMock()
ctx := context.Background()
mockCache := NewMockCache(t)
mockCache.On("GetCollectionID",
mock.Anything, // context.Context
mock.AnythingOfType("string"),
mock.AnythingOfType("string"),
).Return(collectionID, nil)
globalMetaCache = mockCache
dit := dropIndexTask{
ctx: ctx,
DropIndexRequest: &milvuspb.DropIndexRequest{
Base: &commonpb.MsgBase{
MsgType: 0,
MsgID: 0,
Timestamp: 0,
SourceID: 0,
TargetID: 0,
},
CollectionName: collectionName,
FieldName: fieldName,
IndexName: indexName,
},
mixCoord: qc,
result: nil,
collectionID: collectionID,
}
t.Run("normal", func(t *testing.T) {
err := dit.PreExecute(ctx)
assert.NoError(t, err)
})
t.Run("get collectionID error", func(t *testing.T) {
mockCache := NewMockCache(t)
mockCache.On("GetCollectionID",
mock.Anything, // context.Context
mock.AnythingOfType("string"),
mock.AnythingOfType("string"),
).Return(UniqueID(0), errors.New("error"))
globalMetaCache = mockCache
err := dit.PreExecute(ctx)
assert.Error(t, err)
})
mockCache.On("GetCollectionID",
mock.Anything, // context.Context
mock.AnythingOfType("string"),
mock.AnythingOfType("string"),
).Return(collectionID, nil)
globalMetaCache = mockCache
t.Run("coll has been loaded", func(t *testing.T) {
qc := getMockQueryCoord()
qc.ExpectedCalls = nil
qc.EXPECT().LoadCollection(mock.Anything, mock.Anything).Return(merr.Success(), nil)
qc.EXPECT().GetShardLeaders(mock.Anything, mock.Anything).Return(&querypb.GetShardLeadersResponse{
Status: merr.Success(),
Shards: []*querypb.ShardLeadersList{
{
ChannelName: "channel-1",
NodeIds: []int64{1, 2, 3},
NodeAddrs: []string{"localhost:9000", "localhost:9001", "localhost:9002"},
Serviceable: []bool{true, true, true},
},
},
}, nil)
qc.EXPECT().ShowLoadCollections(mock.Anything, mock.Anything).Return(&querypb.ShowCollectionsResponse{
Status: merr.Success(),
CollectionIDs: []int64{collectionID},
}, nil)
dit.mixCoord = qc
err := dit.PreExecute(ctx)
assert.NoError(t, err)
})
}
func getMockQueryCoord() *mocks.MockMixCoordClient {
qc := &mocks.MockMixCoordClient{}
successStatus := &commonpb.Status{ErrorCode: commonpb.ErrorCode_Success}
qc.EXPECT().LoadCollection(mock.Anything, mock.Anything).Return(successStatus, nil)
qc.EXPECT().GetShardLeaders(mock.Anything, mock.Anything).Return(&querypb.GetShardLeadersResponse{
Status: successStatus,
Shards: []*querypb.ShardLeadersList{
{
ChannelName: "channel-1",
NodeIds: []int64{1, 2, 3},
NodeAddrs: []string{"localhost:9000", "localhost:9001", "localhost:9002"},
Serviceable: []bool{true, true, true},
},
},
}, nil)
qc.EXPECT().ShowLoadCollections(mock.Anything, mock.Anything).Return(&querypb.ShowCollectionsResponse{}, nil).Maybe()
return qc
}
func TestCreateIndexTask_PreExecute(t *testing.T) {
collectionName := "collection1"
collectionID := UniqueID(1)
fieldName := newTestSchema().Fields[0].Name
dc := NewMixCoordMock()
ctx := context.Background()
mockCache := NewMockCache(t)
mockCache.On("GetCollectionID",
mock.Anything, // context.Context
mock.AnythingOfType("string"),
mock.AnythingOfType("string"),
).Return(collectionID, nil)
mockCache.On("GetCollectionSchema",
mock.Anything, // context.Context
mock.AnythingOfType("string"),
mock.AnythingOfType("string"),
).Return(newSchemaInfo(newTestSchema()), nil)
mockCache.On("GetCollectionInfo",
mock.Anything, // context.Context
mock.AnythingOfType("string"),
mock.AnythingOfType("string"),
mock.AnythingOfType("int64"),
).Return(&collectionInfo{}, nil)
globalMetaCache = mockCache
cit := createIndexTask{
ctx: ctx,
req: &milvuspb.CreateIndexRequest{
Base: &commonpb.MsgBase{
MsgType: commonpb.MsgType_CreateIndex,
},
CollectionName: collectionName,
FieldName: fieldName,
},
mixCoord: dc,
result: nil,
collectionID: collectionID,
}
t.Run("normal", func(t *testing.T) {
err := cit.PreExecute(ctx)
assert.NoError(t, err)
})
}
func Test_sparse_parseIndexParams(t *testing.T) {
cit := &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
Base: nil,
DbName: "",
CollectionName: "",
FieldName: "",
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "SPARSE_INVERTED_INDEX",
},
{
Key: MetricTypeKey,
Value: "IP",
},
{
Key: common.ParamsKey,
Value: "{\"drop_ratio_build\": 0.3}",
},
},
IndexName: "",
},
ctx: nil,
mixCoord: nil,
result: nil,
isAutoIndex: false,
newIndexParams: nil,
newTypeParams: nil,
collectionID: 0,
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
Description: "field no.1",
DataType: schemapb.DataType_SparseFloatVector,
TypeParams: []*commonpb.KeyValuePair{
{
Key: MetricTypeKey,
Value: "IP",
},
},
},
}
t.Run("parse index params", func(t *testing.T) {
err := cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.ElementsMatch(t,
[]*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "SPARSE_INVERTED_INDEX",
},
{
Key: MetricTypeKey,
Value: "IP",
},
{
Key: "drop_ratio_build",
Value: "0.3",
},
}, cit.newIndexParams)
assert.ElementsMatch(t,
[]*commonpb.KeyValuePair{}, cit.newTypeParams)
})
}
func Test_deduplicate_parseIndexParams(t *testing.T) {
createTestIndexTask := func() *createIndexTask {
return &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: MetricTypeKey, Value: "MHJACCARD"},
},
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
DataType: schemapb.DataType_BinaryVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: MetricTypeKey, Value: "MHJACCARD"},
{Key: DimKey, Value: "128"},
},
},
}
}
t.Run("disable autoindex", func(t *testing.T) {
cit1 := createTestIndexTask()
paramtable.Init()
Params.Save(Params.AutoIndexConfig.Enable.Key, "false")
defer Params.Reset(Params.AutoIndexConfig.Enable.Key)
err := cit1.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.ElementsMatch(t,
[]*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "MINHASH_LSH",
},
{
Key: MetricTypeKey,
Value: "MHJACCARD",
},
}, cit1.newIndexParams)
assert.ElementsMatch(t,
[]*commonpb.KeyValuePair{
{
Key: DimKey,
Value: "128",
},
}, cit1.newTypeParams)
})
t.Run("enable autoindex", func(t *testing.T) {
cit1 := createTestIndexTask()
paramtable.Init()
Params.Save(Params.AutoIndexConfig.Enable.Key, "true")
defer Params.Reset(Params.AutoIndexConfig.Enable.Key)
err := cit1.parseIndexParams(context.TODO())
assert.Error(t, err)
})
t.Run("disable autoindex", func(t *testing.T) {
cit1 := createTestIndexTask()
paramtable.Init()
Params.Save(Params.AutoIndexConfig.Enable.Key, "true")
Params.Save(Params.AutoIndexConfig.EnableDeduplicateIndex.Key, "true")
defer Params.Reset(Params.AutoIndexConfig.Enable.Key)
defer Params.Reset(Params.AutoIndexConfig.EnableDeduplicateIndex.Key)
err := cit1.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.ElementsMatch(t,
[]*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "MINHASH_LSH",
},
{
Key: MetricTypeKey,
Value: "MHJACCARD",
},
}, cit1.newIndexParams)
assert.ElementsMatch(t,
[]*commonpb.KeyValuePair{
{
Key: DimKey,
Value: "128",
},
}, cit1.newTypeParams)
})
}
func Test_parseIndexParamsAllowsParsableParamsWithinSize(t *testing.T) {
paramtable.Init()
Params.Save(Params.ProxyCfg.MaxIndexParamsSize.Key, strconv.Itoa(100*1024))
defer Params.Reset(Params.ProxyCfg.MaxIndexParamsSize.Key)
params, err := json.Marshal(map[string]any{
"custom_param": strings.Repeat("A", 1024),
})
assert.NoError(t, err)
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: indexparamcheck.IndexINVERTED},
{Key: common.ParamsKey, Value: string(params)},
},
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
DataType: schemapb.DataType_VarChar,
},
}
err = cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.Contains(t, cit.newIndexParams, &commonpb.KeyValuePair{Key: "custom_param", Value: strings.Repeat("A", 1024)})
}
func Test_parseIndexParamsRejectsConfiguredMaxIndexParamsSize(t *testing.T) {
paramtable.Init()
Params.Save(Params.ProxyCfg.MaxIndexParamsSize.Key, "64")
defer Params.Reset(Params.ProxyCfg.MaxIndexParamsSize.Key)
params, err := json.Marshal(map[string]any{
"custom_param": strings.Repeat("A", 128),
})
assert.NoError(t, err)
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: indexparamcheck.IndexINVERTED},
{Key: common.ParamsKey, Value: string(params)},
},
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
DataType: schemapb.DataType_VarChar,
},
}
err = cit.parseIndexParams(context.TODO())
assert.Error(t, err)
assert.Contains(t, err.Error(), "index params size")
assert.Contains(t, err.Error(), "64")
}
func Test_parseIndexParamsRejectsOversizedParams(t *testing.T) {
params, err := json.Marshal(map[string]any{
"malicious_padding": strings.Repeat("A", 100*1024),
})
assert.NoError(t, err)
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: indexparamcheck.IndexINVERTED},
{Key: common.ParamsKey, Value: string(params)},
},
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
DataType: schemapb.DataType_VarChar,
},
}
err = cit.parseIndexParams(context.TODO())
assert.Error(t, err)
assert.Contains(t, err.Error(), "index params size")
}
func Test_parseIndexParamsRejectsOversizedRawParams(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: indexparamcheck.IndexINVERTED},
{Key: common.ParamsKey, Value: strings.Repeat(" ", 100*1024) + `{"custom_param":"A"}`},
},
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
DataType: schemapb.DataType_VarChar,
},
}
err := cit.parseIndexParams(context.TODO())
assert.Error(t, err)
assert.Contains(t, err.Error(), "index params size")
}
func Test_parseIndexParamsRejectsFinalIndexParamsOverLimit(t *testing.T) {
paramtable.Init()
Params.Save(Params.ProxyCfg.MaxIndexParamsSize.Key, "128")
Params.Save(Params.AutoIndexConfig.Enable.Key, "false")
Params.Save(Params.AutoIndexConfig.IndexParams.Key, `{"M": 18,"efConstruction": 240,"index_type": "HNSW", "metric_type": "COSINE", "large_config": "`+strings.Repeat("A", 128)+`"}`)
defer Params.Reset(Params.ProxyCfg.MaxIndexParamsSize.Key)
defer Params.Reset(Params.AutoIndexConfig.Enable.Key)
defer Params.Reset(Params.AutoIndexConfig.IndexParams.Key)
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.MetricTypeKey, Value: "L2"},
},
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
DataType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "128"},
},
},
}
err := cit.parseIndexParams(context.TODO())
assert.Error(t, err)
assert.Contains(t, err.Error(), "index params size")
}
func Test_parseIndexParams(t *testing.T) {
cit := &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
Base: nil,
DbName: "",
CollectionName: "",
FieldName: "",
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "HNSW",
},
{
Key: MetricTypeKey,
Value: "IP",
},
{
Key: common.ParamsKey,
Value: "{\"M\": 48, \"efConstruction\": 64}",
},
{
Key: DimKey,
Value: "128",
},
},
IndexName: "",
},
ctx: nil,
mixCoord: nil,
result: nil,
isAutoIndex: false,
newIndexParams: nil,
newTypeParams: nil,
collectionID: 0,
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
Description: "field no.1",
DataType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{
Key: DimKey,
Value: "128",
},
{
Key: MetricTypeKey,
Value: "L2",
},
},
},
}
t.Run("parse index params", func(t *testing.T) {
err := cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.ElementsMatch(t,
[]*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "HNSW",
},
{
Key: MetricTypeKey,
Value: "IP",
},
{
Key: "M",
Value: "48",
},
{
Key: "efConstruction",
Value: "64",
},
}, cit.newIndexParams)
assert.ElementsMatch(t,
[]*commonpb.KeyValuePair{
{
Key: DimKey,
Value: "128",
},
}, cit.newTypeParams)
})
cit2 := &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
Base: nil,
DbName: "",
CollectionName: "",
FieldName: "",
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "IVF_FLAT",
},
{
Key: MetricTypeKey,
Value: "L2",
},
{
Key: common.ParamsKey,
Value: "{\"nlist\": 100}",
},
{
Key: DimKey,
Value: "128",
},
},
IndexName: "",
},
ctx: nil,
mixCoord: nil,
result: nil,
isAutoIndex: false,
newIndexParams: nil,
newTypeParams: nil,
collectionID: 0,
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
Description: "field no.1",
DataType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{
Key: DimKey,
Value: "128",
},
{
Key: MetricTypeKey,
Value: "L2",
},
},
},
}
t.Run("parse index params 2", func(t *testing.T) {
Params.Save(Params.AutoIndexConfig.Enable.Key, "true")
indexParams := map[string]any{
common.IndexTypeKey: "HNSW",
"M": 10,
"efConstruction": 100,
}
indexParamsStr, err := json.Marshal(indexParams)
assert.NoError(t, err)
Params.Save(Params.AutoIndexConfig.IndexParams.Key, string(indexParamsStr))
err = cit2.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.ElementsMatch(t,
[]*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "HNSW",
},
{
Key: MetricTypeKey,
Value: "L2",
},
{
Key: "M",
Value: "10",
},
{
Key: "efConstruction",
Value: "100",
},
{
Key: "nlist",
Value: "100",
},
}, cit2.newIndexParams)
assert.ElementsMatch(t,
[]*commonpb.KeyValuePair{
{
Key: DimKey,
Value: "128",
},
}, cit2.newTypeParams)
})
t.Run("create index on json field", func(t *testing.T) {
cit3 := &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
Base: nil,
DbName: "",
CollectionName: "",
FieldName: "",
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "HNSW",
},
{
Key: MetricTypeKey,
Value: "IP",
},
{
Key: common.ParamsKey,
Value: "{\"M\": 48, \"efConstruction\": 64}",
},
{
Key: DimKey,
Value: "128",
},
},
IndexName: "",
},
ctx: nil,
mixCoord: nil,
result: nil,
isAutoIndex: false,
newIndexParams: nil,
newTypeParams: nil,
collectionID: 0,
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
Description: "field no.1",
DataType: schemapb.DataType_JSON,
},
}
err := cit3.parseIndexParams(context.TODO())
assert.Error(t, err)
})
t.Run("create index on VarChar field", func(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: indexparamcheck.IndexINVERTED,
},
},
IndexName: "",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
DataType: schemapb.DataType_VarChar,
},
}
err := cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
})
t.Run("create scalar index on TEXT field", func(t *testing.T) {
for name, extraParams := range map[string][]*commonpb.KeyValuePair{
"explicit inverted": {
{
Key: common.IndexTypeKey,
Value: indexparamcheck.IndexINVERTED,
},
},
"explicit autoindex": {
{
Key: common.IndexTypeKey,
Value: AutoIndexName,
},
},
"default scalar index": {},
} {
t.Run(name, func(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: extraParams,
IndexName: "",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
DataType: schemapb.DataType_Text,
},
}
err := cit.parseIndexParams(context.TODO())
assert.Error(t, err)
assert.Contains(t, err.Error(), "TEXT field does not support user-created scalar index")
})
}
})
t.Run("create index on VarChar field without index type", func(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{},
IndexName: "",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
DataType: schemapb.DataType_VarChar,
},
}
err := cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
sortKeyValuePairs(cit.newIndexParams)
assert.Equal(t, cit.newIndexParams, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: indexparamcheck.IndexHybrid},
{Key: common.HybridLowCardinalityIndexTypeKey, Value: paramtable.Get().DataCoordCfg.HybridIndexLowCardinalityIndexType.GetValue()},
{Key: common.HybridHighCardinalityIndexTypeKey, Value: paramtable.Get().DataCoordCfg.HybridIndexHighCardinalityIndexType.GetValue()},
{Key: common.BitmapCardinalityLimitKey, Value: strconv.Itoa(paramtable.DefaultBitmapCardinalityLimit)},
})
})
t.Run("create index on Arithmetic field", func(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: DefaultArithmeticIndexType,
},
},
IndexName: "",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
DataType: schemapb.DataType_Int64,
},
}
err := cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
})
t.Run("create index on Arithmetic field without index type", func(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{},
IndexName: "",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
DataType: schemapb.DataType_Int64,
},
}
err := cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
sortKeyValuePairs(cit.newIndexParams)
assert.Equal(t, cit.newIndexParams, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: indexparamcheck.IndexHybrid},
{Key: common.HybridLowCardinalityIndexTypeKey, Value: paramtable.Get().DataCoordCfg.HybridIndexLowCardinalityIndexType.GetValue()},
{Key: common.HybridHighCardinalityIndexTypeKey, Value: paramtable.Get().DataCoordCfg.HybridIndexHighCardinalityIndexType.GetValue()},
{Key: common.BitmapCardinalityLimitKey, Value: strconv.Itoa(paramtable.DefaultBitmapCardinalityLimit)},
})
})
// Compatible with the old version <= 2.3.0
t.Run("create marisa-trie index on VarChar field", func(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "Trie",
},
},
IndexName: "",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
DataType: schemapb.DataType_VarChar,
},
}
err := cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
})
// Compatible with the old version <= 2.3.0
t.Run("create Asceneding index on Arithmetic field", func(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "Asceneding",
},
},
IndexName: "",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
DataType: schemapb.DataType_Int64,
},
}
err := cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
})
t.Run("create unsupported index on Arithmetic field", func(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "invalid_type",
},
},
IndexName: "",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
DataType: schemapb.DataType_Int64,
},
}
err := cit.parseIndexParams(context.TODO())
assert.Error(t, err)
})
t.Run("create index on array field", func(t *testing.T) {
cit3 := &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
Base: nil,
DbName: "",
CollectionName: "",
FieldName: "",
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "STL_SORT",
},
},
IndexName: "",
},
ctx: nil,
mixCoord: nil,
result: nil,
isAutoIndex: false,
newIndexParams: nil,
newTypeParams: nil,
collectionID: 0,
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
Description: "field no.1",
DataType: schemapb.DataType_Array,
ElementType: schemapb.DataType_Int64,
},
}
err := cit3.parseIndexParams(context.TODO())
assert.Error(t, err)
})
t.Run("pass vector index type on scalar field", func(t *testing.T) {
cit4 := &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
Base: nil,
DbName: "",
CollectionName: "",
FieldName: "",
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "HNSW",
},
{
Key: MetricTypeKey,
Value: "IP",
},
{
Key: common.ParamsKey,
Value: "{\"M\": 48, \"efConstruction\": 64}",
},
{
Key: DimKey,
Value: "128",
},
},
IndexName: "",
},
ctx: nil,
mixCoord: nil,
result: nil,
isAutoIndex: false,
newIndexParams: nil,
newTypeParams: nil,
collectionID: 0,
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
Description: "field no.1",
DataType: schemapb.DataType_VarChar,
},
}
err := cit4.parseIndexParams(context.TODO())
assert.Error(t, err)
cit5 := &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
Base: nil,
DbName: "",
CollectionName: "",
FieldName: "",
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "HNSW",
},
{
Key: MetricTypeKey,
Value: "IP",
},
{
Key: common.ParamsKey,
Value: "{\"M\": 48, \"efConstruction\": 64}",
},
{
Key: DimKey,
Value: "128",
},
},
IndexName: "",
},
ctx: nil,
mixCoord: nil,
result: nil,
isAutoIndex: false,
newIndexParams: nil,
newTypeParams: nil,
collectionID: 0,
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
Description: "field no.1",
DataType: schemapb.DataType_Int64,
},
}
err = cit5.parseIndexParams(context.TODO())
assert.Error(t, err)
})
t.Run("enable scalar auto index", func(t *testing.T) {
err := Params.Save(Params.AutoIndexConfig.ScalarAutoIndexEnable.Key, "true")
assert.NoError(t, err)
cit := &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "",
},
},
IndexName: "",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
Description: "field no.1",
DataType: schemapb.DataType_Int64,
},
}
err = cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
sortKeyValuePairs(cit.newIndexParams)
assert.Equal(t, cit.newIndexParams, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: indexparamcheck.IndexHybrid},
{Key: common.HybridLowCardinalityIndexTypeKey, Value: paramtable.Get().DataCoordCfg.HybridIndexLowCardinalityIndexType.GetValue()},
{Key: common.HybridHighCardinalityIndexTypeKey, Value: paramtable.Get().DataCoordCfg.HybridIndexHighCardinalityIndexType.GetValue()},
{Key: common.BitmapCardinalityLimitKey, Value: strconv.Itoa(paramtable.DefaultBitmapCardinalityLimit)},
})
})
t.Run("create auto index on numeric field", func(t *testing.T) {
cit := &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: AutoIndexName,
},
},
IndexName: "",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
Description: "field no.1",
DataType: schemapb.DataType_Int64,
},
}
err := cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
sortKeyValuePairs(cit.newIndexParams)
assert.Equal(t, cit.newIndexParams, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: indexparamcheck.IndexHybrid},
{Key: common.HybridLowCardinalityIndexTypeKey, Value: paramtable.Get().DataCoordCfg.HybridIndexLowCardinalityIndexType.GetValue()},
{Key: common.HybridHighCardinalityIndexTypeKey, Value: paramtable.Get().DataCoordCfg.HybridIndexHighCardinalityIndexType.GetValue()},
{Key: common.BitmapCardinalityLimitKey, Value: strconv.Itoa(paramtable.DefaultBitmapCardinalityLimit)},
})
})
t.Run("create auto index on varchar field", func(t *testing.T) {
cit := &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: AutoIndexName,
},
},
IndexName: "",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
Description: "field no.1",
DataType: schemapb.DataType_VarChar,
},
}
err := cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
sortKeyValuePairs(cit.newIndexParams)
assert.Equal(t, cit.newIndexParams, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: indexparamcheck.IndexHybrid},
{Key: common.HybridLowCardinalityIndexTypeKey, Value: paramtable.Get().DataCoordCfg.HybridIndexLowCardinalityIndexType.GetValue()},
{Key: common.HybridHighCardinalityIndexTypeKey, Value: paramtable.Get().DataCoordCfg.HybridIndexHighCardinalityIndexType.GetValue()},
{Key: common.BitmapCardinalityLimitKey, Value: strconv.Itoa(paramtable.DefaultBitmapCardinalityLimit)},
})
})
t.Run("create auto index on json field", func(t *testing.T) {
cit := &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: AutoIndexName,
},
},
IndexName: "",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldID",
IsPrimaryKey: false,
Description: "field no.1",
DataType: schemapb.DataType_JSON,
},
}
err := cit.parseIndexParams(context.TODO())
assert.Error(t, err)
})
t.Run("create auto index and mmap enable", func(t *testing.T) {
paramtable.Init()
Params.Save(Params.AutoIndexConfig.Enable.Key, "true")
defer Params.Reset(Params.AutoIndexConfig.Enable.Key)
cit := &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: AutoIndexName,
},
{
Key: common.MmapEnabledKey,
Value: "true",
},
},
IndexName: "",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldVector",
IsPrimaryKey: false,
DataType: schemapb.DataType_FloatVector,
},
}
err := cit.parseIndexParams(context.TODO())
assert.Error(t, err)
})
t.Run("verify merge params with yaml", func(t *testing.T) {
paramtable.Init()
Params.Save("knowhere.HNSW.build.M", "3000")
Params.Save("knowhere.HNSW.build.efConstruction", "120")
defer Params.Reset("knowhere.HNSW.build.M")
defer Params.Reset("knowhere.HNSW.build.efConstruction")
cit := &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "HNSW",
},
{
Key: common.MetricTypeKey,
Value: metric.L2,
},
},
IndexName: "",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldVector",
IsPrimaryKey: false,
DataType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "768"},
},
},
}
err := cit.parseIndexParams(context.TODO())
// Out of range in json: param 'M' (3000) should be in range [2, 2048]
assert.Error(t, err)
})
t.Run("check_duplicated_extraparam", func(t *testing.T) {
cit := &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "HNSW",
},
{
Key: common.MetricTypeKey,
Value: metric.L2,
},
{
Key: common.MetricTypeKey,
Value: metric.COSINE,
},
},
IndexName: "",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldVector",
IsPrimaryKey: false,
DataType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "768"},
},
},
}
err := cit.parseIndexParams(context.TODO())
assert.Error(t, err)
})
t.Run("create index with json field", func(t *testing.T) {
Params.Save(Params.AutoIndexConfig.ScalarAutoIndexEnable.Key, "false")
defer Params.Reset(Params.AutoIndexConfig.ScalarAutoIndexEnable.Key)
cit = &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.JSONCastTypeKey,
Value: "double",
},
{
Key: common.IndexTypeKey,
Value: "INVERTED",
},
},
IndexName: "",
FieldName: "FieldJSON",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldJSON",
IsPrimaryKey: false,
DataType: schemapb.DataType_JSON,
},
}
err := cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
jsonPath, err := funcutil.GetAttrByKeyFromRepeatedKV(common.JSONPathKey, cit.newIndexParams)
assert.NoError(t, err)
assert.Equal(t, jsonPath, "FieldJSON")
cit = &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.JSONCastTypeKey,
Value: "double",
},
{
Key: common.IndexTypeKey,
Value: "INVERTED",
},
},
IndexName: "",
FieldName: "DynamicField",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldJSON",
IsPrimaryKey: false,
DataType: schemapb.DataType_JSON,
IsDynamic: true,
},
}
err = cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
jsonPath, err = funcutil.GetAttrByKeyFromRepeatedKV(common.JSONPathKey, cit.newIndexParams)
assert.NoError(t, err)
assert.Equal(t, jsonPath, "DynamicField")
cit = &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.JSONCastTypeKey,
Value: "json",
},
{
Key: common.IndexTypeKey,
Value: AutoIndexName,
},
},
IndexName: "",
FieldName: "FieldJSON",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldJSON",
IsPrimaryKey: false,
DataType: schemapb.DataType_JSON,
},
}
err = cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
indexType, err := funcutil.GetAttrByKeyFromRepeatedKV(common.IndexTypeKey, cit.newIndexParams)
assert.NoError(t, err)
assert.Equal(t, indexparamcheck.IndexINVERTED, indexType)
})
}
func Test_checkEmbeddingListIndex(t *testing.T) {
t.Run("check embedding list index", func(t *testing.T) {
cit := &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "HNSW",
},
{
Key: common.MetricTypeKey,
Value: metric.MaxSim,
},
},
IndexName: "",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "EmbListFloat",
IsPrimaryKey: false,
DataType: schemapb.DataType_ArrayOfVector,
ElementType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "128"},
},
},
}
err := cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
})
t.Run("metric type wrong", func(t *testing.T) {
cit := &createIndexTask{
Condition: nil,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{
Key: common.IndexTypeKey,
Value: "HNSW",
},
{
Key: common.MetricTypeKey,
Value: metric.MaxSim,
},
},
IndexName: "",
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "FieldFloat",
IsPrimaryKey: false,
DataType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "128"},
},
},
}
err := cit.parseIndexParams(context.TODO())
assert.True(t, strings.Contains(err.Error(), "float vector index does not support metric type: MAX_SIM"))
})
}
func Test_arrayOfVector_nonEmbListMetric_indexCompat(t *testing.T) {
// When an ArrayOfVector field uses a non-EmbList metric (e.g., COSINE),
// each embedding is indexed independently. The index should only need to
// support the element vector type, not the EmbeddingList capability.
// This means indexes like IVF_PQ that don't have the EMB_LIST flag
// should still work with ArrayOfVector + COSINE.
t.Run("ArrayOfVector with COSINE should accept IVF_FLAT", func(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "IVF_FLAT"},
{Key: common.MetricTypeKey, Value: metric.COSINE},
{Key: "nlist", Value: "128"},
},
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "vec_field",
DataType: schemapb.DataType_ArrayOfVector,
ElementType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "128"},
},
},
}
err := cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
})
t.Run("ArrayOfVector with MaxSimCosine should accept HNSW", func(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "HNSW"},
{Key: common.MetricTypeKey, Value: metric.MaxSimCosine},
},
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "vec_field",
DataType: schemapb.DataType_ArrayOfVector,
ElementType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "128"},
},
},
}
err := cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
})
t.Run("ArrayOfVector with float element should reject MaxSimHamming", func(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "HNSW_SQ"},
{Key: common.MetricTypeKey, Value: metric.MaxSimHamming},
},
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "vec_field",
DataType: schemapb.DataType_ArrayOfVector,
ElementType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "128"},
},
},
}
err := cit.parseIndexParams(context.TODO())
assert.Error(t, err)
assert.Contains(t, err.Error(), "array of vector with float element type does not support metric type")
})
t.Run("ArrayOfVector with binary element should accept MaxSimHamming", func(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "HNSW"},
{Key: common.MetricTypeKey, Value: metric.MaxSimHamming},
},
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101,
Name: "vec_field",
DataType: schemapb.DataType_ArrayOfVector,
ElementType: schemapb.DataType_BinaryVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "128"},
},
},
}
err := cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
})
}
func Test_ngram_parseIndexParams(t *testing.T) {
t.Run("valid ngram index params", func(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "NGRAM"},
{Key: common.ParamsKey, Value: "{\"min_gram\": \"2\", \"max_gram\": \"3\"}"},
},
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101, Name: "FieldID", DataType: schemapb.DataType_VarChar,
},
}
err := cit.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.ElementsMatch(t, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "NGRAM"},
{Key: indexparamcheck.MinGramKey, Value: "2"},
{Key: indexparamcheck.MaxGramKey, Value: "3"},
}, cit.newIndexParams)
assert.Empty(t, cit.newTypeParams)
})
t.Run("ngram on non varchar field", func(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "NGRAM"},
{Key: common.ParamsKey, Value: "{\"min_gram\": \"2\", \"max_gram\": \"3\"}"},
},
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101, Name: "FieldInt", DataType: schemapb.DataType_Int64,
},
}
err := cit.parseIndexParams(context.TODO())
assert.Error(t, err)
})
t.Run("ngram missing params", func(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "NGRAM"},
{Key: common.ParamsKey, Value: "{\"min_gram\": \"2\"}"},
},
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101, Name: "FieldID", DataType: schemapb.DataType_VarChar,
},
}
err := cit.parseIndexParams(context.TODO())
assert.Error(t, err)
})
t.Run("ngram non-integer params", func(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "NGRAM"},
{Key: common.ParamsKey, Value: "{\"min_gram\": \"a\", \"max_gram\": \"3\"}"},
},
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101, Name: "FieldID", DataType: schemapb.DataType_VarChar,
},
}
err := cit.parseIndexParams(context.TODO())
assert.Error(t, err)
})
t.Run("ngram invalid range", func(t *testing.T) {
cit := &createIndexTask{
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "NGRAM"},
{Key: common.ParamsKey, Value: "{\"min_gram\": \"5\", \"max_gram\": \"3\"}"},
},
},
fieldSchema: &schemapb.FieldSchema{
FieldID: 101, Name: "FieldID", DataType: schemapb.DataType_VarChar,
},
}
err := cit.parseIndexParams(context.TODO())
assert.Error(t, err)
})
}
func Test_wrapUserIndexParams(t *testing.T) {
params := wrapUserIndexParams("L2")
assert.Equal(t, 2, len(params))
assert.Equal(t, "index_type", params[0].Key)
assert.Equal(t, AutoIndexName, params[0].Value)
assert.Equal(t, "metric_type", params[1].Key)
assert.Equal(t, "L2", params[1].Value)
}
func Test_parseIndexParams_AutoIndex_WithType(t *testing.T) {
paramtable.Init()
Params.Save(Params.AutoIndexConfig.Enable.Key, "true")
Params.Save(Params.AutoIndexConfig.IndexParams.Key, `{"M": 30,"efConstruction": 360,"index_type": "HNSW"}`)
Params.Save(Params.AutoIndexConfig.SparseIndexParams.Key, `{"drop_ratio_build": 0.2, "index_type": "SPARSE_INVERTED_INDEX"}`)
Params.Save(Params.AutoIndexConfig.BinaryIndexParams.Key, `{"nlist": 1024, "index_type": "BIN_IVF_FLAT"}`)
defer Params.Reset(Params.AutoIndexConfig.Enable.Key)
defer Params.Reset(Params.AutoIndexConfig.IndexParams.Key)
defer Params.Reset(Params.AutoIndexConfig.SparseIndexParams.Key)
defer Params.Reset(Params.AutoIndexConfig.BinaryIndexParams.Key)
floatFieldSchema := &schemapb.FieldSchema{
DataType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "128"},
},
}
sparseFloatFieldSchema := &schemapb.FieldSchema{
DataType: schemapb.DataType_SparseFloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "64"},
},
}
binaryFieldSchema := &schemapb.FieldSchema{
DataType: schemapb.DataType_BinaryVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "4096"},
},
}
t.Run("case 1, float vector parameters", func(t *testing.T) {
task := &createIndexTask{
fieldSchema: floatFieldSchema,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.MetricTypeKey, Value: "L2"},
},
},
}
err := task.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.True(t, task.userAutoIndexMetricTypeSpecified)
assert.ElementsMatch(t, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "HNSW"},
{Key: common.MetricTypeKey, Value: "L2"},
{Key: "M", Value: "30"},
{Key: "efConstruction", Value: "360"},
}, task.newIndexParams)
})
t.Run("case 2, sparse vector parameters", func(t *testing.T) {
task := &createIndexTask{
fieldSchema: sparseFloatFieldSchema,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.MetricTypeKey, Value: "IP"},
},
},
}
err := task.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.True(t, task.userAutoIndexMetricTypeSpecified)
assert.ElementsMatch(t, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "SPARSE_INVERTED_INDEX"},
{Key: common.MetricTypeKey, Value: "IP"},
{Key: "drop_ratio_build", Value: "0.2"},
}, task.newIndexParams)
})
t.Run("case 3, binary vector parameters", func(t *testing.T) {
task := &createIndexTask{
fieldSchema: binaryFieldSchema,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.MetricTypeKey, Value: "JACCARD"},
},
},
}
err := task.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.True(t, task.userAutoIndexMetricTypeSpecified)
assert.ElementsMatch(t, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "BIN_IVF_FLAT"},
{Key: common.MetricTypeKey, Value: "JACCARD"},
{Key: "nlist", Value: "1024"},
}, task.newIndexParams)
})
}
func Test_parseIndexParams_LargeTopKQueryMode(t *testing.T) {
paramtable.Init()
t.Run("cloud autoindex with large_topk query mode selects IVF_FLAT", func(t *testing.T) {
Params.Save(Params.AutoIndexConfig.Enable.Key, "true")
Params.Save(Params.AutoIndexConfig.IndexParams.Key, `{"M": 30,"efConstruction": 360,"index_type": "HNSW"}`)
Params.Save(Params.AutoIndexConfig.LargeTopKIndexParams.Key, `{"nlist": 128, "index_type": "IVF_FLAT", "metric_type": "COSINE"}`)
defer Params.Reset(Params.AutoIndexConfig.Enable.Key)
defer Params.Reset(Params.AutoIndexConfig.IndexParams.Key)
defer Params.Reset(Params.AutoIndexConfig.LargeTopKIndexParams.Key)
task := &createIndexTask{
fieldSchema: &schemapb.FieldSchema{
DataType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "128"},
},
},
collectionProperties: []*commonpb.KeyValuePair{
{Key: common.QueryModeKey, Value: common.QueryModeLargeTopK},
},
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.MetricTypeKey, Value: "L2"},
},
},
}
err := task.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.True(t, task.userAutoIndexMetricTypeSpecified)
// Should use IVF_FLAT from LargeTopK config, with user metric type overriding
assert.ElementsMatch(t, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "IVF_FLAT"},
{Key: common.MetricTypeKey, Value: "L2"},
{Key: "nlist", Value: "128"},
}, task.newIndexParams)
})
t.Run("cloud autoindex without large_topk uses default HNSW", func(t *testing.T) {
Params.Save(Params.AutoIndexConfig.Enable.Key, "true")
Params.Save(Params.AutoIndexConfig.IndexParams.Key, `{"M": 30,"efConstruction": 360,"index_type": "HNSW"}`)
Params.Save(Params.AutoIndexConfig.LargeTopKIndexParams.Key, `{"nlist": 128, "index_type": "IVF_FLAT", "metric_type": "COSINE"}`)
defer Params.Reset(Params.AutoIndexConfig.Enable.Key)
defer Params.Reset(Params.AutoIndexConfig.IndexParams.Key)
defer Params.Reset(Params.AutoIndexConfig.LargeTopKIndexParams.Key)
task := &createIndexTask{
fieldSchema: &schemapb.FieldSchema{
DataType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "128"},
},
},
collectionProperties: []*commonpb.KeyValuePair{},
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.MetricTypeKey, Value: "L2"},
},
},
}
err := task.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.True(t, task.userAutoIndexMetricTypeSpecified)
// Should use default HNSW params
assert.ElementsMatch(t, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "HNSW"},
{Key: common.MetricTypeKey, Value: "L2"},
{Key: "M", Value: "30"},
{Key: "efConstruction", Value: "360"},
}, task.newIndexParams)
})
t.Run("non-cloud autoindex with large_topk query mode uses default HNSW", func(t *testing.T) {
Params.Save(Params.AutoIndexConfig.Enable.Key, "false")
Params.Save(Params.AutoIndexConfig.IndexParams.Key, `{"M": 30,"efConstruction": 360,"index_type": "HNSW", "metric_type": "IP"}`)
Params.Save(Params.AutoIndexConfig.LargeTopKIndexParams.Key, `{"nlist": 128, "index_type": "IVF_FLAT", "metric_type": "COSINE"}`)
defer Params.Reset(Params.AutoIndexConfig.Enable.Key)
defer Params.Reset(Params.AutoIndexConfig.IndexParams.Key)
defer Params.Reset(Params.AutoIndexConfig.LargeTopKIndexParams.Key)
task := &createIndexTask{
fieldSchema: &schemapb.FieldSchema{
DataType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "128"},
},
},
collectionProperties: []*commonpb.KeyValuePair{
{Key: common.QueryModeKey, Value: common.QueryModeLargeTopK},
},
req: &milvuspb.CreateIndexRequest{
ExtraParams: make([]*commonpb.KeyValuePair, 0),
},
}
err := task.parseIndexParams(context.TODO())
assert.NoError(t, err)
// non-cloud mode does not support LargeTopK override, should use default HNSW
found := false
for _, kv := range task.newIndexParams {
if kv.Key == common.IndexTypeKey {
assert.Equal(t, "HNSW", kv.Value)
found = true
}
}
assert.True(t, found, "index_type should be set to HNSW")
})
t.Run("no query_mode property uses default", func(t *testing.T) {
Params.Save(Params.AutoIndexConfig.Enable.Key, "true")
Params.Save(Params.AutoIndexConfig.IndexParams.Key, `{"M": 30,"efConstruction": 360,"index_type": "HNSW"}`)
Params.Save(Params.AutoIndexConfig.LargeTopKIndexParams.Key, `{"nlist": 128, "index_type": "IVF_FLAT", "metric_type": "COSINE"}`)
defer Params.Reset(Params.AutoIndexConfig.Enable.Key)
defer Params.Reset(Params.AutoIndexConfig.IndexParams.Key)
defer Params.Reset(Params.AutoIndexConfig.LargeTopKIndexParams.Key)
task := &createIndexTask{
fieldSchema: &schemapb.FieldSchema{
DataType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "128"},
},
},
collectionProperties: []*commonpb.KeyValuePair{},
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.MetricTypeKey, Value: "L2"},
},
},
}
err := task.parseIndexParams(context.TODO())
assert.NoError(t, err)
// Should use default HNSW params
assert.ElementsMatch(t, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "HNSW"},
{Key: common.MetricTypeKey, Value: "L2"},
{Key: "M", Value: "30"},
{Key: "efConstruction", Value: "360"},
}, task.newIndexParams)
})
}
func Test_parseIndexParams_AutoIndex(t *testing.T) {
paramtable.Init()
Params.Save(Params.AutoIndexConfig.Enable.Key, "false")
Params.Save(Params.AutoIndexConfig.IndexParams.Key, `{"M": 30,"efConstruction": 360,"index_type": "HNSW", "metric_type": "IP"}`)
Params.Save(Params.AutoIndexConfig.BinaryIndexParams.Key, `{"nlist": 1024, "index_type": "BIN_IVF_FLAT", "metric_type": "JACCARD"}`)
Params.Save(Params.AutoIndexConfig.SparseIndexParams.Key, `{"index_type": "SPARSE_INVERTED_INDEX", "metric_type": "IP"}`)
defer Params.Reset(Params.AutoIndexConfig.Enable.Key)
defer Params.Reset(Params.AutoIndexConfig.IndexParams.Key)
defer Params.Reset(Params.AutoIndexConfig.BinaryIndexParams.Key)
defer Params.Reset(Params.AutoIndexConfig.SparseIndexParams.Key)
autoIndexConfig := Params.AutoIndexConfig.IndexParams.GetAsJSONMap()
autoIndexConfigBinary := Params.AutoIndexConfig.BinaryIndexParams.GetAsJSONMap()
autoIndexConfigSparse := Params.AutoIndexConfig.SparseIndexParams.GetAsJSONMap()
fieldSchema := &schemapb.FieldSchema{
DataType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "8"},
},
}
fieldSchemaBinary := &schemapb.FieldSchema{
DataType: schemapb.DataType_BinaryVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "8"},
},
}
fieldSchemaSparse := &schemapb.FieldSchema{
DataType: schemapb.DataType_SparseFloatVector,
}
t.Run("case 1, empty parameters binary", func(t *testing.T) {
task := &createIndexTask{
fieldSchema: fieldSchemaBinary,
req: &milvuspb.CreateIndexRequest{
ExtraParams: make([]*commonpb.KeyValuePair, 0),
},
}
err := task.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.False(t, task.userAutoIndexMetricTypeSpecified)
assert.ElementsMatch(t, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: AutoIndexName},
{Key: common.MetricTypeKey, Value: autoIndexConfigBinary[common.MetricTypeKey]},
}, task.newExtraParams)
})
t.Run("case 1, empty parameters sparse", func(t *testing.T) {
task := &createIndexTask{
fieldSchema: fieldSchemaSparse,
req: &milvuspb.CreateIndexRequest{
ExtraParams: make([]*commonpb.KeyValuePair, 0),
},
}
err := task.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.False(t, task.userAutoIndexMetricTypeSpecified)
assert.ElementsMatch(t, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: AutoIndexName},
{Key: common.MetricTypeKey, Value: autoIndexConfigSparse[common.MetricTypeKey]},
}, task.newExtraParams)
})
t.Run("case 1, empty parameters float vector", func(t *testing.T) {
task := &createIndexTask{
fieldSchema: fieldSchema,
req: &milvuspb.CreateIndexRequest{
ExtraParams: make([]*commonpb.KeyValuePair, 0),
},
}
err := task.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.False(t, task.userAutoIndexMetricTypeSpecified)
assert.ElementsMatch(t, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: AutoIndexName},
{Key: common.MetricTypeKey, Value: autoIndexConfig[common.MetricTypeKey]},
}, task.newExtraParams)
})
t.Run("case 2, only metric type passed", func(t *testing.T) {
task := &createIndexTask{
fieldSchema: fieldSchema,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.MetricTypeKey, Value: "L2"},
},
},
}
err := task.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.True(t, task.userAutoIndexMetricTypeSpecified)
assert.ElementsMatch(t, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: AutoIndexName},
{Key: common.MetricTypeKey, Value: "L2"},
}, task.newExtraParams)
})
t.Run("case 3, AutoIndex & metric_type passed", func(t *testing.T) {
task := &createIndexTask{
fieldSchema: fieldSchema,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.MetricTypeKey, Value: "L2"},
{Key: common.IndexTypeKey, Value: AutoIndexName},
},
},
}
err := task.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.ElementsMatch(t, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: AutoIndexName},
{Key: common.MetricTypeKey, Value: "L2"},
}, task.newExtraParams)
})
t.Run("case 4, duplicate and useless parameters passed", func(t *testing.T) {
task := &createIndexTask{
fieldSchema: fieldSchema,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: "not important", Value: "L2"},
},
},
}
err := task.parseIndexParams(context.TODO())
assert.Error(t, err)
})
t.Run("case 5, duplicate and useless parameters passed", func(t *testing.T) {
task := &createIndexTask{
fieldSchema: fieldSchema,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.MetricTypeKey, Value: "L2"},
{Key: "not important", Value: "L2"},
},
},
}
err := task.parseIndexParams(context.TODO())
assert.Error(t, err)
})
t.Run("case 6, autoindex & duplicate", func(t *testing.T) {
task := &createIndexTask{
fieldSchema: fieldSchema,
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: AutoIndexName},
{Key: common.MetricTypeKey, Value: "L2"},
{Key: "not important", Value: "L2"},
},
},
}
err := task.parseIndexParams(context.TODO())
assert.Error(t, err)
})
}
func newTestSchema() *schemapb.CollectionSchema {
fields := []*schemapb.FieldSchema{
{FieldID: 0, Name: "FieldID", IsPrimaryKey: false, Description: "field no.1", DataType: schemapb.DataType_Int64},
}
for name, value := range schemapb.DataType_value {
dataType := schemapb.DataType(value)
if !typeutil.IsIntegerType(dataType) && !typeutil.IsFloatingType(dataType) && !typeutil.IsVectorType(dataType) && !typeutil.IsStringType(dataType) {
continue
}
newField := &schemapb.FieldSchema{
FieldID: int64(100 + value), Name: name + "Field", IsPrimaryKey: false, Description: "", DataType: dataType,
}
fields = append(fields, newField)
}
return &schemapb.CollectionSchema{
Name: "test",
Description: "schema for test used",
AutoID: true,
Fields: fields,
EnableDynamicField: true,
}
}
func TestAdjustAutoIndexParamsByDataType(t *testing.T) {
t.Run("nil config", func(t *testing.T) {
result := adjustAutoIndexParamsByDataType(nil, schemapb.DataType_FloatVector)
assert.Nil(t, result)
})
t.Run("no refine_type", func(t *testing.T) {
config := map[string]string{
"index_type": "HNSW_SQ",
"M": "18",
}
result := adjustAutoIndexParamsByDataType(config, schemapb.DataType_BFloat16Vector)
assert.Equal(t, config, result)
})
t.Run("fp32 vector keeps any refine_type", func(t *testing.T) {
config := map[string]string{
"index_type": "HNSW_SQ",
"refine_type": "FP16",
}
result := adjustAutoIndexParamsByDataType(config, schemapb.DataType_FloatVector)
assert.Contains(t, result, "refine_type")
assert.Equal(t, "FP16", result["refine_type"])
})
t.Run("fp16 vector keeps fp16 refine_type", func(t *testing.T) {
config := map[string]string{
"index_type": "HNSW_SQ",
"refine_type": "FP16",
}
result := adjustAutoIndexParamsByDataType(config, schemapb.DataType_Float16Vector)
assert.Equal(t, config, result) // same object, no copy needed
})
t.Run("fp16 vector adjusts bf16 refine_type to FP16", func(t *testing.T) {
config := map[string]string{
"index_type": "HNSW_SQ",
"refine_type": "BF16",
"M": "18",
}
result := adjustAutoIndexParamsByDataType(config, schemapb.DataType_Float16Vector)
assert.Contains(t, result, "refine_type")
assert.Equal(t, "FP16", result["refine_type"])
assert.Contains(t, result, "index_type")
assert.Contains(t, result, "M")
})
t.Run("bf16 vector keeps bf16 refine_type", func(t *testing.T) {
config := map[string]string{
"index_type": "HNSW_SQ",
"refine_type": "BF16",
}
result := adjustAutoIndexParamsByDataType(config, schemapb.DataType_BFloat16Vector)
assert.Equal(t, config, result) // same object, no copy needed
})
t.Run("bf16 vector adjusts fp16 refine_type to BF16", func(t *testing.T) {
config := map[string]string{
"index_type": "HNSW_SQ",
"refine_type": "FP16",
"M": "18",
}
result := adjustAutoIndexParamsByDataType(config, schemapb.DataType_BFloat16Vector)
assert.Contains(t, result, "refine_type")
assert.Equal(t, "BF16", result["refine_type"])
assert.Contains(t, result, "index_type")
assert.Contains(t, result, "M")
})
t.Run("fp16 vector keeps other refine_type unchanged", func(t *testing.T) {
config := map[string]string{
"index_type": "HNSW_SQ",
"refine_type": "SQ8",
}
result := adjustAutoIndexParamsByDataType(config, schemapb.DataType_Float16Vector)
assert.Equal(t, config, result) // not modified
})
t.Run("bf16 vector keeps other refine_type unchanged", func(t *testing.T) {
config := map[string]string{
"index_type": "HNSW_SQ",
"refine_type": "SQ8",
}
result := adjustAutoIndexParamsByDataType(config, schemapb.DataType_BFloat16Vector)
assert.Equal(t, config, result) // not modified
})
t.Run("original config not modified", func(t *testing.T) {
config := map[string]string{
"index_type": "HNSW_SQ",
"refine_type": "FP16",
}
result := adjustAutoIndexParamsByDataType(config, schemapb.DataType_BFloat16Vector)
// Original config should still have original refine_type
assert.Equal(t, "FP16", config["refine_type"])
// Result should have replaced refine_type
assert.Equal(t, "BF16", result["refine_type"])
})
}
func Test_parseIndexParams_AutoIndex_ArrayOfVector(t *testing.T) {
paramtable.Init()
Params.Save(Params.AutoIndexConfig.Enable.Key, "true")
Params.Save(Params.AutoIndexConfig.IndexParams.Key, `{"M": 30,"efConstruction": 360,"index_type": "HNSW"}`)
Params.Save(Params.AutoIndexConfig.SparseIndexParams.Key, `{"drop_ratio_build": 0.2, "index_type": "SPARSE_INVERTED_INDEX"}`)
Params.Save(Params.AutoIndexConfig.IntVectorIndexParams.Key, `{"nlist": 128, "index_type": "IVF_FLAT"}`)
defer Params.Reset(Params.AutoIndexConfig.Enable.Key)
defer Params.Reset(Params.AutoIndexConfig.IndexParams.Key)
defer Params.Reset(Params.AutoIndexConfig.SparseIndexParams.Key)
defer Params.Reset(Params.AutoIndexConfig.IntVectorIndexParams.Key)
t.Run("ArrayOfVector with FloatVector element uses dense float autoindex", func(t *testing.T) {
task := &createIndexTask{
fieldSchema: &schemapb.FieldSchema{
DataType: schemapb.DataType_ArrayOfVector,
ElementType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "128"},
},
},
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.MetricTypeKey, Value: "MAX_SIM_L2"},
},
},
}
err := task.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.True(t, task.userAutoIndexMetricTypeSpecified)
assert.ElementsMatch(t, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "HNSW"},
{Key: common.MetricTypeKey, Value: "MAX_SIM_L2"},
{Key: "M", Value: "30"},
{Key: "efConstruction", Value: "360"},
}, task.newIndexParams)
})
t.Run("ArrayOfVector with SparseFloatVector element is not supported", func(t *testing.T) {
task := &createIndexTask{
fieldSchema: &schemapb.FieldSchema{
DataType: schemapb.DataType_ArrayOfVector,
ElementType: schemapb.DataType_SparseFloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "64"},
},
},
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.MetricTypeKey, Value: "MAX_SIM_IP"},
},
},
}
err := task.parseIndexParams(context.TODO())
assert.Error(t, err)
})
t.Run("ArrayOfVector with Int8Vector element is not supported", func(t *testing.T) {
task := &createIndexTask{
fieldSchema: &schemapb.FieldSchema{
DataType: schemapb.DataType_ArrayOfVector,
ElementType: schemapb.DataType_Int8Vector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "128"},
},
},
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{
{Key: common.MetricTypeKey, Value: "MAX_SIM_L2"},
},
},
}
err := task.parseIndexParams(context.TODO())
assert.Error(t, err)
})
t.Run("ArrayOfVector without user metric maps config metric to EmbList", func(t *testing.T) {
task := &createIndexTask{
fieldSchema: &schemapb.FieldSchema{
DataType: schemapb.DataType_ArrayOfVector,
ElementType: schemapb.DataType_FloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "128"},
},
},
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{},
},
}
err := task.parseIndexParams(context.TODO())
assert.NoError(t, err)
assert.False(t, task.userAutoIndexMetricTypeSpecified)
// Config default metric (COSINE) should be mapped to MAX_SIM_COSINE
assert.ElementsMatch(t, []*commonpb.KeyValuePair{
{Key: common.IndexTypeKey, Value: "HNSW"},
{Key: common.MetricTypeKey, Value: metric.MaxSimCosine},
{Key: "M", Value: "30"},
{Key: "efConstruction", Value: "360"},
}, task.newIndexParams)
})
t.Run("ArrayOfVector sparse without user metric is not supported", func(t *testing.T) {
task := &createIndexTask{
fieldSchema: &schemapb.FieldSchema{
DataType: schemapb.DataType_ArrayOfVector,
ElementType: schemapb.DataType_SparseFloatVector,
TypeParams: []*commonpb.KeyValuePair{
{Key: common.DimKey, Value: "64"},
},
},
req: &milvuspb.CreateIndexRequest{
ExtraParams: []*commonpb.KeyValuePair{},
},
}
err := task.parseIndexParams(context.TODO())
assert.Error(t, err)
})
}
func Test_mapVectorMetricToEmbListMetric(t *testing.T) {
tests := []struct {
input string
expected string
}{
{metric.COSINE, metric.MaxSimCosine},
{metric.L2, metric.MaxSimL2},
{metric.IP, metric.MaxSimIP},
{metric.HAMMING, metric.MaxSimHamming},
{metric.JACCARD, metric.MaxSimJaccard},
// case insensitive
{"cosine", metric.MaxSimCosine},
{"ip", metric.MaxSimIP},
{"l2", metric.MaxSimL2},
// already EmbList metric - pass through
{metric.MaxSimIP, metric.MaxSimIP},
{metric.MaxSim, metric.MaxSim},
// unknown metric - pass through
{"UNKNOWN", "UNKNOWN"},
}
for _, tt := range tests {
t.Run(tt.input, func(t *testing.T) {
assert.Equal(t, tt.expected, mapVectorMetricToEmbListMetric(tt.input))
})
}
}