// Licensed to the LF AI & Data foundation under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The ASF licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you may not use this file except in compliance // with the License. You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. package rootcoord import ( "context" "math" "strconv" "testing" "github.com/bytedance/mockey" "github.com/cockroachdb/errors" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/mock" "github.com/stretchr/testify/require" "google.golang.org/protobuf/proto" "github.com/milvus-io/milvus-proto/go-api/v3/commonpb" "github.com/milvus-io/milvus-proto/go-api/v3/milvuspb" "github.com/milvus-io/milvus-proto/go-api/v3/schemapb" "github.com/milvus-io/milvus/internal/metastore/model" "github.com/milvus-io/milvus/internal/mocks" mockrootcoord "github.com/milvus-io/milvus/internal/rootcoord/mocks" "github.com/milvus-io/milvus/internal/storagev2/packed" "github.com/milvus-io/milvus/pkg/v3/common" "github.com/milvus-io/milvus/pkg/v3/proto/datapb" "github.com/milvus-io/milvus/pkg/v3/proto/querypb" "github.com/milvus-io/milvus/pkg/v3/streaming/util/message" "github.com/milvus-io/milvus/pkg/v3/util" "github.com/milvus-io/milvus/pkg/v3/util/funcutil" "github.com/milvus-io/milvus/pkg/v3/util/merr" "github.com/milvus-io/milvus/pkg/v3/util/paramtable" ) func Test_createCollectionTask_validate(t *testing.T) { paramtable.Init() t.Run("empty request", func(t *testing.T) { task := createCollectionTask{ Req: nil, } err := task.validate(context.TODO()) assert.Error(t, err) }) t.Run("shard num exceeds max configuration", func(t *testing.T) { // TODO: better to have a `Set` method for ParamItem. var cfgMaxShardNum int32 if Params.CommonCfg.PreCreatedTopicEnabled.GetAsBool() { cfgMaxShardNum = int32(len(Params.CommonCfg.TopicNames.GetAsStrings())) } else { cfgMaxShardNum = Params.RootCoordCfg.DmlChannelNum.GetAsInt32() } task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, ShardsNum: cfgMaxShardNum + 1, }, } err := task.validate(context.TODO()) assert.Error(t, err) }) t.Run("shard num exceeds limit", func(t *testing.T) { // TODO: better to have a `Set` method for ParamItem. cfgShardLimit := paramtable.Get().ProxyCfg.MaxShardNum.GetAsInt32() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, ShardsNum: cfgShardLimit + 1, }, } err := task.validate(context.TODO()) assert.Error(t, err) }) t.Run("total collection num exceeds limit", func(t *testing.T) { paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNum.Key, strconv.Itoa(2)) defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNum.Key) meta := mockrootcoord.NewIMetaTable(t) meta.EXPECT().ListAllAvailCollections( mock.Anything, ).Return(map[int64][]int64{1: {1, 2}}) meta.EXPECT().GetDatabaseByName(mock.Anything, mock.Anything, mock.Anything). Return(&model.Database{Name: "db1"}, nil) core := newTestCore(withMeta(meta)) task := createCollectionTask{ Core: core, Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, }, header: &message.CreateCollectionMessageHeader{ DbId: util.DefaultDBID, }, } err := task.validate(context.TODO()) assert.Error(t, err) task = createCollectionTask{ Core: core, Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, }, header: &message.CreateCollectionMessageHeader{ DbId: util.DefaultDBID, }, } err = task.validate(context.TODO()) assert.Error(t, err) }) t.Run("collection num per db exceeds limit with db properties", func(t *testing.T) { paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNumPerDB.Key, strconv.Itoa(2)) defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNumPerDB.Key) meta := mockrootcoord.NewIMetaTable(t) meta.EXPECT().ListAllAvailCollections(mock.Anything).Return(map[int64][]int64{util.DefaultDBID: {1, 2}}) // test reach limit meta.EXPECT().GetDatabaseByName(mock.Anything, mock.Anything, mock.Anything). Return(&model.Database{ Name: "db1", Properties: []*commonpb.KeyValuePair{ { Key: common.DatabaseMaxCollectionsKey, Value: "2", }, }, }, nil).Once() core := newTestCore(withMeta(meta)) task := createCollectionTask{ Core: core, Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, }, header: &message.CreateCollectionMessageHeader{ DbId: util.DefaultDBID, }, } err := task.validate(context.TODO()) assert.Error(t, err) // invalid properties meta.EXPECT().GetDatabaseByName(mock.Anything, mock.Anything, mock.Anything). Return(&model.Database{ Name: "db1", Properties: []*commonpb.KeyValuePair{ { Key: common.DatabaseMaxCollectionsKey, Value: "invalid-value", }, }, }, nil).Once() core = newTestCore(withMeta(meta)) task = createCollectionTask{ Core: core, Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, }, header: &message.CreateCollectionMessageHeader{ DbId: util.DefaultDBID, }, } err = task.validate(context.TODO()) assert.Error(t, err) }) t.Run("collection num per db exceeds limit with global configuration", func(t *testing.T) { paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNumPerDB.Key, strconv.Itoa(2)) defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNumPerDB.Key) meta := mockrootcoord.NewIMetaTable(t) meta.EXPECT().ListAllAvailCollections(mock.Anything).Return(map[int64][]int64{1: {1, 2}}) meta.EXPECT().GetDatabaseByName(mock.Anything, mock.Anything, mock.Anything). Return(&model.Database{Name: "db1"}, nil) core := newTestCore(withMeta(meta)) task := createCollectionTask{ Core: core, Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, }, header: &message.CreateCollectionMessageHeader{ DbId: util.DefaultDBID, }, } err := task.validate(context.TODO()) assert.Error(t, err) task = createCollectionTask{ Core: core, Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, }, header: &message.CreateCollectionMessageHeader{ DbId: util.DefaultDBID, }, } err = task.validate(context.TODO()) assert.Error(t, err) }) t.Run("collection general number exceeds limit", func(t *testing.T) { paramtable.Get().Save(Params.RootCoordCfg.MaxGeneralCapacity.Key, strconv.Itoa(1)) defer paramtable.Get().Reset(Params.RootCoordCfg.MaxGeneralCapacity.Key) meta := mockrootcoord.NewIMetaTable(t) meta.EXPECT().ListAllAvailCollections(mock.Anything).Return(map[int64][]int64{1: {1, 2}}) meta.EXPECT().GetDatabaseByName(mock.Anything, mock.Anything, mock.Anything). Return(&model.Database{Name: "db1"}, nil).Once() meta.EXPECT().GetGeneralCount(mock.Anything).Return(1) core := newTestCore(withMeta(meta)) task := createCollectionTask{ Core: core, Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, NumPartitions: 256, ShardsNum: 2, }, header: &message.CreateCollectionMessageHeader{ DbId: util.DefaultDBID, }, } err := task.validate(context.TODO()) assert.ErrorIs(t, err, merr.ErrGeneralCapacityExceeded) }) t.Run("ok", func(t *testing.T) { paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNumPerDB.Key, "1") defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNumPerDB.Key) meta := mockrootcoord.NewIMetaTable(t) meta.EXPECT().ListAllAvailCollections(mock.Anything).Return(map[int64][]int64{1: {1, 2}}) meta.EXPECT().GetDatabaseByName(mock.Anything, mock.Anything, mock.Anything). Return(&model.Database{ Name: "db1", Properties: []*commonpb.KeyValuePair{ { Key: common.DatabaseMaxCollectionsKey, Value: "3", }, }, }, nil).Once() meta.EXPECT().GetGeneralCount(mock.Anything).Return(0) core := newTestCore(withMeta(meta)) task := createCollectionTask{ Core: core, Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, NumPartitions: 2, ShardsNum: 2, }, header: &message.CreateCollectionMessageHeader{ DbId: util.DefaultDBID, }, } paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNum.Key, strconv.Itoa(math.MaxInt64)) defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNum.Key) err := task.validate(context.TODO()) assert.NoError(t, err) }) } func Test_createCollectionTask_validateSchema(t *testing.T) { t.Run("name mismatch", func(t *testing.T) { collectionName := funcutil.GenRandomStr() otherName := collectionName + "_other" task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: otherName, } err := task.validateSchema(context.TODO(), schema) assert.Error(t, err) }) t.Run("primary field set nullable", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{ { Name: "pk", IsPrimaryKey: true, Nullable: true, }, }, } err := task.validateSchema(context.TODO(), schema) assert.Error(t, err) }) t.Run("primary field set default_value", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{ { Name: "pk", IsPrimaryKey: true, DefaultValue: &schemapb.ValueField{ Data: &schemapb.ValueField_LongData{ LongData: 1, }, }, }, }, } err := task.validateSchema(context.TODO(), schema) assert.Error(t, err) }) t.Run("has system fields", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{ {Name: RowIDFieldName}, }, } err := task.validateSchema(context.TODO(), schema) assert.Error(t, err) }) t.Run("default value type mismatch", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{ { DataType: schemapb.DataType_BinaryVector, DefaultValue: &schemapb.ValueField{ Data: &schemapb.ValueField_BoolData{ BoolData: false, }, }, }, }, } err := task.validateSchema(context.TODO(), schema) assert.ErrorIs(t, err, merr.ErrParameterInvalid) schema1 := &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{ { DataType: schemapb.DataType_Int16, DefaultValue: &schemapb.ValueField{ Data: &schemapb.ValueField_BoolData{ BoolData: false, }, }, }, }, } err1 := task.validateSchema(context.TODO(), schema1) assert.ErrorIs(t, err1, merr.ErrParameterInvalid) schema2 := &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{ { DataType: schemapb.DataType_Bool, DefaultValue: &schemapb.ValueField{ Data: &schemapb.ValueField_IntData{ IntData: 1, }, }, }, }, } err2 := task.validateSchema(context.TODO(), schema2) assert.ErrorIs(t, err2, merr.ErrParameterInvalid) schema3 := &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{ { DataType: schemapb.DataType_Bool, DefaultValue: &schemapb.ValueField{ Data: &schemapb.ValueField_LongData{ LongData: 1, }, }, }, }, } err3 := task.validateSchema(context.TODO(), schema3) assert.ErrorIs(t, err3, merr.ErrParameterInvalid) schema4 := &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{ { DataType: schemapb.DataType_Bool, DefaultValue: &schemapb.ValueField{ Data: &schemapb.ValueField_FloatData{ FloatData: 1, }, }, }, }, } err4 := task.validateSchema(context.TODO(), schema4) assert.ErrorIs(t, err4, merr.ErrParameterInvalid) schema5 := &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{ { DataType: schemapb.DataType_Bool, DefaultValue: &schemapb.ValueField{ Data: &schemapb.ValueField_DoubleData{ DoubleData: 1, }, }, }, }, } err5 := task.validateSchema(context.TODO(), schema5) assert.ErrorIs(t, err5, merr.ErrParameterInvalid) schema6 := &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{ { DataType: schemapb.DataType_Bool, DefaultValue: &schemapb.ValueField{ Data: &schemapb.ValueField_StringData{ StringData: "a", }, }, }, }, } err6 := task.validateSchema(context.TODO(), schema6) assert.ErrorIs(t, err6, merr.ErrParameterInvalid) schema7 := &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{ { DataType: schemapb.DataType_Int16, DefaultValue: &schemapb.ValueField{ Data: &schemapb.ValueField_IntData{ IntData: math.MaxInt32, }, }, }, }, } err7 := task.validateSchema(context.TODO(), schema7) assert.ErrorIs(t, err7, merr.ErrParameterInvalid) schema8 := &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{ { DataType: schemapb.DataType_Int8, DefaultValue: &schemapb.ValueField{ Data: &schemapb.ValueField_IntData{ IntData: math.MaxInt32, }, }, }, }, } err8 := task.validateSchema(context.TODO(), schema8) assert.ErrorIs(t, err8, merr.ErrParameterInvalid) }) t.Run("default value length exceeds", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{ { DataType: schemapb.DataType_VarChar, TypeParams: []*commonpb.KeyValuePair{ { Key: common.MaxLengthKey, Value: "2", }, }, DefaultValue: &schemapb.ValueField{ Data: &schemapb.ValueField_StringData{ StringData: "abc", }, }, }, }, } err := task.validateSchema(context.TODO(), schema) assert.ErrorIs(t, err, merr.ErrParameterInvalid) }) t.Run("duplicate_type_params", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{ { DataType: schemapb.DataType_VarChar, TypeParams: []*commonpb.KeyValuePair{ { Key: common.MaxLengthKey, Value: "256", }, { Key: common.MmapEnabledKey, Value: "true", }, { Key: common.MmapEnabledKey, Value: "True", }, }, }, }, } err := task.validateSchema(context.TODO(), schema) assert.ErrorIs(t, err, merr.ErrParameterInvalid) }) t.Run("duplicate_index_params", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{ { DataType: schemapb.DataType_FloatVector, TypeParams: []*commonpb.KeyValuePair{ { Key: common.DimKey, Value: "256", }, }, IndexParams: []*commonpb.KeyValuePair{ {Key: common.MetricTypeKey, Value: "L2"}, {Key: common.MetricTypeKey, Value: "IP"}, }, }, }, } err := task.validateSchema(context.TODO(), schema) assert.ErrorIs(t, err, merr.ErrParameterInvalid) }) t.Run("normal case", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{}, } err := task.validateSchema(context.TODO(), schema) assert.NoError(t, err) }) t.Run("struct array field - empty fields", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, StructArrayFields: []*schemapb.StructArrayFieldSchema{ { Name: "struct_field", Fields: []*schemapb.FieldSchema{}, }, }, } err := task.validateSchema(context.TODO(), schema) assert.Error(t, err) assert.Contains(t, err.Error(), "empty fields in StructArrayField") }) t.Run("struct array field - vector type with nullable", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, StructArrayFields: []*schemapb.StructArrayFieldSchema{ { Name: "struct_field", Nullable: true, Fields: []*schemapb.FieldSchema{ { Name: "vector_array_field", DataType: schemapb.DataType_ArrayOfVector, ElementType: schemapb.DataType_FloatVector, Nullable: true, TypeParams: []*commonpb.KeyValuePair{ {Key: common.DimKey, Value: "128"}, {Key: common.MaxCapacityKey, Value: "100"}, }, }, }, }, }, } err := task.validateSchema(context.TODO(), schema) assert.NoError(t, err) }) t.Run("struct array field - field with default value", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, StructArrayFields: []*schemapb.StructArrayFieldSchema{ { Name: "struct_field", Fields: []*schemapb.FieldSchema{ { Name: "array_field", DataType: schemapb.DataType_Array, ElementType: schemapb.DataType_Int32, DefaultValue: &schemapb.ValueField{ Data: &schemapb.ValueField_IntData{ IntData: 1, }, }, }, }, }, }, } err := task.validateSchema(context.TODO(), schema) assert.Error(t, err) assert.Contains(t, err.Error(), "fields in struct array field not support default_value") }) t.Run("struct array field - duplicate type params", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, StructArrayFields: []*schemapb.StructArrayFieldSchema{ { Name: "struct_field", Fields: []*schemapb.FieldSchema{ { Name: "array_field", DataType: schemapb.DataType_Array, ElementType: schemapb.DataType_VarChar, TypeParams: []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "100"}, {Key: common.MaxLengthKey, Value: "200"}, }, }, }, }, }, } err := task.validateSchema(context.TODO(), schema) assert.Error(t, err) assert.Contains(t, err.Error(), "duplicated type param key") }) t.Run("struct array field - duplicate index params", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, StructArrayFields: []*schemapb.StructArrayFieldSchema{ { Name: "struct_field", Fields: []*schemapb.FieldSchema{ { Name: "vector_array_field", DataType: schemapb.DataType_ArrayOfVector, ElementType: schemapb.DataType_FloatVector, IndexParams: []*commonpb.KeyValuePair{ {Key: common.MetricTypeKey, Value: "L2"}, {Key: common.MetricTypeKey, Value: "IP"}, }, }, }, }, }, } err := task.validateSchema(context.TODO(), schema) assert.Error(t, err) assert.Contains(t, err.Error(), "duplicated index param key") }) t.Run("struct array field - invalid data type", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, StructArrayFields: []*schemapb.StructArrayFieldSchema{ { Name: "struct_field", Fields: []*schemapb.FieldSchema{ { Name: "invalid_field", DataType: schemapb.DataType_Int64, ElementType: schemapb.DataType_Int64, }, }, }, }, } err := task.validateSchema(context.TODO(), schema) assert.Error(t, err) assert.Contains(t, err.Error(), "fields in StructArrayField can only be array or array of vector") }) t.Run("struct array field - nested array", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, StructArrayFields: []*schemapb.StructArrayFieldSchema{ { Name: "struct_field", Fields: []*schemapb.FieldSchema{ { Name: "nested_array", DataType: schemapb.DataType_Array, ElementType: schemapb.DataType_Array, TypeParams: []*commonpb.KeyValuePair{{Key: common.MaxCapacityKey, Value: "100"}}, }, }, }, }, } err := task.validateSchema(context.TODO(), schema) assert.Error(t, err) assert.Contains(t, err.Error(), "nested array is not supported") }) t.Run("struct array field - invalid element type", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, StructArrayFields: []*schemapb.StructArrayFieldSchema{ { Name: "struct_field", Fields: []*schemapb.FieldSchema{ { Name: "array_field", DataType: schemapb.DataType_Array, ElementType: schemapb.DataType_None, TypeParams: []*commonpb.KeyValuePair{{Key: common.MaxCapacityKey, Value: "100"}}, }, }, }, }, } err := task.validateSchema(context.TODO(), schema) assert.Error(t, err) assert.Contains(t, err.Error(), "field data type: None is not supported") }) t.Run("struct array field - valid case", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, StructArrayFields: []*schemapb.StructArrayFieldSchema{ { Name: "struct_field", Fields: []*schemapb.FieldSchema{ { Name: "text_array", DataType: schemapb.DataType_Array, ElementType: schemapb.DataType_VarChar, TypeParams: []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "100"}, {Key: common.MaxCapacityKey, Value: "100"}, }, }, { Name: "int_array", DataType: schemapb.DataType_Array, ElementType: schemapb.DataType_Int32, TypeParams: []*commonpb.KeyValuePair{{Key: common.MaxCapacityKey, Value: "100"}}, }, { Name: "vector_array", DataType: schemapb.DataType_ArrayOfVector, ElementType: schemapb.DataType_FloatVector, TypeParams: []*commonpb.KeyValuePair{ {Key: common.DimKey, Value: "128"}, {Key: common.MaxCapacityKey, Value: "100"}, }, }, }, }, }, } err := task.validateSchema(context.TODO(), schema) assert.NoError(t, err) }) t.Run("external schema valid case", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, ExternalSource: "s3://bucket/object", ExternalSpec: `{"format":"parquet","extfs":{"region":"us-west-2","anonymous":"true","cloud_provider":"aws"}}`, Fields: []*schemapb.FieldSchema{ { Name: "text_field", DataType: schemapb.DataType_VarChar, ExternalField: "text_col", TypeParams: []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "64"}, }, }, { Name: "vec_field", DataType: schemapb.DataType_FloatVector, ExternalField: "vec_col", TypeParams: []*commonpb.KeyValuePair{ {Key: common.DimKey, Value: "16"}, }, }, }, } err := task.validateSchema(context.TODO(), schema) assert.NoError(t, err) }) t.Run("external schema reject primary key", func(t *testing.T) { collectionName := funcutil.GenRandomStr() task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, ExternalSource: "s3://bucket/object", ExternalSpec: `{"format":"parquet"}`, Fields: []*schemapb.FieldSchema{ { Name: "pk", DataType: schemapb.DataType_Int64, IsPrimaryKey: true, ExternalField: "pk_col", }, { Name: "vec_field", DataType: schemapb.DataType_FloatVector, ExternalField: "vec_col", TypeParams: []*commonpb.KeyValuePair{ {Key: common.DimKey, Value: "16"}, }, }, }, } err := task.validateSchema(context.TODO(), schema) assert.Error(t, err) }) } func Test_createCollectionTask_prepareSchema(t *testing.T) { t.Run("contain system fields", func(t *testing.T) { collectionName := funcutil.GenRandomStr() schema := &schemapb.CollectionSchema{ Name: collectionName, Description: "", AutoID: false, Fields: []*schemapb.FieldSchema{ {Name: TimeStampFieldName}, }, } task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.prepareSchema(context.TODO()) assert.Error(t, err) }) t.Run("normal case", func(t *testing.T) { collectionName := funcutil.GenRandomStr() field1 := funcutil.GenRandomStr() schema := &schemapb.CollectionSchema{ Name: collectionName, Description: "", AutoID: false, Fields: []*schemapb.FieldSchema{ { Name: field1, DataType: schemapb.DataType_Int64, }, }, } task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.prepareSchema(context.TODO()) assert.NoError(t, err) properties := common.CloneKeyValuePairs(task.body.CollectionSchema.Properties).ToMap() assert.Equal(t, "false", properties[common.NamespaceShardingEnabledKey]) enabled, err := common.IsNamespaceShardingEnabled(task.Req.Properties...) assert.NoError(t, err) assert.False(t, enabled) }) t.Run("keeps explicit namespace sharding setting", func(t *testing.T) { collectionName := funcutil.GenRandomStr() field1 := funcutil.GenRandomStr() schema := &schemapb.CollectionSchema{ Name: collectionName, Description: "", AutoID: false, Fields: []*schemapb.FieldSchema{ { Name: field1, DataType: schemapb.DataType_Int64, }, }, } task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, Properties: []*commonpb.KeyValuePair{ {Key: common.NamespaceShardingEnabledKey, Value: "true"}, }, }, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.prepareSchema(context.TODO()) assert.NoError(t, err) properties := common.CloneKeyValuePairs(task.body.CollectionSchema.Properties).ToMap() assert.Equal(t, "true", properties[common.NamespaceShardingEnabledKey]) enabled, err := common.IsNamespaceShardingEnabled(task.Req.Properties...) assert.NoError(t, err) assert.True(t, enabled) }) t.Run("rejects invalid namespace sharding setting", func(t *testing.T) { collectionName := funcutil.GenRandomStr() field1 := funcutil.GenRandomStr() schema := &schemapb.CollectionSchema{ Name: collectionName, Description: "", AutoID: false, Fields: []*schemapb.FieldSchema{ { Name: field1, DataType: schemapb.DataType_Int64, }, }, } task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, Properties: []*commonpb.KeyValuePair{ {Key: common.NamespaceShardingEnabledKey, Value: "invalid"}, }, }, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.prepareSchema(context.TODO()) assert.Error(t, err) assert.Contains(t, err.Error(), "invalid namespace.sharding.enabled") }) t.Run("invalid data type", func(t *testing.T) { collectionName := funcutil.GenRandomStr() field1 := funcutil.GenRandomStr() schema := &schemapb.CollectionSchema{ Name: collectionName, Description: "", AutoID: false, Fields: []*schemapb.FieldSchema{ { Name: field1, DataType: 300, }, }, } task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.prepareSchema(context.TODO()) assert.Error(t, err) }) t.Run("vector type with nullable", func(t *testing.T) { collectionName := funcutil.GenRandomStr() field1 := funcutil.GenRandomStr() schema := &schemapb.CollectionSchema{ Name: collectionName, Description: "", AutoID: false, Fields: []*schemapb.FieldSchema{ { FieldID: 100, Name: "pk", DataType: schemapb.DataType_Int64, IsPrimaryKey: true, }, { FieldID: 101, Name: field1, DataType: schemapb.DataType_FloatVector, Nullable: true, TypeParams: []*commonpb.KeyValuePair{{Key: "dim", Value: "128"}}, }, }, } task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.prepareSchema(context.TODO()) assert.NoError(t, err) }) t.Run("preserve field IDs with system fields", func(t *testing.T) { collectionName := funcutil.GenRandomStr() field1 := funcutil.GenRandomStr() preservedDynamicFieldID := int64(100) preservedNamespaceFieldID := int64(101) schema := &schemapb.CollectionSchema{ Name: collectionName, Description: "", AutoID: false, Fields: []*schemapb.FieldSchema{ { Name: field1, FieldID: 1, DataType: schemapb.DataType_Int64, IsPrimaryKey: true, }, { Name: MetaFieldName, FieldID: preservedDynamicFieldID, DataType: schemapb.DataType_JSON, }, { Name: NamespaceFieldName, FieldID: preservedNamespaceFieldID, DataType: schemapb.DataType_VarChar, }, { Name: TimeStampFieldName, FieldID: TimeStampField, DataType: schemapb.DataType_Int64, }, { Name: RowIDFieldName, FieldID: RowIDField, DataType: schemapb.DataType_Int64, }, }, } marshaledSchema, err := proto.Marshal(schema) assert.NoError(t, err) task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, Schema: marshaledSchema, }, body: &message.CreateCollectionRequest{ CollectionName: collectionName, CollectionSchema: schema, }, preserveFieldID: true, } err = task.prepareSchema(context.TODO()) assert.NoError(t, err) // Unmarshal the schema to verify var resultSchema schemapb.CollectionSchema err = proto.Unmarshal(task.Req.Schema, &resultSchema) assert.NoError(t, err) // Verify that system fields TimeStampFieldName and RowIDFieldName are re-added by appendSysFields hasTimestamp := false hasRowID := false hasMeta := false hasNamespace := false hasUserField := false var metaFieldID int64 var namespaceFieldID int64 for _, field := range resultSchema.Fields { if field.Name == TimeStampFieldName { hasTimestamp = true } if field.Name == RowIDFieldName { hasRowID = true } if field.Name == MetaFieldName { hasMeta = true metaFieldID = field.FieldID } if field.Name == NamespaceFieldName { hasNamespace = true namespaceFieldID = field.FieldID } if field.Name == field1 { hasUserField = true } } assert.True(t, hasTimestamp, "TimeStampFieldName should be re-added by appendSysFields") assert.True(t, hasRowID, "RowIDFieldName should be re-added by appendSysFields") assert.True(t, hasMeta, "MetaFieldName should be preserved") assert.True(t, hasNamespace, "NamespaceFieldName should be preserved") assert.True(t, hasUserField, "User field should be present") assert.Equal(t, preservedDynamicFieldID, metaFieldID, "Dynamic field ID should be preserved") assert.Equal(t, preservedNamespaceFieldID, namespaceFieldID, "Namespace field ID should be preserved") }) t.Run("preserve field IDs without system fields", func(t *testing.T) { collectionName := funcutil.GenRandomStr() field1 := funcutil.GenRandomStr() field2 := funcutil.GenRandomStr() schema := &schemapb.CollectionSchema{ Name: collectionName, Description: "", AutoID: false, Fields: []*schemapb.FieldSchema{ { Name: field1, FieldID: 10, DataType: schemapb.DataType_Int64, IsPrimaryKey: true, }, { Name: field2, FieldID: 20, DataType: schemapb.DataType_VarChar, }, }, } marshaledSchema, err := proto.Marshal(schema) assert.NoError(t, err) task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, Schema: marshaledSchema, }, body: &message.CreateCollectionRequest{ CollectionName: collectionName, CollectionSchema: schema, }, preserveFieldID: true, } err = task.prepareSchema(context.TODO()) assert.NoError(t, err) // Unmarshal the schema to verify var resultSchema schemapb.CollectionSchema err = proto.Unmarshal(task.Req.Schema, &resultSchema) assert.NoError(t, err) // Verify that user fields keep their IDs for _, field := range resultSchema.Fields { if field.Name == field1 { assert.Equal(t, int64(10), field.FieldID, "User field ID should be preserved") } if field.Name == field2 { assert.Equal(t, int64(20), field.FieldID, "User field ID should be preserved") } } }) t.Run("preserve field IDs - user fields integrity", func(t *testing.T) { collectionName := funcutil.GenRandomStr() // Prepare input schema with multiple user fields userFields := []*schemapb.FieldSchema{ { Name: "pk_field", FieldID: 100, DataType: schemapb.DataType_Int64, IsPrimaryKey: true, }, { Name: "varchar_field", FieldID: 105, DataType: schemapb.DataType_VarChar, TypeParams: []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "256"}, }, }, { Name: "vector_field", FieldID: 200, DataType: schemapb.DataType_FloatVector, TypeParams: []*commonpb.KeyValuePair{ {Key: common.DimKey, Value: "128"}, }, }, { Name: "json_field", FieldID: 300, DataType: schemapb.DataType_JSON, }, } // Add system fields to simulate snapshot restore scenario allFields := append([]*schemapb.FieldSchema{}, userFields...) allFields = append(allFields, &schemapb.FieldSchema{ Name: MetaFieldName, FieldID: 50, DataType: schemapb.DataType_JSON, }, &schemapb.FieldSchema{ Name: RowIDFieldName, FieldID: RowIDField, DataType: schemapb.DataType_Int64, }, &schemapb.FieldSchema{ Name: TimeStampFieldName, FieldID: TimeStampField, DataType: schemapb.DataType_Int64, }, ) schema := &schemapb.CollectionSchema{ Name: collectionName, EnableDynamicField: true, Fields: allFields, } // Save expected user field information expectedUserFields := make(map[string]int64) // fieldName -> fieldID for _, field := range userFields { expectedUserFields[field.Name] = field.FieldID } expectedUserFieldsInOrder := []string{"pk_field", "varchar_field", "vector_field", "json_field"} // Create task and execute prepareSchema task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, body: &message.CreateCollectionRequest{ CollectionName: collectionName, CollectionSchema: schema, }, preserveFieldID: true, } err := task.prepareSchema(context.TODO()) assert.NoError(t, err) // Extract user fields after prepareSchema (excluding system fields) systemFieldNames := map[string]bool{ RowIDFieldName: true, TimeStampFieldName: true, MetaFieldName: true, NamespaceFieldName: true, } actualUserFields := make(map[string]int64) actualUserFieldsInOrder := make([]string, 0) for _, field := range task.body.CollectionSchema.Fields { if !systemFieldNames[field.Name] { actualUserFields[field.Name] = field.FieldID actualUserFieldsInOrder = append(actualUserFieldsInOrder, field.Name) } } // Verify user field count remains the same assert.Equal(t, len(expectedUserFields), len(actualUserFields), "User field count mismatch after prepareSchema") // Verify each user field's FieldID is preserved for fieldName, expectedID := range expectedUserFields { actualID, exists := actualUserFields[fieldName] assert.True(t, exists, "User field '%s' is missing after prepareSchema", fieldName) assert.Equal(t, expectedID, actualID, "FieldID mismatch for field '%s': expected %d, got %d", fieldName, expectedID, actualID) } // Verify user field order remains the same assert.Equal(t, expectedUserFieldsInOrder, actualUserFieldsInOrder, "User field order changed after prepareSchema") }) t.Run("preserve field IDs - non-contiguous field IDs", func(t *testing.T) { collectionName := funcutil.GenRandomStr() // Use non-contiguous field IDs to ensure they are truly preserved userFields := []*schemapb.FieldSchema{ { Name: "field_100", FieldID: 100, DataType: schemapb.DataType_Int64, IsPrimaryKey: true, }, { Name: "field_150", FieldID: 150, DataType: schemapb.DataType_VarChar, TypeParams: []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "100"}, }, }, { Name: "field_500", FieldID: 500, DataType: schemapb.DataType_Float, }, { Name: "field_1000", FieldID: 1000, DataType: schemapb.DataType_Int32, }, } schema := &schemapb.CollectionSchema{ Name: collectionName, Fields: userFields, } task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, body: &message.CreateCollectionRequest{ CollectionName: collectionName, CollectionSchema: schema, }, preserveFieldID: true, } err := task.prepareSchema(context.TODO()) assert.NoError(t, err) // Verify non-contiguous IDs are preserved exactly fieldIDMap := make(map[string]int64) for _, field := range task.body.CollectionSchema.Fields { if field.Name != RowIDFieldName && field.Name != TimeStampFieldName { fieldIDMap[field.Name] = field.FieldID } } assert.Equal(t, int64(100), fieldIDMap["field_100"], "Non-contiguous ID 100 should be preserved") assert.Equal(t, int64(150), fieldIDMap["field_150"], "Non-contiguous ID 150 should be preserved") assert.Equal(t, int64(500), fieldIDMap["field_500"], "Non-contiguous ID 500 should be preserved") assert.Equal(t, int64(1000), fieldIDMap["field_1000"], "Non-contiguous ID 1000 should be preserved") }) t.Run("normal with analyzer", func(t *testing.T) { mixcoord := mocks.NewMixCoord(t) mixcoord.EXPECT().ValidateAnalyzer(mock.Anything, mock.Anything).Return(&querypb.ValidateAnalyzerResponse{ Status: merr.Status(nil), ResourceIds: []int64{1, 2, 3}, }, nil) meta := mockrootcoord.NewIMetaTable(t) meta.EXPECT().IncFileResourceRefCnt(mock.Anything).Return(nil) collectionName := funcutil.GenRandomStr() field1 := funcutil.GenRandomStr() field2 := funcutil.GenRandomStr() schema := &schemapb.CollectionSchema{ Name: collectionName, Description: "", AutoID: false, Fields: []*schemapb.FieldSchema{ { Name: field1, DataType: schemapb.DataType_Int64, IsPrimaryKey: true, }, { Name: field2, DataType: schemapb.DataType_VarChar, TypeParams: []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "100"}, {Key: "enable_analyzer", Value: "true"}, {Key: "enable_match", Value: "true"}, {Key: "analyzer_params", Value: `{"type": "standard"}`}, }, }, }, } marshaledSchema, err := proto.Marshal(schema) assert.NoError(t, err) task := createCollectionTask{ Core: newTestCore(withMixCoord(mixcoord), withMeta(meta)), Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, Schema: marshaledSchema, }, body: &message.CreateCollectionRequest{ CollectionName: collectionName, CollectionSchema: schema, }, preserveFieldID: false, } err = task.prepareSchema(context.TODO()) assert.NoError(t, err) }) t.Run("normal with file resource observer", func(t *testing.T) { mixcoord := mocks.NewMixCoord(t) mixcoord.EXPECT().ValidateAnalyzer(mock.Anything, mock.Anything).Return(&querypb.ValidateAnalyzerResponse{ Status: merr.Status(nil), ResourceIds: []int64{1, 2, 3}, }, nil) meta := mockrootcoord.NewIMetaTable(t) meta.EXPECT().IncFileResourceRefCnt(mock.Anything).Return(nil) collectionName := funcutil.GenRandomStr() field1 := funcutil.GenRandomStr() field2 := funcutil.GenRandomStr() schema := &schemapb.CollectionSchema{ Name: collectionName, Description: "", AutoID: false, Fields: []*schemapb.FieldSchema{ { Name: field1, DataType: schemapb.DataType_Int64, IsPrimaryKey: true, }, { Name: field2, DataType: schemapb.DataType_VarChar, TypeParams: []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "100"}, {Key: "enable_analyzer", Value: "true"}, {Key: "enable_match", Value: "true"}, {Key: "analyzer_params", Value: `{"type": "standard"}`}, }, }, }, } marshaledSchema, err := proto.Marshal(schema) assert.NoError(t, err) task := createCollectionTask{ Core: newTestCore(withMixCoord(mixcoord), withMeta(meta)), Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, Schema: marshaledSchema, }, body: &message.CreateCollectionRequest{ CollectionName: collectionName, CollectionSchema: schema, }, preserveFieldID: false, } // with file resource observer fileResourceObserver := NewMockFileResourceObserver(t) fileResourceObserver.EXPECT().CheckAllQnReady().Return(nil) task.fileResourceObserver = fileResourceObserver err = task.prepareSchema(context.TODO()) assert.NoError(t, err) assert.Equal(t, []int64{1, 2, 3}, task.body.CollectionSchema.FileResourceIds) }) t.Run("normal case without preserve field IDs", func(t *testing.T) { collectionName := funcutil.GenRandomStr() field1 := funcutil.GenRandomStr() schema := &schemapb.CollectionSchema{ Name: collectionName, Description: "", AutoID: false, Fields: []*schemapb.FieldSchema{ { Name: field1, DataType: schemapb.DataType_Int64, IsPrimaryKey: true, }, }, } marshaledSchema, err := proto.Marshal(schema) assert.NoError(t, err) task := createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, Schema: marshaledSchema, }, body: &message.CreateCollectionRequest{ CollectionName: collectionName, CollectionSchema: schema, }, preserveFieldID: false, } err = task.prepareSchema(context.TODO()) assert.NoError(t, err) // Use task.schema which is the internal schema after prepareSchema assert.NotNil(t, task.body.CollectionSchema, "Schema should be set") // Verify that user fields have been assigned IDs >= StartOfUserFieldID (100) for _, field := range task.body.CollectionSchema.Fields { if field.Name == field1 { assert.GreaterOrEqual(t, field.FieldID, int64(100), "User field ID should be >= StartOfUserFieldID (100)") } } }) } func TestNextMilvusTableTargetOnlyFieldID(t *testing.T) { source := &schemapb.CollectionSchema{ Fields: []*schemapb.FieldSchema{ {FieldID: common.StartOfUserFieldID, Name: "pk"}, {FieldID: common.StartOfUserFieldID + 3, Name: "vec"}, }, } target := &schemapb.CollectionSchema{ Fields: []*schemapb.FieldSchema{ {FieldID: 0, Name: common.VirtualPKFieldName}, {FieldID: common.StartOfUserFieldID, Name: "target_pk"}, }, } next := nextMilvusTableTargetOnlyFieldID(source, target) assert.Equal(t, int64(common.StartOfUserFieldID+4), next) } func TestPrepareMilvusTableSnapshotSchemaAlignsFieldIDs(t *testing.T) { mockReadMetadata := mockey.Mock(packed.ReadMilvusTableSnapshotMetadata). Return(&datapb.SnapshotMetadata{ Collection: &datapb.CollectionDescription{ Schema: &schemapb.CollectionSchema{ Fields: []*schemapb.FieldSchema{ {FieldID: common.RowIDField, Name: common.RowIDFieldName, DataType: schemapb.DataType_Int64}, {FieldID: 101, Name: "pk", DataType: schemapb.DataType_Int64, IsPrimaryKey: true}, {FieldID: 105, Name: "vec", DataType: schemapb.DataType_FloatVector}, }, }, }, }, nil).Build() defer mockReadMetadata.UnPatch() schema := &schemapb.CollectionSchema{ Name: "target", ExternalSource: "minio://localhost:9000/bucket/snapshots/100/metadata/200.json", ExternalSpec: `{"format":"milvus-table","extfs":{"access_key_id":"AK","access_key_value":"SK"}}`, Fields: []*schemapb.FieldSchema{ {FieldID: common.RowIDField, Name: common.RowIDFieldName, DataType: schemapb.DataType_Int64}, {FieldID: 101, Name: common.VirtualPKFieldName, DataType: schemapb.DataType_Int64, IsPrimaryKey: true}, {FieldID: 0, Name: "id", DataType: schemapb.DataType_Int64, ExternalField: "pk"}, {FieldID: 0, Name: "embedding", DataType: schemapb.DataType_FloatVector, ExternalField: "vec"}, }, } task := &createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ CollectionName: "target", Properties: []*commonpb.KeyValuePair{ {Key: util.PreserveFieldIdsKey, Value: "false"}, }, }, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.prepareMilvusTableSnapshotSchema(context.Background()) require.NoError(t, err) assert.True(t, task.preserveFieldID) require.Len(t, task.Req.GetProperties(), 1) assert.Equal(t, util.PreserveFieldIdsKey, task.Req.GetProperties()[0].GetKey()) assert.Equal(t, "true", task.Req.GetProperties()[0].GetValue()) assert.Equal(t, int64(common.RowIDField), schema.GetFields()[0].GetFieldID()) assert.Equal(t, int64(106), schema.GetFields()[1].GetFieldID()) assert.Equal(t, int64(101), schema.GetFields()[2].GetFieldID()) assert.Equal(t, int64(105), schema.GetFields()[3].GetFieldID()) } func TestPrepareMilvusTableSnapshotSchemaAlignsTargetFunctionOutputs(t *testing.T) { mockReadMetadata := mockey.Mock(packed.ReadMilvusTableSnapshotMetadata). Return(&datapb.SnapshotMetadata{ Collection: &datapb.CollectionDescription{ Schema: &schemapb.CollectionSchema{ Fields: []*schemapb.FieldSchema{ {FieldID: 101, Name: "pk", DataType: schemapb.DataType_Int64, IsPrimaryKey: true}, { FieldID: 105, Name: "vec", DataType: schemapb.DataType_FloatVector, TypeParams: []*commonpb.KeyValuePair{ {Key: common.DimKey, Value: "16"}, }, }, }, }, }, }, nil).Build() defer mockReadMetadata.UnPatch() schema := &schemapb.CollectionSchema{ Name: "target", ExternalSource: "minio://localhost:9000/bucket/snapshots/100/metadata/200.json", ExternalSpec: `{"format":"milvus-table","extfs":{"access_key_id":"AK","access_key_value":"SK"}}`, Fields: []*schemapb.FieldSchema{ {FieldID: 0, Name: "id", DataType: schemapb.DataType_Int64, IsPrimaryKey: true, ExternalField: "pk"}, { FieldID: 0, Name: "embedding", DataType: schemapb.DataType_FloatVector, ExternalField: "vec", TypeParams: []*commonpb.KeyValuePair{ {Key: common.DimKey, Value: "16"}, }, }, {FieldID: 101, Name: "sparse", DataType: schemapb.DataType_SparseFloatVector, IsFunctionOutput: true}, }, Functions: []*schemapb.FunctionSchema{ { Name: "bm25", InputFieldNames: []string{"id"}, OutputFieldNames: []string{"sparse"}, }, }, } task := &createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ CollectionName: "target", Properties: []*commonpb.KeyValuePair{ {Key: util.PreserveFieldIdsKey, Value: "false"}, }, }, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.prepareMilvusTableSnapshotSchema(context.Background()) require.NoError(t, err) assert.True(t, task.preserveFieldID) assert.Equal(t, int64(101), schema.GetFields()[0].GetFieldID()) assert.Equal(t, int64(105), schema.GetFields()[1].GetFieldID()) assert.Equal(t, int64(106), schema.GetFields()[2].GetFieldID()) require.Len(t, schema.GetFunctions(), 1) assert.Equal(t, int64(StartOfUserFunctionID), schema.GetFunctions()[0].GetId()) assert.Equal(t, []int64{101}, schema.GetFunctions()[0].GetInputFieldIds()) assert.Equal(t, []int64{106}, schema.GetFunctions()[0].GetOutputFieldIds()) } func TestPrepareMilvusTableSnapshotSchemaMapsSourceFunctionOutputAsDataField(t *testing.T) { mockReadMetadata := mockey.Mock(packed.ReadMilvusTableSnapshotMetadata). Return(&datapb.SnapshotMetadata{ Collection: &datapb.CollectionDescription{ Schema: &schemapb.CollectionSchema{ Fields: []*schemapb.FieldSchema{ {FieldID: 101, Name: "pk", DataType: schemapb.DataType_Int64, IsPrimaryKey: true}, {FieldID: 105, Name: "vec", DataType: schemapb.DataType_FloatVector}, { FieldID: 106, Name: "sparse", DataType: schemapb.DataType_SparseFloatVector, IsFunctionOutput: true, }, }, Functions: []*schemapb.FunctionSchema{ { Name: "bm25", InputFieldNames: []string{"pk"}, OutputFieldNames: []string{"sparse"}, OutputFieldIds: []int64{106}, }, }, }, }, }, nil).Build() defer mockReadMetadata.UnPatch() schema := &schemapb.CollectionSchema{ Name: "target", ExternalSource: "minio://localhost:9000/bucket/snapshots/100/metadata/200.json", ExternalSpec: `{"format":"milvus-table","extfs":{"access_key_id":"AK","access_key_value":"SK"}}`, Fields: []*schemapb.FieldSchema{ {FieldID: 0, Name: "id", DataType: schemapb.DataType_Int64, IsPrimaryKey: true, ExternalField: "pk"}, {FieldID: 0, Name: "embedding", DataType: schemapb.DataType_FloatVector, ExternalField: "vec"}, {FieldID: 0, Name: "sparse_copy", DataType: schemapb.DataType_SparseFloatVector, ExternalField: "sparse"}, }, } task := &createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ CollectionName: "target", Properties: []*commonpb.KeyValuePair{ {Key: util.PreserveFieldIdsKey, Value: "false"}, }, }, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.prepareMilvusTableSnapshotSchema(context.Background()) require.NoError(t, err) assert.True(t, task.preserveFieldID) assert.Equal(t, int64(101), schema.GetFields()[0].GetFieldID()) assert.Equal(t, int64(105), schema.GetFields()[1].GetFieldID()) assert.Equal(t, int64(106), schema.GetFields()[2].GetFieldID()) } func TestPrepareMilvusTableSnapshotSchemaSkipsReadWhenFieldIDsPreserved(t *testing.T) { mockReadMetadata := mockey.Mock(packed.ReadMilvusTableSnapshotMetadata). Return(nil, errors.New("snapshot metadata should not be read")).Build() defer mockReadMetadata.UnPatch() schema := &schemapb.CollectionSchema{ Name: "target", ExternalSource: "minio://localhost:9000/bucket/snapshots/100/metadata/200.json", ExternalSpec: `{"format":"milvus-table","extfs":{"access_key_id":"AK","access_key_value":"SK"}}`, Fields: []*schemapb.FieldSchema{ {FieldID: 106, Name: common.VirtualPKFieldName, DataType: schemapb.DataType_Int64, IsPrimaryKey: true}, {FieldID: 101, Name: "id", DataType: schemapb.DataType_Int64, ExternalField: "pk"}, {FieldID: 105, Name: "embedding", DataType: schemapb.DataType_FloatVector, ExternalField: "vec"}, }, } task := &createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ CollectionName: "target", Properties: []*commonpb.KeyValuePair{ {Key: util.PreserveFieldIdsKey, Value: "true"}, }, }, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, preserveFieldID: true, } err := task.prepareMilvusTableSnapshotSchema(context.Background()) require.NoError(t, err) assert.True(t, task.preserveFieldID) } func TestPrepareMilvusTableSnapshotSchemaErrors(t *testing.T) { baseSchema := func() *schemapb.CollectionSchema { return &schemapb.CollectionSchema{ Name: "target", ExternalSource: "minio://localhost:9000/bucket/snapshots/100/metadata/200.json", ExternalSpec: `{"format":"milvus-table","extfs":{"access_key_id":"AK","access_key_value":"SK"}}`, Fields: []*schemapb.FieldSchema{ {FieldID: 0, Name: "id", DataType: schemapb.DataType_Int64, ExternalField: "pk"}, }, } } baseTask := func(schema *schemapb.CollectionSchema) *createCollectionTask { return &createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{CollectionName: "target"}, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } } t.Run("invalid source spec", func(t *testing.T) { schema := baseSchema() schema.ExternalSource = "file:///tmp/snapshot.json" err := baseTask(schema).prepareMilvusTableSnapshotSchema(context.Background()) require.Error(t, err) assert.Contains(t, err.Error(), "external_source scheme") }) t.Run("empty source is noop", func(t *testing.T) { schema := baseSchema() schema.ExternalSource = "" err := baseTask(schema).prepareMilvusTableSnapshotSchema(context.Background()) require.NoError(t, err) }) t.Run("non milvus table skips snapshot read", func(t *testing.T) { schema := baseSchema() schema.ExternalSpec = `{"format":"parquet","extfs":{"anonymous":"true","cloud_provider":"minio"}}` err := baseTask(schema).prepareMilvusTableSnapshotSchema(context.Background()) require.NoError(t, err) }) t.Run("read metadata error", func(t *testing.T) { mockReadMetadata := mockey.Mock(packed.ReadMilvusTableSnapshotMetadata). Return(nil, errors.New("read failed")).Build() defer mockReadMetadata.UnPatch() err := baseTask(baseSchema()).prepareMilvusTableSnapshotSchema(context.Background()) require.Error(t, err) assert.Contains(t, err.Error(), "read milvus-table snapshot metadata") }) t.Run("missing source schema", func(t *testing.T) { mockReadMetadata := mockey.Mock(packed.ReadMilvusTableSnapshotMetadata). Return(&datapb.SnapshotMetadata{ Collection: &datapb.CollectionDescription{}, }, nil).Build() defer mockReadMetadata.UnPatch() err := baseTask(baseSchema()).prepareMilvusTableSnapshotSchema(context.Background()) require.Error(t, err) assert.Equal(t, merr.Code(merr.ErrParameterInvalid), merr.Code(err)) assert.Contains(t, err.Error(), "missing collection schema") }) t.Run("external collection snapshot is rejected", func(t *testing.T) { mockReadMetadata := mockey.Mock(packed.ReadMilvusTableSnapshotMetadata). Return(&datapb.SnapshotMetadata{ Collection: &datapb.CollectionDescription{ Schema: &schemapb.CollectionSchema{ ExternalSource: "s3://bucket/external-source", ExternalSpec: `{"format":"parquet"}`, Fields: []*schemapb.FieldSchema{ {FieldID: 100, Name: "pk", DataType: schemapb.DataType_Int64, ExternalField: "pk_col"}, }, }, }, }, nil).Build() defer mockReadMetadata.UnPatch() err := baseTask(baseSchema()).prepareMilvusTableSnapshotSchema(context.Background()) require.Error(t, err) assert.Equal(t, merr.Code(merr.ErrParameterInvalid), merr.Code(err)) assert.Contains(t, err.Error(), "cannot use an external collection snapshot") }) t.Run("schema mismatch", func(t *testing.T) { mockReadMetadata := mockey.Mock(packed.ReadMilvusTableSnapshotMetadata). Return(&datapb.SnapshotMetadata{ Collection: &datapb.CollectionDescription{ Schema: &schemapb.CollectionSchema{ Fields: []*schemapb.FieldSchema{ {FieldID: 100, Name: "pk", DataType: schemapb.DataType_VarChar}, }, }, }, }, nil).Build() defer mockReadMetadata.UnPatch() err := baseTask(baseSchema()).prepareMilvusTableSnapshotSchema(context.Background()) require.Error(t, err) assert.Equal(t, merr.Code(merr.ErrParameterInvalid), merr.Code(err)) assert.Contains(t, err.Error(), "target schema must match source snapshot schema") }) } func TestUpsertCreateCollectionProperty(t *testing.T) { properties := upsertCreateCollectionProperty(nil, "key", "value") require.Len(t, properties, 1) assert.Equal(t, "value", properties[0].GetValue()) properties = upsertCreateCollectionProperty(properties, "key", "updated") require.Len(t, properties, 1) assert.Equal(t, "updated", properties[0].GetValue()) } func Test_createCollectionTask_Prepare(t *testing.T) { initStreamingSystemAndCore(t) paramtable.Init() meta := mockrootcoord.NewIMetaTable(t) meta.On("GetDatabaseByName", mock.Anything, mock.Anything, mock.Anything, ).Return(model.NewDefaultDatabase(nil), nil) meta.On("ListAllAvailCollections", mock.Anything, ).Return(map[int64][]int64{ util.DefaultDBID: {1, 2}, }, nil) meta.EXPECT().GetGeneralCount(mock.Anything).Return(0) meta.EXPECT().DescribeAlias(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return("", errors.New("not found")) meta.EXPECT().GetCollectionByName(mock.Anything, mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil, errors.New("not found")) paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNum.Key, strconv.Itoa(math.MaxInt64)) defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNum.Key) paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNumPerDB.Key, strconv.Itoa(math.MaxInt64)) defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNumPerDB.Key) t.Run("failed to assign id", func(t *testing.T) { collectionName := funcutil.GenRandomStr() field1 := funcutil.GenRandomStr() schema := &schemapb.CollectionSchema{ Name: collectionName, Description: "", AutoID: false, Fields: []*schemapb.FieldSchema{ {Name: field1}, }, } core := newTestCore(withInvalidIDAllocator(), withMeta(meta)) task := createCollectionTask{ Core: core, Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, header: &message.CreateCollectionMessageHeader{}, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.Prepare(context.Background()) assert.Error(t, err) }) t.Run("normal case", func(t *testing.T) { defer cleanTestEnv() collectionName := funcutil.GenRandomStr() field1 := funcutil.GenRandomStr() ticker := newRocksMqTtSynchronizer() core := newTestCore(withValidIDAllocator(), withTtSynchronizer(ticker), withMeta(meta)) schema := &schemapb.CollectionSchema{ Name: collectionName, Description: "", AutoID: false, Fields: []*schemapb.FieldSchema{ { Name: field1, DataType: schemapb.DataType_Int64, }, }, } task := createCollectionTask{ Core: core, Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, header: &message.CreateCollectionMessageHeader{}, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } task.Req.ShardsNum = int32(Params.RootCoordCfg.DmlChannelNum.GetAsInt() + 1) // no enough channels. err := task.Prepare(context.Background()) assert.Error(t, err) task.Req.ShardsNum = common.DefaultShardsNum err = task.Prepare(context.Background()) assert.NoError(t, err) }) } func TestCreateCollectionTask_Prepare_WithProperty(t *testing.T) { initStreamingSystemAndCore(t) paramtable.Init() meta := mockrootcoord.NewIMetaTable(t) t.Run("with db properties", func(t *testing.T) { meta.EXPECT().GetDatabaseByName(mock.Anything, mock.Anything, mock.Anything).Return(&model.Database{ Name: "foo", ID: 1, }, nil).Twice() meta.EXPECT().ListAllAvailCollections(mock.Anything).Return(map[int64][]int64{ util.DefaultDBID: {1, 2}, }).Once() meta.EXPECT().GetGeneralCount(mock.Anything).Return(0).Once() meta.EXPECT().DescribeAlias(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return("", errors.New("not found")) meta.EXPECT().GetCollectionByName(mock.Anything, mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil, errors.New("not found")) defer cleanTestEnv() collectionName := funcutil.GenRandomStr() field1 := funcutil.GenRandomStr() ticker := newRocksMqTtSynchronizer() core := newTestCore(withValidIDAllocator(), withTtSynchronizer(ticker), withMeta(meta)) schema := &schemapb.CollectionSchema{ Name: collectionName, Description: "", AutoID: false, Fields: []*schemapb.FieldSchema{ { Name: field1, DataType: schemapb.DataType_Int64, }, }, } task := createCollectionTask{ Core: core, Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, }, header: &message.CreateCollectionMessageHeader{}, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } task.Req.ShardsNum = common.DefaultShardsNum err := task.Prepare(context.Background()) require.NoError(t, err) assert.Len(t, task.body.CollectionSchema.Properties, 4) assert.Equal(t, "100", common.CloneKeyValuePairs(task.body.CollectionSchema.Properties).ToMap()[common.MaxFieldIDKey]) assert.Equal(t, "false", common.CloneKeyValuePairs(task.body.CollectionSchema.Properties).ToMap()[common.NamespaceShardingEnabledKey]) assert.Len(t, task.Req.Properties, 3) }) t.Run("reject invalid namespace mode", func(t *testing.T) { meta := mockrootcoord.NewIMetaTable(t) meta.EXPECT().GetDatabaseByName(mock.Anything, mock.Anything, mock.Anything).Return(&model.Database{ Name: "foo", ID: 1, }, nil).Twice() meta.EXPECT().ListAllAvailCollections(mock.Anything).Return(map[int64][]int64{ util.DefaultDBID: {1, 2}, }).Once() meta.EXPECT().GetGeneralCount(mock.Anything).Return(0).Once() defer cleanTestEnv() collectionName := funcutil.GenRandomStr() field1 := funcutil.GenRandomStr() ticker := newRocksMqTtSynchronizer() core := newTestCore(withValidIDAllocator(), withTtSynchronizer(ticker), withMeta(meta)) schema := &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{ {Name: field1, DataType: schemapb.DataType_Int64}, }, } task := createCollectionTask{ Core: core, Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, ShardsNum: common.DefaultShardsNum, Properties: []*commonpb.KeyValuePair{ {Key: common.NamespaceModeKey, Value: "invalid"}, }, }, header: &message.CreateCollectionMessageHeader{}, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.Prepare(context.Background()) require.Error(t, err) assert.Contains(t, err.Error(), "invalid namespace.mode") }) t.Run("persist valid namespace mode", func(t *testing.T) { meta := mockrootcoord.NewIMetaTable(t) meta.EXPECT().GetDatabaseByName(mock.Anything, mock.Anything, mock.Anything).Return(&model.Database{ Name: "foo", ID: 1, }, nil).Twice() meta.EXPECT().ListAllAvailCollections(mock.Anything).Return(map[int64][]int64{ util.DefaultDBID: {1, 2}, }).Once() meta.EXPECT().GetGeneralCount(mock.Anything).Return(0).Once() meta.EXPECT().DescribeAlias(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return("", errors.New("not found")) meta.EXPECT().GetCollectionByName(mock.Anything, mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil, errors.New("not found")) defer cleanTestEnv() collectionName := funcutil.GenRandomStr() field1 := funcutil.GenRandomStr() ticker := newRocksMqTtSynchronizer() core := newTestCore(withValidIDAllocator(), withTtSynchronizer(ticker), withMeta(meta)) schema := &schemapb.CollectionSchema{ Name: collectionName, EnableNamespace: true, Fields: []*schemapb.FieldSchema{ {Name: field1, DataType: schemapb.DataType_Int64}, }, } task := createCollectionTask{ Core: core, Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, ShardsNum: common.DefaultShardsNum, Properties: []*commonpb.KeyValuePair{ {Key: common.NamespaceModeKey, Value: common.NamespaceModePartition}, }, }, header: &message.CreateCollectionMessageHeader{}, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.Prepare(context.Background()) require.NoError(t, err) props := common.CloneKeyValuePairs(task.body.CollectionSchema.Properties).ToMap() assert.Equal(t, common.NamespaceModePartition, props[common.NamespaceModeKey]) assert.NotContains(t, props, common.PartitionKeyIsolationKey) for _, field := range task.body.CollectionSchema.GetFields() { assert.NotEqual(t, common.NamespaceFieldName, field.GetName()) } }) } func Test_createCollectionTask_PartitionKey(t *testing.T) { initStreamingSystemAndCore(t) paramtable.Init() defer cleanTestEnv() collectionName := funcutil.GenRandomStr() field1 := funcutil.GenRandomStr() ticker := newRocksMqTtSynchronizer() meta := mockrootcoord.NewIMetaTable(t) meta.On("GetDatabaseByName", mock.Anything, mock.Anything, mock.Anything, ).Return(model.NewDefaultDatabase(nil), nil) meta.On("ListAllAvailCollections", mock.Anything, ).Return(map[int64][]int64{ util.DefaultDBID: {1, 2}, }, nil) meta.EXPECT().GetGeneralCount(mock.Anything).Return(0) meta.EXPECT().DescribeAlias(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return("", errors.New("not found")) meta.EXPECT().GetCollectionByName(mock.Anything, mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil, errors.New("not found")) paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNum.Key, strconv.Itoa(math.MaxInt64)) defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNum.Key) paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNumPerDB.Key, strconv.Itoa(math.MaxInt64)) defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNumPerDB.Key) core := newTestCore(withValidIDAllocator(), withTtSynchronizer(ticker), withMeta(meta)) partitionKeyField := &schemapb.FieldSchema{ Name: field1, DataType: schemapb.DataType_Int64, IsPartitionKey: true, } schema := &schemapb.CollectionSchema{ Name: collectionName, Description: "", AutoID: false, Fields: []*schemapb.FieldSchema{partitionKeyField}, } task := createCollectionTask{ Core: core, Req: &milvuspb.CreateCollectionRequest{ Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection}, CollectionName: collectionName, ShardsNum: common.DefaultShardsNum, }, header: &message.CreateCollectionMessageHeader{}, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } t.Run("without num partition", func(t *testing.T) { task.Req.NumPartitions = 0 err := task.Prepare(context.Background()) assert.Error(t, err) }) t.Run("num partition too large", func(t *testing.T) { task.Req.NumPartitions = Params.RootCoordCfg.MaxPartitionNum.GetAsInt64() + 1 err := task.Prepare(context.Background()) assert.Error(t, err) }) task.Req.NumPartitions = common.DefaultPartitionsWithPartitionKey task.body.CollectionSchema = &schemapb.CollectionSchema{ Name: collectionName, Description: "", AutoID: false, Fields: []*schemapb.FieldSchema{partitionKeyField}, } t.Run("normal case", func(t *testing.T) { err := task.Prepare(context.Background()) assert.NoError(t, err) }) } func TestNamespaceProperty(t *testing.T) { paramtable.Init() ctx := context.Background() prefix := "TestNamespaceProperty" collectionName := prefix + funcutil.GenRandomStr() initSchema := func() *schemapb.CollectionSchema { return &schemapb.CollectionSchema{ Name: collectionName, Fields: []*schemapb.FieldSchema{ { FieldID: 100, Name: "field1", DataType: schemapb.DataType_Int64, IsPrimaryKey: true, }, { FieldID: 101, Name: "vector", DataType: schemapb.DataType_FloatVector, TypeParams: []*commonpb.KeyValuePair{ { Key: common.DimKey, Value: strconv.Itoa(1024), }, }, }, }, EnableNamespace: true, } } hasNamespaceField := func(schema *schemapb.CollectionSchema) bool { for _, f := range schema.Fields { if f.Name == common.NamespaceFieldName { return true } } return false } t.Run("test namespace enabled", func(t *testing.T) { schema := initSchema() task := &createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ CollectionName: collectionName, }, header: &message.CreateCollectionMessageHeader{}, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.handleNamespaceField(ctx, schema) assert.NoError(t, err) assert.True(t, hasNamespaceField(schema)) }) t.Run("test namespace partition mode", func(t *testing.T) { schema := initSchema() task := &createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ CollectionName: collectionName, Properties: []*commonpb.KeyValuePair{ {Key: common.NamespaceModeKey, Value: common.NamespaceModePartition}, }, }, header: &message.CreateCollectionMessageHeader{}, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.handleNamespaceField(ctx, schema) assert.NoError(t, err) assert.False(t, hasNamespaceField(schema)) assert.False(t, hasIsolationProperty(task.Req.Properties...)) }) t.Run("test namespace disabled with isolation and partition key", func(t *testing.T) { schema := initSchema() schema.EnableNamespace = false schema.Fields = append(schema.Fields, &schemapb.FieldSchema{ FieldID: 102, Name: "field2", DataType: schemapb.DataType_Int64, IsPartitionKey: true, }) task := &createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ CollectionName: collectionName, Properties: []*commonpb.KeyValuePair{ { Key: common.PartitionKeyIsolationKey, Value: "true", }, }, }, header: &message.CreateCollectionMessageHeader{}, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.handleNamespaceField(ctx, schema) assert.NoError(t, err) assert.False(t, hasNamespaceField(schema)) }) t.Run("test namespace enabled with isolation", func(t *testing.T) { schema := initSchema() task := &createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ CollectionName: collectionName, Properties: []*commonpb.KeyValuePair{ { Key: common.PartitionKeyIsolationKey, Value: "true", }, }, }, header: &message.CreateCollectionMessageHeader{}, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.handleNamespaceField(ctx, schema) assert.NoError(t, err) assert.True(t, hasNamespaceField(schema)) }) t.Run("test namespace enabled with partition key", func(t *testing.T) { schema := initSchema() schema.Fields = append(schema.Fields, &schemapb.FieldSchema{ FieldID: 102, Name: "field2", DataType: schemapb.DataType_Int64, IsPartitionKey: true, }) task := &createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ CollectionName: collectionName, }, header: &message.CreateCollectionMessageHeader{}, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.handleNamespaceField(ctx, schema) assert.Error(t, err) }) t.Run("test namespace partition mode", func(t *testing.T) { schema := initSchema() task := &createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ CollectionName: collectionName, Properties: []*commonpb.KeyValuePair{ {Key: common.NamespaceModeKey, Value: common.NamespaceModePartition}, }, }, header: &message.CreateCollectionMessageHeader{}, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.handleNamespaceField(ctx, schema) assert.NoError(t, err) assert.False(t, hasNamespaceField(schema)) assert.False(t, hasIsolationProperty(task.Req.Properties...)) }) t.Run("test namespace enabled with external collection", func(t *testing.T) { // ExternalField mapping is enough to mark this fixture as external. schema := &schemapb.CollectionSchema{ Name: collectionName, ExternalSource: "s3://bucket/path", ExternalSpec: `{"format":"parquet"}`, EnableNamespace: true, Fields: []*schemapb.FieldSchema{ { FieldID: 100, Name: "text", DataType: schemapb.DataType_VarChar, ExternalField: "text_col", TypeParams: []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "256"}, }, }, { FieldID: 101, Name: "vector", DataType: schemapb.DataType_FloatVector, ExternalField: "vector_col", TypeParams: []*commonpb.KeyValuePair{ {Key: common.DimKey, Value: "1024"}, }, }, }, } task := &createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ CollectionName: collectionName, }, header: &message.CreateCollectionMessageHeader{}, body: &message.CreateCollectionRequest{ CollectionSchema: schema, }, } err := task.handleNamespaceField(ctx, schema) assert.Error(t, err) }) } func Test_validateMultiAnalyzerParams(t *testing.T) { createTestCollectionSchema := func(fields []*schemapb.FieldSchema) *schemapb.CollectionSchema { return &schemapb.CollectionSchema{ Name: "test_collection", Fields: fields, } } createTestFieldSchema := func(name string, dataType schemapb.DataType) *schemapb.FieldSchema { return &schemapb.FieldSchema{ Name: name, DataType: dataType, } } t.Run("invalid json params", func(t *testing.T) { coll := createTestCollectionSchema([]*schemapb.FieldSchema{}) fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar) infos := make([]*querypb.AnalyzerInfo, 0) err := validateMultiAnalyzerParams("invalid json", coll, fieldSchema, &infos) assert.Error(t, err) }) t.Run("missing by_field", func(t *testing.T) { coll := createTestCollectionSchema([]*schemapb.FieldSchema{}) fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar) infos := make([]*querypb.AnalyzerInfo, 0) params := `{"analyzers": {"default": {}}}` err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos) assert.Error(t, err) }) t.Run("by_field not string", func(t *testing.T) { coll := createTestCollectionSchema([]*schemapb.FieldSchema{}) fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar) infos := make([]*querypb.AnalyzerInfo, 0) params := `{"by_field": 123, "analyzers": {"default": {}}}` err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos) assert.Error(t, err) }) t.Run("by_field references non-existent field", func(t *testing.T) { coll := createTestCollectionSchema([]*schemapb.FieldSchema{ createTestFieldSchema("existing_field", schemapb.DataType_VarChar), }) fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar) infos := make([]*querypb.AnalyzerInfo, 0) params := `{"by_field": "non_existent_field", "analyzers": {"default": {}}}` err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos) assert.Error(t, err) }) t.Run("by_field references non-string field", func(t *testing.T) { coll := createTestCollectionSchema([]*schemapb.FieldSchema{ createTestFieldSchema("int_field", schemapb.DataType_Int64), }) fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar) infos := make([]*querypb.AnalyzerInfo, 0) params := `{"by_field": "int_field", "analyzers": {"default": {}}}` err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos) assert.Error(t, err) }) t.Run("invalid alias format", func(t *testing.T) { coll := createTestCollectionSchema([]*schemapb.FieldSchema{ createTestFieldSchema("string_field", schemapb.DataType_VarChar), }) fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar) infos := make([]*querypb.AnalyzerInfo, 0) params := `{"by_field": "string_field", "alias": "invalid_alias", "analyzers": {"default": {}}}` err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos) assert.Error(t, err) }) t.Run("missing analyzers", func(t *testing.T) { coll := createTestCollectionSchema([]*schemapb.FieldSchema{ createTestFieldSchema("string_field", schemapb.DataType_VarChar), }) fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar) infos := make([]*querypb.AnalyzerInfo, 0) params := `{"by_field": "string_field"}` err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos) assert.Error(t, err) }) t.Run("invalid analyzers format", func(t *testing.T) { coll := createTestCollectionSchema([]*schemapb.FieldSchema{ createTestFieldSchema("string_field", schemapb.DataType_VarChar), }) fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar) infos := make([]*querypb.AnalyzerInfo, 0) params := `{"by_field": "string_field", "analyzers": "invalid_analyzers"}` err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos) assert.Error(t, err) }) t.Run("missing default analyzer", func(t *testing.T) { coll := createTestCollectionSchema([]*schemapb.FieldSchema{ createTestFieldSchema("string_field", schemapb.DataType_VarChar), }) fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar) infos := make([]*querypb.AnalyzerInfo, 0) params := `{"by_field": "string_field", "analyzers": {"custom": {}}}` err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos) assert.Error(t, err) }) t.Run("valid params", func(t *testing.T) { coll := createTestCollectionSchema([]*schemapb.FieldSchema{ createTestFieldSchema("string_field", schemapb.DataType_VarChar), }) fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar) infos := make([]*querypb.AnalyzerInfo, 0) params := `{ "by_field": "string_field", "alias": {"en": "english", "zh": "chinese"}, "analyzers": { "default": {"type": "standard"}, "english": {"type": "english"}, "chinese": {"type": "chinese"} } }` err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos) assert.NoError(t, err) assert.Len(t, infos, 3) analyzerNames := make(map[string]bool) for _, info := range infos { assert.Equal(t, "test_field", info.Field) analyzerNames[info.Name] = true } assert.True(t, analyzerNames["default"]) assert.True(t, analyzerNames["english"]) assert.True(t, analyzerNames["chinese"]) }) t.Run("valid params with minimal config", func(t *testing.T) { coll := createTestCollectionSchema([]*schemapb.FieldSchema{ createTestFieldSchema("string_field", schemapb.DataType_VarChar), }) fieldSchema := createTestFieldSchema("test_field", schemapb.DataType_VarChar) infos := make([]*querypb.AnalyzerInfo, 0) params := `{ "by_field": "string_field", "analyzers": {"default": {"type": "standard"}} }` err := validateMultiAnalyzerParams(params, coll, fieldSchema, &infos) assert.NoError(t, err) assert.Len(t, infos, 1) assert.Equal(t, "default", infos[0].Name) assert.Equal(t, "test_field", infos[0].Field) assert.Equal(t, `{"type": "standard"}`, infos[0].Params) }) } func Test_validateAnalyzer(t *testing.T) { createTestCollectionSchemaWithBM25 := func(fields []*schemapb.FieldSchema, inputFieldName string) *schemapb.CollectionSchema { return &schemapb.CollectionSchema{ Name: "test_collection", Fields: fields, Functions: []*schemapb.FunctionSchema{ { Name: "bm25_func", Type: schemapb.FunctionType_BM25, InputFieldNames: []string{inputFieldName}, OutputFieldNames: []string{"bm25_output"}, }, }, } } createTestFieldSchema := func(name string, dataType schemapb.DataType, typeParams []*commonpb.KeyValuePair) *schemapb.FieldSchema { return &schemapb.FieldSchema{ Name: name, DataType: dataType, TypeParams: typeParams, } } t.Run("field without enable_match and not BM25 input", func(t *testing.T) { fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "100"}, }) collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{fieldSchema}, "invalid_field") infos := make([]*querypb.AnalyzerInfo, 0) err := validateAnalyzer(collSchema, fieldSchema, &infos) assert.NoError(t, err) assert.Len(t, infos, 0) }) t.Run("field with enable_match but no enable_analyzer", func(t *testing.T) { fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "100"}, {Key: "enable_match", Value: "true"}, }) collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{fieldSchema}, "text_field") infos := make([]*querypb.AnalyzerInfo, 0) err := validateAnalyzer(collSchema, fieldSchema, &infos) assert.Error(t, err) }) t.Run("field with enable_match and enable_analyzer", func(t *testing.T) { fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "100"}, {Key: "enable_match", Value: "true"}, {Key: "enable_analyzer", Value: "true"}, {Key: "analyzer_params", Value: "{\"type\": \"standard\"}"}, }) collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{fieldSchema}, "text_field") infos := make([]*querypb.AnalyzerInfo, 0) err := validateAnalyzer(collSchema, fieldSchema, &infos) assert.NoError(t, err) assert.Len(t, infos, 1) assert.Equal(t, "text_field", infos[0].Field) assert.Equal(t, "{\"type\": \"standard\"}", infos[0].Params) }) t.Run("field with multi analyzer and enable_match", func(t *testing.T) { fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "100"}, {Key: "enable_match", Value: "true"}, {Key: "enable_analyzer", Value: "true"}, {Key: "multi_analyzer_params", Value: `{"by_field": "lang", "analyzers": {"default": "{}"}}`}, }) collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{ fieldSchema, createTestFieldSchema("lang", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "10"}, }), }, "text_field") infos := make([]*querypb.AnalyzerInfo, 0) err := validateAnalyzer(collSchema, fieldSchema, &infos) assert.Error(t, err) }) t.Run("field with multi analyzer and analyzer_params", func(t *testing.T) { fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "100"}, {Key: "enable_analyzer", Value: "true"}, {Key: "multi_analyzer_params", Value: `{"by_field": "lang", "analyzers": {"default": "{}"}}`}, {Key: "analyzer_params", Value: `{"type": "standard"}`}, }) collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{ fieldSchema, createTestFieldSchema("lang", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "10"}, }), }, "text_field") infos := make([]*querypb.AnalyzerInfo, 0) err := validateAnalyzer(collSchema, fieldSchema, &infos) assert.Error(t, err) }) t.Run("field with valid multi analyzer", func(t *testing.T) { // Create a field with valid multi analyzer fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "100"}, {Key: "enable_analyzer", Value: "true"}, {Key: "multi_analyzer_params", Value: `{ "by_field": "lang", "analyzers": { "default": {"type": "standard"}, "english": {"type": "english"} } }`}, }) collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{ fieldSchema, createTestFieldSchema("lang", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "10"}, }), }, "text_field") infos := make([]*querypb.AnalyzerInfo, 0) err := validateAnalyzer(collSchema, fieldSchema, &infos) assert.NoError(t, err) assert.Len(t, infos, 2) // Verify analyzer info content analyzerNames := make(map[string]bool) for _, info := range infos { assert.Equal(t, "text_field", info.Field) analyzerNames[info.Name] = true } assert.True(t, analyzerNames["default"]) assert.True(t, analyzerNames["english"]) }) t.Run("field with invalid multi analyzer params", func(t *testing.T) { // Create a field with invalid multi analyzer params fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "100"}, {Key: "enable_analyzer", Value: "true"}, {Key: "multi_analyzer_params", Value: `{"by_field": "non_existent_field", "analyzers": {"default": "{}"}}`}, }) collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{fieldSchema}, "text_field") infos := make([]*querypb.AnalyzerInfo, 0) err := validateAnalyzer(collSchema, fieldSchema, &infos) assert.Error(t, err) }) t.Run("field with analyzer_params only", func(t *testing.T) { // Create a field with analyzer_params only fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "100"}, {Key: "enable_analyzer", Value: "true"}, {Key: "analyzer_params", Value: `{"type": "standard"}`}, }) collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{fieldSchema}, "text_field") infos := make([]*querypb.AnalyzerInfo, 0) err := validateAnalyzer(collSchema, fieldSchema, &infos) require.NoError(t, err) require.Len(t, infos, 1) assert.Equal(t, "text_field", infos[0].Field) assert.Equal(t, "", infos[0].Name) // Regular analyzer has no name assert.Equal(t, `{"type": "standard"}`, infos[0].Params) }) t.Run("field with enable_analyzer but no analyzer_params", func(t *testing.T) { // Create a field with enable_analyzer but no analyzer_params (uses default analyzer) fieldSchema := createTestFieldSchema("text_field", schemapb.DataType_VarChar, []*commonpb.KeyValuePair{ {Key: common.MaxLengthKey, Value: "100"}, {Key: "enable_match", Value: "true"}, {Key: "enable_analyzer", Value: "true"}, }) collSchema := createTestCollectionSchemaWithBM25([]*schemapb.FieldSchema{fieldSchema}, "text_field") infos := make([]*querypb.AnalyzerInfo, 0) err := validateAnalyzer(collSchema, fieldSchema, &infos) assert.NoError(t, err) assert.Len(t, infos, 0) // No analyzer_params, uses default analyzer }) } func Test_appendConsistecyLevel(t *testing.T) { task := &createCollectionTask{ Req: &milvuspb.CreateCollectionRequest{ CollectionName: "test_collection", Properties: []*commonpb.KeyValuePair{ {Key: common.ConsistencyLevel, Value: "Strong"}, }, }, } task.appendConsistecyLevel() require.Len(t, task.Req.Properties, 1) assert.Equal(t, common.ConsistencyLevel, task.Req.Properties[0].Key) ok, consistencyLevel := getConsistencyLevel(task.Req.Properties...) assert.True(t, ok) assert.Equal(t, commonpb.ConsistencyLevel_Strong, consistencyLevel) task.Req.ConsistencyLevel = commonpb.ConsistencyLevel_Session task.appendConsistecyLevel() require.Len(t, task.Req.Properties, 1) assert.Equal(t, common.ConsistencyLevel, task.Req.Properties[0].Key) ok, consistencyLevel = getConsistencyLevel(task.Req.Properties...) assert.True(t, ok) assert.Equal(t, commonpb.ConsistencyLevel_Strong, consistencyLevel) task.Req.Properties = nil task.appendConsistecyLevel() require.Len(t, task.Req.Properties, 1) assert.Equal(t, common.ConsistencyLevel, task.Req.Properties[0].Key) ok, consistencyLevel = getConsistencyLevel(task.Req.Properties...) assert.True(t, ok) assert.Equal(t, commonpb.ConsistencyLevel_Session, consistencyLevel) task.Req.Properties = []*commonpb.KeyValuePair{ {Key: common.ConsistencyLevel, Value: "1020203"}, } task.appendConsistecyLevel() require.Len(t, task.Req.Properties, 1) assert.Equal(t, common.ConsistencyLevel, task.Req.Properties[0].Key) ok, consistencyLevel = getConsistencyLevel(task.Req.Properties...) assert.True(t, ok) assert.Equal(t, commonpb.ConsistencyLevel_Session, consistencyLevel) consistencyLevel, properties := mustConsumeConsistencyLevel(task.Req.Properties) assert.Equal(t, commonpb.ConsistencyLevel_Session, consistencyLevel) assert.Len(t, properties, 0) }