lfnovo--open-notebook/tests/test_recently_viewed_api.py

"""Tests for recently viewed notebooks and sources."""

from unittest.mock import AsyncMock, patch

import pytest
from fastapi.testclient import TestClient

from open_notebook.domain.notebook import Source


@pytest.fixture
def client():
    """Create test client after environment variables have been cleared by conftest."""
    from api.main import app

    return TestClient(app)


class TestRecentlyViewedApi:
    @patch("api.routers.notebooks.repo_query", new_callable=AsyncMock)
    def test_recently_viewed_returns_mixed_items_newest_first(
        self, mock_repo_query, client
    ):
        mock_repo_query.side_effect = [
            [
                {
                    "id": "notebook:old",
                    "title": "Older Notebook",
                    "last_viewed_at": "2026-06-26T10:00:00Z",
                }
            ],
            [
                {
                    "id": "source:new",
                    "title": "Newer Source",
                    "last_viewed_at": "2026-06-27T10:00:00Z",
                }
            ],
        ]

        response = client.get("/api/recently-viewed")

        assert response.status_code == 200
        assert response.json() == [
            {
                "type": "source",
                "id": "source:new",
                "title": "Newer Source",
                "last_viewed_at": "2026-06-27T10:00:00Z",
            },
            {
                "type": "notebook",
                "id": "notebook:old",
                "title": "Older Notebook",
                "last_viewed_at": "2026-06-26T10:00:00Z",
            },
        ]

    @patch("api.routers.notebooks.repo_query", new_callable=AsyncMock)
    def test_recently_viewed_honors_limit(self, mock_repo_query, client):
        mock_repo_query.side_effect = [
            [
                {
                    "id": "notebook:1",
                    "title": "Notebook 1",
                    "last_viewed_at": "2026-06-27T09:00:00Z",
                },
                {
                    "id": "notebook:2",
                    "title": "Notebook 2",
                    "last_viewed_at": "2026-06-27T07:00:00Z",
                },
            ],
            [
                {
                    "id": "source:1",
                    "title": "Source 1",
                    "last_viewed_at": "2026-06-27T10:00:00Z",
                },
                {
                    "id": "source:2",
                    "title": "Source 2",
                    "last_viewed_at": "2026-06-27T08:00:00Z",
                },
            ],
        ]

        response = client.get("/api/recently-viewed?limit=2")

        assert response.status_code == 200
        data = response.json()
        assert [item["id"] for item in data] == ["source:1", "notebook:1"]
        assert len(data) == 2
        assert mock_repo_query.await_args_list[0].args[1] == {"limit": 2}
        assert mock_repo_query.await_args_list[1].args[1] == {"limit": 2}

    @patch("api.routers.notebooks.repo_query", new_callable=AsyncMock)
    def test_recently_viewed_empty_when_no_view_history(self, mock_repo_query, client):
        mock_repo_query.side_effect = [[], []]

        response = client.get("/api/recently-viewed")

        assert response.status_code == 200
        assert response.json() == []

    @patch("api.routers.notebooks.repo_query", new_callable=AsyncMock)
    def test_get_notebook_stamps_last_viewed_at(self, mock_repo_query, client):
        mock_repo_query.side_effect = [
            [
                {
                    "id": "notebook:1",
                    "name": "Notebook",
                    "description": "",
                    "archived": False,
                    "created": "2026-06-27T09:00:00Z",
                    "updated": "2026-06-27T09:00:00Z",
                    "source_count": 0,
                    "note_count": 0,
                }
            ],
            [],
        ]

        response = client.get("/api/notebooks/notebook:1")

        assert response.status_code == 200
        assert (
            "UPDATE $notebook_id SET last_viewed_at = time::now()"
            in (mock_repo_query.await_args_list[1].args[0])
        )

    @patch("api.routers.sources.Source.get_embedded_chunks", new_callable=AsyncMock)
    @patch("api.routers.sources.Source.get", new_callable=AsyncMock)
    @patch("api.routers.sources.repo_query", new_callable=AsyncMock)
    def test_get_source_stamps_last_viewed_at(
        self, mock_repo_query, mock_get_source, mock_chunks, client
    ):
        mock_get_source.return_value = Source(
            id="source:1",
            title="Source",
            topics=[],
            full_text="Source text",
            created="2026-06-27T09:00:00Z",
            updated="2026-06-27T09:00:00Z",
        )
        mock_chunks.return_value = 0
        mock_repo_query.side_effect = [[], []]

        response = client.get("/api/sources/source:1")

        assert response.status_code == 200
        assert (
            "UPDATE $source_id SET last_viewed_at = time::now()"
            in (mock_repo_query.await_args_list[0].args[0])
        )

    @patch("api.routers.notebooks.repo_query", new_callable=AsyncMock)
    def test_recently_viewed_reorders_after_notebook_is_viewed_again(
        self, mock_repo_query, client
    ):
        mock_repo_query.side_effect = [
            [
                {
                    "id": "notebook:1",
                    "title": "Notebook",
                    "last_viewed_at": "2026-06-27T11:00:00Z",
                }
            ],
            [
                {
                    "id": "source:1",
                    "title": "Source",
                    "last_viewed_at": "2026-06-27T10:00:00Z",
                }
            ],
        ]

        response = client.get("/api/recently-viewed")

        assert response.status_code == 200
        assert [item["id"] for item in response.json()] == ["notebook:1", "source:1"]