larksuite--cli/extension/platform/selector_test.go

// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT

package platform_test

import (
	"testing"

	"github.com/larksuite/cli/extension/platform"
)

// fakeView is a minimal CommandView for unit-testing selectors.
type fakeView struct {
	path       string
	domain     string
	risk       string
	riskOK     bool
	identities []string
}

func (v fakeView) Path() string                { return v.path }
func (v fakeView) Domain() string              { return v.domain }
func (v fakeView) Risk() (platform.Risk, bool) { return platform.Risk(v.risk), v.riskOK }
func (v fakeView) Identities() []platform.Identity {
	out := make([]platform.Identity, len(v.identities))
	for i, x := range v.identities {
		out[i] = platform.Identity(x)
	}
	return out
}
func (v fakeView) Annotation(key string) (string, bool) { return "", false }

func TestAll_None(t *testing.T) {
	cmd := fakeView{}
	if !platform.All()(cmd) {
		t.Errorf("All() must match every command")
	}
	if platform.None()(cmd) {
		t.Errorf("None() must match no command")
	}
}

func TestByDomain(t *testing.T) {
	sel := platform.ByDomain("docs", "im")
	if !sel(fakeView{domain: "docs"}) {
		t.Errorf("docs should match")
	}
	if sel(fakeView{domain: "vc"}) {
		t.Errorf("vc must not match docs/im selector")
	}
	// Unknown domain (empty) must not match.
	if sel(fakeView{domain: ""}) {
		t.Errorf("unknown domain must not match ByDomain (use ByDomainOrUnknown style if desired)")
	}
}

// Risk-based selectors match only against the closed taxonomy
// (read / write / high-risk-write). Commands without a risk annotation
// never match; the policy engine guarantees such commands cannot reach
// hook dispatch when a Rule without AllowUnannotated=true is registered.
func TestByExactRisk_unknownDoesNotMatch(t *testing.T) {
	sel := platform.ByExactRisk("write")
	if !sel(fakeView{risk: "write", riskOK: true}) {
		t.Errorf("exact write should match")
	}
	if sel(fakeView{riskOK: false}) {
		t.Errorf("unknown must not match ByExactRisk")
	}
	if sel(fakeView{risk: "read", riskOK: true}) {
		t.Errorf("read must not match ByExactRisk(write)")
	}
}

func TestByWrite_byReadOnly(t *testing.T) {
	if !platform.ByWrite()(fakeView{risk: "write", riskOK: true}) {
		t.Errorf("write should match ByWrite")
	}
	if !platform.ByWrite()(fakeView{risk: "high-risk-write", riskOK: true}) {
		t.Errorf("high-risk-write should match ByWrite")
	}
	if platform.ByWrite()(fakeView{risk: "read", riskOK: true}) {
		t.Errorf("read must not match ByWrite")
	}
	if platform.ByWrite()(fakeView{riskOK: false}) {
		t.Errorf("unknown must not match ByWrite")
	}
	if !platform.ByReadOnly()(fakeView{risk: "read", riskOK: true}) {
		t.Errorf("read should match ByReadOnly")
	}
	if platform.ByReadOnly()(fakeView{riskOK: false}) {
		t.Errorf("unknown must not match ByReadOnly")
	}
}

func TestByCommandPath(t *testing.T) {
	sel := platform.ByCommandPath("docs/**", "im/+send")
	if !sel(fakeView{path: "docs/+update"}) {
		t.Errorf("docs/+update should match docs/**")
	}
	if !sel(fakeView{path: "im/+send"}) {
		t.Errorf("im/+send should match")
	}
	if sel(fakeView{path: "contact/+search"}) {
		t.Errorf("contact/+search must not match")
	}
}

func TestByIdentity(t *testing.T) {
	sel := platform.ByIdentity("bot")
	if !sel(fakeView{identities: []string{"user", "bot"}}) {
		t.Errorf("ids containing bot should match")
	}
	if sel(fakeView{identities: []string{"user"}}) {
		t.Errorf("user-only ids must not match bot selector")
	}
}

func TestSelector_AndOrNot(t *testing.T) {
	docsAndWrite := platform.ByDomain("docs").And(platform.ByExactRisk("write"))
	if !docsAndWrite(fakeView{domain: "docs", risk: "write", riskOK: true}) {
		t.Errorf("AND of matching selectors should match")
	}
	if docsAndWrite(fakeView{domain: "docs", risk: "read", riskOK: true}) {
		t.Errorf("AND fails when one side fails")
	}

	docsOrIm := platform.ByDomain("docs").Or(platform.ByDomain("im"))
	if !docsOrIm(fakeView{domain: "im"}) {
		t.Errorf("OR should match either side")
	}

	notRead := platform.ByReadOnly().Not()
	if notRead(fakeView{risk: "read", riskOK: true}) {
		t.Errorf("Not(ByReadOnly) must reject read commands")
	}
	if !notRead(fakeView{risk: "write", riskOK: true}) {
		t.Errorf("Not(ByReadOnly) should match write")
	}
}

func TestSelector_NilSafeWhenComposed(t *testing.T) {
	// A nil Selector is equivalent to None() per the Selector godoc.
	// Composition must honour that contract: the resulting selector
	// must not panic when invoked and must produce the documented
	// boolean outcome (nil-as-None propagates through AND/OR/NOT).
	var s platform.Selector
	cmd := fakeView{domain: "docs"}

	if got := s.And(platform.All())(cmd); got {
		t.Errorf("nil.And(All) should match None semantics (false), got true")
	}
	if got := s.Or(platform.All())(cmd); !got {
		t.Errorf("nil.Or(All) should match (true), got false")
	}
	if got := platform.All().And(s)(cmd); got {
		t.Errorf("All.And(nil) should be None (false), got true")
	}
	if got := s.Not()(cmd); !got {
		t.Errorf("(nil).Not() should be Not(None) = true, got false")
	}
}