wehub-resource-sync
bf9395e022
CI / results (push) Blocked by required conditions
CI / license-header (push) Has been skipped
CI / e2e-dry-run (push) Has been skipped
CI / e2e-live (push) Waiting to run
CI / fast-gate (push) Failing after 0s
Test PR Label Logic / test-pr-labels (push) Failing after 1s
Skill Format Check / check-format (push) Failing after 2s
CI / security (push) Failing after 5s
CI / unit-test (push) Has been skipped
CI / lint (push) Has been skipped
CI / script-test (push) Has been skipped
CI / deterministic-gate (push) Has been skipped
CI / coverage (push) Has been skipped
CI / deadcode (push) Waiting to run
88 lines
3.0 KiB
Go
88 lines
3.0 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/larksuite/cli/internal/cmdutil"
|
|
"github.com/larksuite/cli/internal/core"
|
|
"github.com/larksuite/cli/internal/registry"
|
|
)
|
|
|
|
func TestResolveStartupBrand_Precedence(t *testing.T) {
|
|
tmp := t.TempDir()
|
|
t.Setenv("LARKSUITE_CLI_CONFIG_DIR", tmp)
|
|
t.Setenv("LARKSUITE_CLI_BRAND", "")
|
|
os.Unsetenv("LARKSUITE_CLI_BRAND")
|
|
|
|
// No config at all → default brand.
|
|
if got := ResolveStartupBrand(""); got != core.BrandFeishu {
|
|
t.Errorf("empty state brand = %q, want feishu", got)
|
|
}
|
|
|
|
// Raw config supplies the active profile's brand — no keychain involved.
|
|
raw := `{"currentApp":"feishu-app","apps":[` +
|
|
`{"name":"feishu-app","appId":"cli_f","appSecret":"test-secret","brand":"feishu","users":[]},` +
|
|
`{"name":"lark-prof","appId":"cli_l","appSecret":"test-secret","brand":"LARK","users":[]}]}`
|
|
if err := os.WriteFile(filepath.Join(tmp, "config.json"), []byte(raw), 0600); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if got := ResolveStartupBrand(""); got != core.BrandFeishu {
|
|
t.Errorf("default profile brand = %q, want feishu", got)
|
|
}
|
|
if got := ResolveStartupBrand("lark-prof"); got != core.BrandLark {
|
|
t.Errorf("lark profile brand = %q, want lark (normalized)", got)
|
|
}
|
|
|
|
// Environment wins over the config file.
|
|
t.Setenv("LARKSUITE_CLI_BRAND", "lark")
|
|
if got := ResolveStartupBrand(""); got != core.BrandLark {
|
|
t.Errorf("env brand = %q, want lark", got)
|
|
}
|
|
}
|
|
|
|
// TestStartupBrandReachesRegistry_RealStartupOrder proves the fix for the
|
|
// production startup sequence: building the command tree locks the registry's
|
|
// sync.Once, so the brand must be injected before the first catalog access.
|
|
// It runs in a subprocess because the registry is process-global.
|
|
func TestStartupBrandReachesRegistry_RealStartupOrder(t *testing.T) {
|
|
if os.Getenv("GO_TEST_STARTUP_BRAND_HELPER") == "1" {
|
|
// Helper: replicate Execute()'s build wiring with a lark config.
|
|
buildInternal(
|
|
context.Background(), cmdutil.InvocationContext{},
|
|
WithIO(strings.NewReader(""), os.Stdout, os.Stderr),
|
|
WithStartupBrand(ResolveStartupBrand("")),
|
|
)
|
|
fmt.Printf("CONFIGURED_BRAND=%s\n", registry.ConfiguredBrand())
|
|
os.Exit(0)
|
|
}
|
|
|
|
tmp := t.TempDir()
|
|
raw := `{"apps":[{"appId":"cli_l","appSecret":"test-secret","brand":"lark","users":[]}]}`
|
|
if err := os.WriteFile(filepath.Join(tmp, "config.json"), []byte(raw), 0600); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
cmd := exec.Command(os.Args[0], "-test.run", "TestStartupBrandReachesRegistry_RealStartupOrder")
|
|
cmd.Env = append(os.Environ(),
|
|
"GO_TEST_STARTUP_BRAND_HELPER=1",
|
|
"LARKSUITE_CLI_CONFIG_DIR="+tmp,
|
|
"LARKSUITE_CLI_REMOTE_META=off", // no network during the subprocess build
|
|
)
|
|
out, err := cmd.CombinedOutput()
|
|
if err != nil {
|
|
t.Fatalf("subprocess failed: %v\n%s", err, out)
|
|
}
|
|
if !strings.Contains(string(out), "CONFIGURED_BRAND=lark") {
|
|
t.Errorf("registry brand after real startup order = %s, want lark", out)
|
|
}
|
|
}
|