chore: import upstream snapshot with attribution

tests/unit_tests/api/service/test_webhook_service.py

@@ -0,0 +1,507 @@
+"""
+Unit tests for WebhookService.
+
+Tests webhook CRUD operations including:
+- Webhook listing
+- Webhook creation
+- Webhook retrieval by ID
+- Webhook updates
+- Webhook deletion
+- Enabled webhooks filtering
+
+Source: src/langbot/pkg/api/http/service/webhook.py
+"""
+
+from __future__ import annotations
+
+import pytest
+from unittest.mock import AsyncMock, Mock
+from types import SimpleNamespace
+
+from langbot.pkg.api.http.service.webhook import WebhookService
+from langbot.pkg.entity.persistence.webhook import Webhook
+
+
+pytestmark = pytest.mark.asyncio
+
+
+def _create_mock_webhook(
+    webhook_id: int = 1,
+    name: str = 'Test Webhook',
+    url: str = 'http://example.com/webhook',
+    description: str = 'Test Description',
+    enabled: bool = True,
+) -> Mock:
+    """Helper to create mock Webhook entity."""
+    webhook = Mock(spec=Webhook)
+    webhook.id = webhook_id
+    webhook.name = name
+    webhook.url = url
+    webhook.description = description
+    webhook.enabled = enabled
+    return webhook
+
+
+def _create_mock_result(items: list = None, first_item=None):
+    """Create mock result object for persistence queries."""
+    result = Mock()
+    result.all = Mock(return_value=items or [])
+    result.first = Mock(return_value=first_item)
+    return result
+
+
+class TestWebhookServiceGetWebhooks:
+    """Tests for get_webhooks method."""
+
+    async def test_get_webhooks_empty_list(self):
+        """Returns empty list when no webhooks exist."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+        mock_result = _create_mock_result([])
+        ap.persistence_mgr.execute_async = AsyncMock(return_value=mock_result)
+        ap.persistence_mgr.serialize_model = Mock(
+            side_effect=lambda model_cls, entity: {
+                'id': entity.id,
+                'name': entity.name,
+                'url': entity.url,
+            }
+        )
+
+        service = WebhookService(ap)
+
+        # Execute
+        result = await service.get_webhooks()
+
+        # Verify
+        assert result == []
+
+    async def test_get_webhooks_returns_serialized_list(self):
+        """Returns serialized list of webhooks."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+
+        webhook1 = _create_mock_webhook(webhook_id=1, name='Webhook 1')
+        webhook2 = _create_mock_webhook(webhook_id=2, name='Webhook 2')
+
+        mock_result = _create_mock_result([webhook1, webhook2])
+        ap.persistence_mgr.execute_async = AsyncMock(return_value=mock_result)
+        ap.persistence_mgr.serialize_model = Mock(
+            side_effect=lambda model_cls, entity: {
+                'id': entity.id,
+                'name': entity.name,
+                'url': entity.url,
+                'description': entity.description,
+                'enabled': entity.enabled,
+            }
+        )
+
+        service = WebhookService(ap)
+
+        # Execute
+        result = await service.get_webhooks()
+
+        # Verify
+        assert len(result) == 2
+        assert result[0]['name'] == 'Webhook 1'
+        assert result[1]['name'] == 'Webhook 2'
+
+
+class TestWebhookServiceCreateWebhook:
+    """Tests for create_webhook method."""
+
+    async def test_create_webhook_full_params(self):
+        """Creates webhook with all parameters."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+
+        # Mock insert result
+        insert_result = Mock()
+
+        # Mock select result for retrieving created webhook
+        created_webhook = _create_mock_webhook(
+            webhook_id=1,
+            name='New Webhook',
+            url='http://new.example.com/webhook',
+            description='New Description',
+            enabled=True,
+        )
+        select_result = _create_mock_result(first_item=created_webhook)
+
+        # execute_async returns different results
+        call_count = 0
+
+        async def mock_execute(query):
+            nonlocal call_count
+            call_count += 1
+            if call_count == 1:
+                return insert_result  # Insert
+            return select_result  # Select
+
+        ap.persistence_mgr.execute_async = AsyncMock(side_effect=mock_execute)
+        ap.persistence_mgr.serialize_model = Mock(
+            return_value={
+                'id': 1,
+                'name': 'New Webhook',
+                'url': 'http://new.example.com/webhook',
+                'description': 'New Description',
+                'enabled': True,
+            }
+        )
+
+        service = WebhookService(ap)
+
+        # Execute
+        result = await service.create_webhook(
+            name='New Webhook',
+            url='http://new.example.com/webhook',
+            description='New Description',
+            enabled=True,
+        )
+
+        # Verify
+        assert result['name'] == 'New Webhook'
+        assert result['url'] == 'http://new.example.com/webhook'
+        assert result['description'] == 'New Description'
+        assert result['enabled'] is True
+
+    async def test_create_webhook_defaults(self):
+        """Creates webhook with default description and enabled."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+
+        created_webhook = _create_mock_webhook(
+            webhook_id=1,
+            name='Minimal Webhook',
+            url='http://minimal.example.com',
+            description='',  # Default
+            enabled=True,  # Default
+        )
+
+        call_count = 0
+
+        async def mock_execute(query):
+            nonlocal call_count
+            call_count += 1
+            if call_count == 1:
+                return Mock()  # Insert
+            return _create_mock_result(first_item=created_webhook)
+
+        ap.persistence_mgr.execute_async = AsyncMock(side_effect=mock_execute)
+        ap.persistence_mgr.serialize_model = Mock(
+            return_value={
+                'id': 1,
+                'name': 'Minimal Webhook',
+                'url': 'http://minimal.example.com',
+                'description': '',
+                'enabled': True,
+            }
+        )
+
+        service = WebhookService(ap)
+
+        # Execute - only name and url required
+        result = await service.create_webhook(name='Minimal Webhook', url='http://minimal.example.com')
+
+        # Verify defaults
+        assert result['description'] == ''
+        assert result['enabled'] is True
+
+    async def test_create_webhook_disabled(self):
+        """Creates webhook with enabled=False."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+
+        created_webhook = _create_mock_webhook(webhook_id=1, enabled=False)
+
+        call_count = 0
+
+        async def mock_execute(query):
+            nonlocal call_count
+            call_count += 1
+            if call_count == 1:
+                return Mock()
+            return _create_mock_result(first_item=created_webhook)
+
+        ap.persistence_mgr.execute_async = AsyncMock(side_effect=mock_execute)
+        ap.persistence_mgr.serialize_model = Mock(return_value={'id': 1, 'enabled': False})
+
+        service = WebhookService(ap)
+
+        # Execute
+        result = await service.create_webhook(name='Disabled', url='http://disabled.com', enabled=False)
+
+        # Verify
+        assert result['enabled'] is False
+
+
+class TestWebhookServiceGetWebhook:
+    """Tests for get_webhook method."""
+
+    async def test_get_webhook_by_id_found(self):
+        """Returns webhook when found by ID."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+
+        webhook = _create_mock_webhook(webhook_id=1, name='Found Webhook')
+        mock_result = _create_mock_result(first_item=webhook)
+        ap.persistence_mgr.execute_async = AsyncMock(return_value=mock_result)
+        ap.persistence_mgr.serialize_model = Mock(
+            return_value={
+                'id': 1,
+                'name': 'Found Webhook',
+                'url': 'http://example.com/webhook',
+            }
+        )
+
+        service = WebhookService(ap)
+
+        # Execute
+        result = await service.get_webhook(1)
+
+        # Verify
+        assert result is not None
+        assert result['id'] == 1
+        assert result['name'] == 'Found Webhook'
+
+    async def test_get_webhook_by_id_not_found(self):
+        """Returns None when webhook not found."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+
+        mock_result = _create_mock_result(first_item=None)
+        ap.persistence_mgr.execute_async = AsyncMock(return_value=mock_result)
+
+        service = WebhookService(ap)
+
+        # Execute
+        result = await service.get_webhook(999)
+
+        # Verify
+        assert result is None
+
+    async def test_get_webhook_by_id_zero(self):
+        """Handles ID=0 (edge case) correctly."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+
+        mock_result = _create_mock_result(first_item=None)
+        ap.persistence_mgr.execute_async = AsyncMock(return_value=mock_result)
+
+        service = WebhookService(ap)
+
+        # Execute
+        result = await service.get_webhook(0)
+
+        # Verify - should return None (no webhook with ID 0)
+        assert result is None
+
+
+class TestWebhookServiceUpdateWebhook:
+    """Tests for update_webhook method."""
+
+    async def test_update_webhook_name_only(self):
+        """Updates only the name field."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+        ap.persistence_mgr.execute_async = AsyncMock()
+
+        service = WebhookService(ap)
+
+        # Execute
+        await service.update_webhook(1, name='Updated Name')
+
+        # Verify
+        ap.persistence_mgr.execute_async.assert_called_once()
+
+    async def test_update_webhook_url_only(self):
+        """Updates only the url field."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+        ap.persistence_mgr.execute_async = AsyncMock()
+
+        service = WebhookService(ap)
+
+        # Execute
+        await service.update_webhook(1, url='http://updated.example.com')
+
+        # Verify
+        ap.persistence_mgr.execute_async.assert_called_once()
+
+    async def test_update_webhook_description_only(self):
+        """Updates only the description field."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+        ap.persistence_mgr.execute_async = AsyncMock()
+
+        service = WebhookService(ap)
+
+        # Execute
+        await service.update_webhook(1, description='Updated description')
+
+        # Verify
+        ap.persistence_mgr.execute_async.assert_called_once()
+
+    async def test_update_webhook_enabled_only(self):
+        """Updates only the enabled field."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+        ap.persistence_mgr.execute_async = AsyncMock()
+
+        service = WebhookService(ap)
+
+        # Execute
+        await service.update_webhook(1, enabled=False)
+
+        # Verify
+        ap.persistence_mgr.execute_async.assert_called_once()
+
+    async def test_update_webhook_all_fields(self):
+        """Updates all fields at once."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+        ap.persistence_mgr.execute_async = AsyncMock()
+
+        service = WebhookService(ap)
+
+        # Execute
+        await service.update_webhook(
+            1,
+            name='All Updated',
+            url='http://all.updated.com',
+            description='All updated description',
+            enabled=False,
+        )
+
+        # Verify
+        ap.persistence_mgr.execute_async.assert_called_once()
+
+    async def test_update_webhook_no_fields(self):
+        """Does nothing when no fields provided."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+        ap.persistence_mgr.execute_async = AsyncMock()
+
+        service = WebhookService(ap)
+
+        # Execute - no update parameters
+        await service.update_webhook(1)
+
+        # Verify - no execute call since no update_data
+        ap.persistence_mgr.execute_async.assert_not_called()
+
+
+class TestWebhookServiceDeleteWebhook:
+    """Tests for delete_webhook method."""
+
+    async def test_delete_webhook_by_id(self):
+        """Deletes webhook by ID."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+        ap.persistence_mgr.execute_async = AsyncMock()
+
+        service = WebhookService(ap)
+
+        # Execute
+        await service.delete_webhook(1)
+
+        # Verify
+        ap.persistence_mgr.execute_async.assert_called_once()
+
+    async def test_delete_webhook_nonexistent_id(self):
+        """Delete operation completes even for nonexistent ID."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+        ap.persistence_mgr.execute_async = AsyncMock()
+
+        service = WebhookService(ap)
+
+        # Execute - should not raise
+        await service.delete_webhook(999)
+
+        # Verify - still called
+        ap.persistence_mgr.execute_async.assert_called_once()
+
+
+class TestWebhookServiceGetEnabledWebhooks:
+    """Tests for get_enabled_webhooks method."""
+
+    async def test_get_enabled_webhooks_empty(self):
+        """Returns empty list when no enabled webhooks."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+        mock_result = _create_mock_result([])
+        ap.persistence_mgr.execute_async = AsyncMock(return_value=mock_result)
+        ap.persistence_mgr.serialize_model = Mock(return_value={})
+
+        service = WebhookService(ap)
+
+        # Execute
+        result = await service.get_enabled_webhooks()
+
+        # Verify
+        assert result == []
+
+    async def test_get_enabled_webhooks_filters_enabled(self):
+        """Returns only enabled webhooks."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+
+        # All returned webhooks should be enabled (SQL filter)
+        webhook1 = _create_mock_webhook(webhook_id=1, name='Enabled 1', enabled=True)
+        webhook2 = _create_mock_webhook(webhook_id=2, name='Enabled 2', enabled=True)
+
+        mock_result = _create_mock_result([webhook1, webhook2])
+        ap.persistence_mgr.execute_async = AsyncMock(return_value=mock_result)
+        ap.persistence_mgr.serialize_model = Mock(
+            side_effect=lambda model_cls, entity: {
+                'id': entity.id,
+                'name': entity.name,
+                'enabled': entity.enabled,
+            }
+        )
+
+        service = WebhookService(ap)
+
+        # Execute
+        result = await service.get_enabled_webhooks()
+
+        # Verify
+        assert len(result) == 2
+        assert all(w['enabled'] for w in result)
+
+    async def test_get_enabled_webhooks_filters_disabled(self):
+        """Does not return disabled webhooks."""
+        # Setup
+        ap = SimpleNamespace()
+        ap.persistence_mgr = SimpleNamespace()
+
+        # Empty result because query filters on enabled=True
+        mock_result = _create_mock_result([])
+        ap.persistence_mgr.execute_async = AsyncMock(return_value=mock_result)
+        ap.persistence_mgr.serialize_model = Mock(return_value={})
+
+        service = WebhookService(ap)
+
+        # Execute
+        result = await service.get_enabled_webhooks()
+
+        # Verify - should be empty (SQL would filter disabled)
+        assert result == []