jundot--omlx/tests/test_install_detection.py

"""Tests for installation method detection."""

from unittest.mock import patch

from omlx.utils.install import (
    get_app_bundle_cli_path,
    get_cli_command_prefix,
    get_cli_prefix,
    get_install_method,
    is_app_bundle,
    is_homebrew,
)


class TestInstallDetection:
    def test_not_app_bundle_in_dev(self):
        """Dev/pip install should not detect as app bundle."""
        assert not is_app_bundle()
        assert get_cli_prefix() == "omlx"

    def test_app_bundle_detected(self, tmp_path):
        """Simulate running inside .app bundle."""
        fake = "/Applications/oMLX.app/Contents/Resources/omlx/utils/install.py"
        with (
            patch("omlx.utils.install.__file__", fake),
            patch("omlx.utils.install.Path.home", return_value=tmp_path),
            patch("omlx.utils.install.shutil.which", return_value=None),
        ):
            assert is_app_bundle()
            assert get_cli_prefix() == "/Applications/oMLX.app/Contents/MacOS/omlx-cli"
            assert (
                str(get_app_bundle_cli_path())
                == "/Applications/oMLX.app/Contents/MacOS/omlx-cli"
            )

    def test_custom_app_location(self, tmp_path):
        """App bundle installed in non-standard location."""
        fake = "/Users/me/Apps/oMLX.app/Contents/Resources/omlx/utils/install.py"
        with (
            patch("omlx.utils.install.__file__", fake),
            patch("omlx.utils.install.Path.home", return_value=tmp_path),
            patch("omlx.utils.install.shutil.which", return_value=None),
        ):
            assert is_app_bundle()
            assert (
                get_cli_prefix()
                == "/Users/me/Apps/oMLX.app/Contents/MacOS/omlx-cli"
            )

    def test_app_bundle_uses_full_path_when_user_shim_is_not_on_path(self, tmp_path):
        """Installed app should not render bare omlx unless PATH resolves it."""
        fake = "/Applications/oMLX.app/Contents/Resources/omlx/utils/install.py"
        shim = tmp_path / ".omlx" / "bin" / "omlx"
        shim.parent.mkdir(parents=True)
        shim.write_text("#!/bin/sh\n")
        shim.chmod(0o755)
        with (
            patch("omlx.utils.install.__file__", fake),
            patch("omlx.utils.install.Path.home", return_value=tmp_path),
            patch("omlx.utils.install.shutil.which", return_value=None),
        ):
            assert get_cli_prefix() == "/Applications/oMLX.app/Contents/MacOS/omlx-cli"

    def test_app_bundle_uses_bare_omlx_when_path_resolves_user_shim(self, tmp_path):
        """Installed app should render the short command when PATH points at its shim."""
        fake = "/Applications/oMLX.app/Contents/Resources/omlx/utils/install.py"
        shim = tmp_path / ".omlx" / "bin" / "omlx"
        shim.parent.mkdir(parents=True)
        shim.write_text("#!/bin/sh\n")
        shim.chmod(0o755)
        with (
            patch("omlx.utils.install.__file__", fake),
            patch("omlx.utils.install.Path.home", return_value=tmp_path),
            patch("omlx.utils.install.shutil.which", return_value=str(shim)),
        ):
            assert get_cli_prefix() == "omlx"

    def test_app_bundle_uses_bare_omlx_when_path_resolves_public_symlink(self, tmp_path):
        """Public symlink to the user shim is app-managed."""
        fake = "/Applications/oMLX.app/Contents/Resources/omlx/utils/install.py"
        shim = tmp_path / ".omlx" / "bin" / "omlx"
        shim.parent.mkdir(parents=True)
        shim.write_text("#!/bin/sh\n")
        shim.chmod(0o755)
        public = tmp_path / "bin" / "omlx"
        public.parent.mkdir()
        public.symlink_to(shim)
        with (
            patch("omlx.utils.install.__file__", fake),
            patch("omlx.utils.install.Path.home", return_value=tmp_path),
            patch("omlx.utils.install.shutil.which", return_value=str(public)),
        ):
            assert get_cli_prefix() == "omlx"

    def test_cli_command_prefix_quotes_full_app_path(self, tmp_path):
        fake = "/Users/me/My Apps/oMLX.app/Contents/Resources/omlx/utils/install.py"
        with (
            patch("omlx.utils.install.__file__", fake),
            patch("omlx.utils.install.Path.home", return_value=tmp_path),
            patch("omlx.utils.install.shutil.which", return_value=None),
        ):
            assert (
                get_cli_command_prefix()
                == "'/Users/me/My Apps/oMLX.app/Contents/MacOS/omlx-cli'"
            )


class TestIsHomebrew:
    def test_not_homebrew_in_dev(self):
        """Dev/pip install should not detect as Homebrew."""
        assert not is_homebrew()

    def test_cellar_prefix(self):
        """Homebrew Cellar path detected."""
        with patch("omlx.utils.install.sys") as mock_sys:
            mock_sys.prefix = "/opt/homebrew/Cellar/omlx/0.3.0/libexec"
            assert is_homebrew()

    def test_homebrew_prefix(self):
        """Generic /homebrew/ path detected."""
        with patch("omlx.utils.install.sys") as mock_sys:
            mock_sys.prefix = "/usr/local/homebrew/opt/omlx/libexec"
            assert is_homebrew()

    def test_non_homebrew_prefix(self):
        """Regular venv should not detect as Homebrew."""
        with patch("omlx.utils.install.sys") as mock_sys:
            mock_sys.prefix = "/Users/me/.venv"
            assert not is_homebrew()


class TestGetInstallMethod:
    def test_dmg_takes_priority(self):
        """App bundle detection takes priority over Homebrew."""
        fake = "/Applications/oMLX.app/Contents/Resources/omlx/utils/install.py"
        with patch("omlx.utils.install.__file__", fake):
            assert get_install_method() == "dmg"

    def test_homebrew_detected(self):
        with patch("omlx.utils.install.sys") as mock_sys:
            mock_sys.prefix = "/opt/homebrew/Cellar/omlx/0.3.0/libexec"
            assert get_install_method() == "homebrew"

    def test_pip_default(self):
        """Default install method is pip."""
        assert get_install_method() == "pip"