9b395f5cc3
Build Chrome Extension / build (push) Waiting to run
Trigger Website Rebuild (Docs Updated) / dispatch (push) Waiting to run
E2E Headed Chrome / e2e-headed (macos-15) (push) Has been cancelled
E2E Headed Chrome / e2e-headed (ubuntu-latest) (push) Has been cancelled
E2E Headed Chrome / e2e-headed (windows-latest) (push) Has been cancelled
CI / build (macos-latest) (push) Has been cancelled
CI / build (ubuntu-latest) (push) Has been cancelled
CI / build (windows-latest) (push) Has been cancelled
CI / unit-test (push) Has been cancelled
CI / bun-test (push) Has been cancelled
CI / adapter-test (push) Has been cancelled
CI / smoke-test (macos-latest) (push) Has been cancelled
CI / smoke-test (ubuntu-latest) (push) Has been cancelled
Security Audit / audit (push) Has been cancelled
297 lines
14 KiB
JavaScript
297 lines
14 KiB
JavaScript
import { afterEach, describe, expect, it, vi } from 'vitest';
|
|
import { readFileSync } from 'node:fs';
|
|
import { dirname, resolve } from 'node:path';
|
|
import { fileURLToPath } from 'node:url';
|
|
import { getRegistry } from '@jackwener/opencli/registry';
|
|
import { CommandExecutionError, EmptyResultError } from '@jackwener/opencli/errors';
|
|
import './transcript.js';
|
|
|
|
const __dirname = dirname(fileURLToPath(import.meta.url));
|
|
const transcriptSource = readFileSync(resolve(__dirname, 'transcript.js'), 'utf8');
|
|
|
|
function createPageMock(captionUrl) {
|
|
const page = {
|
|
goto: vi.fn().mockResolvedValue(undefined),
|
|
wait: vi.fn().mockResolvedValue(undefined),
|
|
evaluate: vi.fn(),
|
|
};
|
|
page.evaluate
|
|
.mockResolvedValueOnce(null)
|
|
.mockResolvedValueOnce({
|
|
captionUrl,
|
|
language: 'en',
|
|
kind: 'manual',
|
|
available: ['en'],
|
|
requestedLang: null,
|
|
langMatched: false,
|
|
langPrefixMatched: false,
|
|
})
|
|
.mockResolvedValue([{ start: 1, end: 3, text: 'hello & world' }]);
|
|
return page;
|
|
}
|
|
|
|
afterEach(() => {
|
|
vi.unstubAllGlobals();
|
|
});
|
|
|
|
describe('youtube transcript source contract', () => {
|
|
it('uses the watch player captions module before falling back to watch HTML, not Android InnerTube', () => {
|
|
expect(transcriptSource).toContain("player.loadModule?.('captions')");
|
|
expect(transcriptSource).toContain("player.setOption('captions', 'track', track)");
|
|
expect(transcriptSource).toContain("url.includes('pot=')");
|
|
expect(transcriptSource).toContain("fetch('/watch?v='");
|
|
expect(transcriptSource).toContain("extractJsonAssignmentFromHtml(html, 'ytInitialPlayerResponse')");
|
|
expect(transcriptSource).toContain('playerCaptionsTracklistRenderer');
|
|
expect(transcriptSource).not.toContain('/youtubei/v1/player');
|
|
expect(transcriptSource).not.toContain("clientName: 'ANDROID'");
|
|
});
|
|
|
|
it('normalizes caption URL to request srv3 XML format', () => {
|
|
expect(transcriptSource).toContain('fmt=srv3');
|
|
});
|
|
|
|
it('checks HTTP status before reading caption response body', () => {
|
|
expect(transcriptSource).toContain('resp.ok');
|
|
});
|
|
|
|
it('restores page fetch and XHR hooks even when caption probing exits early', () => {
|
|
expect(transcriptSource).toContain('} finally {');
|
|
expect(transcriptSource).toContain('globalThis.fetch = originalFetch');
|
|
expect(transcriptSource).toContain('globalThis.XMLHttpRequest = OriginalXHR');
|
|
});
|
|
|
|
it('scopes timedtext URL matching to the current videoId in both in-page paths', () => {
|
|
// YouTube is an SPA — daemon-shared tabs preserve prior videos'
|
|
// performance.getEntriesByType('resource') across watch→watch navigations.
|
|
// Both findTimedtextUrl (resource buffer) and isJson3TimedtextUrl (fetch/XHR
|
|
// hook) must require the URL contain v=<currentVideoId>, otherwise a
|
|
// previously-viewed same-language video's captions can be returned.
|
|
expect(transcriptSource).toContain('const targetVideoId = ');
|
|
expect(transcriptSource).toContain("parsed.searchParams.get('v') === targetVideoId");
|
|
expect(transcriptSource).toContain('timedtextUrlMatchesVideo(url)');
|
|
});
|
|
});
|
|
|
|
describe('youtube transcript caption fetch', () => {
|
|
const command = getRegistry().get('youtube/transcript');
|
|
|
|
it('requests srv3 when the caption track URL has no explicit format', async () => {
|
|
const page = createPageMock('https://www.youtube.com/api/timedtext?v=abc&lang=en');
|
|
|
|
const rows = await command.func(page, { url: 'abc', mode: 'raw' });
|
|
|
|
expect(page.evaluate.mock.calls[2][0]).toContain('const primaryUrl = "https://www.youtube.com/api/timedtext?v=abc&lang=en&fmt=srv3"');
|
|
expect(page.evaluate.mock.calls[2][0]).toContain('const originalUrl = "https://www.youtube.com/api/timedtext?v=abc&lang=en"');
|
|
expect(rows).toEqual([{ index: 1, start: '1.00s', end: '3.00s', text: 'hello & world' }]);
|
|
});
|
|
|
|
it('uses Browser Bridge envelope-wrapped player caption segments without fallback', async () => {
|
|
const page = {
|
|
goto: vi.fn().mockResolvedValue(undefined),
|
|
wait: vi.fn().mockResolvedValue(undefined),
|
|
evaluate: vi.fn().mockResolvedValueOnce({
|
|
session: 'browser:default',
|
|
data: [{ start: 2, end: 4.5, text: 'from player captions' }],
|
|
}),
|
|
};
|
|
|
|
const rows = await command.func(page, { url: 'abc', mode: 'raw' });
|
|
|
|
expect(page.evaluate).toHaveBeenCalledTimes(1);
|
|
expect(rows).toEqual([{ index: 1, start: '2.00s', end: '4.50s', text: 'from player captions' }]);
|
|
});
|
|
|
|
it('uses captured timedtext json3 when player selection returns no segments', async () => {
|
|
const page = {
|
|
goto: vi.fn().mockResolvedValue(undefined),
|
|
wait: vi.fn().mockResolvedValue(undefined),
|
|
startNetworkCapture: vi.fn().mockResolvedValue(undefined),
|
|
readNetworkCapture: vi.fn().mockResolvedValue({
|
|
session: 'browser:default',
|
|
data: [{
|
|
url: 'https://www.youtube.com/api/timedtext?v=abc&lang=en&fmt=json3&pot=token',
|
|
responsePreview: JSON.stringify({
|
|
events: [
|
|
{ tStartMs: 1000, dDurationMs: 1500, segs: [{ utf8: 'hello ' }, { utf8: 'capture' }] },
|
|
],
|
|
}),
|
|
}],
|
|
}),
|
|
evaluate: vi.fn().mockResolvedValueOnce(null),
|
|
};
|
|
|
|
const rows = await command.func(page, { url: 'abc', mode: 'raw', lang: 'en' });
|
|
|
|
expect(page.startNetworkCapture).toHaveBeenCalledWith('/api/timedtext');
|
|
expect(page.evaluate).toHaveBeenCalledTimes(1);
|
|
expect(rows).toEqual([{ index: 1, start: '1.00s', end: '2.50s', text: 'hello capture' }]);
|
|
});
|
|
|
|
it('ignores captured timedtext entries from a prior video and uses only the current videoId', async () => {
|
|
// Regression: opencli daemon reuses one Chrome tab across sequential
|
|
// youtube transcript calls. YouTube's SPA navigation between watch URLs
|
|
// leaves prior videos' timedtext entries in performance.getEntriesByType
|
|
// and (rarely) in the CDP capture buffer. Without filtering by videoId,
|
|
// the same-language predecessor's captions can leak into the current row.
|
|
const page = {
|
|
goto: vi.fn().mockResolvedValue(undefined),
|
|
wait: vi.fn().mockResolvedValue(undefined),
|
|
startNetworkCapture: vi.fn().mockResolvedValue(undefined),
|
|
readNetworkCapture: vi.fn().mockResolvedValue({
|
|
session: 'browser:default',
|
|
data: [
|
|
{
|
|
// Stale entry from a prior watch on the shared tab — must be ignored.
|
|
url: 'https://www.youtube.com/api/timedtext?v=prev&lang=en&fmt=json3&pot=token',
|
|
responsePreview: JSON.stringify({
|
|
events: [
|
|
{ tStartMs: 0, dDurationMs: 1000, segs: [{ utf8: 'WRONG video captions' }] },
|
|
],
|
|
}),
|
|
},
|
|
{
|
|
// Prefix collision: substring matching for "v=abc" would accept this.
|
|
url: 'https://www.youtube.com/api/timedtext?v=abcd&lang=en&fmt=json3&pot=token',
|
|
responsePreview: JSON.stringify({
|
|
events: [
|
|
{ tStartMs: 1000, dDurationMs: 1000, segs: [{ utf8: 'WRONG prefix captions' }] },
|
|
],
|
|
}),
|
|
},
|
|
{
|
|
// Current video's captions.
|
|
url: 'https://www.youtube.com/api/timedtext?v=abc&lang=en&fmt=json3&pot=token',
|
|
responsePreview: JSON.stringify({
|
|
events: [
|
|
{ tStartMs: 2000, dDurationMs: 1000, segs: [{ utf8: 'right captions' }] },
|
|
],
|
|
}),
|
|
},
|
|
],
|
|
}),
|
|
evaluate: vi.fn().mockResolvedValueOnce(null),
|
|
};
|
|
|
|
const rows = await command.func(page, { url: 'abc', mode: 'raw', lang: 'en' });
|
|
|
|
expect(rows).toEqual([{ index: 1, start: '2.00s', end: '3.00s', text: 'right captions' }]);
|
|
});
|
|
|
|
it('does not override an existing caption format', async () => {
|
|
const page = createPageMock('https://www.youtube.com/api/timedtext?v=abc&lang=en&fmt=vtt');
|
|
|
|
await command.func(page, { url: 'abc', mode: 'raw' });
|
|
|
|
expect(page.evaluate.mock.calls[2][0]).toContain('const primaryUrl = "https://www.youtube.com/api/timedtext?v=abc&lang=en&fmt=vtt"');
|
|
expect(page.evaluate.mock.calls[2][0]).toContain('const originalUrl = "https://www.youtube.com/api/timedtext?v=abc&lang=en&fmt=vtt"');
|
|
});
|
|
|
|
it('falls back to the original URL only after an empty successful srv3 response', async () => {
|
|
const page = createPageMock('https://www.youtube.com/api/timedtext?v=abc&lang=en');
|
|
|
|
await command.func(page, { url: 'abc', mode: 'raw' });
|
|
|
|
const script = page.evaluate.mock.calls[2][0];
|
|
expect(script).toContain('if (!result.xml.length && originalUrl !== primaryUrl)');
|
|
expect(script).toContain('result = await fetchCaptionXml(originalUrl)');
|
|
expect(script).toContain('if (result.error) {');
|
|
});
|
|
|
|
it('fails typed on caption HTTP errors instead of falling back silently', async () => {
|
|
const page = createPageMock('https://www.youtube.com/api/timedtext?v=abc&lang=en');
|
|
page.evaluate.mockReset();
|
|
page.evaluate
|
|
.mockResolvedValueOnce(null)
|
|
.mockResolvedValueOnce({
|
|
captionUrl: 'https://www.youtube.com/api/timedtext?v=abc&lang=en',
|
|
language: 'en',
|
|
kind: 'manual',
|
|
available: ['en'],
|
|
requestedLang: null,
|
|
langMatched: false,
|
|
langPrefixMatched: false,
|
|
})
|
|
.mockResolvedValueOnce({ error: 'Caption URL returned HTTP 503' });
|
|
|
|
await expect(command.func(page, { url: 'abc', mode: 'raw' })).rejects.toMatchObject({
|
|
code: 'COMMAND_EXEC',
|
|
message: expect.stringContaining('HTTP 503'),
|
|
});
|
|
});
|
|
|
|
it('fails typed on malformed browser extraction payloads', async () => {
|
|
const page = createPageMock('https://www.youtube.com/api/timedtext?v=abc&lang=en');
|
|
page.evaluate.mockReset();
|
|
page.evaluate
|
|
.mockResolvedValueOnce(null)
|
|
.mockResolvedValueOnce({
|
|
captionUrl: 'https://www.youtube.com/api/timedtext?v=abc&lang=en',
|
|
language: 'en',
|
|
kind: 'manual',
|
|
available: ['en'],
|
|
requestedLang: null,
|
|
langMatched: false,
|
|
langPrefixMatched: false,
|
|
})
|
|
.mockResolvedValueOnce({ session: 'browser:default', data: { rows: [] } });
|
|
|
|
await expect(command.func(page, { url: 'abc', mode: 'raw' })).rejects.toMatchObject({
|
|
code: 'COMMAND_EXEC',
|
|
message: expect.stringContaining('Malformed caption XML extraction payload'),
|
|
});
|
|
});
|
|
|
|
it('fails typed on malformed caption info payloads before URL construction', async () => {
|
|
const page = createPageMock('https://www.youtube.com/api/timedtext?v=abc&lang=en');
|
|
page.evaluate.mockReset();
|
|
page.evaluate
|
|
.mockResolvedValueOnce(null)
|
|
.mockResolvedValueOnce({ session: 'browser:default', data: { rows: [] } });
|
|
|
|
await expect(command.func(page, { url: 'abc', mode: 'raw' })).rejects.toMatchObject({
|
|
code: 'COMMAND_EXEC',
|
|
message: expect.stringContaining('Malformed caption info payload'),
|
|
});
|
|
});
|
|
|
|
it('maps explicit no-captions watch metadata to EmptyResultError', async () => {
|
|
const page = createPageMock('https://www.youtube.com/api/timedtext?v=abc&lang=en');
|
|
page.evaluate.mockReset();
|
|
page.evaluate
|
|
.mockResolvedValueOnce(null)
|
|
.mockResolvedValueOnce({ error: 'No captions available for this video' });
|
|
|
|
await expect(command.func(page, { url: 'abc', mode: 'raw' })).rejects.toBeInstanceOf(EmptyResultError);
|
|
});
|
|
|
|
it('keeps malformed watch metadata as CommandExecutionError', async () => {
|
|
const page = createPageMock('https://www.youtube.com/api/timedtext?v=abc&lang=en');
|
|
page.evaluate.mockReset();
|
|
page.evaluate
|
|
.mockResolvedValueOnce(null)
|
|
.mockResolvedValueOnce({ error: 'ytInitialPlayerResponse not found in watch HTML' });
|
|
|
|
await expect(command.func(page, { url: 'abc', mode: 'raw' })).rejects.toBeInstanceOf(CommandExecutionError);
|
|
});
|
|
|
|
it('fails typed on malformed captured timedtext json3', async () => {
|
|
const page = {
|
|
goto: vi.fn().mockResolvedValue(undefined),
|
|
wait: vi.fn().mockResolvedValue(undefined),
|
|
startNetworkCapture: vi.fn().mockResolvedValue(undefined),
|
|
readNetworkCapture: vi.fn().mockResolvedValue([
|
|
{
|
|
url: 'https://www.youtube.com/api/timedtext?v=abc&lang=en&fmt=json3&pot=token',
|
|
responsePreview: '{"events":',
|
|
},
|
|
]),
|
|
evaluate: vi.fn().mockResolvedValueOnce(null),
|
|
};
|
|
|
|
await expect(command.func(page, { url: 'abc', mode: 'raw', lang: 'en' })).rejects.toMatchObject({
|
|
code: 'COMMAND_EXEC',
|
|
message: expect.stringContaining('Malformed json3 timedtext response'),
|
|
});
|
|
});
|
|
});
|