85453da49f
regression / regression-shards (style-16-prod style-9-prod style-17-prod iframe-render-compat variables-prod mp4-h265-sdr, shard-4) (push) Has been cancelled
regression / regression-shards (style-4-prod style-11-prod style-2-prod animejs-adapter typegpu-adapter parallel-capture-regression, shard-5) (push) Has been cancelled
regression / regression-shards (style-7-prod style-8-prod style-10-prod css-spinner-render-compat webm-transparency mp4-h264-sdr webm-vp9, shard-3) (push) Has been cancelled
regression / regression-shards (sub-composition-video style-18-prod raf-ball-render-compat font-variant-numeric sub-comp-t0 sub-comp-id-selector, shard-7) (push) Has been cancelled
Windows render verification / Detect changes (push) Has been cancelled
Windows render verification / Preflight (lint + format) (push) Has been cancelled
Windows render verification / Render on windows-latest (push) Has been cancelled
Windows render verification / Tests on windows-latest (push) Has been cancelled
CI / Detect changes (push) Has been cancelled
CI / Build (push) Has been cancelled
CI / Lint (push) Has been cancelled
CI / Fallow audit (push) Has been cancelled
CI / Format (push) Has been cancelled
CI / Typecheck (push) Has been cancelled
CI / Test (push) Has been cancelled
CI / Producer: integration tests (push) Has been cancelled
CI / Producer: unit tests (push) Has been cancelled
CI / File size check (push) Has been cancelled
CI / Test: skills (push) Has been cancelled
CI / Skills: manifest in sync (push) Has been cancelled
CI / CLI: npx shim (macos-latest) (push) Has been cancelled
CI / CLI: npx shim (ubuntu-latest) (push) Has been cancelled
CI / CLI: npx shim (windows-latest) (push) Has been cancelled
CI / SDK: unit + contract + smoke (push) Has been cancelled
CI / Test: runtime contract (push) Has been cancelled
CI / Studio: load smoke (push) Has been cancelled
CI / Smoke: global install (push) Has been cancelled
CI / CLI smoke (required) (push) Has been cancelled
CI / Semantic PR title (push) Has been cancelled
Player perf / Detect changes (push) Has been cancelled
Player perf / Preflight (lint + format) (push) Has been cancelled
Player perf / player-perf (push) Has been cancelled
Player perf / Perf: drift (push) Has been cancelled
Player perf / Perf: fps (push) Has been cancelled
Player perf / Perf: parity (push) Has been cancelled
Player perf / Perf: scrub (push) Has been cancelled
Player perf / Perf: load (push) Has been cancelled
preview-regression / Detect changes (push) Has been cancelled
preview-regression / Preflight (lint + format) (push) Has been cancelled
preview-regression / Preview parity (push) Has been cancelled
preview-regression / preview-regression (push) Has been cancelled
regression / regression (push) Has been cancelled
regression / Detect changes (push) Has been cancelled
regression / Preflight (lint + format) (push) Has been cancelled
regression / regression-shards (hdr-regression style-5-prod style-3-prod mov-prores, shard-1) (push) Has been cancelled
regression / regression-shards (overlay-montage-prod style-12-prod chat missing-host-comp-id png-sequence portrait-edge-bleed, shard-6) (push) Has been cancelled
regression / regression-shards (style-13-prod style-6-prod vignelli-stacking gsap-letters-render-compat audio-mux-parity, shard-8) (push) Has been cancelled
regression / regression-shards (style-15-prod hdr-hlg-regression style-1-prod many-cuts vfr-screen-recording render-symlinked-assets, shard-2) (push) Has been cancelled
CodeQL / Analyze (actions) (push) Has been cancelled
CodeQL / Analyze (javascript-typescript) (push) Has been cancelled
CodeQL / Analyze (python) (push) Has been cancelled
Docs / Validate docs (push) Has been cancelled
Sync skills to ClawHub / Publish changed skills (push) Has been cancelled
159 lines
5.1 KiB
JavaScript
159 lines
5.1 KiB
JavaScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { EventEmitter } from "node:events";
|
|
import {
|
|
resolveNpxCliFromNpmExecPath,
|
|
resolveNpxCliPath,
|
|
resolveSpawnCommand,
|
|
spawnP,
|
|
_resetNpxResolutionWarnForTests,
|
|
} from "./tts.mjs";
|
|
|
|
// Regression: on Windows, npx resolves to npx.cmd, which spawn() cannot exec
|
|
// without shell:true — it fails ENOENT, silently swallowed as ok:false by the
|
|
// caller. spawnP takes injectable platform/spawnFn params so this doesn't
|
|
// need to touch the real process.platform or mock node:child_process (whose
|
|
// ESM exports are non-configurable).
|
|
function fakeSpawn(captured) {
|
|
return (cmd, args, opts) => {
|
|
captured.push({ cmd, args, opts });
|
|
const p = new EventEmitter();
|
|
setImmediate(() => p.emit("exit", 0));
|
|
return p;
|
|
};
|
|
}
|
|
|
|
const envWithNpxCli = {
|
|
npm_execpath: "/opt/node/lib/node_modules/npm/bin/npm-cli.js",
|
|
npm_node_execpath: "/opt/node/bin/node",
|
|
};
|
|
const npxCliPath = "/opt/node/lib/node_modules/npm/bin/npx-cli.js";
|
|
const pathExists = (path) => path === npxCliPath;
|
|
|
|
test("resolveNpxCliFromNpmExecPath finds npx-cli next to npm-cli", () => {
|
|
assert.equal(resolveNpxCliFromNpmExecPath(envWithNpxCli.npm_execpath, pathExists), npxCliPath);
|
|
});
|
|
|
|
test("resolveNpxCliPath finds npx-cli beside node when npm_execpath is unset", () => {
|
|
const node = "C:/Program Files/nodejs/node.exe";
|
|
const expected = "C:/Program Files/nodejs/node_modules/npm/bin/npx-cli.js";
|
|
assert.equal(
|
|
resolveNpxCliPath(undefined, node, (path) => path === expected),
|
|
expected,
|
|
);
|
|
});
|
|
|
|
test("resolveSpawnCommand routes npx through node+npx-cli on win32 without shell:true", () => {
|
|
const resolved = resolveSpawnCommand(
|
|
"npx",
|
|
["hyperframes", "tts", "C:\\Users\\Test User\\line.txt", "--voice", "am_michael"],
|
|
{},
|
|
"win32",
|
|
envWithNpxCli,
|
|
pathExists,
|
|
);
|
|
assert.ok(resolved);
|
|
assert.equal(resolved.cmd, envWithNpxCli.npm_node_execpath);
|
|
assert.deepEqual(resolved.args, [
|
|
npxCliPath,
|
|
"hyperframes",
|
|
"tts",
|
|
"C:\\Users\\Test User\\line.txt",
|
|
"--voice",
|
|
"am_michael",
|
|
]);
|
|
assert.equal(resolved.opts.shell, undefined);
|
|
});
|
|
|
|
test("resolveSpawnCommand preserves Windows npx shell metacharacters as argv data", () => {
|
|
const resolved = resolveSpawnCommand(
|
|
"npx",
|
|
["hyperframes", "tts", "hello & calc"],
|
|
{},
|
|
"win32",
|
|
envWithNpxCli,
|
|
pathExists,
|
|
);
|
|
assert.ok(resolved);
|
|
assert.deepEqual(resolved.args, [npxCliPath, "hyperframes", "tts", "hello & calc"]);
|
|
});
|
|
|
|
test("spawnP uses the resolved node+npx-cli command for npx on win32", async () => {
|
|
const captured = [];
|
|
await spawnP(
|
|
"npx",
|
|
["hyperframes", "tts"],
|
|
{},
|
|
"win32",
|
|
fakeSpawn(captured),
|
|
envWithNpxCli,
|
|
pathExists,
|
|
);
|
|
assert.equal(captured.length, 1);
|
|
assert.equal(captured[0].cmd, envWithNpxCli.npm_node_execpath);
|
|
assert.deepEqual(captured[0].args, [npxCliPath, "hyperframes", "tts"]);
|
|
assert.equal(captured[0].opts.shell, undefined);
|
|
});
|
|
|
|
test("spawnP does not enable shell for npx on darwin/linux", async () => {
|
|
const captured = [];
|
|
await spawnP("npx", ["hyperframes", "tts"], {}, "darwin", fakeSpawn(captured));
|
|
assert.equal(captured[0].cmd, "npx");
|
|
assert.deepEqual(captured[0].args, ["hyperframes", "tts"]);
|
|
assert.equal(captured[0].opts.shell, undefined);
|
|
});
|
|
|
|
test("spawnP does not enable shell for non-npx commands even on win32", async () => {
|
|
const captured = [];
|
|
await spawnP("python3", ["-c", "pass"], {}, "win32", fakeSpawn(captured));
|
|
assert.equal(captured[0].cmd, "python3");
|
|
assert.deepEqual(captured[0].args, ["-c", "pass"]);
|
|
assert.equal(captured[0].opts.shell, undefined);
|
|
});
|
|
|
|
test("spawnP resolves npx beside node when npm_execpath is unset on win32", async () => {
|
|
_resetNpxResolutionWarnForTests();
|
|
const captured = [];
|
|
const node = "C:/Program Files/nodejs/node.exe";
|
|
const npxCli = "C:/Program Files/nodejs/node_modules/npm/bin/npx-cli.js";
|
|
const result = await spawnP(
|
|
"npx",
|
|
["hyperframes", "tts"],
|
|
{},
|
|
"win32",
|
|
fakeSpawn(captured),
|
|
{ npm_node_execpath: node },
|
|
(path) => path === npxCli,
|
|
);
|
|
assert.equal(result.status, 0);
|
|
assert.equal(captured.length, 1);
|
|
assert.equal(captured[0].cmd, node);
|
|
assert.deepEqual(captured[0].args, [npxCli, "hyperframes", "tts"]);
|
|
});
|
|
|
|
test("spawnP warns once with an accurate diagnostic when neither npx path exists", async () => {
|
|
_resetNpxResolutionWarnForTests();
|
|
const errors = [];
|
|
const originalError = console.error;
|
|
console.error = (message) => errors.push(String(message));
|
|
try {
|
|
const env = { npm_execpath: "C:/missing/npm-cli.js", npm_node_execpath: "C:/node/node.exe" };
|
|
const missing = () => false;
|
|
assert.equal(
|
|
(await spawnP("npx", ["hyperframes", "tts"], {}, "win32", fakeSpawn([]), env, missing))
|
|
.status,
|
|
-1,
|
|
);
|
|
assert.equal(
|
|
(await spawnP("npx", ["hyperframes", "tts"], {}, "win32", fakeSpawn([]), env, missing))
|
|
.status,
|
|
-1,
|
|
);
|
|
} finally {
|
|
console.error = originalError;
|
|
}
|
|
assert.equal(errors.length, 1);
|
|
assert.match(errors[0], /npm_execpath \(C:\/missing\/npm-cli\.js\)/);
|
|
assert.doesNotMatch(errors[0], /npm_execpath is not set/);
|
|
});
|