chore: import upstream snapshot with attribution
regression / regression-shards (style-16-prod style-9-prod style-17-prod iframe-render-compat variables-prod mp4-h265-sdr, shard-4) (push) Has been cancelled
regression / regression-shards (style-4-prod style-11-prod style-2-prod animejs-adapter typegpu-adapter parallel-capture-regression, shard-5) (push) Has been cancelled
regression / regression-shards (style-7-prod style-8-prod style-10-prod css-spinner-render-compat webm-transparency mp4-h264-sdr webm-vp9, shard-3) (push) Has been cancelled
regression / regression-shards (sub-composition-video style-18-prod raf-ball-render-compat font-variant-numeric sub-comp-t0 sub-comp-id-selector, shard-7) (push) Has been cancelled
Windows render verification / Detect changes (push) Has been cancelled
Windows render verification / Preflight (lint + format) (push) Has been cancelled
Windows render verification / Render on windows-latest (push) Has been cancelled
Windows render verification / Tests on windows-latest (push) Has been cancelled
CI / Detect changes (push) Has been cancelled
CI / Build (push) Has been cancelled
CI / Lint (push) Has been cancelled
CI / Fallow audit (push) Has been cancelled
CI / Format (push) Has been cancelled
CI / Typecheck (push) Has been cancelled
CI / Test (push) Has been cancelled
CI / Producer: integration tests (push) Has been cancelled
CI / Producer: unit tests (push) Has been cancelled
CI / File size check (push) Has been cancelled
CI / Test: skills (push) Has been cancelled
CI / Skills: manifest in sync (push) Has been cancelled
CI / CLI: npx shim (macos-latest) (push) Has been cancelled
CI / CLI: npx shim (ubuntu-latest) (push) Has been cancelled
CI / CLI: npx shim (windows-latest) (push) Has been cancelled
CI / SDK: unit + contract + smoke (push) Has been cancelled
CI / Test: runtime contract (push) Has been cancelled
CI / Studio: load smoke (push) Has been cancelled
CI / Smoke: global install (push) Has been cancelled
CI / CLI smoke (required) (push) Has been cancelled
CI / Semantic PR title (push) Has been cancelled
Player perf / Detect changes (push) Has been cancelled
Player perf / Preflight (lint + format) (push) Has been cancelled
Player perf / player-perf (push) Has been cancelled
Player perf / Perf: drift (push) Has been cancelled
Player perf / Perf: fps (push) Has been cancelled
Player perf / Perf: parity (push) Has been cancelled
Player perf / Perf: scrub (push) Has been cancelled
Player perf / Perf: load (push) Has been cancelled
preview-regression / Detect changes (push) Has been cancelled
preview-regression / Preflight (lint + format) (push) Has been cancelled
preview-regression / Preview parity (push) Has been cancelled
preview-regression / preview-regression (push) Has been cancelled
regression / regression (push) Has been cancelled
regression / Detect changes (push) Has been cancelled
regression / Preflight (lint + format) (push) Has been cancelled
regression / regression-shards (hdr-regression style-5-prod style-3-prod mov-prores, shard-1) (push) Has been cancelled
regression / regression-shards (overlay-montage-prod style-12-prod chat missing-host-comp-id png-sequence portrait-edge-bleed, shard-6) (push) Has been cancelled
regression / regression-shards (style-13-prod style-6-prod vignelli-stacking gsap-letters-render-compat audio-mux-parity, shard-8) (push) Has been cancelled
regression / regression-shards (style-15-prod hdr-hlg-regression style-1-prod many-cuts vfr-screen-recording render-symlinked-assets, shard-2) (push) Has been cancelled
CodeQL / Analyze (actions) (push) Has been cancelled
CodeQL / Analyze (javascript-typescript) (push) Has been cancelled
CodeQL / Analyze (python) (push) Has been cancelled
Docs / Validate docs (push) Has been cancelled
Sync skills to ClawHub / Publish changed skills (push) Has been cancelled
regression / regression-shards (style-16-prod style-9-prod style-17-prod iframe-render-compat variables-prod mp4-h265-sdr, shard-4) (push) Has been cancelled
regression / regression-shards (style-4-prod style-11-prod style-2-prod animejs-adapter typegpu-adapter parallel-capture-regression, shard-5) (push) Has been cancelled
regression / regression-shards (style-7-prod style-8-prod style-10-prod css-spinner-render-compat webm-transparency mp4-h264-sdr webm-vp9, shard-3) (push) Has been cancelled
regression / regression-shards (sub-composition-video style-18-prod raf-ball-render-compat font-variant-numeric sub-comp-t0 sub-comp-id-selector, shard-7) (push) Has been cancelled
Windows render verification / Detect changes (push) Has been cancelled
Windows render verification / Preflight (lint + format) (push) Has been cancelled
Windows render verification / Render on windows-latest (push) Has been cancelled
Windows render verification / Tests on windows-latest (push) Has been cancelled
CI / Detect changes (push) Has been cancelled
CI / Build (push) Has been cancelled
CI / Lint (push) Has been cancelled
CI / Fallow audit (push) Has been cancelled
CI / Format (push) Has been cancelled
CI / Typecheck (push) Has been cancelled
CI / Test (push) Has been cancelled
CI / Producer: integration tests (push) Has been cancelled
CI / Producer: unit tests (push) Has been cancelled
CI / File size check (push) Has been cancelled
CI / Test: skills (push) Has been cancelled
CI / Skills: manifest in sync (push) Has been cancelled
CI / CLI: npx shim (macos-latest) (push) Has been cancelled
CI / CLI: npx shim (ubuntu-latest) (push) Has been cancelled
CI / CLI: npx shim (windows-latest) (push) Has been cancelled
CI / SDK: unit + contract + smoke (push) Has been cancelled
CI / Test: runtime contract (push) Has been cancelled
CI / Studio: load smoke (push) Has been cancelled
CI / Smoke: global install (push) Has been cancelled
CI / CLI smoke (required) (push) Has been cancelled
CI / Semantic PR title (push) Has been cancelled
Player perf / Detect changes (push) Has been cancelled
Player perf / Preflight (lint + format) (push) Has been cancelled
Player perf / player-perf (push) Has been cancelled
Player perf / Perf: drift (push) Has been cancelled
Player perf / Perf: fps (push) Has been cancelled
Player perf / Perf: parity (push) Has been cancelled
Player perf / Perf: scrub (push) Has been cancelled
Player perf / Perf: load (push) Has been cancelled
preview-regression / Detect changes (push) Has been cancelled
preview-regression / Preflight (lint + format) (push) Has been cancelled
preview-regression / Preview parity (push) Has been cancelled
preview-regression / preview-regression (push) Has been cancelled
regression / regression (push) Has been cancelled
regression / Detect changes (push) Has been cancelled
regression / Preflight (lint + format) (push) Has been cancelled
regression / regression-shards (hdr-regression style-5-prod style-3-prod mov-prores, shard-1) (push) Has been cancelled
regression / regression-shards (overlay-montage-prod style-12-prod chat missing-host-comp-id png-sequence portrait-edge-bleed, shard-6) (push) Has been cancelled
regression / regression-shards (style-13-prod style-6-prod vignelli-stacking gsap-letters-render-compat audio-mux-parity, shard-8) (push) Has been cancelled
regression / regression-shards (style-15-prod hdr-hlg-regression style-1-prod many-cuts vfr-screen-recording render-symlinked-assets, shard-2) (push) Has been cancelled
CodeQL / Analyze (actions) (push) Has been cancelled
CodeQL / Analyze (javascript-typescript) (push) Has been cancelled
CodeQL / Analyze (python) (push) Has been cancelled
Docs / Validate docs (push) Has been cancelled
Sync skills to ClawHub / Publish changed skills (push) Has been cancelled
This commit is contained in:
@@ -0,0 +1,64 @@
|
||||
# locate — find "X" in an image (no detector API assumed)
|
||||
|
||||
The single contract every consumer (asset-fusion ring, webpage highlight, future
|
||||
explainer/recut overlays) uses:
|
||||
|
||||
```
|
||||
locate(image, target-description) → { box: [x0,y0,x1,y1], center: [cx,cy] } # normalized 0..1
|
||||
```
|
||||
|
||||
## Why this exists
|
||||
|
||||
Author models are unreliable at **regressing pixel coordinates** on a cluttered
|
||||
full image (measured: weak vision models ~16–24% center error → rings land off-target)
|
||||
but reliable at **picking a numbered strip** (~3–4% with the loop below). So:
|
||||
never eyeball coordinates; localize by discrete choice. (RSVP, ACL 2025.)
|
||||
|
||||
## Routing — pick the cheapest path that's actually available
|
||||
|
||||
1. **A strong detector is available** (e.g. `GEMINI_API_KEY` in env) →
|
||||
`node grounding/locate.mjs auto <img> "<target>"` — one call, done.
|
||||
**Never assume the key exists.** No key → path 2.
|
||||
2. **No detector (the normal case)** → YOU are the localizer; run the grid loop.
|
||||
|
||||
## The grid loop (you read images between steps)
|
||||
|
||||
```
|
||||
node grounding/locate.mjs overlay <img> --out /tmp/g
|
||||
→ READ /tmp/g/gv.png (vertical strips 1-9) and gh.png (horizontal 1-9);
|
||||
decide which strip numbers the target spans (list EVERY strip it touches).
|
||||
node grounding/locate.mjs region <img> --vids 4,5 --hids 6,7 --out /tmp/g
|
||||
→ READ /tmp/g/gc.png (the region cropped + upscaled, finer 6×6 grid);
|
||||
pick the finer strips. (Pick strips again — do NOT switch to estimating
|
||||
coordinates; discrete choice is the whole point, at BOTH stages.)
|
||||
node grounding/locate.mjs final <img> --region <from step 2> --vids 3,4 --hids 3,4
|
||||
→ the final {box, center}.
|
||||
node grounding/locate.mjs mark <img> --box <final box> --out /tmp/g/check.png
|
||||
→ VERIFY: READ check.png. Red box ON the target → done. Off → redo
|
||||
region/final with corrected strips (you now know which direction). Never
|
||||
skip this step; it converts silent misses into one cheap retry.
|
||||
```
|
||||
|
||||
## Ambiguity — resolve BEFORE localizing
|
||||
|
||||
If the target description can match several instances ("a drum" when the scene
|
||||
has five), no geometry will save you. First make the reference unique
|
||||
("the right-most drum", "the drum on the front boat"), asking the user if
|
||||
needed — then run the loop.
|
||||
|
||||
## Degradation path (if locate.mjs itself is unavailable)
|
||||
|
||||
The idea is 5 lines — reproduce it with any image tool:
|
||||
draw a numbered 9×9 grid → pick the strips the target spans → crop that region
|
||||
(+pad ~0.4 strip) and upscale → draw a finer 6×6 grid → pick again → map back
|
||||
(`global = region_origin + local × region_size`) → draw the box and LOOK at it.
|
||||
|
||||
## Notes
|
||||
|
||||
- Geometry is frozen in `locate.mjs` (node + ffmpeg, zero npm deps — both
|
||||
already required by hyperframes). Don't re-implement it ad hoc; the measured
|
||||
accuracy holds for THIS implementation.
|
||||
- Consumers: `samples/asset-fusion/_ref-circle-highlight.html` takes `CFG.box`
|
||||
directly from `final`/`auto` output.
|
||||
- Measured end-to-end (same agent, same template, only the localization step
|
||||
differs): eyeballing 6.5% avg center error → this protocol 2.3%, no case worse.
|
||||
@@ -0,0 +1,227 @@
|
||||
#!/usr/bin/env node
|
||||
/* locate.mjs — find "X" in an image WITHOUT any detector API or key.
|
||||
*
|
||||
* You (the author model) are weak at regressing pixel coordinates but strong at
|
||||
* "which numbered strip is the target in?" — so localization = RSVP grid-index
|
||||
* (ACL 2025 long.715): pick strips on a numbered grid, reconstruct the box
|
||||
* geometrically. Zero npm deps — node + ffmpeg (both already required by
|
||||
* hyperframes). Full protocol: grounding/PROTOCOL.md.
|
||||
*
|
||||
* THE LOOP (you read images between steps):
|
||||
* 1) node locate.mjs overlay <img> --out DIR
|
||||
* → DIR/gv.png (vertical strips 1..9) + DIR/gh.png (horizontal 1..9).
|
||||
* READ both, pick the strip numbers the target spans.
|
||||
* 2) node locate.mjs region <img> --vids 4,5 --hids 6,7 --out DIR
|
||||
* → prints coarse region + writes DIR/gc.png (region cropped+upscaled,
|
||||
* finer 6×6 grid). READ it, pick the finer strips.
|
||||
* 3) node locate.mjs final <img> --region x0,y0,x1,y1 --vids 3,4 --hids 3,4
|
||||
* → {box, center} normalized to the FULL image.
|
||||
* 4) node locate.mjs mark <img> --box x0,y0,x1,y1 --out DIR/check.png
|
||||
* → VERIFY: read check.png — is the red box on the target? If off,
|
||||
* redo step 2/3 with corrected strips. Never skip this.
|
||||
*/
|
||||
import { execFileSync } from "node:child_process";
|
||||
import { existsSync, mkdirSync, copyFileSync } from "node:fs";
|
||||
|
||||
const N1 = 9,
|
||||
PAD1 = 0.4; // stage 1: strips per axis, padding in STRIP units
|
||||
const N2 = 6,
|
||||
PAD2 = 0.25; // stage 2 (crop)
|
||||
const GREEN = "0x3CDC5A",
|
||||
BLUE = "0x3C82FF",
|
||||
RED = "0xFF3232";
|
||||
|
||||
const ff = (args) =>
|
||||
execFileSync("ffmpeg", ["-v", "error", "-y", ...args], {
|
||||
stdio: ["ignore", "ignore", "inherit"],
|
||||
});
|
||||
function probe(img) {
|
||||
const out = execFileSync("ffprobe", [
|
||||
"-v",
|
||||
"error",
|
||||
"-select_streams",
|
||||
"v:0",
|
||||
"-show_entries",
|
||||
"stream=width,height",
|
||||
"-of",
|
||||
"csv=p=0",
|
||||
img,
|
||||
])
|
||||
.toString()
|
||||
.trim();
|
||||
const [w, h] = out.split(",").map(Number);
|
||||
return { w, h };
|
||||
}
|
||||
function font() {
|
||||
const dst = "/tmp/locate-font.ttf";
|
||||
if (!existsSync(dst)) {
|
||||
for (const c of [
|
||||
"/System/Library/Fonts/Supplemental/Arial Bold.ttf",
|
||||
"/System/Library/Fonts/Supplemental/Arial.ttf",
|
||||
"/usr/share/fonts/truetype/dejavu/DejaVuSans-Bold.ttf",
|
||||
]) {
|
||||
if (existsSync(c)) {
|
||||
copyFileSync(c, dst);
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
return dst;
|
||||
}
|
||||
function gridFilters(w, h, n, axis, fz) {
|
||||
const F = font(),
|
||||
fs = [];
|
||||
if (axis === "v" || axis === "both") {
|
||||
for (let i = 1; i < n; i++)
|
||||
fs.push(`drawbox=x=${Math.round((i * w) / n)}:y=0:w=2:h=${h}:color=${GREEN}@0.8:t=fill`);
|
||||
for (let i = 0; i < n; i++)
|
||||
fs.push(
|
||||
`drawtext=fontfile=${F}:text='${i + 1}':x=${Math.round(((i + 0.5) * w) / n - fz * 0.3)}:y=6:fontsize=${fz}:fontcolor=black:box=1:boxcolor=white@0.95:boxborderw=5`,
|
||||
);
|
||||
}
|
||||
if (axis === "h" || axis === "both") {
|
||||
for (let j = 1; j < n; j++)
|
||||
fs.push(`drawbox=x=0:y=${Math.round((j * h) / n)}:w=${w}:h=2:color=${BLUE}@0.8:t=fill`);
|
||||
for (let j = 0; j < n; j++)
|
||||
fs.push(
|
||||
`drawtext=fontfile=${F}:text='${j + 1}':x=6:y=${Math.round(((j + 0.5) * h) / n - fz * 0.5)}:fontsize=${fz}:fontcolor=black:box=1:boxcolor=white@0.95:boxborderw=5`,
|
||||
);
|
||||
}
|
||||
return fs;
|
||||
}
|
||||
const ids = (s) => String(s).split(",").filter(Boolean).map(Number);
|
||||
const regionOf = (v, h, n, pad) => [
|
||||
Math.max(Math.min(...v) - 1 - pad, 0) / n,
|
||||
Math.max(Math.min(...h) - 1 - pad, 0) / n,
|
||||
Math.min(Math.max(...v) + pad, n) / n,
|
||||
Math.min(Math.max(...h) + pad, n) / n,
|
||||
];
|
||||
const r4 = (x) => Math.round(x * 1e4) / 1e4;
|
||||
const out = (o) => console.log(JSON.stringify(o));
|
||||
|
||||
// --- tiny arg parsing: locate.mjs <cmd> <img?> --k v ---
|
||||
const [cmd, ...rest] = process.argv.slice(2);
|
||||
const pos = rest.filter((a) => !a.startsWith("--"));
|
||||
const opt = {};
|
||||
for (let i = 0; i < rest.length; i++)
|
||||
if (rest[i].startsWith("--")) opt[rest[i].slice(2)] = rest[i + 1];
|
||||
const img = pos[0];
|
||||
|
||||
if (cmd === "overlay") {
|
||||
const dir = opt.out || ".";
|
||||
mkdirSync(dir, { recursive: true });
|
||||
const n = Number(opt.n || N1);
|
||||
const { w, h } = probe(img);
|
||||
const fz = Math.max(16, Math.round(Math.min(w, h) / 22));
|
||||
ff(["-i", img, "-vf", gridFilters(w, h, n, "v", fz).join(","), `${dir}/gv.png`]);
|
||||
ff(["-i", img, "-vf", gridFilters(w, h, n, "h", fz).join(","), `${dir}/gh.png`]);
|
||||
out({
|
||||
w,
|
||||
h,
|
||||
n,
|
||||
vertical: `${dir}/gv.png`,
|
||||
horizontal: `${dir}/gh.png`,
|
||||
next: "READ gv.png + gh.png, then: locate.mjs region <img> --vids .. --hids .. --out " + dir,
|
||||
});
|
||||
} else if (cmd === "region") {
|
||||
const dir = opt.out || ".";
|
||||
mkdirSync(dir, { recursive: true });
|
||||
const n = Number(opt.n || N1),
|
||||
nf = Number(opt.nf || N2);
|
||||
const reg = regionOf(ids(opt.vids), ids(opt.hids), n, PAD1);
|
||||
const { w, h } = probe(img);
|
||||
const cx = Math.floor(reg[0] * w),
|
||||
cy = Math.floor(reg[1] * h);
|
||||
const cw = Math.max(2, Math.floor((reg[2] - reg[0]) * w)),
|
||||
ch = Math.max(2, Math.floor((reg[3] - reg[1]) * h));
|
||||
const uw = Math.max(cw, 640),
|
||||
uh = Math.round((ch * uw) / cw);
|
||||
const fz = Math.max(15, Math.round(Math.min(uw, uh) / 16));
|
||||
ff([
|
||||
"-i",
|
||||
img,
|
||||
"-vf",
|
||||
[
|
||||
`crop=${cw}:${ch}:${cx}:${cy}`,
|
||||
`scale=${uw}:${uh}`,
|
||||
...gridFilters(uw, uh, nf, "both", fz),
|
||||
].join(","),
|
||||
`${dir}/gc.png`,
|
||||
]);
|
||||
out({
|
||||
region: reg.map(r4),
|
||||
crop_grid: `${dir}/gc.png`,
|
||||
nf,
|
||||
next: `READ gc.png, then: locate.mjs final <img> --region ${reg.map(r4).join(",")} --vids .. --hids ..`,
|
||||
});
|
||||
} else if (cmd === "final") {
|
||||
const nf = Number(opt.nf || N2);
|
||||
const reg = opt.region.split(",").map(Number);
|
||||
const rl = regionOf(ids(opt.vids), ids(opt.hids), nf, PAD2);
|
||||
const [x0, y0, x1, y1] = reg;
|
||||
const box = [
|
||||
x0 + rl[0] * (x1 - x0),
|
||||
y0 + rl[1] * (y1 - y0),
|
||||
x0 + rl[2] * (x1 - x0),
|
||||
y0 + rl[3] * (y1 - y0),
|
||||
].map(r4);
|
||||
out({
|
||||
box,
|
||||
center: [r4((box[0] + box[2]) / 2), r4((box[1] + box[3]) / 2)],
|
||||
next:
|
||||
"VERIFY: locate.mjs mark <img> --box " +
|
||||
box.join(",") +
|
||||
" --out <dir>/check.png — then READ it",
|
||||
});
|
||||
} else if (cmd === "mark") {
|
||||
const box = opt.box.split(",").map(Number);
|
||||
const { w, h } = probe(img);
|
||||
const bx = Math.round(box[0] * w),
|
||||
by = Math.round(box[1] * h);
|
||||
const bw = Math.max(2, Math.round((box[2] - box[0]) * w)),
|
||||
bh = Math.max(2, Math.round((box[3] - box[1]) * h));
|
||||
const dst = opt.out || "./check.png";
|
||||
ff(["-i", img, "-vf", `drawbox=x=${bx}:y=${by}:w=${bw}:h=${bh}:color=${RED}@1:t=6`, dst]);
|
||||
out({
|
||||
marked: dst,
|
||||
next: "READ it — red box on the target? If off, redo region/final with corrected strips.",
|
||||
});
|
||||
} else if (cmd === "auto") {
|
||||
// OPTIONAL fast path — only if a strong detector key happens to exist. Never assume it.
|
||||
const key = process.env.GEMINI_API_KEY;
|
||||
if (!key) {
|
||||
console.error(
|
||||
"auto needs GEMINI_API_KEY; use the grid loop instead (overlay→region→final→mark)",
|
||||
);
|
||||
process.exit(1);
|
||||
}
|
||||
const target = pos[1];
|
||||
const b64 = execFileSync("base64", ["-i", img]).toString().replace(/\n/g, "");
|
||||
const mime = img.match(/\.png$/i) ? "image/png" : "image/jpeg";
|
||||
const body = {
|
||||
contents: [
|
||||
{
|
||||
parts: [
|
||||
{ inline_data: { mime_type: mime, data: b64 } },
|
||||
{
|
||||
text: `Detect "${target}". Return ONLY {"box_2d":[ymin,xmin,ymax,xmax]} integers 0-1000.`,
|
||||
},
|
||||
],
|
||||
},
|
||||
],
|
||||
generationConfig: { temperature: 0, response_mime_type: "application/json" },
|
||||
};
|
||||
const res = await fetch(
|
||||
`https://generativelanguage.googleapis.com/v1beta/models/gemini-3.5-flash:generateContent?key=${key}`,
|
||||
{ method: "POST", headers: { "Content-Type": "application/json" }, body: JSON.stringify(body) },
|
||||
);
|
||||
const t = (await res.json()).candidates[0].content.parts[0].text;
|
||||
let bb = JSON.parse(t.match(/\{[\s\S]*\}/)[0]).box_2d;
|
||||
if (Array.isArray(bb[0])) bb = bb[0];
|
||||
const s = Math.max(...bb) > 1.5 ? 1000 : 1;
|
||||
const box = [bb[1] / s, bb[0] / s, bb[3] / s, bb[2] / s].map(r4);
|
||||
out({ box, center: [r4((box[0] + box[2]) / 2), r4((box[1] + box[3]) / 2)] });
|
||||
} else {
|
||||
console.error("usage: locate.mjs overlay|region|final|mark|auto … (see header comment)");
|
||||
process.exit(1);
|
||||
}
|
||||
Reference in New Issue
Block a user