package agent import ( "context" "encoding/json" "errors" "testing" "reasonix/internal/agent/testutil" "reasonix/internal/event" "reasonix/internal/provider" "reasonix/internal/tool" ) // steerThenCancelTool queues a steer while the turn is running, then cancels // the turn so Run exits before the loop's per-iteration consume can deliver it. type steerThenCancelTool struct { agent *Agent cancel context.CancelFunc steerText string accepted bool } func (t *steerThenCancelTool) Name() string { return "steer_then_cancel" } func (t *steerThenCancelTool) Description() string { return "queues a steer and cancels the turn" } func (t *steerThenCancelTool) Schema() json.RawMessage { return json.RawMessage(`{"type":"object","properties":{}}`) } func (t *steerThenCancelTool) ReadOnly() bool { return true } func (t *steerThenCancelTool) Execute(context.Context, json.RawMessage) (string, error) { t.accepted = t.agent.Steer(t.steerText) t.cancel() return "ok", nil } // TestRunFlushesUnconsumedSteersOnCancel proves a steer that is still queued // when the turn is cancelled survives into the session (history + next turn's // context) and emits its Steer event, instead of being silently dropped // (#6238: queued guidance vanished from both the model and the transcript). func TestRunFlushesUnconsumedSteersOnCancel(t *testing.T) { mp := testutil.NewMock("m", testutil.Turn{ToolCalls: []provider.ToolCall{{ID: "call-1", Name: "steer_then_cancel", Arguments: `{}`}}}, testutil.Turn{Text: "never reached"}, ) hijack := &steerThenCancelTool{steerText: "use plan B"} reg := tool.NewRegistry() reg.Add(hijack) var steerEvents []string sink := event.FuncSink(func(e event.Event) { if e.Kind == event.Steer { steerEvents = append(steerEvents, e.Text) } }) a := New(mp, reg, NewSession(""), Options{}, sink) ctx, cancel := context.WithCancel(context.Background()) defer cancel() hijack.agent = a hijack.cancel = cancel err := a.Run(ctx, "go") if !errors.Is(err, context.Canceled) { t.Fatalf("Run should exit on the cancelled context, got %v", err) } if !hijack.accepted { t.Fatalf("Steer during an active turn should be accepted") } var persisted []string for _, m := range a.Session().Messages { if m.Role != provider.RoleUser { continue } if text, ok := SteerText(m.Content); ok { persisted = append(persisted, text) } } if len(persisted) != 1 || persisted[0] != "use plan B" { t.Fatalf("unconsumed steer should be persisted once and round-trip through SteerText, got %v", persisted) } if len(steerEvents) != 1 || steerEvents[0] != "use plan B" { t.Fatalf("flushed steer should emit its Steer event, got %v", steerEvents) } if n := a.steerQueueLen(); n != 0 { t.Fatalf("steer queue should be empty after the turn, len=%d", n) } if a.Steer("after the turn") { t.Fatalf("Steer must be rejected once the turn has exited") } } // TestSteerTextSurvivesTurnPreferenceWrapping pins replay: steers are // persisted through withTurnPreferences, which prepends transient language // blocks (for Chinese text even in auto mode, and for any text under an // explicit language) ahead of the steer prefix. SteerText must skip the // wrapping and return the user's exact original text, or replay degrades the // steer into a plain user message. func TestSteerTextSurvivesTurnPreferenceWrapping(t *testing.T) { plain := New(nil, nil, NewSession(""), Options{}, event.Discard) explicit := New(nil, nil, NewSession(""), Options{}, event.Discard) explicit.SetReasoningLanguage("zh") explicit.SetResponseLanguage("zh") cases := []struct { name string agent *Agent text string }{ {"english auto (no blocks)", plain, "use plan B"}, {"chinese auto (reasoning block)", plain, "请改用方案B"}, {"explicit zh (both blocks)", explicit, "switch to plan B"}, {"exact text preserved", plain, " spaced\ttext "}, } for _, tc := range cases { persisted := tc.agent.withTurnPreferences(midTurnSteerMessage(tc.text)) got, ok := SteerText(persisted) if !ok { t.Fatalf("%s: SteerText failed to recognize the persisted steer (head %.80q)", tc.name, persisted) } if got != tc.text { t.Fatalf("%s: SteerText = %q, want %q", tc.name, got, tc.text) } } if _, ok := SteerText(plain.withTurnPreferences("请总结一下这个文件")); ok { t.Fatalf("a wrapped ordinary user message must not be detected as a steer") } } // TestSteerRejectedWithoutActiveTurn proves a steer arriving when no turn is // running is rejected instead of parked in a queue no loop will consume, so // the controller can convert it into a regular turn. func TestSteerRejectedWithoutActiveTurn(t *testing.T) { a := New(testutil.NewMock("m", testutil.Turn{Text: "done"}), tool.NewRegistry(), NewSession(""), Options{}, event.Discard) if a.Steer("early") { t.Fatalf("Steer with no active turn must be rejected") } if n := a.steerQueueLen(); n != 0 { t.Fatalf("rejected steer must not linger in the queue, len=%d", n) } if err := a.Run(context.Background(), "go"); err != nil { t.Fatalf("Run: %v", err) } if a.Steer("between turns") { t.Fatalf("Steer between turns must be rejected") } }