426e9eeabd
Voice Workbench / headless workbench (mocked backends) (push) Has been cancelled
Voice Workbench / real acoustic lane (nightly, provisioned only) (push) Has been cancelled
ci / test (push) Has been cancelled
ci / lint-and-format (push) Has been cancelled
ci / build (push) Has been cancelled
ci / dev-startup (push) Has been cancelled
gitleaks / gitleaks (push) Has been cancelled
Markdown Links / Relative Markdown Links (push) Has been cancelled
Quality (Extended) / Homepage Build (PR smoke) (push) Has been cancelled
Quality (Extended) / Comment-only diff guard (push) Has been cancelled
Quality (Extended) / Format + Type Safety Ratchet (push) Has been cancelled
Quality (Extended) / Develop Gate (secret scan + UI determinism) (push) Has been cancelled
Quality (Extended) / Develop Gate (lint) (push) Has been cancelled
Chat shell gestures / Chat shell gesture + parity e2e (push) Has been cancelled
Cloud Gateway Discord / Test (push) Has been cancelled
Benchmark Bridge Tests / benchmark (bunx @biomejs/biome check packages/lifeops-bench/src, benchmark-lint) (push) Has been cancelled
Benchmark Bridge Tests / benchmark (bunx vitest run --config packages/lifeops-bench/vitest.config.ts --root packages/lifeops-bench --passWithNoTests, benchmark-tests) (push) Has been cancelled
Build Agent Image / build-and-push (push) Has been cancelled
Dev Smoke / bun run dev onboarding chat (push) Has been cancelled
Dev Smoke / Vite HMR dependency-level smoke (push) Has been cancelled
Electrobun Submodule Guard / electrobun gitlink is fetchable (push) Has been cancelled
Publish @elizaos/example-code / check_npm (push) Has been cancelled
Publish @elizaos/example-code / publish_npm (push) Has been cancelled
Publish @elizaos/plugin-elizacloud / verify_version (push) Has been cancelled
Publish @elizaos/plugin-elizacloud / publish_npm (push) Has been cancelled
Sandbox Live Smoke / Sandbox live smoke (push) Has been cancelled
Snap Build & Test / Build Snap (amd64) (push) Has been cancelled
Snap Build & Test / Build Snap (arm64) (push) Has been cancelled
Test Packaging / elizaos CLI global-install smoke (node + bun) (push) Has been cancelled
Cloud Gateway Webhook / Test (push) Has been cancelled
Cloud Tests / lint-and-types (push) Has been cancelled
Cloud Tests / unit-tests (push) Has been cancelled
Cloud Tests / integration-tests (push) Has been cancelled
Cloud Tests / e2e-tests (push) Has been cancelled
CodeQL Advanced / Analyze (javascript-typescript) (push) Has been cancelled
Deploy Apps Worker (Product 2) / Determine environment (push) Has been cancelled
Deploy Apps Worker (Product 2) / Deploy apps worker to apps-control host (${{ needs.determine-env.outputs.environment }}) (push) Has been cancelled
Deploy Eliza Provisioning Worker / Determine environment (push) Has been cancelled
Deploy Eliza Provisioning Worker / Deploy worker to Hetzner host (${{ needs.determine-env.outputs.environment }} @ ${{ needs.determine-env.outputs.deployment_sha }}) (push) Has been cancelled
Dev Smoke / Classify changed paths (push) Has been cancelled
supply-chain / sbom (push) Has been cancelled
supply-chain / vulnerability-scan (push) Has been cancelled
Build, Push & Deploy to Phala Cloud / build-and-push (push) Has been cancelled
Test Packaging / Validate Packaging Configs (push) Has been cancelled
Test Packaging / Build & Test PyPI Package (push) Has been cancelled
Test Packaging / PyPI on Python ${{ matrix.python }} (push) Has been cancelled
Test Packaging / Pack & Test JS Tarballs (push) Has been cancelled
UI Fixture E2E / ui-fixture-e2e (push) Has been cancelled
UI Fixture E2E / fixture-e2e (push) Has been cancelled
UI Story Gate / story-gate (push) Has been cancelled
vault-ci / test (macos-latest) (push) Has been cancelled
vault-ci / test (ubuntu-latest) (push) Has been cancelled
vault-ci / test (windows-latest) (push) Has been cancelled
vault-ci / app-core wiring tests (push) Has been cancelled
verify-patches / verify patches/CHECKSUMS.sha256 (push) Has been cancelled
Voice Benchmark Smoke / voice-emotion fixture smoke (push) Has been cancelled
Voice Benchmark Smoke / voiceagentbench fixture smoke (push) Has been cancelled
Voice Benchmark Smoke / voicebench-quality unit smoke (push) Has been cancelled
Voice Benchmark Smoke / voicebench TypeScript unit (no audio) (push) Has been cancelled
Voice Benchmark Smoke / voice bench smoke summary (push) Has been cancelled
Windows CI / windows ([bun run --cwd packages/app-core test bun run --cwd packages/elizaos test bun run --cwd packages/cloud/shared test], app-and-cli) (push) Has been cancelled
Windows CI / windows ([bun run --cwd packages/scenario-runner test bun run --cwd packages/vault test bun run --cwd packages/security test bun run --cwd plugins/plugin-coding-tools test], framework-packages) (push) Has been cancelled
Windows CI / windows ([bun run --cwd plugins/plugin-elizacloud test bun run --cwd plugins/plugin-discord test bun run --cwd plugins/plugin-anthropic test bun run --cwd plugins/plugin-openai test bun run --cwd plugins/plugin-app-control test bun run --cwd plugins/pl… (push) Has been cancelled
Windows CI / windows ([node packages/scripts/run-turbo.mjs run build --filter=@elizaos/core --filter=@elizaos/shared --filter=@elizaos/agent --concurrency=4 node packages/scripts/run-bash-linux-only.mjs scripts/verify-riscv64-buildpaths.sh node packages/scripts/run… (push) Has been cancelled
Windows CI / windows ([node packages/scripts/run-turbo.mjs run typecheck --filter=@elizaos/core --filter=@elizaos/shared --filter=@elizaos/cloud-shared --concurrency=4 bun run --cwd packages/core test bun run --cwd packages/shared test], core-runtime, 75) (push) Has been cancelled
140 lines
4.3 KiB
TypeScript
140 lines
4.3 KiB
TypeScript
/**
|
|
* Unit tests for the draft-stream controller's finalize path — the final
|
|
* streamed message must carry the reply's rendered components (#14527).
|
|
* Hand-rolled channel/message stubs capture the exact discord.js send/edit
|
|
* payloads; no network, no discord.com.
|
|
*/
|
|
import type {
|
|
ActionRowBuilder,
|
|
MessageActionRowComponentBuilder,
|
|
TextChannel,
|
|
} from "discord.js";
|
|
import { describe, expect, it } from "vitest";
|
|
import { createDraftStreamController } from "../draft-stream";
|
|
import type { DiscordActionRow } from "../types";
|
|
import { buildDiscordComponents } from "../utils";
|
|
|
|
interface CapturedSend {
|
|
content?: string;
|
|
components?: ActionRowBuilder<MessageActionRowComponentBuilder>[];
|
|
}
|
|
|
|
function makeChannel() {
|
|
const sends: CapturedSend[] = [];
|
|
const edits: CapturedSend[] = [];
|
|
const channel = {
|
|
send: async (options: CapturedSend) => {
|
|
sends.push(options);
|
|
return {
|
|
id: `msg-${sends.length}`,
|
|
content: options.content ?? "",
|
|
createdTimestamp: Date.now(),
|
|
attachments: { size: 0 },
|
|
edit: async (editOptions: CapturedSend) => {
|
|
edits.push(editOptions);
|
|
return { id: `msg-${sends.length}` };
|
|
},
|
|
};
|
|
},
|
|
} as unknown as TextChannel;
|
|
return { channel, sends, edits };
|
|
}
|
|
|
|
const choiceRow: DiscordActionRow = {
|
|
type: 1,
|
|
components: [
|
|
{ type: 2, custom_id: "ia1:yes", label: "Yes", style: 2 },
|
|
{ type: 2, custom_id: "ia1:no", label: "No", style: 2 },
|
|
],
|
|
};
|
|
|
|
function choiceComponents() {
|
|
const components = buildDiscordComponents([choiceRow]);
|
|
if (components?.length !== 1) {
|
|
throw new Error("choice row did not build into a Discord component");
|
|
}
|
|
return components;
|
|
}
|
|
|
|
function rowJson(component: unknown): {
|
|
type: number;
|
|
components: Array<{ custom_id?: string; label?: string }>;
|
|
} {
|
|
return (component as { toJSON: () => ReturnType<typeof rowJson> }).toJSON();
|
|
}
|
|
|
|
describe("draft-stream finalize components (#14527)", () => {
|
|
it("attaches components to the finalized message", async () => {
|
|
const { channel, sends } = makeChannel();
|
|
const controller = createDraftStreamController();
|
|
await controller.start(channel);
|
|
|
|
const messages = await controller.finalize("Pick one", choiceComponents());
|
|
|
|
expect(messages).toHaveLength(1);
|
|
expect(sends).toHaveLength(1);
|
|
expect(sends[0].components).toHaveLength(1);
|
|
const row = rowJson(sends[0].components?.[0]);
|
|
expect(row.type).toBe(1);
|
|
expect(row.components.map((c) => c.custom_id)).toEqual([
|
|
"ia1:yes",
|
|
"ia1:no",
|
|
]);
|
|
});
|
|
|
|
it("edits the last snapshot to attach components when the final text already streamed", async () => {
|
|
const { channel, sends, edits } = makeChannel();
|
|
const controller = createDraftStreamController({
|
|
throttleMs: 250,
|
|
minInitialChars: 1,
|
|
});
|
|
await controller.start(channel);
|
|
|
|
controller.update("Pick one");
|
|
// Let the throttled snapshot flush so the full final text is already out.
|
|
await new Promise((resolve) => setTimeout(resolve, 400));
|
|
expect(sends).toHaveLength(1);
|
|
|
|
await controller.finalize("Pick one", choiceComponents());
|
|
|
|
// No duplicate message; the streamed snapshot gained the components.
|
|
expect(sends).toHaveLength(1);
|
|
expect(edits).toHaveLength(1);
|
|
expect(edits[0].content).toBe("Pick one");
|
|
const row = rowJson(edits[0].components?.[0]);
|
|
expect(row.components.map((c) => c.label)).toEqual(["Yes", "No"]);
|
|
});
|
|
|
|
it("attaches components only to the last chunk of a multi-message finalize", async () => {
|
|
const { channel, sends } = makeChannel();
|
|
const controller = createDraftStreamController({ maxChars: 60 });
|
|
await controller.start(channel);
|
|
|
|
const longText = Array.from(
|
|
{ length: 8 },
|
|
(_, i) => `Sentence number ${i} pads the reply.`,
|
|
).join(" ");
|
|
expect(longText.length).toBeGreaterThan(60);
|
|
|
|
await controller.finalize(longText, choiceComponents());
|
|
|
|
expect(sends.length).toBeGreaterThan(1);
|
|
const last = sends[sends.length - 1];
|
|
expect(last.components).toHaveLength(1);
|
|
for (const earlier of sends.slice(0, -1)) {
|
|
expect(earlier.components).toBeUndefined();
|
|
}
|
|
});
|
|
|
|
it("finalize without components stays component-free", async () => {
|
|
const { channel, sends } = makeChannel();
|
|
const controller = createDraftStreamController();
|
|
await controller.start(channel);
|
|
|
|
await controller.finalize("Just prose");
|
|
|
|
expect(sends).toHaveLength(1);
|
|
expect(sends[0].components).toBeUndefined();
|
|
});
|
|
});
|