Files
wehub-resource-sync 5357c39144
Fuzzer / Run Fuzzer (push) Has been cancelled
Race tests / Go race tests (ubuntu-22.04) (push) Has been cancelled
chore: import upstream snapshot with attribution
2026-07-13 13:01:40 +08:00

464 lines
17 KiB
Go

// Copyright 2024 Dolthub, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package commands
import (
"bytes"
"context"
"errors"
"fmt"
"os"
"strings"
"github.com/dolthub/go-mysql-server/sql"
"github.com/dolthub/dolt/go/cmd/dolt/cli"
"github.com/dolthub/dolt/go/cmd/dolt/errhand"
"github.com/dolthub/dolt/go/libraries/doltcore/dconfig"
"github.com/dolthub/dolt/go/libraries/doltcore/env"
"github.com/dolthub/dolt/go/libraries/doltcore/env/actions"
"github.com/dolthub/dolt/go/libraries/doltcore/rebase"
"github.com/dolthub/dolt/go/libraries/doltcore/sqle/dprocedures"
"github.com/dolthub/dolt/go/libraries/doltcore/sqle/dsess"
"github.com/dolthub/dolt/go/libraries/utils/argparser"
"github.com/dolthub/dolt/go/libraries/utils/config"
"github.com/dolthub/dolt/go/libraries/utils/editor"
eventsapi "github.com/dolthub/eventsapi_schema/dolt/services/eventsapi/v1alpha1"
)
var rebaseDocs = cli.CommandDocumentationContent{
ShortDesc: "Reapplies commits on top of another base tip",
LongDesc: `Rewrites commit history for the current branch by replaying commits, allowing the commits to be reordered,
squashed, or dropped. The commits included in the rebase plan are the commits reachable by the current branch, but NOT
reachable from the branch specified as the argument when starting a rebase (also known as the upstream branch). This is
the same as Git and Dolt's "two dot log" syntax, or |upstreamBranch|..|currentBranch|.
Rebasing is useful to clean and organize your commit history, especially before merging a feature branch back to a shared
branch. For example, you can drop commits that contain debugging or test changes, or squash or fixup small commits into a
single commit, or reorder commits so that related changes are adjacent in the new commit history.
`,
Synopsis: []string{
`[-i | --interactive] [--empty=drop|keep] {{.LessThan}}upstream{{.GreaterThan}}`,
`(--continue | --abort)`,
},
}
type RebaseCmd struct{}
var _ cli.Command = RebaseCmd{}
// Name returns the name of the Dolt cli command. This is what is used on the command line to invoke the command
func (cmd RebaseCmd) Name() string {
return "rebase"
}
// Description returns a description of the command
func (cmd RebaseCmd) Description() string {
return rebaseDocs.ShortDesc
}
// EventType returns the type of the event to log
func (cmd RebaseCmd) EventType() eventsapi.ClientEventType {
return eventsapi.ClientEventType_REBASE
}
func (cmd RebaseCmd) Docs() *cli.CommandDocumentation {
ap := cmd.ArgParser()
return cli.NewCommandDocumentation(rebaseDocs, ap)
}
func (cmd RebaseCmd) ArgParser() *argparser.ArgParser {
return cli.CreateRebaseArgParser()
}
// Exec executes the command
func (cmd RebaseCmd) Exec(ctx context.Context, commandStr string, args []string, dEnv *env.DoltEnv, cliCtx cli.CliContext) int {
ap := cmd.ArgParser()
help, usage := cli.HelpAndUsagePrinters(cli.CommandDocsForCommandString(commandStr, rebaseDocs, ap))
apr := cli.ParseArgsOrDie(ap, args, help)
queryist, err := cliCtx.QueryEngine(ctx)
if err != nil {
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(err), usage)
}
if queryist.IsRemote {
msg := fmt.Sprintf(cli.RemoteUnsupportedMsg, commandStr)
cli.Println(msg)
return 1
}
// Set @@dolt_allow_commit_conflicts in case there are data conflicts that need to be resolved by the caller.
// Without this, the conflicts can't be committed to the branch working set, and the caller can't access them.
if _, err = cli.GetRowsForSql(queryist.Queryist, queryist.Context, "set @@dolt_allow_commit_conflicts=1;"); err != nil {
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(err), usage)
}
branchName, err := getActiveBranchName(queryist.Context, queryist.Queryist)
if err != nil {
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(err), usage)
}
query, err := interpolateStoredProcedureCall("DOLT_REBASE", args)
if err != nil {
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(err), usage)
}
rows, err := cli.GetRowsForSql(queryist.Queryist, queryist.Context, query)
if err != nil {
if isRebaseConflictError(err) {
if checkoutErr := syncCliBranchToSqlSessionBranch(queryist.Context, dEnv); checkoutErr != nil {
// The checkout of the dolt_rebase_<> branch failed, we might want to `--abort`, but chances
// are that won't work either. We are gonna be in a weird state no matter what, so just print the error and exit.
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(checkoutErr), usage)
}
}
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(err), usage)
}
status, err := getInt64ColAsInt64(rows[0][0])
if err != nil {
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(err), usage)
}
if status == 1 {
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(errors.New("error: "+rows[0][1].(string))), usage)
}
if status != 0 {
cli.Println(fmt.Sprintf("runtime error: unexpected non-zero, non-one status from DOLT_REBASE: %d", status))
return 1
}
// If the rebase was successful, or if it was aborted, print out the message and
// ensure the branch being rebased is checked out in the CLI
message := rows[0][1].(string)
if strings.Contains(message, dprocedures.SuccessfulRebaseMessage) ||
strings.Contains(message, dprocedures.RebaseAbortedMessage) {
cli.Println(message)
if err = syncCliBranchToSqlSessionBranch(queryist.Context, dEnv); err != nil {
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(err), usage)
}
return 0
}
if strings.HasPrefix(message, dprocedures.EditPausePrefix) {
// We need to pause to edit a commit. This is similar to date conflicts, but that makes it's way to us as an error
// This is not an error scenario, Just print the message, and return 0.
cli.Println(message)
return 0
}
// At this point, we know the rebase has just been initiated, and we are in interactive mode.
rebasePlan, err := getRebasePlan(cliCtx, queryist.Context, queryist.Queryist, apr.Arg(0), branchName)
if err != nil {
// attempt to abort the rebase
_, _, _, _ = queryist.Queryist.Query(queryist.Context, "CALL DOLT_REBASE('--abort');")
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(err), usage)
}
// if all uncommented lines are deleted in the editor, abort the rebase
if rebasePlan == nil || rebasePlan.Steps == nil || len(rebasePlan.Steps) == 0 {
rows, err := cli.GetRowsForSql(queryist.Queryist, queryist.Context, "CALL DOLT_REBASE('--abort');")
if err != nil {
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(err), usage)
}
status, err := getInt64ColAsInt64(rows[0][0])
if err != nil {
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(err), usage)
}
if status == 1 {
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(errors.New("error: "+rows[0][1].(string))), usage)
}
cli.Println(dprocedures.RebaseAbortedMessage)
return 0
}
err = insertRebasePlanIntoDoltRebaseTable(rebasePlan, queryist.Context, queryist.Queryist)
if err != nil {
// attempt to abort the rebase
_, _, _, _ = queryist.Queryist.Query(queryist.Context, "CALL DOLT_REBASE('--abort');")
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(err), usage)
}
rows, err = cli.GetRowsForSql(queryist.Queryist, queryist.Context, "CALL DOLT_REBASE('--continue');")
if err != nil {
if isRebaseConflictError(err) {
if checkoutErr := syncCliBranchToSqlSessionBranch(queryist.Context, dEnv); checkoutErr != nil {
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(checkoutErr), usage)
}
} else {
_, _, _, _ = queryist.Queryist.Query(queryist.Context, "CALL DOLT_REBASE('--abort');")
if checkoutErr := syncCliBranchToSqlSessionBranch(queryist.Context, dEnv); checkoutErr != nil {
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(checkoutErr), usage)
}
}
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(err), usage)
}
status, err = getInt64ColAsInt64(rows[0][0])
if err != nil {
_, _, _, _ = queryist.Queryist.Query(queryist.Context, "CALL DOLT_REBASE('--abort');")
if err = syncCliBranchToSqlSessionBranch(queryist.Context, dEnv); err != nil {
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(err), usage)
}
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(err), usage)
}
if status == 1 {
_, _, _, _ = queryist.Queryist.Query(queryist.Context, "CALL DOLT_REBASE('--abort');")
if err = syncCliBranchToSqlSessionBranch(queryist.Context, dEnv); err != nil {
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(err), usage)
}
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(errors.New("error: "+rows[0][1].(string))), usage)
}
message = rows[0][1].(string)
// Check if this is an edit pause. Such messages have a status value of 0, so all we have to go on is the message.
if strings.Contains(message, dprocedures.EditPausePrefix) {
// Make sure the CLI is on the same branch so the user can make their edits.
if checkoutErr := syncCliBranchToSqlSessionBranch(queryist.Context, dEnv); checkoutErr != nil {
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(checkoutErr), usage)
}
}
cli.Println(message)
return 0
}
// getRebasePlan opens an editor for users to edit the rebase plan and returns the parsed rebase plan from the editor.
func getRebasePlan(cliCtx cli.CliContext, sqlCtx *sql.Context, queryist cli.Queryist, rebaseBranch, currentBranch string) (*rebase.RebasePlan, error) {
if cli.ExecuteWithStdioRestored == nil {
return nil, nil
}
if !checkIsTerminal() {
return nil, nil
}
initialRebaseMsg, err := buildInitialRebaseMsg(sqlCtx, queryist, rebaseBranch, currentBranch)
if err != nil {
return nil, err
}
backupEd := "vim"
// try getting default editor on the user system
if ed, edSet := os.LookupEnv(dconfig.EnvEditor); edSet {
backupEd = ed
}
// try getting Dolt config core.editor
editorStr := cliCtx.Config().GetStringOrDefault(config.DoltEditor, backupEd)
var rebaseMsg string
cli.ExecuteWithStdioRestored(func() {
rebaseMsg, err = editor.OpenTempEditor(editorStr, initialRebaseMsg, "")
})
if err != nil {
return nil, err
}
return parseRebaseMessage(rebaseMsg)
}
// buildInitialRebaseMsg builds the initial message to display to the user when they open the rebase plan editor,
// including the formatted rebase plan.
func buildInitialRebaseMsg(sqlCtx *sql.Context, queryist cli.Queryist, rebaseBranch, currentBranch string) (string, error) {
var buffer bytes.Buffer
rows, err := cli.GetRowsForSql(queryist, sqlCtx, "SELECT action, commit_hash, commit_message FROM dolt_rebase ORDER BY rebase_order")
if err != nil {
return "", err
}
// rebase plan
for _, row := range rows {
action, found := getRebaseAction(row[0])
if !found {
return "", errors.New("invalid rebase action")
}
commitHash, ok, err := sql.Unwrap[string](sqlCtx, row[1])
if err != nil {
return "", err
}
if !ok {
return "", fmt.Errorf("unexpected type for commit_hash; expected string, found %T", commitHash)
}
commitMessage, ok, err := sql.Unwrap[string](sqlCtx, row[2])
if err != nil {
return "", err
}
if !ok {
return "", fmt.Errorf("unexpected type for commit_message; expected string, found %T", commitMessage)
}
// Match Git's behavior and filter out newlines
commitMessage = strings.Replace(commitMessage, "\n", " ", -1)
buffer.WriteString(fmt.Sprintf("%s %s %s\n", action, commitHash, commitMessage))
}
buffer.WriteString("\n")
// help text
rebaseBranchHash, err := getHashOf(queryist, sqlCtx, rebaseBranch)
if err != nil {
return "", err
}
currentBranchHash, err := getHashOf(queryist, sqlCtx, currentBranch)
if err != nil {
return "", err
}
numSteps := len(rows)
buffer.WriteString(fmt.Sprintf("# Rebase %s..%s onto %s (%d commands)\n#\n", rebaseBranchHash, currentBranchHash, rebaseBranchHash, numSteps))
buffer.WriteString("# Commands:\n")
buffer.WriteString("# p, pick <commit> = use commit\n")
buffer.WriteString("# d, drop <commit> = remove commit\n")
buffer.WriteString("# e, edit <commit> = use commit, but stop for amending\n")
buffer.WriteString("# r, reword <commit> = use commit, but edit the commit message\n")
buffer.WriteString("# s, squash <commit> = use commit, but meld into previous commit\n")
buffer.WriteString("# f, fixup <commit> = like \"squash\", but discard this commit's message\n")
buffer.WriteString("# These lines can be re-ordered; they are executed from top to bottom.\n")
buffer.WriteString("#\n")
buffer.WriteString("# If you remove a line here THAT COMMIT WILL BE LOST.\n")
buffer.WriteString("#\n")
buffer.WriteString("# However, if you remove everything, the rebase will be aborted.\n")
buffer.WriteString("#\n")
return buffer.String(), nil
}
// getRebaseAction returns the rebase action for the given row. This conversion is necessary because a local client
// returns an int representing the enum whereas a remote client properly returns the label.
// TODO: Remove this once the local client returns the label.
func getRebaseAction(col interface{}) (string, bool) {
action, ok := col.(string)
if ok {
return action, true
} else {
return dprocedures.RebaseActionEnumType.At(int(col.(uint16)))
}
}
// rebaseActionMap maps short action forms to their full names
var rebaseActionMap = map[string]string{
"p": rebase.RebaseActionPick,
"r": rebase.RebaseActionReword,
"e": rebase.RebaseActionEdit,
"s": rebase.RebaseActionSquash,
"f": rebase.RebaseActionFixup,
"d": rebase.RebaseActionDrop,
// Also accept full names
rebase.RebaseActionPick: rebase.RebaseActionPick,
rebase.RebaseActionReword: rebase.RebaseActionReword,
rebase.RebaseActionEdit: rebase.RebaseActionEdit,
rebase.RebaseActionSquash: rebase.RebaseActionSquash,
rebase.RebaseActionFixup: rebase.RebaseActionFixup,
rebase.RebaseActionDrop: rebase.RebaseActionDrop,
}
func expandRebaseAction(action string) (string, error) {
if fullAction, ok := rebaseActionMap[action]; ok {
return fullAction, nil
}
return "", fmt.Errorf("unknown action in rebase plan: %s", action)
}
// parseRebaseMessage parses the rebase message from the editor and adds all uncommented out lines as steps in the rebase plan.
func parseRebaseMessage(rebaseMsg string) (*rebase.RebasePlan, error) {
plan := &rebase.RebasePlan{}
splitMsg := strings.Split(rebaseMsg, "\n")
for i, line := range splitMsg {
if !strings.HasPrefix(line, "#") && strings.TrimSpace(line) != "" {
rebaseStepParts := strings.SplitN(line, " ", 3)
if len(rebaseStepParts) != 3 {
return nil, fmt.Errorf("invalid line %d: %s", i, line)
}
expandedAction, err := expandRebaseAction(rebaseStepParts[0])
if err != nil {
return nil, fmt.Errorf("line %d: %s", i+1, err.Error())
}
plan.Steps = append(plan.Steps, rebase.RebasePlanStep{
Action: expandedAction,
CommitHash: rebaseStepParts[1],
CommitMsg: rebaseStepParts[2],
})
}
}
return plan, nil
}
// insertRebasePlanIntoDoltRebaseTable inserts the rebase plan into the dolt_rebase table by re-building the dolt_rebase
// table from scratch.
func insertRebasePlanIntoDoltRebaseTable(plan *rebase.RebasePlan, sqlCtx *sql.Context, queryist cli.Queryist) error {
_, err := cli.GetRowsForSql(queryist, sqlCtx, "TRUNCATE TABLE dolt_rebase")
if err != nil {
return err
}
for i, step := range plan.Steps {
_, err := cli.GetRowsForSql(queryist, sqlCtx, fmt.Sprintf("INSERT INTO dolt_rebase VALUES (%d, '%s', '%s', '%s')", i+1, step.Action, step.CommitHash, step.CommitMsg))
if err != nil {
return err
}
}
return nil
}
// syncCliBranchToSqlSessionBranch sets the current branch for the CLI (in repo_state.json) to the active branch
// for the current session. This is needed during rebasing, as the user may need to stop in the middle of the
// process to handle a conflict or an edit operation.
func syncCliBranchToSqlSessionBranch(ctx *sql.Context, dEnv *env.DoltEnv) error {
doltSession := dsess.DSessFromSess(ctx.Session)
currentBranch, err := doltSession.GetBranch(ctx)
if err != nil {
return err
}
return saveHeadBranch(dEnv.FS, currentBranch)
}
// isRebaseConflictError checks if the given error represents a rebase pause condition
// (data conflicts or verification failure) that should not abort the rebase but instead
// allow the user to resolve/continue.
func isRebaseConflictError(err error) bool {
if err == nil {
return false
}
// Check typed errors first (for local execution)
if dprocedures.ErrRebaseDataConflict.Is(err) {
return true
}
if dprocedures.ErrRebaseVerificationFailed.Is(err) {
return true
}
if actions.ErrCommitVerificationFailed.Is(err) {
return true
}
// For over-the-wire errors that lose their type, match against error message patterns.
// Use Contains instead of HasPrefix because MySQL wire errors are prefixed with
// "Error 1105 (HY000): " by the go-mysql-driver.
errMsg := err.Error()
return strings.Contains(errMsg, dprocedures.RebaseDataConflictPrefix) ||
strings.Contains(errMsg, dprocedures.RebaseVerificationFailedPrefix) ||
strings.Contains(errMsg, actions.CommitVerificationFailedPrefix)
}