wehub-resource-sync
78 lines
3.3 KiB
TypeScript
78 lines
3.3 KiB
TypeScript
/**
|
|
* #3199 follow-up to #3204 — a deleted synced (fetched) model must STAY deleted
|
|
* across an auto-fetch re-import.
|
|
*
|
|
* #3204 added `removeSyncedAvailableModel`, but the DELETE route did not mark the
|
|
* model deleted and `replaceSyncedAvailableModelsForConnection` did not skip
|
|
* deleted ids — so the next `/models` sync re-imported the model and it
|
|
* reappeared. This test guards that a deleted id is filtered out on re-import.
|
|
*
|
|
* #3782 update: the delete marker is now the DISTINCT `isDeleted` flag (the route
|
|
* sets `isDeleted` + `isHidden`), separate from the EYE/visibility toggle which
|
|
* sets `isHidden` only and must be preserved across re-syncs. The sync filter
|
|
* keys on `isDeleted`, so this test now simulates the route via `isDeleted`.
|
|
*/
|
|
import test, { before, after } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import fs from "node:fs";
|
|
|
|
// Hermetic DB: this test marks a model hidden (an override persisted in the
|
|
// `modelCompatOverrides` key_value namespace). Without an isolated DATA_DIR it
|
|
// would write that override into the shared dev/CI database and never clean it
|
|
// up, so the SECOND run would see `model-del` already hidden and the first-sync
|
|
// precondition would fail. Point DATA_DIR at a throwaway dir before any import
|
|
// that opens the SQLite connection.
|
|
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-test-synced-del-"));
|
|
process.env.DATA_DIR = tmpDir;
|
|
|
|
const {
|
|
replaceSyncedAvailableModelsForConnection,
|
|
getSyncedAvailableModels,
|
|
mergeModelCompatOverride,
|
|
} = await import("../../src/lib/localDb.ts");
|
|
const { resetDbInstance } = await import("../../src/lib/db/core.ts");
|
|
|
|
before(() => {
|
|
resetDbInstance();
|
|
});
|
|
|
|
after(() => {
|
|
resetDbInstance();
|
|
fs.rmSync(tmpDir, { recursive: true, force: true });
|
|
});
|
|
|
|
test("a hidden (deleted) synced model is not re-added on re-import", async () => {
|
|
const provider = "llama-cpp";
|
|
const connectionId = "conn-3199";
|
|
|
|
// Initial sync brings in two models.
|
|
await replaceSyncedAvailableModelsForConnection(provider, connectionId, [
|
|
{ id: "model-keep", name: "Keep" },
|
|
{ id: "model-del", name: "Delete me" },
|
|
]);
|
|
let synced = (await getSyncedAvailableModels(provider)).map((m) => m.id);
|
|
assert.ok(synced.includes("model-del"), "both models present after first sync");
|
|
|
|
// Operator deletes model-del → the DELETE route marks it deleted.
|
|
// #3782: the route now writes the DISTINCT `isDeleted` marker (plus `isHidden`
|
|
// for back-compat) instead of bare `isHidden`, so an eye/visibility-hidden
|
|
// model — which sets `isHidden` only — is preserved across a re-sync while a
|
|
// genuinely-deleted one stays dropped. The sync filter keys on `isDeleted`.
|
|
mergeModelCompatOverride(provider, "model-del", { isDeleted: true, isHidden: true });
|
|
|
|
// Auto-fetch re-imports the SAME upstream list (still advertising model-del).
|
|
await replaceSyncedAvailableModelsForConnection(provider, connectionId, [
|
|
{ id: "model-keep", name: "Keep" },
|
|
{ id: "model-del", name: "Delete me" },
|
|
]);
|
|
|
|
synced = (await getSyncedAvailableModels(provider)).map((m) => m.id);
|
|
assert.ok(synced.includes("model-keep"), "non-deleted model stays");
|
|
assert.ok(
|
|
!synced.includes("model-del"),
|
|
"deleted (hidden) model must NOT be re-added by the re-import"
|
|
);
|
|
});
|