diegosouzapw--omniroute/tests/unit/provider-metrics-route.test.ts

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";

const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-provider-metrics-route-"));
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
process.env.DATA_DIR = TEST_DATA_DIR;

const core = await import("../../src/lib/db/core.ts");
const providerMetricsRoute = await import("../../src/app/api/provider-metrics/route.ts");

type ProviderMetricsResponse = {
  metrics: Record<
    string,
    {
      totalRequests: number;
      totalSuccesses: number;
      successRate: number;
      lastRequestAt: string | null;
      lastErrorAt: string | null;
      lastStatus: number | null;
      lastErrorStatus: number | null;
    }
  >;
  topology: {
    providers: string[];
    lastProvider: string;
    errorProvider: string;
  };
};

function resetStorage() {
  core.resetDbInstance();
  fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
  fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}

test.beforeEach(() => {
  resetStorage();
});

test.after(() => {
  core.resetDbInstance();
  fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });

  if (ORIGINAL_DATA_DIR === undefined) {
    delete process.env.DATA_DIR;
  } else {
    process.env.DATA_DIR = ORIGINAL_DATA_DIR;
  }
});

test("GET /api/provider-metrics includes provider recency and error topology", async () => {
  const db = core.getDbInstance();
  db.prepare(
    `INSERT INTO call_logs (id, timestamp, provider, status, duration, error_summary)
     VALUES (?, ?, ?, ?, ?, ?)`
  ).run("openai-success", "2026-05-22T10:00:00.000Z", "openai", 200, 120, null);
  db.prepare(
    `INSERT INTO call_logs (id, timestamp, provider, status, duration, error_summary)
     VALUES (?, ?, ?, ?, ?, ?)`
  ).run("anthropic-success", "2026-05-22T10:05:00.000Z", "anthropic", 200, 240, null);
  db.prepare(
    `INSERT INTO call_logs (id, timestamp, provider, status, duration, error_summary)
     VALUES (?, ?, ?, ?, ?, ?)`
  ).run("openai-error", "2026-05-22T10:10:00.000Z", "openai", 500, 80, "upstream error");

  const response = await providerMetricsRoute.GET();
  const body = (await response.json()) as ProviderMetricsResponse;

  assert.equal(response.status, 200);
  assert.equal(body.metrics.openai.totalRequests, 2);
  assert.equal(body.metrics.openai.totalSuccesses, 1);
  assert.equal(body.metrics.openai.successRate, 50);
  assert.equal(body.metrics.openai.lastRequestAt, "2026-05-22T10:10:00.000Z");
  assert.equal(body.metrics.openai.lastErrorAt, "2026-05-22T10:10:00.000Z");
  assert.equal(body.metrics.openai.lastStatus, 500);
  assert.equal(body.metrics.openai.lastErrorStatus, 500);
  assert.equal(body.metrics.anthropic.lastRequestAt, "2026-05-22T10:05:00.000Z");
  assert.equal(body.metrics.anthropic.lastErrorAt, null);
  assert.deepEqual(body.topology.providers.sort(), ["anthropic", "openai"]);
  assert.equal(body.topology.lastProvider, "openai");
  assert.equal(body.topology.errorProvider, "openai");
});

test("GET /api/provider-metrics errorProvider must NOT flag a provider whose most recent request succeeded", async () => {
  // Arrange: providerA had an error long ago but recovered (last request = 200).
  //          providerB never errored.
  // Bug (pre-fix): errorProvider = "providerA" because lastErrorAt > 0.
  // Fix (post-fix): errorProvider = "" because lastStatus for providerA is 200.
  const db = core.getDbInstance();
  db.prepare(
    `INSERT INTO call_logs (id, timestamp, provider, status, duration, error_summary)
     VALUES (?, ?, ?, ?, ?, ?)`
  ).run("a-old-error", "2026-01-01T00:00:00.000Z", "providerA", 500, 100, "old error");
  db.prepare(
    `INSERT INTO call_logs (id, timestamp, provider, status, duration, error_summary)
     VALUES (?, ?, ?, ?, ?, ?)`
  ).run("a-recent-ok", "2026-06-01T00:00:00.000Z", "providerA", 200, 80, null);
  db.prepare(
    `INSERT INTO call_logs (id, timestamp, provider, status, duration, error_summary)
     VALUES (?, ?, ?, ?, ?, ?)`
  ).run("b-ok", "2026-05-01T00:00:00.000Z", "providerB", 200, 60, null);

  const response = await providerMetricsRoute.GET();
  const body = (await response.json()) as ProviderMetricsResponse;

  assert.equal(response.status, 200);
  // providerA's last request succeeded — must NOT appear as errorProvider
  assert.notEqual(
    body.topology.errorProvider,
    "providerA",
    "providerA recovered (lastStatus=200) and must not be marked as errorProvider"
  );
  // No provider is currently in error — errorProvider should be empty
  assert.equal(
    body.topology.errorProvider,
    "",
    "errorProvider must be empty when no provider's most recent request was a failure"
  );
});

test("GET /api/provider-metrics returns sanitized 500 when metrics cannot be loaded", async () => {
  const db = core.getDbInstance();
  db.close();

  const response = await providerMetricsRoute.GET();
  const body = await response.json();

  assert.equal(response.status, 500);
  assert.equal(body.error?.message, "Failed to load provider metrics");
  assert.equal(body.error?.message.includes("at /"), false);
  assert.equal(JSON.stringify(body).includes("SqliteError"), false);
});