446 lines
17 KiB
TypeScript
446 lines
17 KiB
TypeScript
/**
|
|
* Combo response-quality validation extracted from combo.ts.
|
|
*
|
|
* `validateResponseQuality` (bounded SSE peek + non-streaming content check) and
|
|
* `toRetryAfterDisplayValue` moved out of the combo.ts god-file (Quality Gate v2
|
|
* / Fase 9). Logic unchanged; re-exported from combo.ts for compatibility.
|
|
*/
|
|
|
|
import {
|
|
createSSEDataLineNormalizer,
|
|
isKnownNonClaudeStreamPayload,
|
|
} from "../../utils/streamHelpers.ts";
|
|
import { evaluateResponseValidation, type ResponseValidationConfig } from "./responseValidation.ts";
|
|
import { getReasoningTokens } from "../../../src/lib/usage/tokenAccounting.ts";
|
|
import type { ComboRetryAfter } from "./types.ts";
|
|
|
|
export function toRetryAfterDisplayValue(value: ComboRetryAfter): string | Date {
|
|
if (typeof value !== "number") return value;
|
|
if (value > 0 && value < 1_000_000_000) {
|
|
return new Date(Date.now() + value * 1000);
|
|
}
|
|
return new Date(value);
|
|
}
|
|
|
|
function responsesApiOutputHasContent(output: unknown): boolean {
|
|
return (
|
|
Array.isArray(output) &&
|
|
output.some((item) => {
|
|
if (!item || typeof item !== "object") return false;
|
|
const record = item as Record<string, unknown>;
|
|
if (record.type !== "message") return Boolean(record.type);
|
|
const content = record.content;
|
|
return (
|
|
Array.isArray(content) &&
|
|
content.some(
|
|
(part) =>
|
|
!!part &&
|
|
typeof part === "object" &&
|
|
typeof (part as Record<string, unknown>).text === "string" &&
|
|
((part as Record<string, string>).text as string).length > 0
|
|
)
|
|
);
|
|
})
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Validate that a successful (HTTP 200) non-streaming response actually contains
|
|
* meaningful content. Returns { valid: true } or { valid: false, reason }.
|
|
*
|
|
* Only inspects non-streaming JSON responses — streaming responses are passed through
|
|
* because buffering the full stream would defeat the purpose of streaming.
|
|
*
|
|
* Checks:
|
|
* 1. Body is valid JSON
|
|
* 2. Has at least one choice with non-empty content or tool_calls
|
|
*/
|
|
export async function validateResponseQuality(
|
|
response: Response,
|
|
isStreaming: boolean,
|
|
log: { warn?: (...args: unknown[]) => void },
|
|
responseValidation?: ResponseValidationConfig | null
|
|
): Promise<{ valid: boolean; reason?: string; clonedResponse?: Response }> {
|
|
// Issue #3685: For Claude SSE streaming responses, use a BOUNDED PEEK to
|
|
// detect the empty-content-block pattern (content_filter stop_reason with
|
|
// no content_block_* events) WITHOUT de-streaming non-empty responses.
|
|
//
|
|
// Parse SSE events incrementally. Stop buffering once a content_block_* event
|
|
// or a known non-Claude SSE payload appears, replay the buffered prefix, then
|
|
// pipe the original reader so the rest of the stream keeps flowing normally.
|
|
// Only fail over when a complete Claude lifecycle ends without content_block.
|
|
//
|
|
// Non-text/event-stream streaming responses are not buffered at all.
|
|
if (isStreaming) {
|
|
const contentType = response.headers.get("content-type") || "";
|
|
if (!contentType.includes("text/event-stream")) {
|
|
return { valid: true };
|
|
}
|
|
|
|
if (!response.body) {
|
|
return { valid: true };
|
|
}
|
|
|
|
const reader = response.body.getReader();
|
|
const decoder = new TextDecoder("utf-8");
|
|
|
|
// Raw Uint8Array chunks accumulated so far — used to replay the prefix
|
|
// in the returned clonedResponse.
|
|
const bufferedChunks: Uint8Array[] = [];
|
|
// Decoded text accumulated across chunks for incremental SSE parsing.
|
|
// Only the tail of the most-recently-processed line window remains here
|
|
// between iterations (incomplete lines are deferred to the next chunk).
|
|
let decodedSoFar = "";
|
|
|
|
// SSE lifecycle state.
|
|
let hasMessageStart = false;
|
|
let hasContentBlock = false;
|
|
let hasLifecycleEnd = false;
|
|
let anyContentFound = false;
|
|
let sawAnyBytes = false;
|
|
const sseLineNormalizer = createSSEDataLineNormalizer();
|
|
let pendingEventType = "";
|
|
|
|
/**
|
|
* Parse any complete SSE lines from `decodedSoFar`, updating lifecycle
|
|
* flags in the closure. The last (potentially incomplete) line is kept in
|
|
* `decodedSoFar` for the next iteration.
|
|
*
|
|
* Returns true when a content_block_* event is detected — the caller
|
|
* should stop peeking and treat the stream as non-empty.
|
|
*/
|
|
function parseAccumulatedSse(): boolean {
|
|
const lines = decodedSoFar.split(/\r?\n/);
|
|
// Retain the potentially-incomplete trailing fragment.
|
|
decodedSoFar = lines[lines.length - 1];
|
|
|
|
for (const line of sseLineNormalizer.normalize(lines.slice(0, -1))) {
|
|
const trimmed = line.trim();
|
|
|
|
if (trimmed.startsWith("event:")) {
|
|
pendingEventType = trimmed.slice(6).trim();
|
|
continue;
|
|
}
|
|
|
|
if (!trimmed.startsWith("data:")) {
|
|
if (!trimmed) pendingEventType = "";
|
|
continue;
|
|
}
|
|
|
|
const data = trimmed.slice(5).trim();
|
|
if (!data || data === "[DONE]") continue;
|
|
|
|
let parsed: Record<string, unknown>;
|
|
try {
|
|
parsed = JSON.parse(data);
|
|
} catch {
|
|
continue;
|
|
}
|
|
|
|
const eventType =
|
|
(typeof parsed.type === "string" ? parsed.type : null) || pendingEventType || "";
|
|
pendingEventType = "";
|
|
|
|
if (isKnownNonClaudeStreamPayload(parsed, eventType)) {
|
|
return true;
|
|
}
|
|
|
|
switch (eventType) {
|
|
case "message_start":
|
|
hasMessageStart = true;
|
|
break;
|
|
case "content_block_start":
|
|
case "content_block_delta":
|
|
case "content_block_stop":
|
|
hasContentBlock = true;
|
|
// Signal caller to stop buffering immediately.
|
|
return true;
|
|
case "message_stop":
|
|
hasLifecycleEnd = true;
|
|
break;
|
|
case "message_delta": {
|
|
const delta = parsed.delta;
|
|
if (
|
|
delta &&
|
|
typeof delta === "object" &&
|
|
(delta as Record<string, unknown>).stop_reason != null
|
|
) {
|
|
hasLifecycleEnd = true;
|
|
}
|
|
break;
|
|
}
|
|
default:
|
|
break;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* Build a Response whose body first replays all bytes in `bufferedChunks`,
|
|
* then forwards the remainder of `readerToForward` chunk-by-chunk.
|
|
* Preserves the original response's status, statusText, and headers.
|
|
*/
|
|
function buildReplayResponse(
|
|
readerToForward: ReadableStreamDefaultReader<Uint8Array>
|
|
): Response {
|
|
// Snapshot the prefix so mutations after this point don't affect it.
|
|
const prefix = bufferedChunks.slice();
|
|
let prefixIdx = 0;
|
|
const stream = new ReadableStream<Uint8Array>({
|
|
async pull(controller) {
|
|
// 1. Drain the buffered prefix one chunk at a time.
|
|
if (prefixIdx < prefix.length) {
|
|
controller.enqueue(prefix[prefixIdx++]);
|
|
return;
|
|
}
|
|
// 2. Forward the remainder from the original reader.
|
|
try {
|
|
const { done, value } = await readerToForward.read();
|
|
if (done) {
|
|
controller.close();
|
|
} else {
|
|
controller.enqueue(value);
|
|
}
|
|
} catch {
|
|
controller.close();
|
|
}
|
|
},
|
|
});
|
|
return new Response(stream, {
|
|
status: response.status,
|
|
statusText: response.statusText,
|
|
headers: response.headers,
|
|
});
|
|
}
|
|
|
|
// Main bounded-peek loop.
|
|
try {
|
|
while (true) {
|
|
const { done, value } = await reader.read();
|
|
|
|
if (done) {
|
|
// Stream finished — flush the TextDecoder and parse any remaining text.
|
|
const tail = decoder.decode(undefined, { stream: false });
|
|
if (tail) decodedSoFar += tail;
|
|
if (decodedSoFar.trim()) decodedSoFar += "\n\n";
|
|
parseAccumulatedSse();
|
|
|
|
if (hasMessageStart && hasLifecycleEnd && !hasContentBlock) {
|
|
// Complete Claude lifecycle with zero content blocks → failover.
|
|
log.warn?.(
|
|
"COMBO",
|
|
"Streaming Claude response has complete lifecycle but zero content blocks (content_filter?) — marking as invalid for combo failover"
|
|
);
|
|
return { valid: false, reason: "streaming empty content block" };
|
|
}
|
|
|
|
// Stream ended with a truly EMPTY body (e.g. Gemini returning HTTP
|
|
// 200 with zero bytes) — mark as invalid for combo failover so the
|
|
// sibling model gets tried. Streams that carried ANY SSE activity
|
|
// (an explicit `data: [DONE]`, ping/metadata events, an incomplete
|
|
// Claude lifecycle) keep the pass-through contract (#3399/#3685):
|
|
// those are handled by the stream-readiness timeout, not failover.
|
|
if (!anyContentFound && !hasContentBlock && !sawAnyBytes) {
|
|
log.warn?.(
|
|
"COMBO",
|
|
"Streaming response ended with no recognized content — marking as invalid for combo failover"
|
|
);
|
|
return { valid: false, reason: "streaming no recognized content" };
|
|
}
|
|
|
|
// Incomplete lifecycle or non-Claude stream — replay all buffered
|
|
// bytes. The reader is exhausted so the forwarding reader will
|
|
// immediately signal done.
|
|
const clonedResponse = buildReplayResponse(reader);
|
|
return { valid: true, clonedResponse };
|
|
}
|
|
|
|
// Accumulate raw bytes for potential replay.
|
|
bufferedChunks.push(value);
|
|
if (value && value.length > 0) sawAnyBytes = true;
|
|
|
|
// Decode incrementally (stream:true keeps multi-byte char state).
|
|
decodedSoFar += decoder.decode(value, { stream: true });
|
|
const foundContent = parseAccumulatedSse();
|
|
|
|
if (foundContent) {
|
|
anyContentFound = true;
|
|
// A content_block_* event was found — stop peeking. Return a
|
|
// clonedResponse that replays all buffered bytes (the current chunk
|
|
// is already in bufferedChunks) and then forwards the remainder of
|
|
// the original reader unchanged.
|
|
const clonedResponse = buildReplayResponse(reader);
|
|
return { valid: true, clonedResponse };
|
|
}
|
|
}
|
|
} catch (streamErr) {
|
|
// If reading the stream fails due to a locked stream or pipe error,
|
|
// the content cannot be verified — mark as invalid for combo failover.
|
|
// A locked ReadableStream means the response body is already consumed
|
|
// or corrupted (e.g. "Invalid state: The ReadableStream is locked").
|
|
// Broad match: Chrome/V8 throws "body used already", Firefox throws
|
|
// "ReadableStream is locked", etc.
|
|
const errMsg = streamErr instanceof Error ? streamErr.message : String(streamErr);
|
|
if (
|
|
streamErr instanceof TypeError &&
|
|
(errMsg.includes("locked") ||
|
|
errMsg.includes("disturbed") ||
|
|
errMsg.includes("used already"))
|
|
) {
|
|
return { valid: false, reason: "stream locked or disturbed" };
|
|
}
|
|
// Other read errors — pass through (stream readiness timeout will catch truly broken streams)
|
|
return { valid: true };
|
|
}
|
|
}
|
|
|
|
const contentType = response.headers.get("content-type") || "";
|
|
if (!contentType.includes("application/json") && !contentType.includes("text/")) {
|
|
return { valid: true };
|
|
}
|
|
|
|
let cloned: Response;
|
|
try {
|
|
cloned = response.clone();
|
|
} catch {
|
|
return { valid: true };
|
|
}
|
|
|
|
let text: string;
|
|
try {
|
|
text = await cloned.text();
|
|
} catch {
|
|
return { valid: true };
|
|
}
|
|
|
|
if (!text || text.trim().length === 0) {
|
|
return { valid: false, reason: "empty response body" };
|
|
}
|
|
|
|
let json: Record<string, unknown>;
|
|
try {
|
|
json = JSON.parse(text);
|
|
} catch {
|
|
if (text.startsWith("data:") || text.startsWith("event:")) return { valid: true };
|
|
return { valid: false, reason: "response is not valid JSON" };
|
|
}
|
|
|
|
// Feature 4985: apply the combo's configured response-body predicate. A failure here
|
|
// fails over to the next target via the same path as the built-in empty-content checks.
|
|
if (responseValidation) {
|
|
const verdict = evaluateResponseValidation(json, responseValidation);
|
|
if (!verdict.valid) {
|
|
return { valid: false, reason: verdict.reason };
|
|
}
|
|
}
|
|
|
|
const choices = json?.choices;
|
|
if (json?.object === "response") {
|
|
if (!responsesApiOutputHasContent(json.output))
|
|
return { valid: false, reason: "empty_choices" };
|
|
const status = typeof json.status === "string" ? json.status : "";
|
|
if (status && !["completed", "done"].includes(status)) {
|
|
return { valid: false, reason: "no_terminal" };
|
|
}
|
|
return {
|
|
valid: true,
|
|
clonedResponse: new Response(text, {
|
|
status: response.status,
|
|
statusText: response.statusText,
|
|
headers: response.headers,
|
|
}),
|
|
};
|
|
}
|
|
|
|
if (!Array.isArray(choices) || choices.length === 0) {
|
|
if (json?.output || json?.result || json?.data || json?.response) return { valid: true };
|
|
if (json?.error) {
|
|
const err = json.error as Record<string, unknown>;
|
|
return {
|
|
valid: false,
|
|
reason: `upstream error in 200 body: ${err?.message || JSON.stringify(json.error).substring(0, 200)}`,
|
|
};
|
|
}
|
|
return { valid: true };
|
|
}
|
|
|
|
const firstChoice = choices[0];
|
|
const message = firstChoice?.message || firstChoice?.delta;
|
|
if (!message) {
|
|
return { valid: false, reason: "choice has no message object" };
|
|
}
|
|
|
|
const content = message.content;
|
|
const toolCalls = message.tool_calls;
|
|
// Issue #2341: Reasoning models (Kimi-K2.5-TEE, GLM-5-TEE, etc.) emit their
|
|
// output in `reasoning_content` (or `reasoning`) with `content: null`. The
|
|
// validator used to flag those as empty and trigger a false-positive 502
|
|
// fallback. Count a non-empty reasoning_content as valid output too.
|
|
const reasoningContent = message.reasoning_content ?? message.reasoning;
|
|
const hasReasoningContent =
|
|
typeof reasoningContent === "string" && reasoningContent.trim().length > 0;
|
|
const hasContent =
|
|
(content !== null && content !== undefined && content !== "") || hasReasoningContent;
|
|
const hasToolCalls = Array.isArray(toolCalls) && toolCalls.length > 0;
|
|
|
|
if (!hasContent && !hasToolCalls) {
|
|
return { valid: false, reason: "empty content and no tool_calls in response" };
|
|
}
|
|
|
|
// Issue #3587: Reasoning models (deepseek-v4-flash, nemotron, etc.) may consume
|
|
// ALL max_tokens for reasoning_tokens, leaving content empty. When content is
|
|
// empty but reasoning_content exists, and usage shows reasoning consumed nearly
|
|
// all completion tokens, treat as invalid so the combo loop retries with more
|
|
// tokens or falls back to a non-reasoning model.
|
|
const contentIsEmpty = content === null || content === undefined || content === "";
|
|
if (contentIsEmpty && hasReasoningContent && !hasToolCalls) {
|
|
const usage = json?.usage as Record<string, unknown> | undefined;
|
|
if (usage) {
|
|
const completionTokens = Number(usage.completion_tokens) || 0;
|
|
const reasoningTokens = getReasoningTokens(usage);
|
|
// If reasoning consumed 90%+ of completion tokens, the model ran out of
|
|
// budget before producing any content output.
|
|
if (completionTokens > 0 && reasoningTokens >= completionTokens * 0.9) {
|
|
return {
|
|
valid: false,
|
|
reason: `reasoning consumed ${reasoningTokens}/${completionTokens} tokens — no content output`,
|
|
};
|
|
}
|
|
}
|
|
}
|
|
|
|
return {
|
|
valid: true,
|
|
clonedResponse: new Response(text, {
|
|
status: response.status,
|
|
statusText: response.statusText,
|
|
headers: response.headers,
|
|
}),
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Release the peek-and-abandon clone used by {@link validateResponseQuality}.
|
|
*
|
|
* The quality check clones the upstream response, reads the clone only until the
|
|
* first content block, then hands back a `clonedResponse` that callers on the
|
|
* streaming path DISCARD (they forward the original, untouched response). Because
|
|
* a `Response.clone()` tees the body, that abandoned branch would otherwise buffer
|
|
* the entire remaining body in memory until the original finishes streaming.
|
|
*
|
|
* Cancelling the abandoned branch releases that buffer. Per the ReadableStream tee
|
|
* contract, cancelling one branch does NOT cancel the shared source while the other
|
|
* branch (the original response being streamed to the client) is still active, so
|
|
* this is safe. No-op when the clone fell back to the original (clone unsupported)
|
|
* or when quality reading already exhausted the body (no `clonedResponse`).
|
|
*/
|
|
export function releaseQualityClone(
|
|
clone: Response,
|
|
original: Response,
|
|
quality: { clonedResponse?: Response }
|
|
): void {
|
|
if (clone === original) return;
|
|
void quality.clonedResponse?.body?.cancel().catch(() => {});
|
|
}
|