chore: import upstream snapshot with attribution
This commit is contained in:
wehub-resource-sync
@@ -0,0 +1,190 @@
|
||||
/*
|
||||
* test_store_pragmas.c — Tests for SQLite pragma resolution.
|
||||
*
|
||||
* Validates that the CBM_SQLITE_MMAP_SIZE env var controls the mmap_size
|
||||
* pragma applied to on-disk stores. Default behavior (env unset) must
|
||||
* remain 64 MB. Setting the env to 0 disables memory-mapped I/O so
|
||||
* concurrent processes that truncate the DB file under a sibling's live
|
||||
* mapping return SQLITE_IOERR instead of crashing the process with SIGBUS.
|
||||
*/
|
||||
#include "../src/foundation/compat.h"
|
||||
#include "test_framework.h"
|
||||
#include "test_helpers.h"
|
||||
#include <store/store.h>
|
||||
#include <stdio.h>
|
||||
#include <stdlib.h>
|
||||
#include <string.h>
|
||||
#include <unistd.h>
|
||||
|
||||
static void clear_mmap_env(void) {
|
||||
cbm_unsetenv("CBM_SQLITE_MMAP_SIZE");
|
||||
}
|
||||
|
||||
TEST(mmap_size_default_when_unset) {
|
||||
clear_mmap_env();
|
||||
ASSERT_EQ(cbm_store_resolve_mmap_size(), 67108864LL);
|
||||
PASS();
|
||||
}
|
||||
|
||||
TEST(mmap_size_zero_disables_mmap) {
|
||||
cbm_setenv("CBM_SQLITE_MMAP_SIZE", "0", 1);
|
||||
ASSERT_EQ(cbm_store_resolve_mmap_size(), 0LL);
|
||||
clear_mmap_env();
|
||||
PASS();
|
||||
}
|
||||
|
||||
TEST(mmap_size_explicit_value) {
|
||||
cbm_setenv("CBM_SQLITE_MMAP_SIZE", "1048576", 1);
|
||||
ASSERT_EQ(cbm_store_resolve_mmap_size(), 1048576LL);
|
||||
clear_mmap_env();
|
||||
PASS();
|
||||
}
|
||||
|
||||
TEST(mmap_size_negative_clamped_to_zero) {
|
||||
cbm_setenv("CBM_SQLITE_MMAP_SIZE", "-1", 1);
|
||||
ASSERT_EQ(cbm_store_resolve_mmap_size(), 0LL);
|
||||
clear_mmap_env();
|
||||
PASS();
|
||||
}
|
||||
|
||||
TEST(mmap_size_garbage_falls_back_to_default) {
|
||||
cbm_setenv("CBM_SQLITE_MMAP_SIZE", "not-a-number", 1);
|
||||
ASSERT_EQ(cbm_store_resolve_mmap_size(), 67108864LL);
|
||||
clear_mmap_env();
|
||||
PASS();
|
||||
}
|
||||
|
||||
TEST(mmap_size_partial_garbage_falls_back_to_default) {
|
||||
cbm_setenv("CBM_SQLITE_MMAP_SIZE", "123abc", 1);
|
||||
ASSERT_EQ(cbm_store_resolve_mmap_size(), 67108864LL);
|
||||
clear_mmap_env();
|
||||
PASS();
|
||||
}
|
||||
|
||||
/* Integration smoke: opening a file-backed store with mmap_size=0 must
|
||||
* succeed. Proves the resolver is wired through configure_pragmas(). */
|
||||
TEST(store_open_with_mmap_disabled) {
|
||||
cbm_setenv("CBM_SQLITE_MMAP_SIZE", "0", 1);
|
||||
char tmp_path[256];
|
||||
snprintf(tmp_path, sizeof(tmp_path), "%s/cbm_test_pragmas_%d.db", cbm_tmpdir(), (int)getpid());
|
||||
unlink(tmp_path);
|
||||
|
||||
cbm_store_t *s = cbm_store_open_path(tmp_path);
|
||||
ASSERT(s != NULL);
|
||||
cbm_store_close(s);
|
||||
|
||||
unlink(tmp_path);
|
||||
/* WAL/SHM siblings created by the open */
|
||||
char tmp_wal[300];
|
||||
char tmp_shm[300];
|
||||
snprintf(tmp_wal, sizeof(tmp_wal), "%s-wal", tmp_path);
|
||||
snprintf(tmp_shm, sizeof(tmp_shm), "%s-shm", tmp_path);
|
||||
unlink(tmp_wal);
|
||||
unlink(tmp_shm);
|
||||
|
||||
clear_mmap_env();
|
||||
PASS();
|
||||
}
|
||||
|
||||
|
||||
/* #896: a row-scan that dies mid-stream (SQLITE_CORRUPT) must surface a
|
||||
* loud store error, not masquerade as a clean end of results. Counts are
|
||||
* answered from covering indexes (still correct) while row fetches die at
|
||||
* the first corrupt table page — the old loops discarded the terminal
|
||||
* sqlite3_step code, so every query surface returned plausible
|
||||
* truncated/empty answers with no error. */
|
||||
TEST(corrupt_page_scan_returns_error_not_truncation) {
|
||||
enum { CORRUPT_NODES = 2000, ZERO_PAGES = 40 };
|
||||
char *td = th_mktempdir("cbm_corrupt");
|
||||
char db_path[512];
|
||||
snprintf(db_path, sizeof(db_path), "%s/c.db", td);
|
||||
|
||||
cbm_store_t *s = cbm_store_open_path(db_path);
|
||||
ASSERT_NOT_NULL(s);
|
||||
cbm_store_upsert_project(s, "corr", "/tmp/corr");
|
||||
for (int i = 0; i < CORRUPT_NODES; i++) {
|
||||
char name[64];
|
||||
char qn[256];
|
||||
snprintf(name, sizeof(name), "corrupt_probe_fn_%04d", i);
|
||||
snprintf(qn, sizeof(qn),
|
||||
"corr.some.rather.long.module.path.to.fill.table.pages.%s_padding_padding",
|
||||
name);
|
||||
cbm_node_t n = {.project = "corr",
|
||||
.label = "Function",
|
||||
.name = name,
|
||||
.qualified_name = qn,
|
||||
.file_path = "src/corrupt_probe.py",
|
||||
.start_line = i + 1,
|
||||
.end_line = i + 2};
|
||||
ASSERT_TRUE(cbm_store_upsert_node(s, &n) > 0);
|
||||
}
|
||||
/* Precondition: a full scan works on the healthy file. */
|
||||
cbm_search_params_t params = {.project = "corr", .label = "Function", .limit = 50};
|
||||
cbm_search_output_t out = {0};
|
||||
ASSERT_EQ(cbm_store_search(s, ¶ms, &out), CBM_STORE_OK);
|
||||
ASSERT_EQ(out.total, CORRUPT_NODES);
|
||||
cbm_store_search_free(&out);
|
||||
cbm_store_close(s);
|
||||
|
||||
/* Zero a band of mid-file pages (the report's dd repro): page 25%..
|
||||
* covers nodes-table leaves on a file this shape. */
|
||||
FILE *f = fopen(db_path, "rb+");
|
||||
ASSERT_NOT_NULL(f);
|
||||
(void)fseek(f, 0, SEEK_END);
|
||||
long fsize = ftell(f);
|
||||
enum { PAGE = 4096 };
|
||||
long page_count = fsize / PAGE;
|
||||
ASSERT_TRUE(page_count > ZERO_PAGES + 8);
|
||||
char zero[PAGE];
|
||||
memset(zero, 0, sizeof(zero));
|
||||
(void)fseek(f, (page_count / 4) * (long)PAGE, SEEK_SET);
|
||||
for (int i = 0; i < ZERO_PAGES; i++) {
|
||||
ASSERT_EQ(fwrite(zero, 1, PAGE, f), (size_t)PAGE);
|
||||
}
|
||||
(void)fclose(f);
|
||||
|
||||
/* The scans must now fail LOUDLY (CBM_STORE_ERR), not truncate. */
|
||||
cbm_store_t *s2 = cbm_store_open_path(db_path);
|
||||
ASSERT_NOT_NULL(s2);
|
||||
/* The scan must CROSS the corrupt band: request every row. */
|
||||
cbm_search_params_t all_params = {.project = "corr", .label = "Function",
|
||||
.limit = CORRUPT_NODES};
|
||||
cbm_search_output_t out2 = {0};
|
||||
int rc_search = cbm_store_search(s2, &all_params, &out2);
|
||||
if (rc_search == CBM_STORE_OK && out2.count == CORRUPT_NODES) {
|
||||
/* Vacuous-guard: a complete, healthy scan means corruption missed
|
||||
* the table pages — rebuild the fixture, don't relax the assert. */
|
||||
FAIL("fixture failed to hit table pages (full scan healthy)");
|
||||
}
|
||||
/* THE BUG (#896): OK + silently truncated rows. Fixed = loud ERR. */
|
||||
ASSERT_EQ(rc_search, CBM_STORE_ERR);
|
||||
cbm_store_search_free(&out2);
|
||||
|
||||
/* Point lookups may legitimately succeed when their row's page
|
||||
* escaped the corrupt band — the class contract is about SCANS. A
|
||||
* second scan surface (qn-suffix, different SQL path) must also err. */
|
||||
cbm_node_t *hits = NULL;
|
||||
int hit_count = 0;
|
||||
int rc_suffix =
|
||||
cbm_store_find_nodes_by_qn_suffix(s2, "corr", "padding_padding", &hits, &hit_count);
|
||||
if (rc_suffix == CBM_STORE_OK && hit_count == CORRUPT_NODES) {
|
||||
FAIL("suffix scan healthy — fixture failed to hit table pages");
|
||||
}
|
||||
ASSERT_EQ(rc_suffix, CBM_STORE_ERR);
|
||||
cbm_store_free_nodes(hits, hit_count);
|
||||
cbm_store_close(s2);
|
||||
|
||||
unlink(db_path);
|
||||
PASS();
|
||||
}
|
||||
|
||||
SUITE(store_pragmas) {
|
||||
RUN_TEST(corrupt_page_scan_returns_error_not_truncation);
|
||||
RUN_TEST(mmap_size_default_when_unset);
|
||||
RUN_TEST(mmap_size_zero_disables_mmap);
|
||||
RUN_TEST(mmap_size_explicit_value);
|
||||
RUN_TEST(mmap_size_negative_clamped_to_zero);
|
||||
RUN_TEST(mmap_size_garbage_falls_back_to_default);
|
||||
RUN_TEST(mmap_size_partial_garbage_falls_back_to_default);
|
||||
RUN_TEST(store_open_with_mmap_disabled);
|
||||
}
|
||||
Reference in New Issue
Block a user