wehub-resource-sync
1 line
3.8 KiB
JSON
1 line
3.8 KiB
JSON
{"content": "# PR Review\n\n**PR Link/Number**: $ARGUMENTS\n\n> **Instructions**: Execute each task in the order given to conduct a thorough code review. Update GitHub with this review.\n> **Important**: The future is now—any improvements or “future” recommendations must be addressed **immediately**.\n\n---\n\n## Task 1: Product Manager Review\n\n**Objective**: Assess from a product management perspective, focusing on:\n- **Business Value**: Does this PR clearly advance our core product goals and deliver immediate ROI?\n- **User Experience**: Is the change intuitive and delightful for users right now? If not, make fixes immediately.\n- **Strategic Alignment**: Does the PR align with current (and long-term, i.e., now) strategic objectives?\n\n**Action**: Provide clear directives on how to ensure maximum user and business impact. All “future” suggestions must be implemented now.\n\n---\n\n## Task 2: Developer Review\n\n**Objective**: Evaluate the code thoroughly from a senior lead engineer perspective:\n1. **Code Quality & Maintainability**: Is the code structured for readability and easy maintenance? If not, refactor now.\n2. **Performance & Scalability**: Will these changes operate efficiently at scale? If not, optimize immediately.\n3. **Best Practices & Standards**: Note any deviation from coding standards and correct it now.\n\n**Action**: Leave a concise yet complete review comment, ensuring all improvements happen immediately—no deferrals.\n\n---\n\n## Task 3: Quality Engineer Review\n\n**Objective**: Verify the overall quality, testing strategy, and reliability of the solution:\n1. **Test Coverage**: Are there sufficient tests (unit, integration, E2E)? If not, add them now.\n2. **Potential Bugs & Edge Cases**: Have all edge cases been considered? If not, address them immediately.\n3. **Regression Risk**: Confirm changes don’t undermine existing functionality. If risk is identified, mitigate now with additional checks or tests.\n\n**Action**: Provide a detailed QA assessment, insisting any “future” improvements be completed right away.\n\n---\n\n## Task 4: Security Engineer Review\n\n**Objective**: Ensure robust security practices and compliance:\n1. **Vulnerabilities**: Could these changes introduce security vulnerabilities? If so, fix them right away.\n2. **Data Handling**: Are we properly protecting sensitive data (e.g., encryption, sanitization)? Address all gaps now.\n3. **Compliance**: Confirm alignment with any relevant security or privacy standards (e.g., OWASP, GDPR, HIPAA). Implement missing requirements immediately.\n\n**Action**: Provide a security assessment. Any recommended fixes typically scheduled for “later” must be addressed now.\n\n---\n\n## Task 5: DevOps Review\n\n**Objective**: Evaluate build, deployment, and monitoring considerations:\n1. **CI/CD Pipeline**: Validate that the PR integrates smoothly with existing build/test/deploy processes. If not, fix it now.\n2. **Infrastructure & Configuration**: Check whether the code changes require immediate updates to infrastructure or configs.\n3. **Monitoring & Alerts**: Identify new monitoring needs or potential improvements and implement them immediately.\n\n**Action**: Provide a DevOps-centric review, insisting that any improvements or tweaks be executed now.\n\n---\n\n## Task 6: UI/UX Designer Review\n\n**Objective**: Ensure optimal user-centric design:\n1. **Visual Consistency**: Confirm adherence to brand/design guidelines. If not, adjust now.\n2. **Usability & Accessibility**: Validate that the UI is intuitive and compliant with accessibility standards. Make any corrections immediately.\n3. **Interaction Flow**: Assess whether the user flow is seamless. If friction exists, refine now.\n\n**Action**: Provide a detailed UI/UX evaluation. Any enhancements typically set for “later” must be done immediately.\n\n---\n\n**End of PR Review**"} |