wehub-resource-sync
307 lines
10 KiB
TypeScript
307 lines
10 KiB
TypeScript
/**
|
|
* Contract: the anchored subagent HUD (rendered above the editor, next to the
|
|
* Todos block) lists exactly the running *detached* subagents as
|
|
* `Id: description` rows and yields no output once nothing qualifies, so the
|
|
* block self-clears. Sync task spawns and eval `agent()` spawns are excluded:
|
|
* their progress is already rendered inline (tool block / eval cell).
|
|
*/
|
|
import { afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "bun:test";
|
|
import * as path from "node:path";
|
|
import { Agent } from "@oh-my-pi/pi-agent-core";
|
|
import { ModelRegistry } from "@oh-my-pi/pi-coding-agent/config/model-registry";
|
|
import { resetSettingsForTest, Settings } from "@oh-my-pi/pi-coding-agent/config/settings";
|
|
import { InteractiveMode, renderSubagentHudLines } from "@oh-my-pi/pi-coding-agent/modes/interactive-mode";
|
|
import {
|
|
type ObservableSession,
|
|
SessionObserverRegistry,
|
|
} from "@oh-my-pi/pi-coding-agent/modes/session-observer-registry";
|
|
import { initTheme } from "@oh-my-pi/pi-coding-agent/modes/theme/theme";
|
|
import { AgentSession } from "@oh-my-pi/pi-coding-agent/session/agent-session";
|
|
import { AuthStorage } from "@oh-my-pi/pi-coding-agent/session/auth-storage";
|
|
import { SessionManager } from "@oh-my-pi/pi-coding-agent/session/session-manager";
|
|
import {
|
|
type AgentProgress,
|
|
type SubagentLifecyclePayload,
|
|
type SubagentProgressPayload,
|
|
TASK_SUBAGENT_LIFECYCLE_CHANNEL,
|
|
TASK_SUBAGENT_PROGRESS_CHANNEL,
|
|
} from "@oh-my-pi/pi-coding-agent/task";
|
|
import { EventBus } from "@oh-my-pi/pi-coding-agent/utils/event-bus";
|
|
import { TempDir } from "@oh-my-pi/pi-utils";
|
|
|
|
function makeSession(overrides: Partial<ObservableSession> & { id: string }): ObservableSession {
|
|
return {
|
|
kind: "subagent",
|
|
label: overrides.id,
|
|
status: "active",
|
|
detached: true,
|
|
lastUpdate: Date.now(),
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function makeProgress(overrides: Partial<AgentProgress> & { id: string }): AgentProgress {
|
|
return {
|
|
index: 0,
|
|
agent: "task",
|
|
agentSource: "bundled",
|
|
status: "running",
|
|
task: "",
|
|
recentTools: [],
|
|
recentOutput: [],
|
|
toolCount: 0,
|
|
requests: 0,
|
|
tokens: 0,
|
|
cost: 0,
|
|
durationMs: 0,
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function makeLifecycle(id: string, index: number, description: string, detached?: boolean): SubagentLifecyclePayload {
|
|
return {
|
|
id,
|
|
index,
|
|
agent: "task",
|
|
agentSource: "bundled",
|
|
description,
|
|
status: "started",
|
|
parentToolCallId: "tool-call",
|
|
detached,
|
|
};
|
|
}
|
|
|
|
function makeProgressPayload(
|
|
id: string,
|
|
index: number,
|
|
description: string,
|
|
detached?: boolean,
|
|
): SubagentProgressPayload {
|
|
return {
|
|
index,
|
|
agent: "task",
|
|
agentSource: "bundled",
|
|
task: description,
|
|
parentToolCallId: "tool-call",
|
|
detached,
|
|
progress: makeProgress({ id, index, description, task: description }),
|
|
};
|
|
}
|
|
|
|
function render(sessions: ObservableSession[], columns = 120): string {
|
|
return Bun.stripANSI(renderSubagentHudLines(sessions, columns).join("\n"));
|
|
}
|
|
|
|
describe("subagent HUD lines", () => {
|
|
beforeAll(async () => {
|
|
await initTheme();
|
|
});
|
|
|
|
it("renders running subagents as Id: description under a Subagents header", () => {
|
|
const out = render([
|
|
makeSession({ id: "AuthLoader", description: "Refactoring the auth flow" }),
|
|
makeSession({ id: "SchemaMigrator", description: "Migrating the users table" }),
|
|
]);
|
|
expect(out).toContain("Subagents");
|
|
expect(out).toContain("AuthLoader: Refactoring the auth flow");
|
|
expect(out).toContain("SchemaMigrator: Migrating the users table");
|
|
});
|
|
|
|
it("only shows active subagents and clears once everything finished", () => {
|
|
const finishedStates = ["completed", "failed", "aborted"] as const;
|
|
const sessions: ObservableSession[] = [
|
|
{ id: "main", kind: "main", label: "Main Session", status: "active", lastUpdate: Date.now() },
|
|
...finishedStates.map(status => makeSession({ id: `Done-${status}`, status, description: "old work" })),
|
|
];
|
|
expect(renderSubagentHudLines(sessions, 120)).toEqual([]);
|
|
|
|
const out = render([...sessions, makeSession({ id: "StillRunning", description: "live work" })]);
|
|
expect(out).toContain("StillRunning: live work");
|
|
expect(out).not.toContain("Done-");
|
|
expect(out).not.toContain("Main Session");
|
|
});
|
|
|
|
it("falls back to the description and task carried by progress snapshots", () => {
|
|
const fromProgressDesc = render([
|
|
makeSession({ id: "Worker", progress: makeProgress({ id: "Worker", description: "From progress" }) }),
|
|
]);
|
|
expect(fromProgressDesc).toContain("Worker: From progress");
|
|
|
|
const fromTask = render([
|
|
makeSession({ id: "Worker", progress: makeProgress({ id: "Worker", task: "Investigate flaky CI on macOS" }) }),
|
|
]);
|
|
expect(fromTask).toContain("Worker Investigate flaky CI on macOS");
|
|
});
|
|
|
|
it("hides non-detached spawns: sync task calls and eval agent() helpers", () => {
|
|
// Sync task spawn (parent blocked on the call) and eval `agent()` spawn
|
|
// (no detached flag at all) both stay off the HUD.
|
|
const sessions = [
|
|
makeSession({ id: "SyncSpawn", description: "inline task work", detached: false }),
|
|
makeSession({ id: "EvalSpawn", description: "eval cell work", detached: undefined }),
|
|
];
|
|
expect(renderSubagentHudLines(sessions, 120)).toEqual([]);
|
|
|
|
const out = render([...sessions, makeSession({ id: "BackgroundSpawn", description: "detached work" })]);
|
|
expect(out).toContain("BackgroundSpawn: detached work");
|
|
expect(out).not.toContain("SyncSpawn");
|
|
expect(out).not.toContain("EvalSpawn");
|
|
});
|
|
|
|
it("threads the detached flag from lifecycle and progress payloads", () => {
|
|
const eventBus = new EventBus();
|
|
const registry = new SessionObserverRegistry();
|
|
registry.subscribeToEventBus(eventBus);
|
|
|
|
eventBus.emit(TASK_SUBAGENT_LIFECYCLE_CHANNEL, makeLifecycle("Detached", 0, "background work", true));
|
|
eventBus.emit(TASK_SUBAGENT_LIFECYCLE_CHANNEL, makeLifecycle("Inline", 1, "sync work"));
|
|
eventBus.emit(TASK_SUBAGENT_PROGRESS_CHANNEL, makeProgressPayload("FromProgress", 2, "background work", true));
|
|
|
|
const out = render(registry.getSessions());
|
|
expect(out).toContain("Detached: background work");
|
|
expect(out).toContain("FromProgress: background work");
|
|
expect(out).not.toContain("Inline");
|
|
});
|
|
|
|
it("renders nested ids as a breadcrumb and truncates long descriptions to the viewport", () => {
|
|
const out = render([makeSession({ id: "Anna.Bob", description: `start ${"x".repeat(300)} end` })], 60);
|
|
expect(out).toContain("Anna>Bob:");
|
|
expect(out).not.toContain("end");
|
|
for (const line of out.split("\n")) {
|
|
expect(Bun.stringWidth(line)).toBeLessThanOrEqual(60);
|
|
}
|
|
});
|
|
|
|
it("keeps subagent registry order stable while progress arrives out of order", () => {
|
|
const eventBus = new EventBus();
|
|
const registry = new SessionObserverRegistry();
|
|
registry.subscribeToEventBus(eventBus);
|
|
const activeIds = () =>
|
|
registry
|
|
.getSessions()
|
|
.filter(session => session.kind === "subagent" && session.status === "active")
|
|
.map(session => session.id);
|
|
|
|
eventBus.emit(
|
|
TASK_SUBAGENT_LIFECYCLE_CHANNEL,
|
|
makeLifecycle("BlastRadius", 1, "Survey id-keyed downstream consumers"),
|
|
);
|
|
eventBus.emit(
|
|
TASK_SUBAGENT_LIFECYCLE_CHANNEL,
|
|
makeLifecycle("SelectorSurfaces", 0, "Map model-selector resolution surfaces"),
|
|
);
|
|
eventBus.emit(
|
|
TASK_SUBAGENT_LIFECYCLE_CHANNEL,
|
|
makeLifecycle("VariantsSurvey", 2, "Survey tier-variant ids across catalog"),
|
|
);
|
|
|
|
expect(activeIds()).toEqual(["SelectorSurfaces", "BlastRadius", "VariantsSurvey"]);
|
|
|
|
eventBus.emit(
|
|
TASK_SUBAGENT_PROGRESS_CHANNEL,
|
|
makeProgressPayload("VariantsSurvey", 2, "Survey tier-variant ids across catalog"),
|
|
);
|
|
eventBus.emit(
|
|
TASK_SUBAGENT_PROGRESS_CHANNEL,
|
|
makeProgressPayload("BlastRadius", 1, "Survey id-keyed downstream consumers"),
|
|
);
|
|
|
|
expect(activeIds()).toEqual(["SelectorSurfaces", "BlastRadius", "VariantsSurvey"]);
|
|
});
|
|
|
|
it("renders the first eight active detached subagents and summarizes the rest", () => {
|
|
const active = Array.from({ length: 10 }, (_, index) =>
|
|
makeSession({
|
|
id: `Worker${index}`,
|
|
description: `job ${index}`,
|
|
}),
|
|
);
|
|
|
|
const out = render(active, 120);
|
|
|
|
for (const session of active.slice(0, 8)) {
|
|
expect(out).toContain(`${session.id}: ${session.description}`);
|
|
}
|
|
for (const session of active.slice(8)) {
|
|
expect(out).not.toContain(`${session.id}: ${session.description}`);
|
|
}
|
|
expect(out).toContain("2 more running");
|
|
});
|
|
});
|
|
|
|
describe("InteractiveMode subagent observer UI sync", () => {
|
|
let tempDir: TempDir;
|
|
let authStorage: AuthStorage;
|
|
let session: AgentSession;
|
|
let mode: InteractiveMode;
|
|
let eventBus: EventBus;
|
|
|
|
beforeAll(async () => {
|
|
await initTheme();
|
|
});
|
|
|
|
beforeEach(async () => {
|
|
resetSettingsForTest();
|
|
tempDir = TempDir.createSync("@pi-subagent-observer-");
|
|
await Settings.init({
|
|
inMemory: true,
|
|
cwd: tempDir.path(),
|
|
overrides: { "startup.quiet": true },
|
|
});
|
|
authStorage = await AuthStorage.create(path.join(tempDir.path(), "testauth.db"));
|
|
const modelRegistry = new ModelRegistry(authStorage);
|
|
const model = modelRegistry.find("anthropic", "claude-sonnet-4-5");
|
|
if (!model) throw new Error("Expected claude-sonnet-4-5 to exist in registry");
|
|
|
|
eventBus = new EventBus();
|
|
session = new AgentSession({
|
|
agent: new Agent({
|
|
initialState: {
|
|
model,
|
|
systemPrompt: ["Test"],
|
|
tools: [],
|
|
messages: [],
|
|
},
|
|
}),
|
|
sessionManager: SessionManager.create(tempDir.path(), tempDir.path()),
|
|
settings: Settings.isolated({ "startup.quiet": true }),
|
|
modelRegistry,
|
|
});
|
|
mode = new InteractiveMode(session, "test", undefined, undefined, undefined, undefined, eventBus);
|
|
});
|
|
|
|
afterEach(async () => {
|
|
mode?.stop();
|
|
await session?.dispose();
|
|
authStorage?.close();
|
|
tempDir?.removeSync();
|
|
vi.useRealTimers();
|
|
vi.restoreAllMocks();
|
|
resetSettingsForTest();
|
|
});
|
|
|
|
it("coalesces a burst of progress observer changes into one HUD rebuild and render request", async () => {
|
|
await mode.init({ suppressWelcomeIntro: true });
|
|
const requestRender = vi.spyOn(mode.ui, "requestRender").mockImplementation(() => {});
|
|
const rebuildHud = vi.spyOn(mode.subagentContainer, "clear");
|
|
vi.useFakeTimers();
|
|
|
|
for (let index = 0; index < 6; index++) {
|
|
eventBus.emit(
|
|
TASK_SUBAGENT_PROGRESS_CHANNEL,
|
|
makeProgressPayload(`BurstAgent${index}`, index, `Burst job ${index}`, true),
|
|
);
|
|
}
|
|
|
|
await Promise.resolve();
|
|
vi.runAllTimers();
|
|
await Promise.resolve();
|
|
|
|
const hud = Bun.stripANSI(mode.subagentContainer.render(120).join("\n"));
|
|
expect(hud).toContain("BurstAgent0: Burst job 0");
|
|
expect(hud).toContain("BurstAgent5: Burst job 5");
|
|
expect(rebuildHud).toHaveBeenCalledTimes(1);
|
|
expect(requestRender).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|