"""Tests for extract_images support in extract_clean_markdown.
Root cause of AGI-101: markdownify strips img src URLs when images appear inside table cells
(
/
) or heading elements, because those contexts set the _inline flag. The extract_images
parameter fixes this by adding those tags to keep_inline_images_in.
Block-level images (direct children of
,
, etc.) are ALWAYS included in markdown
regardless of extract_images. The parameter only matters for images inside
,
,
-
.
"""
import asyncio
import pytest
from pytest_httpserver import HTTPServer
from browser_use.browser import BrowserProfile, BrowserSession
from browser_use.dom.markdown_extractor import extract_clean_markdown
# --- Fixtures ---
@pytest.fixture(scope='session')
def http_server():
"""Test HTTP server serving pages with product images."""
server = HTTPServer()
server.start()
# Table-layout products — images are in
, the actual bug scenario.
# With extract_images=False (default), img in td becomes just alt text (no URL).
# With extract_images=True, img in td becomes  with the real URL.
server.expect_request('/products-table').respond_with_data(
"""
Products Table
Product Catalog
Image
Name
Price
Widget A
$29.99
Widget B
$49.99
Gadget C
$19.50
""",
content_type='text/html',
)
# Block-level products — images in
/ are ALWAYS included in markdown,
# regardless of extract_images value.
server.expect_request('/products-block').respond_with_data(
"""
Products Block
Widget A - $29.99
""",
content_type='text/html',
)
server.expect_request('/text-only').respond_with_data(
"""
Text Only
No Images Here
Just some text content with no images at all.
""",
content_type='text/html',
)
yield server
server.stop()
@pytest.fixture(scope='session')
def base_url(http_server):
return f'http://{http_server.host}:{http_server.port}'
@pytest.fixture(scope='module')
async def browser_session():
session = BrowserSession(
browser_profile=BrowserProfile(
headless=True,
user_data_dir=None,
keep_alive=True,
)
)
await session.start()
yield session
await session.kill()
# --- Helper ---
async def _navigate(browser_session, url: str):
"""Navigate to URL and wait for page load."""
await browser_session.navigate_to(url)
await asyncio.sleep(0.5)
# --- Tests ---
class TestExtractCleanMarkdown:
"""Tests for extract_clean_markdown with extract_images parameter."""
async def test_table_images_excluded_by_default(self, browser_session, base_url):
"""Images inside
lose their URL with extract_images=False (default).
This is the AGI-101 root cause: markdownify strips img src in _inline contexts
(td/th/headings) when keep_inline_images_in=[]. The alt text is kept but not the URL.
"""
await _navigate(browser_session, f'{base_url}/products-table')
content, _ = await extract_clean_markdown(browser_session=browser_session, extract_images=False)
# Alt text (product names) should still be present
assert 'Widget A' in content
assert 'Widget B' in content
# But image URLs should NOT appear — img in td is stripped to alt text
assert 'widget-a.jpg' not in content
assert 'widget-b.jpg' not in content
assert 'gadget-c.png' not in content
# No markdown image syntax
assert ' regardless
assert '![' in content_false
assert 'widget-a.jpg' in content_false
assert '![' in content_true
assert 'widget-a.jpg' in content_true
async def test_false_is_default(self, browser_session, base_url):
"""Calling extract_clean_markdown without extract_images behaves same as extract_images=False."""
await _navigate(browser_session, f'{base_url}/products-table')
content_default, _ = await extract_clean_markdown(browser_session=browser_session)
content_false, _ = await extract_clean_markdown(browser_session=browser_session, extract_images=False)
assert content_default == content_false
async def test_no_images_on_text_only_page(self, browser_session, base_url):
"""extract_images=True on a page with no images returns no image markdown."""
await _navigate(browser_session, f'{base_url}/text-only')
content, _ = await extract_clean_markdown(browser_session=browser_session, extract_images=True)
assert '![' not in content
assert 'No Images Here' in content or 'text content' in content
class TestExtractImagesAutoDetection:
"""Tests for auto-detection of image-related queries in the extract action."""
async def test_auto_detect_image_url_query(self, browser_session, base_url, tmp_path):
"""Query containing 'image url' auto-enables extract_images: table-cell img URLs appear in LLM input."""
from unittest.mock import AsyncMock
from browser_use.filesystem.file_system import FileSystem
from browser_use.llm import BaseChatModel
from browser_use.llm.views import ChatInvokeCompletion
from browser_use.tools.service import Tools
await _navigate(browser_session, f'{base_url}/products-table')
captured_content: list[str] = []
mock_llm = AsyncMock(spec=BaseChatModel)
mock_llm.model = 'mock-llm'
mock_llm._verified_api_keys = True
mock_llm.provider = 'mock'
mock_llm.name = 'mock-llm'
mock_llm.model_name = 'mock-llm'
async def capture_ainvoke(*args, **kwargs):
if args:
for msg in args[0]:
content = getattr(msg, 'content', '')
if isinstance(content, str):
captured_content.append(content)
elif isinstance(content, list):
for part in content:
if isinstance(part, dict) and part.get('type') == 'text':
captured_content.append(part.get('text', ''))
return ChatInvokeCompletion(completion='Widget A image: http://localhost/images/widget-a.jpg', usage=None)
mock_llm.ainvoke.side_effect = capture_ainvoke
tools = Tools()
await tools.extract(
query='get image url for each product',
browser_session=browser_session,
page_extraction_llm=mock_llm,
file_system=FileSystem(base_dir=str(tmp_path)),
)
# The LLM should have received content that includes image markdown (td images with URLs)
all_content = ' '.join(captured_content)
assert '![' in all_content or 'widget-a.jpg' in all_content or 'widget-b.jpg' in all_content, (
f'Expected image URLs in LLM input but got: {all_content[:500]}'
)
async def test_no_auto_detect_without_image_keyword(self, browser_session, base_url, tmp_path):
"""Query without image keywords does NOT auto-enable extract_images: table-cell img URLs absent."""
from unittest.mock import AsyncMock
from browser_use.filesystem.file_system import FileSystem
from browser_use.llm import BaseChatModel
from browser_use.llm.views import ChatInvokeCompletion
from browser_use.tools.service import Tools
await _navigate(browser_session, f'{base_url}/products-table')
captured_content: list[str] = []
mock_llm = AsyncMock(spec=BaseChatModel)
mock_llm.model = 'mock-llm'
mock_llm._verified_api_keys = True
mock_llm.provider = 'mock'
mock_llm.name = 'mock-llm'
mock_llm.model_name = 'mock-llm'
async def capture_ainvoke(*args, **kwargs):
if args:
for msg in args[0]:
content = getattr(msg, 'content', '')
if isinstance(content, str):
captured_content.append(content)
elif isinstance(content, list):
for part in content:
if isinstance(part, dict) and part.get('type') == 'text':
captured_content.append(part.get('text', ''))
return ChatInvokeCompletion(completion='Widget A - $29.99, Widget B - $49.99', usage=None)
mock_llm.ainvoke.side_effect = capture_ainvoke
tools = Tools()
await tools.extract(
query='get product names and prices',
browser_session=browser_session,
page_extraction_llm=mock_llm,
file_system=FileSystem(base_dir=str(tmp_path)),
)
# Table-cell image URLs should NOT appear (extract_images=False, no auto-detect)
all_content = ' '.join(captured_content)
assert 'widget-a.jpg' not in all_content and 'widget-b.jpg' not in all_content, (
f'Did not expect image URLs in LLM input but got: {all_content[:500]}'
)
