{ "title": "[Hexagon] 2-d allocation cleanup", "body": "- Added device validity check in allocation. HexagonDeviceAPI should only be called for CPU/Hexagon types.\r\n\r\n- Check for \"global.vtcm\" scope instead of \"vtcm\". The ccope of N-d allocations produced by `LowerVtcmAlloc` should be `\"global.vtcm\"`. The previous check allowed unsupported scope such as `\"local.vtcm\"`.\r\n\r\n- Remove `vtcmallocs` entry after calling free.\n\n\nThanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.\n\n\nPreviously, the vtcm allocation map kept dangling pointers to `HexagonBuffer` objects after they had been freed.\r\n\r\n- Rename N-d alloc and free packed functions. Since most of the similar device functions use snake case, renaming `*.AllocND` to `*.alloc_nd` and `*.FreeND` to `*.free_nd`.\n\n\ncc @someone\n\r\n\r\nCo-authored-by: Adam Straw \n\n\nThanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.\n\n", "state": "OPEN", "author": { "login": "abc" }, "comments": { "pageInfo": { "hasPreviousPage": false }, "nodes": [] }, "authorCommits": { "nodes": [ { "commit": { "authors": { "nodes": [ { "name": "Eric Lunderberg", "email": "elunderberg@octoml.ai" }, { "name": "Adam Straw", "email": "astraw@octoml.ai" } ] } } } ] }, "commits": { "nodes": [ { "commit": { "oid": "6f04bcf57d07f915a98fd91178f04d9e92a09fcd", "statusCheckRollup": { "contexts": { "pageInfo": { "hasNextPage": false }, "nodes": [ { "name": "MacOS", "checkSuite": { "workflowRun": { "workflow": { "name": "CI" } } }, "status": "COMPLETED", "conclusion": "SUCCESS", "url": "https://github.com/apache/tvm/runs/5694945392" }, { "name": "cc-reviewers", "checkSuite": { "workflowRun": { "workflow": { "name": "PR" } } }, "status": "COMPLETED", "conclusion": "SUCCESS", "url": "https://github.com/apache/tvm/runs/5694945029" }, { "name": "tag-teams", "checkSuite": { "workflowRun": { "workflow": { "name": "Teams" } } }, "status": "COMPLETED", "conclusion": "SUCCESS", "url": "https://github.com/apache/tvm/runs/5694945030" }, { "name": "Windows", "checkSuite": { "workflowRun": { "workflow": { "name": "CI" } } }, "status": "COMPLETED", "conclusion": "SUCCESS", "url": "https://github.com/apache/tvm/runs/5694945524" }, { "state": "SUCCESS", "context": "tvm-ci/pr-head", "targetUrl": "https://ci.tlcpack.ai/job/tvm/job/PR-10786/1/display/redirect" } ] } } } } ] }, "reviewDecision": "APPROVED", "reviews": { "pageInfo": { "hasPreviousPage": false }, "nodes": [ { "body": "@tvm-bot merge", "updatedAt": "2022-03-25T22:13:50Z", "authorCanPushToRepository": true, "commit": { "oid": "6f04bcf57d07f915a98fd91178f04d9e92a09fcd" }, "author": { "login": "kparzysz-quic" }, "state": "APPROVED" } ] } }