a789495a98
FreeBSD Smoke / FreeBSD Smoke (x86_64) (push) Has been cancelled
CI / Quality Guardrails (push) Has been cancelled
CI / Build & Test (macos-latest) (push) Has been cancelled
CI / Build & Test (ubuntu-latest) (push) Has been cancelled
CI / Build & Test (windows-latest) (push) Has been cancelled
CI / Format (push) Has been cancelled
CI / PowerShell Syntax (push) Has been cancelled
CI / Windows Cross-Target Check (Linux) (push) Has been cancelled
116 lines
3.4 KiB
Python
Executable File
116 lines
3.4 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
"""Check lightweight crate dependency boundaries.
|
|
|
|
Type crates should remain data-contract crates. This guard intentionally starts
|
|
small: it blocks direct dependencies from any `jcode-*-types` crate to root or
|
|
runtime-heavy internal crates. It allows external dependencies for now, while
|
|
making internal domain leaks visible and easy to extend.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import subprocess
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
ROOT = Path(__file__).resolve().parents[1]
|
|
|
|
# Internal crates that are allowed as dependencies of type crates.
|
|
# Keep this list narrow. Add a crate only if it is itself a data-contract crate.
|
|
ALLOWED_INTERNAL_TYPE_DEPS = {
|
|
"jcode-message-types",
|
|
}
|
|
|
|
# Internal crates that type crates must not depend on directly. Most are runtime,
|
|
# provider, UI, storage, or root behavior crates. `jcode-core` is intentionally
|
|
# blocked so it does not become the backdoor catch-all dependency for DTO crates.
|
|
FORBIDDEN_INTERNAL_DEPS = {
|
|
"jcode",
|
|
"jcode-agent-runtime",
|
|
"jcode-azure-auth",
|
|
"jcode-core",
|
|
"jcode-desktop",
|
|
"jcode-embedding",
|
|
"jcode-mobile-core",
|
|
"jcode-mobile-sim",
|
|
"jcode-notify-email",
|
|
"jcode-pdf",
|
|
"jcode-plan",
|
|
"jcode-provider-core",
|
|
"jcode-provider-gemini",
|
|
"jcode-provider-metadata",
|
|
"jcode-provider-openrouter",
|
|
"jcode-protocol",
|
|
"jcode-terminal-launch",
|
|
"jcode-tui-core",
|
|
"jcode-tui-markdown",
|
|
"jcode-tui-mermaid",
|
|
"jcode-tui-render",
|
|
"jcode-tui-workspace",
|
|
}
|
|
|
|
|
|
def cargo_metadata() -> dict:
|
|
result = subprocess.run(
|
|
["cargo", "metadata", "--no-deps", "--format-version", "1"],
|
|
cwd=ROOT,
|
|
check=True,
|
|
text=True,
|
|
stdout=subprocess.PIPE,
|
|
)
|
|
return json.loads(result.stdout)
|
|
|
|
|
|
def is_type_crate(name: str) -> bool:
|
|
return name.startswith("jcode-") and name.endswith("-types")
|
|
|
|
|
|
def main() -> int:
|
|
metadata = cargo_metadata()
|
|
package_by_id = {package["id"]: package for package in metadata["packages"]}
|
|
workspace_ids = set(metadata["workspace_members"])
|
|
workspace_names = {
|
|
package_by_id[package_id]["name"] for package_id in workspace_ids if package_id in package_by_id
|
|
}
|
|
|
|
errors: list[str] = []
|
|
warnings: list[str] = []
|
|
|
|
for package_id in sorted(workspace_ids, key=lambda pid: package_by_id[pid]["name"]):
|
|
package = package_by_id[package_id]
|
|
name = package["name"]
|
|
if not is_type_crate(name):
|
|
continue
|
|
|
|
for dep in package.get("dependencies", []):
|
|
dep_name = dep["name"]
|
|
if dep_name not in workspace_names:
|
|
continue
|
|
if dep_name in ALLOWED_INTERNAL_TYPE_DEPS:
|
|
continue
|
|
if is_type_crate(dep_name):
|
|
continue
|
|
if dep_name in FORBIDDEN_INTERNAL_DEPS:
|
|
errors.append(f"{name} must not depend on runtime/internal crate {dep_name}")
|
|
else:
|
|
warnings.append(
|
|
f"{name} depends on internal non-type crate {dep_name}; review boundary policy"
|
|
)
|
|
|
|
for warning in warnings:
|
|
print(f"warning: {warning}", file=sys.stderr)
|
|
for error in errors:
|
|
print(f"error: {error}", file=sys.stderr)
|
|
|
|
if errors:
|
|
print(f"dependency boundary check failed: {len(errors)} error(s)", file=sys.stderr)
|
|
return 1
|
|
|
|
print("dependency boundary check passed")
|
|
return 0
|
|
|
|
|
|
if __name__ == "__main__":
|
|
raise SystemExit(main())
|