docs: remove windows workaround and document Node LTS support (#2074)
Adds test coverage for 26, removes test coverage for 23 and 20.
This commit is contained in:
@@ -21,10 +21,10 @@ jobs:
|
||||
- windows-latest
|
||||
- macos-latest
|
||||
node:
|
||||
- 20
|
||||
- 22
|
||||
- 23
|
||||
- 24
|
||||
- 26
|
||||
|
||||
steps:
|
||||
- name: Check out repository
|
||||
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
||||
@@ -43,12 +43,6 @@ jobs:
|
||||
env:
|
||||
PUPPETEER_SKIP_DOWNLOAD: true
|
||||
|
||||
- name: Patch
|
||||
if: ${{ matrix.os == 'windows-latest' }}
|
||||
shell: bash
|
||||
run: |
|
||||
node scripts/patch.mjs
|
||||
|
||||
- name: Install browser
|
||||
shell: bash
|
||||
run: npx puppeteer browsers install chrome
|
||||
|
||||
@@ -61,7 +61,7 @@ You can disable these update checks by setting the `CHROME_DEVTOOLS_MCP_NO_UPDAT
|
||||
|
||||
## Requirements
|
||||
|
||||
- [Node.js](https://nodejs.org/) v20.19 or a newer [latest maintenance LTS](https://github.com/nodejs/Release#release-schedule) version.
|
||||
- [Node.js](https://nodejs.org/) [LTS](https://github.com/nodejs/Release#release-schedule).
|
||||
- [Chrome](https://www.google.com/chrome/) current stable version or newer.
|
||||
- [npm](https://www.npmjs.com/)
|
||||
|
||||
|
||||
@@ -1,41 +0,0 @@
|
||||
/**
|
||||
* @license
|
||||
* Copyright 2026 Google LLC
|
||||
* SPDX-License-Identifier: Apache-2.0
|
||||
*/
|
||||
|
||||
import fs from 'node:fs';
|
||||
import path from 'node:path';
|
||||
|
||||
const file = path.join(
|
||||
process.cwd(),
|
||||
'node_modules',
|
||||
'@puppeteer',
|
||||
'browsers',
|
||||
'lib',
|
||||
'fileUtil.js',
|
||||
);
|
||||
|
||||
if (!fs.existsSync(file)) {
|
||||
console.error(
|
||||
'File not found. Make sure you run this from the project root and npm install has been run.',
|
||||
);
|
||||
process.exit(1);
|
||||
}
|
||||
|
||||
const search =
|
||||
"await execFileAsync('tar.exe', ['-xf', archivePath, '-C', folderPath]);";
|
||||
|
||||
// Double escape the backslashes so they write as single backslashes into the target file
|
||||
const replace = `const systemRoot = process.env['SystemRoot'] ?? process.env['SYSTEMROOT'] ?? 'C:\\\\Windows';
|
||||
const systemTar = \`\${systemRoot}\\\\System32\\\\tar.exe\`;
|
||||
await execFileAsync(systemTar, ['-xf', archivePath, '-C', folderPath]);`;
|
||||
|
||||
let content = fs.readFileSync(file, 'utf8');
|
||||
|
||||
if (content.includes(search)) {
|
||||
fs.writeFileSync(file, content.replace(search, replace));
|
||||
console.log('Patch applied successfully.');
|
||||
} else {
|
||||
console.log('Target string not found. Already patched?');
|
||||
}
|
||||
Reference in New Issue
Block a user