Duc-Tam Nguyen
dab6c11ea8
kage launched Chrome with --no-sandbox unconditionally, which turns off the browser's main security boundary for every run, including ordinary desktop use where the sandbox works fine. Since kage renders pages from the open web, a renderer exploit could then reach the host. Reported in #10. Keep the sandbox on by default and drop it only where it genuinely cannot initialize: inside a container, or when running as root (Chrome refuses to start a sandbox as root). Containers are detected from IN_DOCKER or the /.dockerenv marker, and there kage also sets --disable-dev-shm-usage because the default 64 MB /dev/shm is too small for the renderer on large pages. Whenever the sandbox is dropped kage says so on stderr, so it is never silent. Thanks to Dimitrios Prasakis for the report and to the commenter on Hacker News who suggested the IN_DOCKER opt-in.
113 lines
2.9 KiB
Go
113 lines
2.9 KiB
Go
package asset
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"net/url"
|
|
"sync/atomic"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestStatusErrorMessage(t *testing.T) {
|
|
cases := map[int]string{
|
|
403: "HTTP 403 Forbidden",
|
|
404: "HTTP 404 Not Found",
|
|
999: "HTTP 999",
|
|
}
|
|
for code, want := range cases {
|
|
if got := (&StatusError{Code: code}).Error(); got != want {
|
|
t.Errorf("StatusError{%d} = %q; want %q", code, got, want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestGetRetriesTransientThenSucceeds(t *testing.T) {
|
|
var hits int32
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
// 403 on the first try (like bot-protection), then serve the file.
|
|
if atomic.AddInt32(&hits, 1) == 1 {
|
|
w.WriteHeader(http.StatusForbidden)
|
|
return
|
|
}
|
|
w.Header().Set("Content-Type", "text/css")
|
|
_, _ = w.Write([]byte("body{}"))
|
|
}))
|
|
defer srv.Close()
|
|
|
|
d := NewDownloader("kage-test", 5*time.Second, 0)
|
|
u, _ := url.Parse(srv.URL + "/style.css")
|
|
res, err := d.Get(context.Background(), u, "")
|
|
if err != nil {
|
|
t.Fatalf("Get after retry: %v", err)
|
|
}
|
|
if !res.IsCSS || string(res.Body) != "body{}" {
|
|
t.Errorf("unexpected result: css=%v body=%q", res.IsCSS, res.Body)
|
|
}
|
|
if hits < 2 {
|
|
t.Errorf("expected a retry; server saw %d hits", hits)
|
|
}
|
|
}
|
|
|
|
func TestGetDoesNotRetryPermanent(t *testing.T) {
|
|
var hits int32
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
atomic.AddInt32(&hits, 1)
|
|
w.WriteHeader(http.StatusNotFound)
|
|
}))
|
|
defer srv.Close()
|
|
|
|
d := NewDownloader("kage-test", 5*time.Second, 0)
|
|
u, _ := url.Parse(srv.URL + "/missing.png")
|
|
_, err := d.Get(context.Background(), u, "")
|
|
|
|
var se *StatusError
|
|
if !errors.As(err, &se) || se.Code != 404 {
|
|
t.Fatalf("got %v; want StatusError 404", err)
|
|
}
|
|
if hits != 1 {
|
|
t.Errorf("404 should not be retried; server saw %d hits", hits)
|
|
}
|
|
}
|
|
|
|
func TestGetGivesUpAfterRetries(t *testing.T) {
|
|
var hits int32
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
atomic.AddInt32(&hits, 1)
|
|
w.WriteHeader(http.StatusTooManyRequests)
|
|
}))
|
|
defer srv.Close()
|
|
|
|
d := NewDownloader("kage-test", 5*time.Second, 0)
|
|
d.Retries = 2
|
|
u, _ := url.Parse(srv.URL + "/rate.css")
|
|
_, err := d.Get(context.Background(), u, "")
|
|
|
|
var se *StatusError
|
|
if !errors.As(err, &se) || se.Code != 429 {
|
|
t.Fatalf("got %v; want StatusError 429", err)
|
|
}
|
|
if hits != 3 { // 1 try + 2 retries
|
|
t.Errorf("expected 3 attempts, server saw %d", hits)
|
|
}
|
|
}
|
|
|
|
func TestTransientClassification(t *testing.T) {
|
|
transientCodes := []int{403, 408, 425, 429, 500, 502, 503}
|
|
for _, c := range transientCodes {
|
|
if !transient(&StatusError{Code: c}) {
|
|
t.Errorf("status %d should be transient", c)
|
|
}
|
|
}
|
|
for _, c := range []int{400, 401, 404, 410} {
|
|
if transient(&StatusError{Code: c}) {
|
|
t.Errorf("status %d should be permanent", c)
|
|
}
|
|
}
|
|
if transient(context.Canceled) {
|
|
t.Error("context.Canceled should not be transient")
|
|
}
|
|
}
|